Re: [PATCH] ecpg: fix progname memory leak

2020-10-09 Thread John Naylor
On Fri, Oct 9, 2020 at 12:50 PM Tom Lane wrote: > Consulting the wiki page's edit history shows that Bruce has been > doing some maintenance work, but almost nobody else does. Evidently > that's not enough. > > I'd be +1 for the "aggressive culling" suggested upthread, but > I'm not particularly

Re: [PATCH] ecpg: fix progname memory leak

2020-10-09 Thread Bruce Momjian
On Fri, Oct 9, 2020 at 12:50:36PM -0400, Tom Lane wrote: > Magnus Hagander writes: > > That said, having this in a different format would in no way fix the fact > > that the information is mislabeled and obsolete. It would likely be > > equally mislabeled and obsolete in an issue tracker. Just l

Re: [PATCH] ecpg: fix progname memory leak

2020-10-09 Thread Tom Lane
Magnus Hagander writes: > That said, having this in a different format would in no way fix the fact > that the information is mislabeled and obsolete. It would likely be > equally mislabeled and obsolete in an issue tracker. Just look at almost > any of the other projects out there that *do* use

Re: [PATCH] ecpg: fix progname memory leak

2020-10-09 Thread Magnus Hagander
On Fri, Oct 9, 2020 at 1:08 PM John Naylor wrote: > > On Fri, Oct 9, 2020 at 4:47 AM Daniel Gustafsson wrote: > >> Now, I don't actually suggest we *remove* it, as there is valuable curated >> content, but that we rename it to something which won't encourage >> newcomers to >> pick something fro

Re: [PATCH] ecpg: fix progname memory leak

2020-10-09 Thread John Naylor
On Fri, Oct 9, 2020 at 4:47 AM Daniel Gustafsson wrote: > Now, I don't actually suggest we *remove* it, as there is valuable curated > content, but that we rename it to something which won't encourage > newcomers to > pick something from the list simply because it exists. The name "TODO" > impli

Re: [PATCH] ecpg: fix progname memory leak

2020-10-09 Thread Daniel Gustafsson
> On 8 Oct 2020, at 19:08, Bruce Momjian wrote: > OK, TODO removed. Potentially controversial proposal: Should we perhaps remove (for some value of) the TODO list altogether? The value of the list is questionable as it's not actually a TODO list for established developers, and for aspiring new

Re: [PATCH] ecpg: fix progname memory leak

2020-10-08 Thread Michael Paquier
On Thu, Oct 08, 2020 at 01:17:25PM -0400, Tom Lane wrote: > Agreed. In theory there might be some point in removing leaks that happen > per-statement, so as to avoid unreasonable memory bloat when processing an > extremely long input file. In practice nobody has complained about that, > and if so

Re: [PATCH] ecpg: fix progname memory leak

2020-10-08 Thread Ranier Vilela
On Thu, Oct 8, 2020 at 10:13:53AM -0700, John W Higgins wrote: >It's not going to win a Turing award - but I thought this project was a >little more friendly then what I've seen in this thread towards a first >time contributor. Instead, it is unfriendly. It takes a lot of motivation to "try" to

Re: [PATCH] ecpg: fix progname memory leak

2020-10-08 Thread Tom Lane
Michael Meskes writes: > On Thu, 2020-10-08 at 12:27 -0400, Bruce Momjian wrote: >> Agreed, but what does the TODO item mean then? >> >> Fix small memory leaks in ecpg >> Memory leaks in a short running application like ecpg are not really >> a problem, but make debugging m

Re: [PATCH] ecpg: fix progname memory leak

2020-10-08 Thread Bruce Momjian
On Thu, Oct 8, 2020 at 10:13:53AM -0700, John W Higgins wrote: > > On Wed, Oct 7, 2020 at 6:35 PM Michael Paquier wrote: > > On Wed, Oct 07, 2020 at 02:31:54PM +0300, Maksim Kita wrote: > > Fix progname memory leak in ecpg client. > > Issue taken from todo list https://wiki.postgres

Re: [PATCH] ecpg: fix progname memory leak

2020-10-08 Thread John W Higgins
On Wed, Oct 7, 2020 at 6:35 PM Michael Paquier wrote: > On Wed, Oct 07, 2020 at 02:31:54PM +0300, Maksim Kita wrote: > > Fix progname memory leak in ecpg client. > > Issue taken from todo list https://wiki.postgresql.org/wiki/Todo. > > FWIW, I don't see much point in doing that. > I hope that ev

Re: [PATCH] ecpg: fix progname memory leak

2020-10-08 Thread Bruce Momjian
On Thu, Oct 8, 2020 at 06:58:14PM +0200, Michael Meskes wrote: > On Thu, 2020-10-08 at 12:27 -0400, Bruce Momjian wrote: > > On Thu, Oct 8, 2020 at 10:35:41AM +0900, Michael Paquier wrote: > > > On Wed, Oct 07, 2020 at 02:31:54PM +0300, Maksim Kita wrote: > > > > Fix progname memory leak in ecpg

Re: [PATCH] ecpg: fix progname memory leak

2020-10-08 Thread Michael Meskes
On Thu, 2020-10-08 at 12:27 -0400, Bruce Momjian wrote: > On Thu, Oct 8, 2020 at 10:35:41AM +0900, Michael Paquier wrote: > > On Wed, Oct 07, 2020 at 02:31:54PM +0300, Maksim Kita wrote: > > > Fix progname memory leak in ecpg client. > > > Issue taken from todo list https://wiki.postgresql.org/wik

Re: [PATCH] ecpg: fix progname memory leak

2020-10-08 Thread Bruce Momjian
On Thu, Oct 8, 2020 at 10:35:41AM +0900, Michael Paquier wrote: > On Wed, Oct 07, 2020 at 02:31:54PM +0300, Maksim Kita wrote: > > Fix progname memory leak in ecpg client. > > Issue taken from todo list https://wiki.postgresql.org/wiki/Todo. > > FWIW, I don't see much point in doing that. For on

Re: [PATCH] ecpg: fix progname memory leak

2020-10-07 Thread Michael Paquier
On Wed, Oct 07, 2020 at 02:31:54PM +0300, Maksim Kita wrote: > Fix progname memory leak in ecpg client. > Issue taken from todo list https://wiki.postgresql.org/wiki/Todo. FWIW, I don't see much point in doing that. For one, we have a more-or-less established rule that progname remains set until

[PATCH] ecpg: fix progname memory leak

2020-10-07 Thread Maksim Kita
Hi, Fix progname memory leak in ecpg client. Issue taken from todo list https://wiki.postgresql.org/wiki/Todo. Best regards, Maksim Kita >From 2f730117cbff1207c6b0bffc3097831fe5028fec Mon Sep 17 00:00:00 2001 From: Maksim Kita Date: Wed, 7 Oct 2020 14:15:52 +0300 Subject: [PATCH] ecpg: