Re: [RFC] building postgres with meson - v11

2022-09-08 Thread samay sharma
On Tue, Sep 6, 2022 at 9:46 PM Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > On 02.09.22 01:12, samay sharma wrote: > > So, I was thinking of the following structure: > > - Supported Platforms > > - Getting the Source > > - Building with make and autoconf > >-- Short version >

Re: [RFC] building postgres with meson - v11

2022-09-08 Thread samay sharma
Hi, On Tue, Sep 6, 2022 at 9:48 PM Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > On 02.09.22 19:16, samay sharma wrote: > > Another thing I'd like input on. A common question I've heard from > > people who've tried out the docs is How do we do the equivalent of X in > > make with

Re: [RFC] building postgres with meson - v11

2022-09-06 Thread Peter Eisentraut
On 02.09.22 19:16, samay sharma wrote: Another thing I'd like input on. A common question I've heard from people who've tried out the docs is How do we do the equivalent of X in make with meson. As meson will be new for a bunch of people who are fluent with make, I won't be surprised if this is

Re: [RFC] building postgres with meson - v11

2022-09-06 Thread Peter Eisentraut
On 02.09.22 01:12, samay sharma wrote: So, I was thinking of the following structure: - Supported Platforms - Getting the Source - Building with make and autoconf   -- Short version   -- Requirements   -- Installation Procedure and it's subsections - Building with Meson   -- Short version  

Re: [RFC] building postgres with meson - v11

2022-09-02 Thread samay sharma
On Thu, Sep 1, 2022 at 4:12 PM samay sharma wrote: > Hi, > > On Wed, Aug 31, 2022 at 1:42 AM Peter Eisentraut < > peter.eisentr...@enterprisedb.com> wrote: > >> On 24.08.22 17:30, Andres Freund wrote: >> >> 0545eec895 meson: Add docs >> >> >> >> We should think more about how to arrange the docum

Re: [RFC] building postgres with meson - v11

2022-09-01 Thread samay sharma
Hi, On Wed, Aug 31, 2022 at 1:42 AM Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > On 24.08.22 17:30, Andres Freund wrote: > >> 0545eec895 meson: Add docs > >> > >> We should think more about how to arrange the documentation. We > >> probably don't want to copy-and-paste all the

Re: [RFC] building postgres with meson - v11

2022-08-31 Thread Peter Eisentraut
On 24.08.22 17:30, Andres Freund wrote: 0545eec895 meson: Add docs We should think more about how to arrange the documentation. We probably don't want to copy-and-paste all the introductory and requirements information. I think we can make this initially much briefer, like the Windows installa

Re: [RFC] building postgres with meson - v11

2022-08-25 Thread Peter Eisentraut
On 24.08.22 17:30, Andres Freund wrote: 258f6dc0a7 Don't hardcode tmp_check/ as test directory for tap tests 8ecc33cf04 Split TESTDIR into TESTLOGDIR and TESTDATADIR I think these patches are split up a bit incorrectly. If you apply the first patch by itself, then the output appears in tab_comp

Re: [RFC] building postgres with meson - v11

2022-08-24 Thread samay sharma
Hi, On Wed, Aug 24, 2022 at 8:30 AM Andres Freund wrote: > Hi, > > On 2022-08-24 11:39:06 +0200, Peter Eisentraut wrote: > > I have looked at your branch at 0545eec895: > > > > 258f6dc0a7 Don't hardcode tmp_check/ as test directory for tap tests > > 8ecc33cf04 Split TESTDIR into TESTLOGDIR and T

Re: [RFC] building postgres with meson - v11

2022-08-24 Thread Andres Freund
Hi, On 2022-08-17 14:53:17 -0700, Andres Freund wrote: > > - In the top-level meson.build, the "renaming" of the Windows system > > name > > > > host_system = host_machine.system() == 'windows' ? 'win32' : > > host_machine.system() > > build_system = build_machine.system() == 'window

Re: [RFC] building postgres with meson - v11

2022-08-24 Thread Andres Freund
Hi, On 2022-08-24 11:39:06 +0200, Peter Eisentraut wrote: > I have looked at your branch at 0545eec895: > > 258f6dc0a7 Don't hardcode tmp_check/ as test directory for tap tests > 8ecc33cf04 Split TESTDIR into TESTLOGDIR and TESTDATADIR > > I think these patches are split up a bit incorrectly. I

Re: [RFC] building postgres with meson - v11

2022-08-24 Thread Peter Eisentraut
I have looked at your branch at 0545eec895: 258f6dc0a7 Don't hardcode tmp_check/ as test directory for tap tests 8ecc33cf04 Split TESTDIR into TESTLOGDIR and TESTDATADIR I think these patches are split up a bit incorrectly. If you apply the first patch by itself, then the output appears in tab_

Re: [RFC] building postgres with meson - v11

2022-08-20 Thread Andres Freund
Hi, On 2022-08-20 09:38:48 +0200, Peter Eisentraut wrote: > On 17.08.22 23:53, Andres Freund wrote: > > Any comment on the pg_regress_ecpg commit? I'd like to get that out of the > > way, and it seems considerably cleaner than the hackery we do right now to > > make VPATH builds work. > > That on

Re: [RFC] building postgres with meson - v11

2022-08-20 Thread Peter Eisentraut
On 17.08.22 23:53, Andres Freund wrote: Any comment on the pg_regress_ecpg commit? I'd like to get that out of the way, and it seems considerably cleaner than the hackery we do right now to make VPATH builds work. That one looks like a very good improvement.

Re: [RFC] building postgres with meson - v11

2022-08-17 Thread Andres Freund
Hi, On 2022-08-17 15:50:23 +0200, Peter Eisentraut wrote: > - There are various references to "pch" (pre-compiled headers). Is > there more discussion anywhere about this? I don't know what this > would entail or whether there are any drawbacks to be aware of. The > new *_pch.h files don'

Re: [RFC] building postgres with meson - v11

2022-08-17 Thread Peter Eisentraut
On 11.08.22 02:20, Andres Freund wrote: Attached is a new version of the meson patchset. Plenty changes: I have various bits of comments on this. - There are various references to "pch" (pre-compiled headers). Is there more discussion anywhere about this? I don't know what this would ent