Re: ACL dump ordering broken as well for tablespaces

2019-05-23 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Wed, May 22, 2019 at 06:35:31PM +, Bossart, Nathan wrote: > > A bit of digging led me to the commit that removed databases and > > tablespaces from pg_init_privs [0] and to a related thread [1]. IIUC > > the problem is that using

Re: ACL dump ordering broken as well for tablespaces

2019-05-22 Thread Michael Paquier
On Wed, May 22, 2019 at 06:35:31PM +, Bossart, Nathan wrote: > The patch looks good to me. Thanks for double-checking. I have applied and back-patched. The good thing here is that there were zero conflicts. > A bit of digging led me to the commit that removed databases and > tablespaces

Re: ACL dump ordering broken as well for tablespaces

2019-05-22 Thread Bossart, Nathan
On 5/22/19, 12:16 AM, "Michael Paquier" wrote: > Attached is a patch to fix that, so as pg_dumpall does not complain > when piling up GRANT commands using WITH GRANT OPTION. Are there any > complains to apply that down to 9.6? The patch looks good to me. > As the problem is kind of different

ACL dump ordering broken as well for tablespaces

2019-05-22 Thread Michael Paquier
Hi all, As some may have noticed, I have been looking at the ACL dump ordering for databases, and I have noticed the same issue with tablespaces: https://www.postgresql.org/message-id/20190522062626.gc1...@paquier.xyz For the sake of avoiding looking at the other email, here is how to reproduce