Re: Add %x to PROMPT1 and PROMPT2

2020-02-12 Thread Vik Fearing
On 12/02/2020 05:35, Michael Paquier wrote: > On Tue, Feb 11, 2020 at 10:05:25AM -0500, Robert Haas wrote: >> No objections here. I'm glad that we put in the effort to get more >> opinions, but I agree that an overall vote of ~58 to ~8 is a pretty >> strong consensus. > > Clearly, so done as

Re: Add %x to PROMPT1 and PROMPT2

2020-02-11 Thread Michael Paquier
On Tue, Feb 11, 2020 at 10:05:25AM -0500, Robert Haas wrote: > No objections here. I'm glad that we put in the effort to get more > opinions, but I agree that an overall vote of ~58 to ~8 is a pretty > strong consensus. Clearly, so done as dcdbb5a. -- Michael signature.asc Description: PGP

Re: Add %x to PROMPT1 and PROMPT2

2020-02-11 Thread Robert Haas
On Sun, Feb 9, 2020 at 7:45 PM Michael Paquier wrote: > On Mon, Feb 10, 2020 at 12:16:44AM +0100, Vik Fearing wrote: > > There is a little bit of overlap within those three groups but among the > > minuscule percentage of our users that responded, the result is > > overwhelmingly in favor of this

Re: Add %x to PROMPT1 and PROMPT2

2020-02-09 Thread Michael Paquier
On Mon, Feb 10, 2020 at 12:16:44AM +0100, Vik Fearing wrote: > There is a little bit of overlap within those three groups but among the > minuscule percentage of our users that responded, the result is > overwhelmingly in favor of this change. Thanks Vik for handling that. So, it seems to me

Re: Add %x to PROMPT1 and PROMPT2

2020-02-09 Thread Vik Fearing
On 06/02/2020 03:56, Vik Fearing wrote: > On 06/02/2020 03:38, Michael Paquier wrote: >> On Wed, Feb 05, 2020 at 10:21:11AM -0500, Tom Lane wrote: >>> Robert Haas writes: I'm not really against this change but, given how long it's been the way that it is, I think we shouldn't make it

Re: Add %x to PROMPT1 and PROMPT2

2020-02-05 Thread Vik Fearing
On 06/02/2020 03:38, Michael Paquier wrote: > On Wed, Feb 05, 2020 at 10:21:11AM -0500, Tom Lane wrote: >> Robert Haas writes: >>> I'm not really against this change but, given how long it's been the >>> way that it is, I think we shouldn't make it without more plus votes. >>> If we've actually

Re: Add %x to PROMPT1 and PROMPT2

2020-02-05 Thread Michael Paquier
On Wed, Feb 05, 2020 at 10:21:11AM -0500, Tom Lane wrote: > Robert Haas writes: >> I'm not really against this change but, given how long it's been the >> way that it is, I think we shouldn't make it without more plus votes. >> If we've actually got a broad consensus on it, sure, but I don't

Re: Add %x to PROMPT1 and PROMPT2

2020-02-05 Thread Fabien COELHO
+1 one for this change, it's something I also add to every .psqlrc I setup. So.. We have: +1: Vik, Ian, Daniel, Alvaro, Christoph +-0: Tom (?), Fabien (?) I did not know I had a vote. I'm "+1" on this change, if that matters. Just this morning I had a case where I wished I had the

Re: Add %x to PROMPT1 and PROMPT2

2020-02-05 Thread Magnus Hagander
On Wed, Feb 5, 2020 at 3:30 PM Robert Haas wrote: > > On Tue, Feb 4, 2020 at 3:20 AM Michael Paquier wrote: > > So.. We have: > > +1: Vik, Ian, Daniel, Alvaro, Christoph > > +-0: Tom (?), Fabien (?) > > -1: Michael P. > > I'm not really against this change but, given how long it's been the >

Re: Add %x to PROMPT1 and PROMPT2

2020-02-05 Thread Tom Lane
Robert Haas writes: > I'm not really against this change but, given how long it's been the > way that it is, I think we shouldn't make it without more plus votes. > If we've actually got a broad consensus on it, sure, but I don't think > 4 votes is a broad consensus. Fair point. I'm still

Re: Add %x to PROMPT1 and PROMPT2

2020-02-05 Thread Robert Haas
On Tue, Feb 4, 2020 at 3:20 AM Michael Paquier wrote: > So.. We have: > +1: Vik, Ian, Daniel, Alvaro, Christoph > +-0: Tom (?), Fabien (?) > -1: Michael P. I'm not really against this change but, given how long it's been the way that it is, I think we shouldn't make it without more plus votes.

Re: Add %x to PROMPT1 and PROMPT2

2020-02-04 Thread Michael Paquier
On Tue, Feb 04, 2020 at 10:31:43AM +0900, Ian Barwick wrote: > The last change I recall affecting default psql behaviour was the addition > of COMP_KEYWORD_CASE in 9.2 (db84ba65), which personally I (and no doubt > others) > found annoying, but the world still turns. > > +1 one for this change,

Re: Add %x to PROMPT1 and PROMPT2

2020-02-03 Thread Ian Barwick
On 2020/02/03 23:40, Tom Lane wrote: Daniel Gustafsson writes: On 3 Feb 2020, at 08:08, Michael Paquier wrote: FWIW, I am not really in favor of changing a default old enough that it could vote (a45195a). That by itself doesn't seem a good reason to not change things. My concern would

Re: Add %x to PROMPT1 and PROMPT2

2020-02-03 Thread Tom Lane
Daniel Gustafsson writes: > On 3 Feb 2020, at 08:08, Michael Paquier wrote: >> FWIW, I am not really in favor of changing a default old enough that >> it could vote (a45195a). > That by itself doesn't seem a good reason to not change things. > My concern would be that users who have never ever

Re: Add %x to PROMPT1 and PROMPT2

2020-02-03 Thread Alvaro Herrera
On 2020-Feb-03, Daniel Gustafsson wrote: > > On 3 Feb 2020, at 08:08, Michael Paquier wrote: > > > FWIW, I am not really in favor of changing a default old enough that > > it could vote (a45195a). > > That by itself doesn't seem a good reason to not change things. Yeah. > My concern would be

Re: Add %x to PROMPT1 and PROMPT2

2020-02-03 Thread Daniel Gustafsson
> On 3 Feb 2020, at 08:08, Michael Paquier wrote: > FWIW, I am not really in favor of changing a default old enough that > it could vote (a45195a). That by itself doesn't seem a good reason to not change things. My concern would be that users who have never ever considered that the prompt can

Re: Add %x to PROMPT1 and PROMPT2

2020-02-02 Thread Michael Paquier
On Wed, Jan 29, 2020 at 11:51:10PM +0100, Vik Fearing wrote: > Thanks for the review! > > Would you mind changing the status in the commitfest app? > https://commitfest.postgresql.org/27/2427/ FWIW, I am not really in favor of changing a default old enough that it could vote (a45195a). --

Re: Add %x to PROMPT1 and PROMPT2

2020-01-29 Thread Vik Fearing
On 29/01/2020 08:25, Fabien COELHO wrote: > > Hello Vik, > >>> Isn't there examples in the documentation which use the default prompts? >>> >>> If so, should they be updated accordingly? >> >> Good catch! >> I thought about the documentation but not the examples therein. >> >> Updated patch

Re: Add %x to PROMPT1 and PROMPT2

2020-01-28 Thread Fabien COELHO
Hello Vik, Isn't there examples in the documentation which use the default prompts? If so, should they be updated accordingly? Good catch! I thought about the documentation but not the examples therein. Updated patch attached. Ok. Only one transaction prompt example in the whole

Re: Add %x to PROMPT1 and PROMPT2

2020-01-26 Thread Vik Fearing
On 26/01/2020 19:48, Fabien COELHO wrote: > > Hello Vik, > >> I cannot ever think of a time when I don't want to know if I'm in a >> transaction or not (and what its state is).  Every new setup I do, I add >> %x to the psql prompt. >> >> I think it should be part of the default prompt.  Path

Re: Add %x to PROMPT1 and PROMPT2

2020-01-26 Thread Fabien COELHO
Hello Vik, I cannot ever think of a time when I don't want to know if I'm in a transaction or not (and what its state is). Every new setup I do, I add %x to the psql prompt. I think it should be part of the default prompt. Path attached. Isn't there examples in the documentation which

Re: Add %x to PROMPT1 and PROMPT2

2020-01-26 Thread Christoph Berg
Re: Vik Fearing 2020-01-26 <09502c40-cfe1-bb29-10f9-4b3fa7b2b...@2ndquadrant.com> > I cannot ever think of a time when I don't want to know if I'm in a > transaction or not (and what its state is). Every new setup I do, I add > %x to the psql prompt. > > I think it should be part of the default

Add %x to PROMPT1 and PROMPT2

2020-01-26 Thread Vik Fearing
I cannot ever think of a time when I don't want to know if I'm in a transaction or not (and what its state is). Every new setup I do, I add %x to the psql prompt. I think it should be part of the default prompt. Path attached. -- Vik Fearing >From 6118b8b2ab4cfc70525666b8d57eaa351d6c2a3d Mon