Re: Add isCatalogRel in rmgrdesc

2023-12-20 Thread Bertrand Drouvot
Hi, On Thu, Dec 21, 2023 at 10:13:16AM +0900, Masahiko Sawada wrote: > On Thu, Dec 21, 2023 at 9:04 AM Michael Paquier wrote: > > > > On Wed, Dec 20, 2023 at 10:43:30AM +0900, Masahiko Sawada wrote: > > > Thank you for updating the patch. The v2 patch looks good to me. I'll > > > push it, barring

Re: Add isCatalogRel in rmgrdesc

2023-12-20 Thread Masahiko Sawada
On Thu, Dec 21, 2023 at 10:13 AM Masahiko Sawada wrote: > > On Thu, Dec 21, 2023 at 9:04 AM Michael Paquier wrote: > > > > On Wed, Dec 20, 2023 at 10:43:30AM +0900, Masahiko Sawada wrote: > > > Thank you for updating the patch. The v2 patch looks good to me. I'll > > > push it, barring any object

Re: Add isCatalogRel in rmgrdesc

2023-12-20 Thread Masahiko Sawada
On Thu, Dec 21, 2023 at 9:04 AM Michael Paquier wrote: > > On Wed, Dec 20, 2023 at 10:43:30AM +0900, Masahiko Sawada wrote: > > Thank you for updating the patch. The v2 patch looks good to me. I'll > > push it, barring any objections. > > This is capturing the eight records where the flag exists,

Re: Add isCatalogRel in rmgrdesc

2023-12-20 Thread Michael Paquier
On Wed, Dec 20, 2023 at 10:43:30AM +0900, Masahiko Sawada wrote: > Thank you for updating the patch. The v2 patch looks good to me. I'll > push it, barring any objections. This is capturing the eight records where the flag exists, so it looks OK seen from here. As you said, there may be a point

Re: Add isCatalogRel in rmgrdesc

2023-12-19 Thread Masahiko Sawada
On Tue, Dec 19, 2023 at 6:27 PM Drouvot, Bertrand wrote: > > Hi, > > On 12/19/23 9:00 AM, Masahiko Sawada wrote: > > On Tue, Dec 12, 2023 at 6:15 PM Michael Paquier wrote: > >> > >> On Tue, Dec 12, 2023 at 09:23:46AM +0100, Drouvot, Bertrand wrote: > >>> Please find attached a patch to add this f

Re: Add isCatalogRel in rmgrdesc

2023-12-19 Thread Drouvot, Bertrand
Hi, On 12/19/23 9:00 AM, Masahiko Sawada wrote: On Tue, Dec 12, 2023 at 6:15 PM Michael Paquier wrote: On Tue, Dec 12, 2023 at 09:23:46AM +0100, Drouvot, Bertrand wrote: Please find attached a patch to add this field in the related rmgrdesc (i.e all the ones that already provide the snapshot

Re: Add isCatalogRel in rmgrdesc

2023-12-19 Thread Masahiko Sawada
On Tue, Dec 12, 2023 at 6:15 PM Michael Paquier wrote: > > On Tue, Dec 12, 2023 at 09:23:46AM +0100, Drouvot, Bertrand wrote: > > Please find attached a patch to add this field in the related rmgrdesc (i.e > > all the ones that already provide the snapshotConflictHorizon except the one > > related

Re: Add isCatalogRel in rmgrdesc

2023-12-12 Thread Drouvot, Bertrand
Hi, On 12/12/23 10:15 AM, Michael Paquier wrote: On Tue, Dec 12, 2023 at 09:23:46AM +0100, Drouvot, Bertrand wrote: Please find attached a patch to add this field in the related rmgrdesc (i.e all the ones that already provide the snapshotConflictHorizon except the one related to xl_heap_visible

Re: Add isCatalogRel in rmgrdesc

2023-12-12 Thread Michael Paquier
On Tue, Dec 12, 2023 at 09:23:46AM +0100, Drouvot, Bertrand wrote: > Please find attached a patch to add this field in the related rmgrdesc (i.e > all the ones that already provide the snapshotConflictHorizon except the one > related to xl_heap_visible: indeed a new bit was added in its flag field

Add isCatalogRel in rmgrdesc

2023-12-12 Thread Drouvot, Bertrand
Hi hackers, 6af1793954 added a new field namely "isCatalogRel" in some WAL records to help detecting row removal conflict during logical decoding from standby. Please find attached a patch to add this field in the related rmgrdesc (i.e all the ones that already provide the snapshotConflictHorizo