Re: CI cpluspluscheck failures

2024-08-19 Thread Amul Sul
On Mon, Aug 19, 2024 at 1:30 AM Thomas Munro wrote: > > On Mon, Aug 19, 2024 at 12:10 AM Thomas Munro wrote: > > I'm not sure why the first one started happening at the commit > > (aa2d6b15) that caused the second one, I feel like I'm missing > > something... Thanks, Thomas, for addressing the m

Re: CI cpluspluscheck failures

2024-08-18 Thread Thomas Munro
On Mon, Aug 19, 2024 at 12:10 AM Thomas Munro wrote: > I'm not sure why the first one started happening at the commit > (aa2d6b15) that caused the second one, I feel like I'm missing > something... What I was missing is that the LLVM warnings were already present, but not causing failures because

CI cpluspluscheck failures

2024-08-18 Thread Thomas Munro
Hi, The CompilerWarnings cspluspluscheck started failing recently. 1. LLVM library version issue. See commit message for details. 2. pg_verify_backup.h now uses simplehash.h, which references pg_fatal(), which nobody declared. I'm not sure why the first one started happening at the commit (aa