Re: DOCS: Generated table columns are skipped by logical replication

2024-06-20 Thread Amit Kapila
On Thu, Jun 20, 2024 at 6:36 AM Peter Smith wrote: > > Hi Amit. > > I modified the patch text slightly according to Peter E's suggestion [1]. > > I also tested the above examples against all older PostgreSQL versions > 12,13,14,15,16,17. The logical replication behaviour of skipping > generated co

Re: DOCS: Generated table columns are skipped by logical replication

2024-06-19 Thread Peter Smith
On Wed, Jun 19, 2024 at 2:21 PM Amit Kapila wrote: > ... > > Thanks for sharing examples. Your proposed patch as-is looks good to > me. We should back-patch this unless you or someone else thinks > otherwise. > Hi Amit. I modified the patch text slightly according to Peter E's suggestion [1]. I

Re: DOCS: Generated table columns are skipped by logical replication

2024-06-19 Thread Peter Eisentraut
On 18.06.24 08:40, Peter Smith wrote: For now, I have provided just a simple patch for the "Generated Columns" section [3]. Perhaps it is enough. Makes sense. + Generated columns are skipped for logical replication, and cannot be + specified in a CREATE PUBLICATION column-list. Maybe remove t

Re: DOCS: Generated table columns are skipped by logical replication

2024-06-18 Thread Amit Kapila
On Wed, Jun 19, 2024 at 6:46 AM Peter Smith wrote: > > On Tue, Jun 18, 2024 at 9:40 PM Amit Kapila wrote: > > > > On Tue, Jun 18, 2024 at 12:11 PM Peter Smith wrote: > > > > > > While reviewing another thread that proposes to include "generated > > > columns" support for logical replication [1]

Re: DOCS: Generated table columns are skipped by logical replication

2024-06-18 Thread Peter Smith
On Tue, Jun 18, 2024 at 9:40 PM Amit Kapila wrote: > > On Tue, Jun 18, 2024 at 12:11 PM Peter Smith wrote: > > > > While reviewing another thread that proposes to include "generated > > columns" support for logical replication [1] I was looking for any > > existing PostgreSQL documentation on thi

Re: DOCS: Generated table columns are skipped by logical replication

2024-06-18 Thread Amit Kapila
On Tue, Jun 18, 2024 at 12:11 PM Peter Smith wrote: > > While reviewing another thread that proposes to include "generated > columns" support for logical replication [1] I was looking for any > existing PostgreSQL documentation on this topic. > > But, I found almost nothing about it at all -- I on

DOCS: Generated table columns are skipped by logical replication

2024-06-17 Thread Peter Smith
Hi hackers, While reviewing another thread that proposes to include "generated columns" support for logical replication [1] I was looking for any existing PostgreSQL documentation on this topic. But, I found almost nothing about it at all -- I only saw one aside mention saying that logical replic