> On 28 Jul 2021, at 16:15, Daniel Gustafsson wrote:
> I took a look at this I agree with the reviewer that it's a good change.
Pushed to master, thanks!
--
Daniel Gustafsson https://vmware.com/
On Wed, Jul 28, 2021 at 04:15:19PM +0200, Daniel Gustafsson wrote:
> Since get_namespace_name() returns a palloced string, this will lead to a 2x
> leak of the namespace length as opposed to the 1x of today. While hardly a
> big
> deal, it seems prudent to cap this by storing the returned string
I took a look at this I agree with the reviewer that it's a good change. The
output from multiple jobs in vacuumdb is clearly easier to parse with this
since the initial LOG and later DETAIL can be interleaved with other relations
of the same name in other namespaces.
+ get_namespace_name(R
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
Passed make check-world. Running make installcheck-world had 2 errors
On Fri, Jun 25, 2021, at 12:10 PM, Mike wrote:
> Awesome, thanks! Are there any other steps I should take?
No. Keep an eye on this thread. If you modify this patch, check if PostgreSQL
Patch Tester [1] reports failure. Since your patch does not modify a
considerable amount of code, it probably won'
Awesome, thanks! Are there any other steps I should take?
On Wed, Jun 23, 2021 at 5:46 PM Corey Huinker
wrote:
> On Tue, Jun 22, 2021 at 6:08 PM Mike wrote:
>
>> When running a VACUUM or CLUSTER command, the namespace name is not part
>> of the emitted message.
>>
>> Using `vacuumdb` CLI tool r
On Tue, Jun 22, 2021 at 6:08 PM Mike wrote:
> When running a VACUUM or CLUSTER command, the namespace name is not part
> of the emitted message.
>
> Using `vacuumdb` CLI tool recently with multiple jobs, I found that
> reading the output messages harder to match the relations with their
> namespa
which `open` relation was
completed.
Attached is a patch using existing functions to include the namespace in
the output string.
Looking forward to feedback!
-Mike Fiedler
From c66506ad7440a1b501cca858b5120cc568f7a00b Mon Sep 17 00:00:00 2001
From: Mike Fiedler
Date: Tue, 22 Jun 2021 12:05:48 -0400
