Re: Fix a couple of typos in JIT

2020-08-20 Thread David Rowley
On Fri, 21 Aug 2020 at 02:25, Andres Freund wrote: > David, sounds good, after adapting to Abhijit's concerns. Thank you both for having a look. Now pushed. David

Re: Fix a couple of typos in JIT

2020-08-20 Thread Andres Freund
Hi, On 2020-08-20 15:59:26 +0530, Abhijit Menon-Sen wrote: > The original sentence may not be the most shining example of > sentence-ry, but it is correct, and removing the "That" breaks it. That made me laugh ;) David, sounds good, after adapting to Abhijit's concerns. Greetings, Andres Freun

Re: Fix a couple of typos in JIT

2020-08-20 Thread Abhijit Menon-Sen
At 2020-08-20 22:51:41 +1200, dgrowle...@gmail.com wrote: > > > +This is done at query execution time, possibly even only in cases where > > +the relevant task is done a number of times, makes it JIT, rather than > > +ahead-of-time (AOT). Given the way JIT compilation is used in PostgreSQL, > > +th

Re: Fix a couple of typos in JIT

2020-08-20 Thread David Rowley
On Thu, 20 Aug 2020 at 22:29, Abhijit Menon-Sen wrote: > > At 2020-08-20 22:19:49 +1200, dgrowle...@gmail.com wrote: > > > > I was just looking over the JIT code and noticed a few comment and > > documentation typos. The attached fixes them. > > The first change does not seem to be correct: > > -

Re: Fix a couple of typos in JIT

2020-08-20 Thread Abhijit Menon-Sen
At 2020-08-20 22:19:49 +1200, dgrowle...@gmail.com wrote: > > I was just looking over the JIT code and noticed a few comment and > documentation typos. The attached fixes them. The first change does not seem to be correct: -That this is done at query execution time, possibly even only in cases -

Fix a couple of typos in JIT

2020-08-20 Thread David Rowley
Hi, I was just looking over the JIT code and noticed a few comment and documentation typos. The attached fixes them. I'll push this in my UTC+12 morning if nobody objects to any of the changes before then. Unsure if it'll be worth backpatching or not. David fix_a_few_jit_typos.patch Descript