Re: Fix last unitialized memory warning

2023-08-10 Thread Peter Eisentraut
On 09.08.23 17:29, Tristan Partin wrote: On Wed Aug 9, 2023 at 10:02 AM CDT, Peter Eisentraut wrote: On 09.08.23 10:07, Peter Eisentraut wrote: > On 08.08.23 17:14, Tristan Partin wrote: >>> I was able to reproduce the warning now on Fedora.  I agree with the >>> patch >>> >>> -  

Re: Fix last unitialized memory warning

2023-08-10 Thread Richard Guo
On Thu, Aug 10, 2023 at 8:57 AM Julien Rouhaud wrote: > On Wed, Aug 09, 2023 at 10:29:56AM -0500, Tristan Partin wrote: > > On Wed Aug 9, 2023 at 10:02 AM CDT, Peter Eisentraut wrote: > > > > > > This patch has apparently upset one buildfarm member with a very old > > > compiler: > > > >

Re: Fix last unitialized memory warning

2023-08-09 Thread Julien Rouhaud
On Wed, Aug 09, 2023 at 10:29:56AM -0500, Tristan Partin wrote: > On Wed Aug 9, 2023 at 10:02 AM CDT, Peter Eisentraut wrote: > > > > This patch has apparently upset one buildfarm member with a very old > > compiler: > > https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=lapwing=HEAD > >

Re: Fix last unitialized memory warning

2023-08-09 Thread Tristan Partin
On Wed Aug 9, 2023 at 10:02 AM CDT, Peter Eisentraut wrote: On 09.08.23 10:07, Peter Eisentraut wrote: > On 08.08.23 17:14, Tristan Partin wrote: >>> I was able to reproduce the warning now on Fedora.  I agree with the >>> patch >>> >>> -   PgBenchValue vargs[MAX_FARGS]; >>> +  

Re: Fix last unitialized memory warning

2023-08-09 Thread Peter Eisentraut
On 09.08.23 10:07, Peter Eisentraut wrote: On 08.08.23 17:14, Tristan Partin wrote: I was able to reproduce the warning now on Fedora.  I agree with the patch -   PgBenchValue vargs[MAX_FARGS]; +   PgBenchValue vargs[MAX_FARGS] = { 0 }; I suggest to also do   typedef enum   { -  

Re: Fix last unitialized memory warning

2023-08-09 Thread Peter Eisentraut
On 08.08.23 17:14, Tristan Partin wrote: I was able to reproduce the warning now on Fedora.  I agree with the patch -   PgBenchValue vargs[MAX_FARGS]; +   PgBenchValue vargs[MAX_FARGS] = { 0 }; I suggest to also do   typedef enum   { -   PGBT_NO_VALUE, +   PGBT_NO_VALUE = 0,

Re: Fix last unitialized memory warning

2023-08-08 Thread Tristan Partin
On Tue Aug 8, 2023 at 5:20 AM CDT, Peter Eisentraut wrote: On 19.07.23 19:15, Tristan Partin wrote: > On Sun Jul 9, 2023 at 2:23 AM CDT, Peter Eisentraut wrote: >> On 06.07.23 15:41, Tristan Partin wrote: >> > On Thu Jul 6, 2023 at 3:21 AM CDT, Peter Eisentraut wrote: >> >> On 05.07.23 23:06,

Re: Fix last unitialized memory warning

2023-08-08 Thread Peter Eisentraut
On 19.07.23 19:15, Tristan Partin wrote: On Sun Jul 9, 2023 at 2:23 AM CDT, Peter Eisentraut wrote: On 06.07.23 15:41, Tristan Partin wrote: > On Thu Jul 6, 2023 at 3:21 AM CDT, Peter Eisentraut wrote: >> On 05.07.23 23:06, Tristan Partin wrote: >>> Thanks for following up. My system is Fedora

Re: Fix last unitialized memory warning

2023-07-19 Thread Tristan Partin
On Sun Jul 9, 2023 at 2:23 AM CDT, Peter Eisentraut wrote: On 06.07.23 15:41, Tristan Partin wrote: > On Thu Jul 6, 2023 at 3:21 AM CDT, Peter Eisentraut wrote: >> On 05.07.23 23:06, Tristan Partin wrote: >>> Thanks for following up. My system is Fedora 38. I can confirm this is >>> still

Re: Fix last unitialized memory warning

2023-07-09 Thread Peter Eisentraut
On 06.07.23 15:41, Tristan Partin wrote: On Thu Jul 6, 2023 at 3:21 AM CDT, Peter Eisentraut wrote: On 05.07.23 23:06, Tristan Partin wrote: Thanks for following up. My system is Fedora 38. I can confirm this is still happening on master. $ gcc --version gcc (GCC) 13.1.1 20230614 (Red Hat

Re: Fix last unitialized memory warning

2023-07-06 Thread Andres Freund
Hi, On 2023-07-06 10:21:44 +0200, Peter Eisentraut wrote: > On 05.07.23 23:06, Tristan Partin wrote: > > Thanks for following up. My system is Fedora 38. I can confirm this is > > still happening on master. > > > > $ gcc --version > > gcc (GCC) 13.1.1 20230614 (Red Hat 13.1.1-4) > > Copyright

Re: Fix last unitialized memory warning

2023-07-06 Thread Tristan Partin
On Thu Jul 6, 2023 at 3:21 AM CDT, Peter Eisentraut wrote: > On 05.07.23 23:06, Tristan Partin wrote: > > Thanks for following up. My system is Fedora 38. I can confirm this is > > still happening on master. > > > > $ gcc --version > > gcc (GCC) 13.1.1 20230614 (Red Hat 13.1.1-4) > > Copyright

Re: Fix last unitialized memory warning

2023-07-06 Thread Peter Eisentraut
On 05.07.23 23:06, Tristan Partin wrote: Thanks for following up. My system is Fedora 38. I can confirm this is still happening on master. $ gcc --version gcc (GCC) 13.1.1 20230614 (Red Hat 13.1.1-4) Copyright (C) 2023 Free Software Foundation, Inc. This is free software; see the source for

Re: Fix last unitialized memory warning

2023-07-05 Thread Tristan Partin
On Mon Jul 3, 2023 at 1:19 AM CDT, Peter Eisentraut wrote: > On 07.06.23 16:31, Tristan Partin wrote: > > This patch is really not necessary from a functional point of view. It > > is only necessary if we want to silence a compiler warning. > > > > Tested on `gcc (GCC) 13.1.1 20230511 (Red Hat

Re: Fix last unitialized memory warning

2023-07-03 Thread Peter Eisentraut
On 07.06.23 16:31, Tristan Partin wrote: This patch is really not necessary from a functional point of view. It is only necessary if we want to silence a compiler warning. Tested on `gcc (GCC) 13.1.1 20230511 (Red Hat 13.1.1-2)`. After silencing this warning, all I am left with (given my build

Re: Fix last unitialized memory warning

2023-06-08 Thread Gurjeet Singh
On Wed, Jun 7, 2023 at 7:31 AM Tristan Partin wrote: > > This patch is really not necessary from a functional point of view. It > is only necessary if we want to silence a compiler warning. > > Tested on `gcc (GCC) 13.1.1 20230511 (Red Hat 13.1.1-2)`. ... > From my perspective, this warning

Fix last unitialized memory warning

2023-06-07 Thread Tristan Partin
This patch is really not necessary from a functional point of view. It is only necessary if we want to silence a compiler warning. Tested on `gcc (GCC) 13.1.1 20230511 (Red Hat 13.1.1-2)`. After silencing this warning, all I am left with (given my build configuration) is: [1667/2280] Compiling