On Sat, 11 Nov 2023 at 00:03, Krishnakumar R wrote:
>
> Thank you for review, Peter.
>
> Makes sense on the split part. Was starting to think in same lines, at the
> end of last iteration. Will come back shortly.
>
> On Fri, Nov 10, 2023 at 12:48 AM Peter Eisentraut
> wrote:
>>
>> On 17.10.23
Thank you for review, Peter.
Makes sense on the split part. Was starting to think in same lines, at the
end of last iteration. Will come back shortly.
On Fri, Nov 10, 2023 at 12:48 AM Peter Eisentraut
wrote:
> On 17.10.23 03:32, Krishnakumar R wrote:
> >> The version comparison has been moved
On 17.10.23 03:32, Krishnakumar R wrote:
The version comparison has been moved from initdb to bootstrap. This
created some compatibility problems with windows tests. For now I kept
the version check to not have \n added, which worked fine and serves
the purpose. However hoping to have something
On 06.10.23 02:24, Krishnakumar R wrote:
elog(INFO, "Open bki file %s\n", bki_file);
+ boot_yyin = fopen(bki_file, "r");
Why is this needed? It already reads the bki file from stdin?
We no longer open the bki file in initdb and pass to postgres to parse
from stdin, instead we open the bki
> The version comparison has been moved from initdb to bootstrap. This
> created some compatibility problems with windows tests. For now I kept
> the version check to not have \n added, which worked fine and serves
> the purpose. However hoping to have something better in v3 in addition
> to
Thank you, Peter, Andres and Tom for your comments and thoughts.
Hi Peter,
> For example, for NAMEDATALEN, SIZEOF_POINTER, ALIGNOF_POINTER,
> FLOAT8PASSBYVAL, these are known at build time, so we could have
> genbki.pl substitute them at build time.
I have modified the patch to use genbki to
On 01.09.23 10:01, Krishnakumar R wrote:
This patch moves the pre-processing for tokens in the bki file from
initdb to bootstrap. With these changes the bki file will only be
opened once in bootstrap and parsing will be done by the bootstrap
parser.
I did some rough performance tests on this.
Hi,
On 2023-09-01 14:59:57 +0200, Peter Eisentraut wrote:
> On 01.09.23 14:37, Tom Lane wrote:
> > Krishnakumar R writes:
> > > This patch moves the pre-processing for tokens in the bki file from
> > > initdb to bootstrap. With these changes the bki file will only be
> > > opened once in
On 01.09.23 14:37, Tom Lane wrote:
Krishnakumar R writes:
This patch moves the pre-processing for tokens in the bki file from
initdb to bootstrap. With these changes the bki file will only be
opened once in bootstrap and parsing will be done by the bootstrap
parser.
You haven't provided any
Krishnakumar R writes:
> This patch moves the pre-processing for tokens in the bki file from
> initdb to bootstrap. With these changes the bki file will only be
> opened once in bootstrap and parsing will be done by the bootstrap
> parser.
You haven't provided any iota of evidence why this would
Hi All,
This patch moves the pre-processing for tokens in the bki file from
initdb to bootstrap. With these changes the bki file will only be
opened once in bootstrap and parsing will be done by the bootstrap
parser.
The flow of bki file processing will be as follows:
- In initdb gather the
11 matches
Mail list logo
