Re: New default role- 'pg_read_all_data'

2021-03-04 Thread gkokolatos
Hi, ‐‐‐ Original Message ‐‐‐ On Monday, November 23, 2020 11:31 PM, Stephen Frost wrote: > Greetings, > > - Anastasia Lubennikova (a.lubennik...@postgrespro.ru) wrote: > > > On 29.10.2020 17:19, Stephen Frost wrote: > > > > > - Georgios Kokolatos (gkokola...@protonmail.com)

Re: New default role- 'pg_read_all_data'

2020-11-23 Thread Stephen Frost
Greetings, * Anastasia Lubennikova (a.lubennik...@postgrespro.ru) wrote: > On 29.10.2020 17:19, Stephen Frost wrote: > >* Georgios Kokolatos (gkokola...@protonmail.com) wrote: > >>this patch is in "Ready for committer" state and the Cfbot is happy. > >Glad that's still the case. :) > > > >>Is

Re: New default role- 'pg_read_all_data'

2020-11-23 Thread Anastasia Lubennikova
On 29.10.2020 17:19, Stephen Frost wrote: Greetings, * Georgios Kokolatos (gkokola...@protonmail.com) wrote: this patch is in "Ready for committer" state and the Cfbot is happy. Glad that's still the case. :) Is there any committer that is available for taking a look at it? If there aren't

Re: New default role- 'pg_read_all_data'

2020-10-29 Thread Georgios Kokolatos
Hi, this patch is in "Ready for committer" state and the Cfbot is happy. Is there any committer that is available for taking a look at it? Cheers, //Georgios - CFM 2020-11

Re: New default role- 'pg_read_all_data'

2020-10-29 Thread Stephen Frost
Greetings, * Georgios Kokolatos (gkokola...@protonmail.com) wrote: > this patch is in "Ready for committer" state and the Cfbot is happy. Glad that's still the case. :) > Is there any committer that is available for taking a look at it? If there aren't any objections or further comments, I'll

Re: New default role- 'pg_read_all_data'

2020-09-01 Thread Georgios Kokolatos
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: not tested Documentation:not tested Version 2 of the patch, implements a useful feature. Based on the

Re: New default role- 'pg_read_all_data'

2020-08-31 Thread gkokolatos
‐‐‐ Original Message ‐‐‐ On Monday, 31 August 2020 02:20, Stephen Frost wrote: > Greetings, > > - Stephen Frost (sfr...@snowman.net) wrote: > > > - Magnus Hagander (mag...@hagander.net) wrote: > > > > > On Fri, Aug 28, 2020 at 2:38 PM Stephen Frost sfr...@snowman.net wrote: > >

Re: New default role- 'pg_read_all_data'

2020-08-30 Thread Stephen Frost
Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Magnus Hagander (mag...@hagander.net) wrote: > > On Fri, Aug 28, 2020 at 2:38 PM Stephen Frost wrote: > > > * Magnus Hagander (mag...@hagander.net) wrote: > > > > Without having actually looked at the code, definite +1 for this > > > >

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Stephen Frost
Greetings, * Gilles Darold (gil...@darold.net) wrote: > Le 28/08/2020 à 16:52, Stephen Frost a écrit : > >Using an FDW will often also require having a user mapping and there's > >no way for that to be accomplished through only GRANT'ing a default > >role, so I don't think we should mix this

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Georgios Kokolatos
Thank you for the patch. My high level review comment: The patch seems to be implementing a useful and requested feature. The patch applies cleanly and passes the basic regress tests. Also the commitfest bot is happy. A first pass at the code, has not revealed any worthwhile comments. Please

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Gilles Darold
Le 28/08/2020 à 16:52, Stephen Frost a écrit : Greetings, * Gilles Darold (gil...@darold.net) wrote: Le 28/08/2020 à 15:26, Stephen Frost a écrit : * Magnus Hagander (mag...@hagander.net) wrote: On Fri, Aug 28, 2020 at 2:38 PM Stephen Frost wrote: * Magnus Hagander (mag...@hagander.net)

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Stephen Frost
Greetings, * Gilles Darold (gil...@darold.net) wrote: > Le 28/08/2020 à 15:26, Stephen Frost a écrit : > >* Magnus Hagander (mag...@hagander.net) wrote: > >>On Fri, Aug 28, 2020 at 2:38 PM Stephen Frost wrote: > >>>* Magnus Hagander (mag...@hagander.net) wrote: > Without having actually

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Gilles Darold
Le 28/08/2020 à 15:26, Stephen Frost a écrit : Greetings, * Magnus Hagander (mag...@hagander.net) wrote: On Fri, Aug 28, 2020 at 2:38 PM Stephen Frost wrote: * Magnus Hagander (mag...@hagander.net) wrote: Without having actually looked at the code, definite +1 for this feature. It's much

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Fri, Aug 28, 2020 at 2:38 PM Stephen Frost wrote: > > * Magnus Hagander (mag...@hagander.net) wrote: > > > Without having actually looked at the code, definite +1 for this feature. > > > It's much requested... > > > > Thanks. > > > >

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Isaac Morland
On Fri, 28 Aug 2020 at 08:54, Stephen Frost wrote: > > Yes, it's the latter. I'm not really sure about the documentation > change you're contemplating- have a specific suggestion? > Sorry, I was discussing this as if it was an abstract idea, not a concrete patch. I've just taken a look at the

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Stephen Frost
Greetings, * gkokola...@pm.me (gkokola...@pm.me) wrote: > On Friday, 28 August 2020 15:43, Stephen Frost wrote: > > > What privileges would the user be left with? Would it be possible to end > > > up in the same privilege only with a GRANT command? > > > > I'm not sure what's being asked here.

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread gkokolatos
‐‐‐ Original Message ‐‐‐ On Friday, 28 August 2020 15:43, Stephen Frost wrote: > Greetings, > > - Georgios Kokolatos (gkokola...@protonmail.com) wrote: > > > The patch seems to be implementing a useful and requested feature. > > The patch applies cleanly and passes the basic

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Magnus Hagander
On Fri, Aug 28, 2020 at 2:43 PM Stephen Frost wrote: > Greetings, > > * Georgios Kokolatos (gkokola...@protonmail.com) wrote: > > The patch seems to be implementing a useful and requested feature. > > The patch applies cleanly and passes the basic regress tests. Also the > commitfest bot is

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Stephen Frost
Greetings, * Isaac Morland (isaac.morl...@gmail.com) wrote: > On Fri, 28 Aug 2020 at 08:43, Stephen Frost wrote: > > This would simply REVOKE that role from the user. Privileges > > independently GRANT'd directly to the user wouldn't be affected. Nor > > would other role membership. > > > > >

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Isaac Morland
On Fri, 28 Aug 2020 at 08:43, Stephen Frost wrote: > This would simply REVOKE that role from the user. Privileges > independently GRANT'd directly to the user wouldn't be affected. Nor > would other role membership. > > > What privileges would the user be left with? Would it be possible to

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Magnus Hagander
On Fri, Aug 28, 2020 at 2:38 PM Stephen Frost wrote: > Greetings, > > * Magnus Hagander (mag...@hagander.net) wrote: > > Without having actually looked at the code, definite +1 for this feature. > > It's much requested... > > Thanks. > > > But, should we also have a pg_write_all_data to go along

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Stephen Frost
Greetings, * Georgios Kokolatos (gkokola...@protonmail.com) wrote: > The patch seems to be implementing a useful and requested feature. > The patch applies cleanly and passes the basic regress tests. Also the > commitfest bot is happy. > > A first pass at the code, has not revealed any

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > Without having actually looked at the code, definite +1 for this feature. > It's much requested... Thanks. > But, should we also have a pg_write_all_data to go along with it? Perhaps, but could certainly be a different patch, and it'd

Re: New default role- 'pg_read_all_data'

2020-08-28 Thread Magnus Hagander
On Fri, Aug 28, 2020 at 2:30 AM Stephen Frost wrote: > Greetings, > > There's no shortage of requests and responses regarding how to have a > 'read all of the data' role in PG, with various hacks involving "GRANT > ALL" and "ALTER DEFAULT PRIVILEGES" to "solve" this, neither of which > really

Re: New default role- 'pg_read_all_data'

2020-08-27 Thread Steven Pousty
On Thu, Aug 27, 2020 at 5:30 PM Stephen Frost wrote: > Greetings, > > There's no shortage of requests and responses regarding how to have a > 'read all of the data' role in PG, with various hacks involving "GRANT > ALL" and "ALTER DEFAULT PRIVILEGES" to "solve" this, neither of which > really

New default role- 'pg_read_all_data'

2020-08-27 Thread Stephen Frost
Greetings, There's no shortage of requests and responses regarding how to have a 'read all of the data' role in PG, with various hacks involving "GRANT ALL" and "ALTER DEFAULT PRIVILEGES" to "solve" this, neither of which really works long term ("GRANT ALL" is one-time, and "ALTER DEFAULT" only