RE: Is psSocketPoll doing the right thing?

2023-02-19 Thread Hayato Kuroda (Fujitsu)
Dear Horiguchi-san, My comment may be no longer needed, but I can +1 to your opinion. > > On 2023/02/09 11:50, Kyotaro Horiguchi wrote: > > > Hello. > > > While looking a patch, I found that pqSocketPoll passes through the > > > result from poll(2) to the caller and throws away revents. If I > >

Re: Is psSocketPoll doing the right thing?

2023-02-15 Thread Katsuragi Yuta
On 2023-02-10 10:42, Kyotaro Horiguchi wrote: On 2023/02/09 11:50, Kyotaro Horiguchi wrote: > Hello. > While looking a patch, I found that pqSocketPoll passes through the > result from poll(2) to the caller and throws away revents. If I > understand it correctly, poll() *doesn't* return -1 nor

Re: Is psSocketPoll doing the right thing?

2023-02-09 Thread Kyotaro Horiguchi
> Subject: is p*s*Socket.. Oops... At Thu, 9 Feb 2023 17:32:08 +0900, Fujii Masao wrote in > > > On 2023/02/09 11:50, Kyotaro Horiguchi wrote: > > Hello. > > While looking a patch, I found that pqSocketPoll passes through the > > result from poll(2) to the caller and throws away revents. If

Re: Is psSocketPoll doing the right thing?

2023-02-09 Thread Fujii Masao
On 2023/02/09 11:50, Kyotaro Horiguchi wrote: Hello. While looking a patch, I found that pqSocketPoll passes through the result from poll(2) to the caller and throws away revents. If I understand it correctly, poll() *doesn't* return -1 nor errno by the reason it has set POLLERR, POLLHUP,