Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2024-05-15 Thread Nazir Bilal Yavuz
Hi, On Sun, 12 May 2024 at 14:53, Peter Eisentraut wrote: > > On 14.12.23 14:40, Nazir Bilal Yavuz wrote: > > On Fri, 6 Oct 2023 at 17:07, Tom Lane wrote: > >> > >> As a quick cross-check, I searched our commit log to see how many > >> README-only commits there were so far this year. I found 11

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2024-05-12 Thread Peter Eisentraut
On 14.12.23 14:40, Nazir Bilal Yavuz wrote: On Fri, 6 Oct 2023 at 17:07, Tom Lane wrote: As a quick cross-check, I searched our commit log to see how many README-only commits there were so far this year. I found 11 since January. (Several were triggered by the latest round of pgindent code a

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2024-01-17 Thread Andrew Dunstan
On 2023-10-06 Fr 10:07, Tom Lane wrote: Peter Eisentraut writes: I don't have a good sense of what you are trying to optimize for. If it's the mainline build-on-every-commit type, then I wonder how many commits would really be affected by this. Like, how many commits touch only a README fil

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2024-01-17 Thread Daniel Gustafsson
> On 14 Dec 2023, at 14:40, Nazir Bilal Yavuz wrote: > On Fri, 6 Oct 2023 at 17:07, Tom Lane wrote: >> Not sure what that tells us about the value of changing the CI >> logic, but it does seem like it could be worth the one-liner >> change needed to teach buildfarm animals to ignore READMEs. >

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2023-12-14 Thread Nazir Bilal Yavuz
Hi, Sorry for the late reply. On Fri, 6 Oct 2023 at 17:07, Tom Lane wrote: > > As a quick cross-check, I searched our commit log to see how many > README-only commits there were so far this year. I found 11 since > January. (Several were triggered by the latest round of pgindent > code and pro

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2023-10-06 Thread Tom Lane
Peter Eisentraut writes: > I don't have a good sense of what you are trying to optimize for. If > it's the mainline build-on-every-commit type, then I wonder how many > commits would really be affected by this. Like, how many commits touch > only a README file. If it's for things like the cf

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2023-10-06 Thread Peter Eisentraut
On 26.09.23 16:51, Nazir Bilal Yavuz wrote: Also note that there are also dependencies in the other direction. For example, the psql help is compiled from XML DocBook sources. So your other patch would also need to include similar changesInclude() clauses. If there are more cases like this, i

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2023-09-26 Thread Nazir Bilal Yavuz
Hi, On Tue, 26 Sept 2023 at 13:48, Peter Eisentraut wrote: > > On 25.09.23 12:56, Nazir Bilal Yavuz wrote: > > + # Only run if a specific OS is not requested and if there are changes in > > docs > > + # or in the CI files. > > + skip: > > > +$CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:.*' |

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2023-09-26 Thread Peter Eisentraut
On 25.09.23 12:56, Nazir Bilal Yavuz wrote: + # Only run if a specific OS is not requested and if there are changes in docs + # or in the CI files. + skip: > +$CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:.*' || +!changesInclude('doc/**', +'.cirrus.yml', +

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2023-09-25 Thread Nazir Bilal Yavuz
Hi, I attached the second version of the patch. On Mon, 11 Sept 2023 at 15:11, Daniel Gustafsson wrote: > > > On 11 Sep 2023, at 13:03, Nazir Bilal Yavuz wrote: > > >> Almost, but not entirely. There are a set of scripts which generate > >> content > >> for the docs based on files in src/, li

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2023-09-11 Thread Daniel Gustafsson
> On 11 Sep 2023, at 13:03, Nazir Bilal Yavuz wrote: >> Almost, but not entirely. There are a set of scripts which generate content >> for the docs based on files in src/, like >> src/backend/catalog/sql_features.txt >> and src/include/parser/kwlist.h. If those source files change, or their >>

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2023-09-11 Thread Nazir Bilal Yavuz
Hi, Thanks for the reply! On Fri, 8 Sept 2023 at 11:05, Daniel Gustafsson wrote: > > > On 7 Sep 2023, at 18:06, Nazir Bilal Yavuz wrote: > > > if the changes are only in the docs, don't run > > all tasks except building the docs task; this could help to save more > > CI times. > > A related ide

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2023-09-08 Thread Daniel Gustafsson
> On 7 Sep 2023, at 18:06, Nazir Bilal Yavuz wrote: > if the changes are only in the docs, don't run > all tasks except building the docs task; this could help to save more > CI times. A related idea for docs in order to save CI time: if the changes are only in internal docs, ie README files, th