Re: ERROR: failed to add item to the index page

2019-05-02 Thread Andreas Joseph Krogh
På torsdag 02. mai 2019 kl. 21:38:02, skrev Peter Geoghegan : > Pushed, though final version does the test a little differently. It > adds the required heap TID space to itupsz, rather than subtracting it > from pgspc. This is actually representative of the underlying logic, > and avoids unsign

Re: ERROR: failed to add item to the index page

2019-05-02 Thread Peter Geoghegan
On Tue, Apr 30, 2019 at 6:28 PM Peter Geoghegan wrote: > Attached is a much more polished version of the same patch. I tried to > make clear how the "page full" test (the test that has been fixed to > take heap TID space for high key into account) is related to other > close-by code, such as the t

Re: ERROR: failed to add item to the index page

2019-04-30 Thread Peter Geoghegan
On Tue, Apr 30, 2019 at 10:58 AM Peter Geoghegan wrote:j > I have found what the problem is. I simply neglected to make a > conservative assumption about suffix truncation needing to add a heap > TID to a leaf page's new high key in nbtsort.c (following commit > dd299df8189), even though I didn't

Sv: Re: ERROR: failed to add item to the index page

2019-04-30 Thread Andreas Joseph Krogh
På tirsdag 30. april 2019 kl. 21:26:52, skrev Andres Freund mailto:and...@anarazel.de>>: > [...] > The standard on pg lists is to write in a manner that's usable for both > text mail readers and the archive. Doesn't terribly matter to the > occasional one-off poster on -general, but you're not th

Re: ERROR: failed to add item to the index page

2019-04-30 Thread Andres Freund
Hi, On 2019-04-30 21:23:21 +0200, Andreas Joseph Krogh wrote: > På tirsdag 30. april 2019 kl. 20:59:43, skrev Andres Freund > >: [...] > Andreas, unfortunately your emails are pretty unreadable. Check the > quoted email, and the web archive: > > > https://www.post

Re: ERROR: failed to add item to the index page

2019-04-30 Thread Andreas Joseph Krogh
På tirsdag 30. april 2019 kl. 20:59:43, skrev Andres Freund mailto:and...@anarazel.de>>: [...] Andreas, unfortunately your emails are pretty unreadable. Check the quoted email, and the web archive: https://www.postgresql.org/message-id/VisenaEmail.41.51d7719d814a1f54.16a6f98a5e9%40tc7-visena

Re: ERROR: failed to add item to the index page

2019-04-30 Thread Andres Freund
Hi, On 2019-04-30 20:54:45 +0200, Andreas Joseph Krogh wrote: > På tirsdag 30. april 2019 kl. 19:58:31, skrev Peter Geoghegan >: On Tue, Apr 30, 2019 at 9:59 AM Peter Geoghegan > wrote: > > I'll start investigating the problem right away. > > I have found what the proble

Re: Re: ERROR: failed to add item to the index page

2019-04-30 Thread Peter Geoghegan
On Tue, Apr 30, 2019 at 11:54 AM Andreas Joseph Krogh wrote: > Nice, thanks! Thanks for the report! -- Peter Geoghegan

Sv: Re: ERROR: failed to add item to the index page

2019-04-30 Thread Andreas Joseph Krogh
På tirsdag 30. april 2019 kl. 19:58:31, skrev Peter Geoghegan mailto:p...@bowt.ie>>: On Tue, Apr 30, 2019 at 9:59 AM Peter Geoghegan wrote: > I'll start investigating the problem right away. I have found what the problem is. I simply neglected to make a conservative assumption about suffix tr

Re: ERROR: failed to add item to the index page

2019-04-30 Thread Peter Geoghegan
On Tue, Apr 30, 2019 at 9:59 AM Peter Geoghegan wrote: > I'll start investigating the problem right away. I have found what the problem is. I simply neglected to make a conservative assumption about suffix truncation needing to add a heap TID to a leaf page's new high key in nbtsort.c (following

Re: ERROR: failed to add item to the index page

2019-04-30 Thread Peter Geoghegan
On Tue, Apr 30, 2019 at 9:56 AM Andreas Joseph Krogh wrote: > I've sent you guys a link (Google Drive) off-list. I'll start investigating the problem right away. Thanks -- Peter Geoghegan

Re: ERROR: failed to add item to the index page

2019-04-30 Thread Andreas Joseph Krogh
På tirsdag 30. april 2019 kl. 18:48:45, skrev Peter Geoghegan mailto:p...@bowt.ie>>: On Tue, Apr 30, 2019 at 9:47 AM Tom Lane wrote: > Andreas Joseph Krogh writes: > > I have a 1.4GB dump (only one table) which reliably reproduces this error. > > Shall I share it off-list? -- > > That's awf

Re: ERROR: failed to add item to the index page

2019-04-30 Thread Peter Geoghegan
On Tue, Apr 30, 2019 at 9:47 AM Tom Lane wrote: > Andreas Joseph Krogh writes: > > I have a 1.4GB dump (only one table) which reliably reproduces this error. > > Shall I share it off-list? -- > > That's awfully large :-(. How do you have in mind to transmit it? I've send dumps that were larger

Re: ERROR: failed to add item to the index page

2019-04-30 Thread Tom Lane
Andreas Joseph Krogh writes: > I have a 1.4GB dump (only one table) which reliably reproduces this error. > Shall I share it off-list? -- That's awfully large :-(. How do you have in mind to transmit it? Maybe you could write a short script that generates dummy data to reproduce the problem?

Re: ERROR: failed to add item to the index page

2019-04-30 Thread Peter Geoghegan
On Tue, Apr 30, 2019 at 9:44 AM Andreas Joseph Krogh wrote: > I have a 1.4GB dump (only one table) which reliably reproduces this error. > Shall I share it off-list? I would be quite interested in this, too, since there is a chance that it's my bug. -- Peter Geoghegan

Re: ERROR: failed to add item to the index page

2019-04-30 Thread Andreas Joseph Krogh
På tirsdag 30. april 2019 kl. 16:27:05, skrev Andreas Joseph Krogh < andr...@visena.com >: [snip] Yep, happens without --with-llvm also. I'll try to load only the necessary table(s) to reproduce. I have a 1.4GB dump (only one table) which reliably reproduces this error.

Re: Sv: Sv: Re: Sv: Re: ERROR: failed to add item to the index page

2019-04-30 Thread Andrew Dunstan
Please fix or abstain from using the MUA that produces this monstrosity of a Subject: "Sv: Sv: Re: Sv: Re: ERROR: failed to add item to the index page" cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA

Sv: Sv: Re: Sv: Re: ERROR: failed to add item to the index page

2019-04-30 Thread Andreas Joseph Krogh
På tirsdag 30. april 2019 kl. 16:03:04, skrev Andreas Joseph Krogh < andr...@visena.com >: På tirsdag 30. april 2019 kl. 15:53:50, skrev Tom Lane mailto:t...@sss.pgh.pa.us>>: Andreas Joseph Krogh writes: > I built with this: make distclean && ./configure > --prefix=$

Sv: Re: Sv: Re: ERROR: failed to add item to the index page

2019-04-30 Thread Andreas Joseph Krogh
På tirsdag 30. april 2019 kl. 15:53:50, skrev Tom Lane mailto:t...@sss.pgh.pa.us>>: Andreas Joseph Krogh writes: > I built with this: make distclean && ./configure > --prefix=$HOME/programs/postgresql-master --with-openssl --with-llvm && make -j > 8 install-world-contrib-recurse install-world-

Re: Sv: Re: ERROR: failed to add item to the index page

2019-04-30 Thread Tom Lane
Andreas Joseph Krogh writes: > I built with this: make distclean && ./configure > --prefix=$HOME/programs/postgresql-master --with-openssl --with-llvm && make > -j > 8 install-world-contrib-recurse install-world-doc-recurse --with-llvm, eh? Does it reproduce without that? What platform is th

Sv: Re: ERROR: failed to add item to the index page

2019-04-30 Thread Andreas Joseph Krogh
På tirsdag 30. april 2019 kl. 15:43:16, skrev Tom Lane mailto:t...@sss.pgh.pa.us>>: Andreas Joseph Krogh writes: > With master (3dbb317d32f4f084ef7badaed8ef36f5c9b85fe6) I'm getting this: > visena=# CREATE INDEX origo_email_part_hdrvl_value_idx ON > public.origo_email_part_headervalue USING btr

Re: ERROR: failed to add item to the index page

2019-04-30 Thread Tom Lane
Andreas Joseph Krogh writes: > With master (3dbb317d32f4f084ef7badaed8ef36f5c9b85fe6) I'm getting this: > visena=# CREATE INDEX origo_email_part_hdrvl_value_idx ON > public.origo_email_part_headervalue USING btree > (lower(substr((header_value)::text, 0, 1000)) varchar_pattern_ops); > psql: ER