> On 3 Jul 2023, at 13:37, Heikki Linnakangas wrote:
> If "pg_ctl restart" fails because of a timeout, for example, the PID file
> could be present. Previously, the _update_pid(0) would error out on that, but
> now it's accepted. I think that's fine, but just wanted to point it out.
On 31/05/2023 15:47, Daniel Gustafsson wrote:
The SSL tests for pg_ctl restarts with an incorrect key passphrase run pg_ctl
manually and use the internal method _update_pid to set the server PID file
accordingly. This is needed since $node->restart will BAIL in case the restart
fails, which
> On 31 May 2023, at 15:46, Melih Mutlu wrote:
> I was comparing this new restart function to start and stop functions.
> I see that restart() does not return a value if it's successful while
> others return 1.
> Its return value is not checked anywhere, so it may not be useful at
> the moment.
Hi Daniel,
Thanks for the patch.
Daniel Gustafsson , 31 May 2023 Çar, 15:48 tarihinde
şunu yazdı:
>
> To avoid this, the attached adds fail_ok functionality to restart() which
> makes
> it easier to use it in tests, and aligns it with how stop() and start() works.
> The resulting SSL tests are
The SSL tests for pg_ctl restarts with an incorrect key passphrase run pg_ctl
manually and use the internal method _update_pid to set the server PID file
accordingly. This is needed since $node->restart will BAIL in case the restart
fails, which clearly isn't useful to anyone wanting to test
