Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included

Hi, It seems like there are some instances where xloginsert.h is included right after xlog.h but xlog.h has already included xloginsert.h. Unless I'm missing something badly, we can safely remove including xloginsert.h after xlog.h. Attempting to post a patch to remove the extra xloginsert.h inclu

Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included

On 2022-Jan-28, Bharath Rupireddy wrote: > Hi, > > It seems like there are some instances where xloginsert.h is included > right after xlog.h but xlog.h has already included xloginsert.h. > Unless I'm missing something badly, we can safely remove including > xloginsert.h after xlog.h. Attempting

Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included

On Fri, Jan 28, 2022 at 9:25 PM Alvaro Herrera wrote: > > On 2022-Jan-28, Bharath Rupireddy wrote: > > > Hi, > > > > It seems like there are some instances where xloginsert.h is included > > right after xlog.h but xlog.h has already included xloginsert.h. > > Unless I'm missing something badly, we

Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included

On 2022-Jan-29, Bharath Rupireddy wrote: > Removing the xloginsert.h in xlog.h would need us to add xloginsert.h > in more areas. Sure. > And also, it might break any non-core extensions that > includes just xlog.h and gets xloginsert.h. That's a pretty easy fix anyway -- it's not even version-

Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included

On Sun, Jan 30, 2022 at 1:07 AM Alvaro Herrera wrote: > > On 2022-Jan-29, Bharath Rupireddy wrote: > > > Removing the xloginsert.h in xlog.h would need us to add xloginsert.h > > in more areas. > > Sure. > > > And also, it might break any non-core extensions that > > includes just xlog.h and gets

Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included

Hi, On Sun, Jan 30, 2022 at 06:52:48PM +0530, Bharath Rupireddy wrote: > > Here's the v3 patch removing xloginsert.h from xlog.h and adding > xloginsert.h in the required files. +1, this approach is better. In general it's better to increase the number of include lines rather than having a few

Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included

On 2022-Jan-30, Bharath Rupireddy wrote: > Here's the v3 patch removing xloginsert.h from xlog.h and adding > xloginsert.h in the required files. Pushed, but I added xloginsert.h to 9 additional files that needed it to avoid compiler warnings. Thanks! -- Álvaro Herrera Valdivia, C