Re: Remove io prefix from pg_stat_io columns

2023-04-24 Thread Andres Freund
On 2023-04-21 07:38:01 +0900, Michael Paquier wrote: > On Thu, Apr 20, 2023 at 11:38:42AM +0900, Michael Paquier wrote: > > No worries, committers should take care of that. > > Done as of 0ecb87e, as I can keep an eye on the buildfarm today, with > a catversion bump. Thanks!

Re: Remove io prefix from pg_stat_io columns

2023-04-20 Thread Michael Paquier
On Thu, Apr 20, 2023 at 11:38:42AM +0900, Michael Paquier wrote: > No worries, committers should take care of that. Done as of 0ecb87e, as I can keep an eye on the buildfarm today, with a catversion bump. -- Michael signature.asc Description: PGP signature

Re: Remove io prefix from pg_stat_io columns

2023-04-19 Thread Kyotaro Horiguchi
At Thu, 20 Apr 2023 10:13:04 +0900, Michael Paquier wrote in > On Wed, Apr 19, 2023 at 08:50:13PM -0400, Melanie Plageman wrote: > > I thought about changing parameter and local variable names to remove > > the prefix, but in the original discussion folks seemed to think it made > > sense to lea

Re: Remove io prefix from pg_stat_io columns

2023-04-19 Thread Michael Paquier
On Wed, Apr 19, 2023 at 09:45:32PM -0400, Melanie Plageman wrote: > Great, thanks! Once you feel an appropriate amount of time has passed, > it would be great if you could apply it. Sure. Probably on tomorrow morning, or Monday in the worst-case scenario, I think.. > I forgot to add a note about

Re: Remove io prefix from pg_stat_io columns

2023-04-19 Thread Melanie Plageman
On Thu, Apr 20, 2023 at 10:13:04AM +0900, Michael Paquier wrote: > On Wed, Apr 19, 2023 at 08:50:13PM -0400, Melanie Plageman wrote: > > I thought about changing parameter and local variable names to remove > > the prefix, but in the original discussion folks seemed to think it made > > sense to le

Re: Remove io prefix from pg_stat_io columns

2023-04-19 Thread Michael Paquier
On Wed, Apr 19, 2023 at 08:50:13PM -0400, Melanie Plageman wrote: > I thought about changing parameter and local variable names to remove > the prefix, but in the original discussion folks seemed to think it made > sense to leave the "C level" references with an "io" prefix. I think we > could chan

Re: Remove io prefix from pg_stat_io columns

2023-04-19 Thread Melanie Plageman
On Wed, Apr 19, 2023 at 8:42 PM Michael Paquier wrote: > > On Wed, Apr 19, 2023 at 01:54:21PM -0300, Fabrízio de Royes Mello wrote: > > On Wed, Apr 19, 2023 at 1:27 PM Melanie Plageman > > wrote: > >> Over in [1], we discussed removing the "io" prefix from the columns > >> "io_context" and "io_o

Re: Remove io prefix from pg_stat_io columns

2023-04-19 Thread Michael Paquier
On Wed, Apr 19, 2023 at 01:54:21PM -0300, Fabrízio de Royes Mello wrote: > On Wed, Apr 19, 2023 at 1:27 PM Melanie Plageman > wrote: >> Over in [1], we discussed removing the "io" prefix from the columns >> "io_context" and "io_object" in pg_stat_io since they seem redundant >> given the view nam

Re: Remove io prefix from pg_stat_io columns

2023-04-19 Thread Fabrízio de Royes Mello
On Wed, Apr 19, 2023 at 1:27 PM Melanie Plageman wrote: > > Hi, > > Over in [1], we discussed removing the "io" prefix from the columns > "io_context" and "io_object" in pg_stat_io since they seem redundant > given the view name > LGTM. All tests passed and were built without warnings. Regards

Remove io prefix from pg_stat_io columns

2023-04-19 Thread Melanie Plageman
7543675435826022.horikyota.ntt%40gmail.com From 632102f3a9ad5f0246d544c0e29c85915ccde495 Mon Sep 17 00:00:00 2001 From: Melanie Plageman Date: Wed, 19 Apr 2023 11:43:13 -0400 Subject: [PATCH v1] Remove io prefix from pg_stat_io columns a9c70b46 added the statistics view pg_stat_io which contained colum