On Fri, Jun 7, 2019 at 8:52 PM Michael Paquier wrote:
>
> On Fri, Jun 07, 2019 at 03:30:35PM +0900, Masahiko Sawada wrote:
> > Agreed. Please find an attached patch.
>
> Thanks, committed.
Thank you!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source
On Fri, Jun 07, 2019 at 03:30:35PM +0900, Masahiko Sawada wrote:
> Agreed. Please find an attached patch.
Thanks, committed.
--
Michael
signature.asc
Description: PGP signature
On Thu, Jun 6, 2019 at 10:21 PM Michael Paquier wrote:
>
> On Thu, Jun 06, 2019 at 05:16:30PM +0900, Masahiko Sawada wrote:
> > So I'd like to propose a small fix for that; move the comment to the
> > right place and add another comment. Please find an attached small
> > patch.
>
> No objections
On Thu, Jun 06, 2019 at 05:16:30PM +0900, Masahiko Sawada wrote:
> So I'd like to propose a small fix for that; move the comment to the
> right place and add another comment. Please find an attached small
> patch.
No objections to that. Perhaps we should also mention that this does
not protect
Hi,
While reading the pg_checksums code I found the following comment
"Check if cluster is running" is not placed at right place.
/* Check if cluster is running */
ControlFile = get_controlfile(DataDir, _ok);
if (!crc_ok)
{
pg_log_error("pg_control CRC value is
