Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Fri, Feb 11, 2022 at 12:29 AM Justin Pryzby wrote: > > On Thu, Feb 10, 2022 at 10:21:08PM +0530, Bharath Rupireddy wrote: > > Thanks for the comments. Above looks good to me, changed that way, PSA v2. > > I spy a typo: subcription Thanks. Corrected in v3 attached. The CF entry

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Thu, Feb 10, 2022 at 10:21:08PM +0530, Bharath Rupireddy wrote: > Thanks for the comments. Above looks good to me, changed that way, PSA v2. I spy a typo: subcription -- Justin

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Mon, Dec 13, 2021 at 5:09 AM Juan José Santamaría Flecha wrote: > > > On Thu, Oct 21, 2021 at 7:21 AM Bharath Rupireddy > wrote: >> >> >> Here's the documentation v1 patch that I've come up with. Please review it. >> > There's a typo: > + To run an arbitrary TAP test set, run vcregress

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Thu, Oct 21, 2021 at 7:21 AM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > > Here's the documentation v1 patch that I've come up with. Please review it. > > There's a typo: + To run an arbitrary TAP test set, run vcregress taptest + comamnd. For example, use the

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Tue, Oct 19, 2021 at 11:49 AM Bharath Rupireddy wrote: > > On Tue, Oct 19, 2021 at 6:16 AM Michael Paquier wrote: > > > > On Mon, Oct 18, 2021 at 09:56:41AM -0400, Andrew Dunstan wrote: > > > Well, see > > > > >

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Tue, Oct 19, 2021 at 6:16 AM Michael Paquier wrote: > > On Mon, Oct 18, 2021 at 09:56:41AM -0400, Andrew Dunstan wrote: > > Well, see > > > > > > Maybe we should move that section. > > As this is the part of the

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Mon, Oct 18, 2021 at 6:19 PM Andrew Dunstan wrote: > > Thanks for your opinion. IIUC, the subscription tests can be run with > > setting environment variables PROVE_FLAGS, PROVE_TESTS and the > > "vcregress taptest" command right? I failed to set the environment > > variables appropriately and

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Mon, Oct 18, 2021 at 09:56:41AM -0400, Andrew Dunstan wrote: > Well, see > > > Maybe we should move that section. As this is the part of the docs where we document the builds, it looks indeed a bit confusing to

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On 10/18/21 9:37 AM, Tom Lane wrote: > Andrew Dunstan writes: >> On 10/18/21 1:41 AM, Bharath Rupireddy wrote: >>> Another thing I noticed is that we don't have any mention of >>> "vcregress taptest" command in the docs [1], if I read the docs >>> correctly. How about we have it along with a

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

Andrew Dunstan writes: > On 10/18/21 1:41 AM, Bharath Rupireddy wrote: >> Another thing I noticed is that we don't have any mention of >> "vcregress taptest" command in the docs [1], if I read the docs >> correctly. How about we have it along with a sample example on how to >> run a specific TAP

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On 10/18/21 1:41 AM, Bharath Rupireddy wrote: > On Sat, Oct 16, 2021 at 6:35 PM Andrew Dunstan wrote: >>> The problems with having "vcregress checkworld" are: 1) required code >>> modifications are more as the available "vcregress" test functions, >>> which required pre-started pg instance,

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Sat, Oct 16, 2021 at 6:35 PM Andrew Dunstan wrote: > > > The problems with having "vcregress checkworld" are: 1) required code > > modifications are more as the available "vcregress" test functions, > > which required pre-started pg instance, can't be used directly. 2) it > > looks like

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On 10/16/21 7:21 AM, Bharath Rupireddy wrote: > On Wed, Oct 6, 2021 at 4:31 PM Bharath Rupireddy > wrote: >> On Wed, Oct 6, 2021 at 7:52 AM Michael Paquier wrote: >>> On Wed, Oct 06, 2021 at 07:19:04AM +0530, Bharath Rupireddy wrote: I was thinking of the same. +1 for "vcregress

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Wed, Oct 6, 2021 at 4:31 PM Bharath Rupireddy wrote: > > On Wed, Oct 6, 2021 at 7:52 AM Michael Paquier wrote: > > > > On Wed, Oct 06, 2021 at 07:19:04AM +0530, Bharath Rupireddy wrote: > > > I was thinking of the same. +1 for "vcregress check-world" which is > > > more in sync with it's peer

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Wed, Oct 6, 2021 at 7:52 AM Michael Paquier wrote: > > On Wed, Oct 06, 2021 at 07:19:04AM +0530, Bharath Rupireddy wrote: > > I was thinking of the same. +1 for "vcregress check-world" which is > > more in sync with it's peer "make check-world" instead of "vcregress > > all-taptest". I'm not

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Wed, Oct 6, 2021 at 7:52 AM Michael Paquier wrote: > My take is that there is value for both installcheck-world and > check-world, depending on if we want to test on an installed instance > or not. For CIs, check-world makes things simpler perhaps? > > > vcregress plcheck > > vcregress

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Wed, Oct 06, 2021 at 07:19:04AM +0530, Bharath Rupireddy wrote: > I was thinking of the same. +1 for "vcregress check-world" which is > more in sync with it's peer "make check-world" instead of "vcregress > all-taptest". I'm not sure whether we can also have "vcregress > installcheck-world" as

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Wed, Oct 6, 2021 at 6:53 AM Alvaro Herrera wrote: > > On 2021-Oct-06, Michael Paquier wrote: > > > On Tue, Oct 05, 2021 at 06:18:47PM -0400, Andrew Dunstan wrote: > > > On 10/5/21 4:38 PM, Andres Freund wrote: > > >> My problem with that is that that means there's no convenient way to > > >>

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On 2021-Oct-06, Michael Paquier wrote: > On Tue, Oct 05, 2021 at 06:18:47PM -0400, Andrew Dunstan wrote: > > On 10/5/21 4:38 PM, Andres Freund wrote: > >> My problem with that is that that means there's no convenient way to > >> discover > >> what one needs to do to run all tests. Perhaps we

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Tue, Oct 05, 2021 at 06:18:47PM -0400, Andrew Dunstan wrote: > On 10/5/21 4:38 PM, Andres Freund wrote: >> My problem with that is that that means there's no convenient way to discover >> what one needs to do to run all tests. Perhaps we could have one all-taptest >> target or such? >> > >

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On 10/5/21 4:38 PM, Andres Freund wrote: > Hi, > > On 2021-10-05 16:03:53 -0400, Andrew Dunstan wrote: >> I would actually prefer to reduce the number of special things in >> vcregress.pl rather than add more. We should be able to add a new set of >> TAP tests somewhere without having to do

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

Hi, On 2021-10-05 16:03:53 -0400, Andrew Dunstan wrote: > I would actually prefer to reduce the number of special things in > vcregress.pl rather than add more. We should be able to add a new set of > TAP tests somewhere without having to do anything to vcregress.pl. > That's more or less why I

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On 10/5/21 1:25 PM, Bharath Rupireddy wrote: > Hi, > > While working one of the internal features, I figured out that we > don't have subscription TAP tests option for "vcregress" tool for msvc > builds. Is there any specific reason that we didn't add "vcregress > subscriptioncheck" option

can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

Hi, While working one of the internal features, I figured out that we don't have subscription TAP tests option for "vcregress" tool for msvc builds. Is there any specific reason that we didn't add "vcregress subscriptioncheck" option similar to "vcregress recoverycheck"? It looks like one can run