Re: crash testing suggestions for 12 beta 1

2019-06-06 Thread Michael Paquier
On Wed, Jun 05, 2019 at 02:32:49PM -0700, Peter Geoghegan wrote: > Forgive me for droning on about amcheck once more, but maybe it'll > help: amcheck has the capability to detect at least two historic bugs > in CREATE INDEX CONCURRENTLY that made it into stable releases. The > "heapallindexed"

Re: crash testing suggestions for 12 beta 1

2019-06-05 Thread Peter Geoghegan
On Wed, Jun 5, 2019 at 2:11 PM Alvaro Herrera wrote: > REINDEX CONCURRENTLY would be one good area to focus on, I think, as > well as ALTER TABLE ATTACH PARTITION. Maybe also INCLUDE columns in > GiST, and the stuff in commits 9155580fd, fe280694d and 7df159a62. Those all seem like good things

Re: crash testing suggestions for 12 beta 1

2019-06-05 Thread Alvaro Herrera
On 2019-May-23, Jeff Janes wrote: > Now that beta is out, I wanted to do some crash-recovery testing where I > inject PANIC-inducing faults and see if it recovers correctly. A long-lived > Perl process keeps track of what it should find after the crash, and > verifies that it finds it. You will

Re: crash testing suggestions for 12 beta 1

2019-05-23 Thread Peter Geoghegan
On Thu, May 23, 2019 at 8:24 AM Jeff Janes wrote: > Now that beta is out, I wanted to do some crash-recovery testing where I > inject PANIC-inducing faults and see if it recovers correctly. Thank you for doing this. It's important work. > Making the ctid be tie-breakers in btree index is also

crash testing suggestions for 12 beta 1

2019-05-23 Thread Jeff Janes
Now that beta is out, I wanted to do some crash-recovery testing where I inject PANIC-inducing faults and see if it recovers correctly. A long-lived Perl process keeps track of what it should find after the crash, and verifies that it finds it. You will probably be familiar with the general theme