Re: itemptr_encode/itemptr_decode

2019-05-18 Thread Peter Geoghegan
On Wed, Apr 17, 2019 at 4:22 PM Tom Lane wrote: > As for the general usability argument, I'm not sure --- as we start > to look at alternate AMs, we might have more use for them. When I first > saw the functions, I thought maybe they were part of sort acceleration > for TIDs; evidently they're

Re: itemptr_encode/itemptr_decode

2019-05-17 Thread Andres Freund
Hi, On 2019-04-17 19:22:08 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-04-17 18:57:00 -0400, Tom Lane wrote: > >> What on God's green earth are these functions doing in > >> src/include/catalog/index.h? > > > I'm happy to move them elsewhere, but I'm not sure there's really a

Re: itemptr_encode/itemptr_decode

2019-04-17 Thread Tom Lane
Andres Freund writes: > On 2019-04-17 18:57:00 -0400, Tom Lane wrote: >> What on God's green earth are these functions doing in >> src/include/catalog/index.h? > I'm happy to move them elsewhere, but I'm not sure there's really a good > location. I guess we could move them to itemptr.h - but

Re: itemptr_encode/itemptr_decode

2019-04-17 Thread Andres Freund
Hi, On 2019-04-17 18:57:00 -0400, Tom Lane wrote: > What on God's green earth are these functions doing in > src/include/catalog/index.h? > They don't have any obvious connection to indexes, let alone > catalog operations on indexes, which is what that file is for. Well, they were previously

itemptr_encode/itemptr_decode

2019-04-17 Thread Tom Lane
What on God's green earth are these functions doing in src/include/catalog/index.h? They don't have any obvious connection to indexes, let alone catalog operations on indexes, which is what that file is for. They weren't there before 2a96909a4, either. regards, tom lane