Re: pg_basebackup against older server versions

2019-03-08 Thread Sergei Kornilov
HiGreat, thank you! regards, Sergei

Re: pg_basebackup against older server versions

2019-03-07 Thread Michael Paquier
On Thu, Mar 07, 2019 at 10:57:46AM +0300, Sergei Kornilov wrote: > Looks fine, thanks. I tested against HEAD and v11.2 with and without > -R in both plain and tar formats. Same here, so I have committed the patch. -- Michael signature.asc Description: PGP signature

Re: pg_basebackup against older server versions

2019-03-06 Thread Sergei Kornilov
Hi > No problem. Thanks for the patch, the logic looks good and I made > some adjustments as attached. Does that look fine to you? Looks fine, thanks. I tested against HEAD and v11.2 with and without -R in both plain and tar formats. regards, Sergei

Re: pg_basebackup against older server versions

2019-03-06 Thread Michael Paquier
On Wed, Mar 06, 2019 at 01:42:16PM +0300, Sergei Kornilov wrote: > My fault. I thought pg_basebackup works only with same major version, sorry. > How about attached patch? No problem. Thanks for the patch, the logic looks good and I made some adjustments as attached. Does that look fine to you?

Re: pg_basebackup against older server versions

2019-03-06 Thread Sergei Kornilov
Hello My fault. I thought pg_basebackup works only with same major version, sorry. How about attached patch? regards, Sergeidiff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c index 3d2d4cd0b9..e1aa2c1cfc 100644 --- a/src/bin/pg_basebackup/pg_basebackup.c ++

Re: pg_basebackup against older server versions

2019-03-06 Thread Michael Paquier
On Wed, Mar 06, 2019 at 11:55:12AM +0300, Devrim Gündüz wrote: > Apologies if this has been discussed before: When I run pg_basebackup in git > head against v11 server, it treats v11 as v12: Does not create recovery.conf, > adds recovery parameters to postgresql.auto.conf, and also creates > stand

pg_basebackup against older server versions

2019-03-06 Thread Devrim Gündüz
Hi, Apologies if this has been discussed before: When I run pg_basebackup in git head against v11 server, it treats v11 as v12: Does not create recovery.conf, adds recovery parameters to postgresql.auto.conf, and also creates standby.signal file. Is this expected, or a bug? Regards, -- Devrim