Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

On 1/8/18 08:14, Michael Paquier wrote: > On Sat, Jan 06, 2018 at 09:10:51AM +0900, Michael Paquier wrote: >> On Sat, Jan 6, 2018 at 2:56 AM, Alvaro Herrera >> wrote: >> Good idea as a whole, but I don't think this is the right approach. As >> we include $(bindir) in

Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

On Sat, Jan 06, 2018 at 09:10:51AM +0900, Michael Paquier wrote: > On Sat, Jan 6, 2018 at 2:56 AM, Alvaro Herrera > wrote: > Good idea as a whole, but I don't think this is the right approach. As > we include $(bindir) in PATH when running the prove command, why not >

Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

On Sat, Jan 6, 2018 at 2:56 AM, Alvaro Herrera wrote: > Peter Eisentraut wrote: >> On 1/5/18 09:28, Michael Paquier wrote: >> > In order to do things cleanly, we should make this TAP test >> > conditional on the version of OpenSSL. >> >> How about looking into

Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

Peter Eisentraut wrote: > On 1/5/18 09:28, Michael Paquier wrote: > > In order to do things cleanly, we should make this TAP test > > conditional on the version of OpenSSL. > > How about looking into pg_config.h, like in the attached patch? I suppose if this starts to spread, we'll come up with

Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

On 1/5/18 09:28, Michael Paquier wrote: > In order to do things cleanly, we should make this TAP test > conditional on the version of OpenSSL. How about looking into pg_config.h, like in the attached patch? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development,

Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

On Thu, Jan 4, 2018 at 4:09 PM, Thomas Munro wrote: > On Fri, Jan 5, 2018 at 9:36 AM, Peter Eisentraut wrote: >> Implement channel binding tls-server-end-point for SCRAM > > FYI some BF animals are saying: > > libpq/be-secure-openssl.o: In function