Re: tableam: inconsistent parameter name

2019-06-07 Thread Robert Haas
On Fri, Jun 7, 2019 at 1:19 PM Andres Freund wrote: > On 2019-06-07 13:11:21 -0400, Robert Haas wrote: > > I found what appears to be another typo very nearby. Attached please > > find v2, fixing both issues. > > Hm, I thinks that's fixed already? Oops, you're right. -- Robert Haas

Re: tableam: inconsistent parameter name

2019-06-07 Thread Andres Freund
On 2019-06-07 13:11:21 -0400, Robert Haas wrote: > I found what appears to be another typo very nearby. Attached please > find v2, fixing both issues. Hm, I thinks that's fixed already?

Re: tableam: inconsistent parameter name

2019-06-07 Thread Robert Haas
On Fri, Jun 7, 2019 at 12:52 PM Andres Freund wrote: > On 2019-06-07 12:37:33 -0400, Robert Haas wrote: > > TableAmRoutine's index_build_range_scan thinks that parameter #8 is > > called end_blockno, but table_index_build_range_scan and > > heapam_index_build_range_scan and BRIN's summarize_range

Re: tableam: inconsistent parameter name

2019-06-07 Thread Andres Freund
Hi, On 2019-06-07 12:37:33 -0400, Robert Haas wrote: > TableAmRoutine's index_build_range_scan thinks that parameter #8 is > called end_blockno, but table_index_build_range_scan and > heapam_index_build_range_scan and BRIN's summarize_range all agree > that it's the number of blocks to be

tableam: inconsistent parameter name

2019-06-07 Thread Robert Haas
TableAmRoutine's index_build_range_scan thinks that parameter #8 is called end_blockno, but table_index_build_range_scan and heapam_index_build_range_scan and BRIN's summarize_range all agree that it's the number of blocks to be scanned. I assume that this got changed at some point while Andres