On Mon, Jun 24, 2024 at 02:44:33PM -0400, Robert Haas wrote:
> I think the first two cases could be made more like each other by
> changing the varlistentires that are just about one setting to use the
> second format instead of the first, e.g. pg_checkpoint allows
> executing the CHECKPOINT comman
Prior to macOS SDK 15, there were include guards in
$SDK_ROOT/usr/include/xlocale/_regex.h:
#ifndef _REGEX_H_
#include <_regex.h>
#endif // _REGEX_H_
#include <_xlocale.h>
In macOS SDK 15, these include guards are gone:
#include <_regex.h>
#include <_xlocale.h>
Because _REGEX_H_ was
On Mon, Jun 24, 2024 at 05:20:21PM +0530, Amit Kapila wrote:
> On Sun, Jun 23, 2024 at 11:52 AM Noah Misch wrote:
> >
> > > +static void
> > > +create_publication(PGconn *conn, struct LogicalRepInfo *dbinfo)
> > > +{
> >
> > > + appendPQExpBuffer(str, "CREATE PUBLICATION %s FOR ALL TABLES",
>
Prior to macOS SDK 15, there were include guards in
$SDK_ROOT/usr/include/xlocale/_regex.h:
#ifndef _REGEX_H_
#include <_regex.h>
#endif // _REGEX_H_
#include <_xlocale.h>
In macOS SDK 15, these include guards are gone:
#include <_regex.h>
#include <_xlocale.h>
Because _REGEX_H_ was
On Mon, Jun 24, 2024, at 23:15, David G. Johnston wrote:
> I really dislike "For avoidance of doubt and clarity" - and in terms of
> being equivalent the following seems like a more accurate description
> of reality.
>
> The PostgreSQL documentation, and code, refers to the specifications
> with
On Mon, Jun 24, 2024 at 2:53 PM Nathan Bossart
wrote:
> On Mon, Jun 24, 2024 at 02:44:33PM -0400, Robert Haas wrote:
>
> > I don't know what to do about pg_database_owner. I almost wonder if
> > that should be moved out of the table and documented as a special
> > case. Or maybe some more wordsmi
On Mon, Jun 24, 2024 at 02:56:00PM -0300, Israel Barth Rubio wrote:
> I've been playing a bit with the incremental backup feature which might
> come as
> part of the 17 release, and I think I hit a possible bug in the WAL
> summarizer
> process.
Thanks for testing new features and for this report!
On Mon, Jun 24, 2024, at 01:46, Michael Paquier wrote:
> Rather unrelated to this patch, still this patch makes the situation
> more complicated in the docs, but wouldn't it be better to add ACL as
> a term in acronyms.sql, and reuse it here? It would be a doc-only
> patch that applies on top of t
On Mon, 24 Jun 2024 at 17:59, Richard Guo wrote:
> Thank you for reviewing.
>
> On Mon, Jun 24, 2024 at 1:27 PM Li Japin wrote:
>> + /*
>> +* For now we do not support RIGHT_SEMI join in mergejoin or nestloop
>> +* join.
>> +*/
>> + if (jointype == JOIN_RIGHT_S
At Fri, 21 Jun 2024 11:48:22 +0530, Amit Kapila wrote
in
> On Wed, Jun 19, 2024 at 10:44 AM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Dear Horiguchi-san,
> >
> > Thanks for sharing the patch! I agree this approach (ensure WAL records are
> > flushed)
> > Is more proper than others.
> >
> > I ha
>> 2. the leader being interrupted while waiting is also already happening on
>> master
>> due to the pgstat_progress_parallel_incr_param() calls in
>> parallel_vacuum_process_one_index() (that have been added in
>> 46ebdfe164). It has been the case "only" 36 times during my test case.
46ebdfe164
On Fri, Jun 21, 2024 at 11:31:21AM +0200, Michail Nikolaev wrote:
> Yes, I also have tried that approach, but it doesn't work, unfortunately.
> You may fail test increasing number of connections:
>
> '--no-vacuum --client=10 -j 2 --transactions=1000',
>
> The source of the issue is not the swap o
On Mon, Jun 24, 2024 at 04:51:24PM -0400, Peter Geoghegan wrote:
> On Mon, Jun 24, 2024 at 4:36 PM Robert Haas wrote:
> > I'm not sure I understand. The most important thing here is fixing the
> > bug. But if we have a choice of how to fix the bug, I'd prefer to do
> > it by having the pruning cod
On Mon, Jun 24, 2024 at 9:30 PM Noah Misch wrote:
> On Mon, Jun 24, 2024 at 03:23:39PM -0400, Melanie Plageman wrote:
> > Right now, in master, we do use a single horizon when determining what
> > is pruned -- that from GlobalVisState. OldestXmin is only used for
> > freezing and full page visibil
On Tue, Jun 25, 2024 at 01:21:14AM +0200, Joel Jacobson wrote:
> Good idea, I've started a separate thread for this:
>
> https://postgr.es/m/9253b872-dbb1-42a6-a79e-b1e96effc857%40app.fastmail.com
>
> This patch now assumes ACL will be supported.
Thanks for doing that! That helps in making revi
On Mon, Jun 24, 2024 at 02:58:47PM -0700, Stan Hu wrote:
> Prior to macOS SDK 15, there were include guards in
> $SDK_ROOT/usr/include/xlocale/_regex.h:
>
> #ifndef _REGEX_H_
> #include <_regex.h>
> #endif // _REGEX_H_
> #include <_xlocale.h>
Ugh. Which means that you are testing macOS S
On Mon, Jun 24, 2024 at 09:49:53PM -0400, Peter Geoghegan wrote:
> On Mon, Jun 24, 2024 at 9:30 PM Noah Misch wrote:
> > On Mon, Jun 24, 2024 at 03:23:39PM -0400, Melanie Plageman wrote:
> > > Right now, in master, we do use a single horizon when determining what
> > > is pruned -- that from Globa
On Mon, Jun 24, 2024 at 01:29:38PM +0300, Heikki Linnakangas wrote:
> InjectionPointRun() acquires InjectionPointLock, looks up the hash entry,
> and releases the lock:
>
> > LWLockAcquire(InjectionPointLock, LW_SHARED);
> > entry_by_name = (InjectionPointEntry *)
> > hash_sear
Michael Paquier writes:
> Ugh. Which means that you are testing macOS Sequoia still in beta
> phase? Thanks for the report.
> Perhaps we should wait for the actual release before seeing if this is
> still an issue and see if this is still a problem? Tom is a heavy
> macOS user, I'm still under
On Saturday, June 22, 2024 5:47 PM Amit Kapila wrote:
>
> On Sat, Jun 22, 2024 at 1:49 AM Nathan Bossart
> wrote:
> >
> > On Fri, Jun 21, 2024 at 03:50:00PM -0400, Tom Lane wrote:
> > > Allow specification of physical standbys that must be
> > > synchronized before they are visible to su
On Mon, Jun 24, 2024 at 11:03:09AM -0400, Tom Lane wrote:
> Heikki Linnakangas writes:
> > ... I can't do that, because InjectionPointRun() requires a PGPROC
> > entry, because it uses an LWLock. That also makes it impossible to use
> > injection points in the postmaster. Any chance we could all
On Mon, Jun 24, 2024 at 11:03:09AM -0400, Tom Lane wrote:
> Given your point that the existing locking is just a fig leaf
> anyway, maybe we could simply not have any? Then it's on the
> test author to be sure that the injection point won't be
> getting invoked when it's about to be removed.
That
On Tue, Jun 25, 2024 at 11:21 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Saturday, June 22, 2024 5:47 PM Amit Kapila
> wrote:
> >
> > On Sat, Jun 22, 2024 at 1:49 AM Nathan Bossart
> > wrote:
> > >
> > > On Fri, Jun 21, 2024 at 03:50:00PM -0400, Tom Lane wrote:
> > > > Allow specification of phy
Hi Japin Li
Thank you for your reviewing ,This way the notes are more accurate and
complete. Thanks also to the author for updating the patch ,I also tested
the new patch ,It looks good to me
Regrads
Japin Li 于2024年6月25日周二 08:51写道：
> On Mon, 24 Jun 2024 at 17:59, Richard Guo wrote:
> > T
On Mon, Jun 24, 2024 at 7:46 PM Amit Langote wrote:
>
> Hi,
>
> On Mon, Jun 24, 2024 at 7:04 PM jian he wrote:
> >
> > hi.
> > the following two queries should return the same result?
> >
> > SELECT * FROM JSON_query (jsonb 'null', '$' returning jsonb);
> > SELECT * FROM JSON_value (jsonb 'null',
On Tue, Jun 25, 2024 at 12:18 PM jian he wrote:
> On Mon, Jun 24, 2024 at 7:46 PM Amit Langote wrote:
> > On Mon, Jun 24, 2024 at 7:04 PM jian he wrote:
> > >
> > > hi.
> > > the following two queries should return the same result?
> > >
> > > SELECT * FROM JSON_query (jsonb 'null', '$' returnin
>Вторник, 25 июня 2024, 11:17 +07:00 от David E. Wheeler
>:
>
>On Jun 7, 2024, at 10:23, David E. Wheeler < da...@justatheory.com > wrote:
>
>> Rebased and moved the new tests to the end of the file.
>Bah, sorry, that was the previous patch. Here’s v3.
>
>D
>
Hi! Looks good to me, bu
Thanks, Tom and Michael. I've submitted a bug report via Apple's
Feedback Assistant. It's filed under FB14047412.
If anyone happens to know the right person at Apple to look at this,
please direct them there.
On Mon, Jun 24, 2024 at 7:15 PM Tom Lane wrote:
>
> Michael Paquier writes:
> > Ugh.
On Tue, Jun 25, 2024 at 11:23 AM Amit Langote wrote:
>
> On Tue, Jun 25, 2024 at 12:18 PM jian he wrote:
> > On Mon, Jun 24, 2024 at 7:46 PM Amit Langote
> > wrote:
> > > On Mon, Jun 24, 2024 at 7:04 PM jian he
> > > wrote:
> > > >
> > > > hi.
> > > > the following two queries should return t
On Tue, Jun 25, 2024 at 8:20 AM Masahiko Sawada wrote:
>
> On Tue, Jun 25, 2024 at 11:21 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > I agree the current name seems too generic and the suggested '
> > synchronized_standby_slots '
> > is better than the current one.
> >
> > Some other ideas could be:
24.06.2024 01:59, Jelte Fennema-Nio wrote:
On Sat, 22 Jun 2024 at 17:00, Alexander Lakhin wrote:
@@ -2775,6 +2775,7 @@
SET LOCAL statement_timeout = '10ms';
select count(*) from ft1 CROSS JOIN ft2 CROSS JOIN ft4 CROSS JOIN ft5; --
this takes very long
ERROR: canceling statement due t
On Mon, Jun 24, 2024 at 8:06 PM Tomas Vondra
wrote:
>
> On 6/24/24 12:54, Amit Kapila wrote:
> > ...
> >>
> I'm not sure there are any cases where using SRE instead of AE would
> cause
> problems for logical decoding, but it seems very hard to prove. I'd be
> very
> surp
On Tue, Jun 25, 2024 at 12:20:20AM +0200, Joel Jacobson wrote:
> Thanks, much better. New version attached.
+ The PostgreSQL documentation, and code, refers
+ to the specifications within the ACL as "privileges". This has the same
+ meaning as "permissions" on the linked page. Gen
On Tue, Jun 25, 2024, at 03:57, Michael Paquier wrote:
> On Tue, Jun 25, 2024 at 01:21:14AM +0200, Joel Jacobson wrote:
>> Good idea, I've started a separate thread for this:
>>
>> https://postgr.es/m/9253b872-dbb1-42a6-a79e-b1e96effc857%40app.fastmail.com
>>
>> This patch now assumes ACL will be
On Tue, Jun 25, 2024, at 07:11, Michael Paquier wrote:
> On Tue, Jun 25, 2024 at 12:20:20AM +0200, Joel Jacobson wrote:
>> Thanks, much better. New version attached.
>
> + The PostgreSQL documentation, and code,
> refers
> + to the specifications within the ACL as "privileges". This has
On Tue, Jun 25, 2024 at 3:38 AM Noah Misch wrote:
>
> On Mon, Jun 24, 2024 at 05:20:21PM +0530, Amit Kapila wrote:
> > On Sun, Jun 23, 2024 at 11:52 AM Noah Misch wrote:
> > >
> > > > +static void
> > > > +create_publication(PGconn *conn, struct LogicalRepInfo *dbinfo)
> > > > +{
> > >
> > > > +
Here are some review comments for the patch v10-0002.
==
Commit Message
1.
Note that we don't copy columns when the subscriber-side column is also
generated. Those will be filled as normal with the subscriber-side computed or
default data.
~
Now this patch also introduced some errors etc, s
Hi Jelte, hackers.
Thank you for explanations.
Actually, I have other tasks about "PARTIAL_AGGREAGATE" keyword
to respond Requirement1 and Requirement2 in the following mail.
https://www.postgresql.org/message-id/TYAPR01MB3088755F2281D41F5EEF06D495F92%40TYAPR01MB3088.jpnprd01.prod.outlook.com
Af
Hi,
On Tue, Jun 25, 2024 at 10:24:41AM +0530, Amit Kapila wrote:
> On Tue, Jun 25, 2024 at 8:20 AM Masahiko Sawada wrote:
> >
> > On Tue, Jun 25, 2024 at 11:21 AM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > I agree the current name seems too generic and the suggested '
> > > synchronized_standb
On Tue, Jun 25, 2024 at 08:06:41AM +0200, Joel Jacobson wrote:
> Not sure if I see how to implement it for pg_get_acl() though.
>
> I've had a look at how pg_describe_object() works for this case:
>
> SELECT pg_describe_object(0,'t'::regclass::oid,0);
> ERROR: unsupported object class: 0
>
> I
Hey!
Lots of SQL/JSON threads going about. This one is less about technical
correctness and more about usability of the documentation. Though in
writing this I am finding some things that aren't quite clear. I'm going
to come back with those on a follow-on post once I get a chance to make my
se
101 - 141 of 141 matches
Mail list logo
