On Wed, Jul 21, 2021 at 3:52 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
>
> On Tue, Jul 13, 2021 at 9:03 PM vignesh C wrote:
> >
> > On Wed, May 12, 2021 at 2:27 AM Robert Haas
wrote:
> > >
> > > Maybe we should have a role
On Mon, Jul 19, 2021 at 9:32 AM tanghy.f...@fujitsu.com <
tanghy.f...@fujitsu.com> wrote:
>
> On Friday, July 16, 2021 6:10 PM vignesh C
> > On Wed, Jul 14, 2021 at 6:25 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > Wednesday, July 14, 2021 6:17 P
On Mon, Jul 19, 2021 at 2:41 PM Greg Nancarrow wrote:
>
> On Fri, Jul 16, 2021 at 8:13 PM vignesh C wrote:
> >
> > Modified.
> >
> > Thanks for the comments, these issues are fixed as part of the v12 patch
> > posted at [1].
> > [1] -
On Wed, Jul 21, 2021 at 3:14 PM Rahila Syed wrote:
>
>
>
> On Mon, Jul 19, 2021 at 2:41 PM Greg Nancarrow
wrote:
>>
>> On Fri, Jul 16, 2021 at 8:13 PM vignesh C wrote:
>> >
>> > Modified.
>> >
>> > Thanks for the comments, these issu
On Fri, Jul 16, 2021 at 9:19 AM Justin Pryzby wrote:
>
> rebased.
>
> Also, there were two redundant checks for multiple SET ACCESS METHOD commands.
> But one of them wasn't hit if the ALTER was setting the current AM due to the
> no-op test.
>
> I think it's better to fail in every case, and not
On Fri, Jul 2, 2021 at 7:35 AM Amit Langote wrote:
>
> On Fri, Jul 2, 2021 at 1:39 AM Tom Lane wrote:
> >
> > Amit Langote writes:
> > > [ v6-0001-Allow-batching-of-inserts-during-cross-partition-.patch ]
> >
> > Per the cfbot, this isn't applying anymore, so I'm setting it back
> > to Waiting o
On Thu, Jul 1, 2021 at 6:41 AM Gurjeet Singh wrote:
>
> The proposed patch is attached.
There is one compilation warning:
xid.c:165:1: warning: no previous prototype for
‘FullTransactionIdToStr’ [-Wmissing-prototypes]
165 | FullTransactionIdToStr(FullTransactionId fxid)
| ^~~~
On Thu, Jul 1, 2021 at 9:42 PM Mark Dilger wrote:
>
>
>
> > On Jun 29, 2021, at 6:25 PM, Mark Dilger
> > wrote:
> >
> > Please find attached a new set of patches.
>
> And again, this time attaching a fifth patch which includes the work to allow
> users who belong to the right security role to S
On Tue, Jun 29, 2021 at 7:10 PM Peter Eisentraut
wrote:
>
> Here is an updated patch with some merge conflicts resolved, to keep it
> fresh. It's still pending in the commit fest from last time.
>
> My focus right now is to work on the "psql - add SHOW_ALL_RESULTS
> option" patch (https://commitf
On Thu, Jul 15, 2021 at 5:12 PM vignesh C wrote:
>
> On Thu, Jul 15, 2021 at 1:40 PM Dean Rasheed wrote:
> >
> > On Tue, 13 Jul 2021 at 15:30, vignesh C wrote:
> > >
> > > On Tue, Jul 13, 2021 at 4:25 PM Dean Rasheed
> > > wrote:
> > >
On Sat, Jun 12, 2021 at 1:59 PM Julien Rouhaud wrote:
>
> On Tue, Jun 08, 2021 at 12:16:48PM +0800, Julien Rouhaud wrote:
> > On Sun, Jun 06, 2021 at 02:50:19PM +0800, Julien Rouhaud wrote:
> > > On Sat, May 01, 2021 at 03:24:58PM +0800, Julien Rouhaud wrote:
> > > >
> > > > I'm attaching some POC
On Thu, Jul 22, 2021 at 9:38 AM Greg Nancarrow wrote:
>
> On Thu, Jul 22, 2021 at 1:42 PM houzj.f...@fujitsu.com
> wrote:
> >
> > Personally, the new name pg_publication_sch is not very easy to
understand.
> > (Maybe it's because I am not a native english speaker. If others feel
ok,
> > please ig
On Fri, Jul 23, 2021 at 6:26 AM tanghy.f...@fujitsu.com
wrote:
>
> On Thursday, July 22, 2021 1:30 AM vignesh C wrote:
> >
> > Thanks for reporting this issue, this issue is fixed in the attached v13
> > patch.
> > I have changed relation name pg_publication_schem
On Fri, Jul 23, 2021 at 3:23 AM Peter Smith wrote:
>
> I think the patch maybe is not quite correct for all the flags.
>
> For example,
>
> @@ -7607,44 +7615,44 @@ are available since protocol version 3.
>
> Int8
>
> -Flags; currently unused (must be 0).
> +Fla
On Mon, Jul 26, 2021 at 7:41 AM tanghy.f...@fujitsu.com <
tanghy.f...@fujitsu.com> wrote:
>
> On Friday, July 23, 2021 8:18 PM vignesh C wrote:
> >
> > I have changed it to not report any error, this issue is fixed in the
> > v14 patch attached at [1].
> > [1]
On Tue, Jul 27, 2021 at 5:11 AM Greg Nancarrow wrote:
>
> On Mon, Jul 26, 2021 at 3:21 PM vignesh C wrote:
> >
> > Thanks for the comment, this is modified in the v15 patch attached.
> >
>
> I have several minor review comments.
>
> (1) src/backend/catalog/ob
On Fri, Jul 30, 2021 at 9:32 AM Peter Smith wrote:
>
> Please find attached the latest patch set v100*
>
> v99-0002 --> v100-0001
>
> Differences:
>
> * Rebased to HEAD @ today (needed because some recent commits [1][2] broke
> v99)
>
The patch applies neatly, tests passes and documentation look
On Sat, Jul 31, 2021 at 11:12 AM Ajin Cherian wrote:
>
> On Sat, Jul 31, 2021 at 2:39 PM Amit Kapila wrote:
>
> > Here, the test is expecting 2 prepared transactions corresponding to
> > two subscriptions but it waits for just one subscription via
> > appname_copy. It should wait for the second s
On Sat, Jul 31, 2021 at 2:30 AM Tom Lane wrote:
>
> vignesh C writes:
> [ v6-0001-Included-the-actual-datatype-used-in-logical-repl.patch ]
>
> I see what you want to do here, but the way you did it seems quite
> detrimental to the readability of the field description
On Sun, Aug 1, 2021 at 4:11 PM Peter Smith wrote:
>
> On Sat, Jul 31, 2021 at 7:00 AM Tom Lane wrote:
> >
> > vignesh C writes:
> > [ v6-0001-Included-the-actual-datatype-used-in-logical-repl.patch ]
> >
> > I see what you want to do here, but the way you d
On Mon, Aug 2, 2021 at 9:10 PM Tom Lane wrote:
>
> Peter Smith writes:
> > I agree. The specified value looks better when it comes first, as you did
> > it.
>
> Actually, it looks to me like we don't have to resolve the question of
> which should come first, because I don't see any cases where i
On Mon, Aug 2, 2021 at 3:31 PM tanghy.f...@fujitsu.com
wrote:
>
> Hi Hackers
>
> When review and test another patch at [1], I found some comments in existing
> test code of " src/test/regress/sql/publication.sql " is a little bit
> confused.
> Attached a patch to fix them, please take a check.
>
On Mon, Aug 2, 2021 at 1:13 PM Masahiko Sawada wrote:
>
> On Mon, Aug 2, 2021 at 2:52 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Thursday, July 29, 2021 10:50 AM Masahiko Sawada
> > wrote:
> > > On Thu, Jul 8, 2021 at 3:55 PM osumi.takami...@fujitsu.com
> > > wrote:
> > > > When the cu
On Tue, Aug 3, 2021 at 12:32 PM Amit Kapila wrote:
>
> On Tue, Aug 3, 2021 at 6:17 AM Peter Smith wrote:
> >
> > Please find attached the latest patch set v102*
> >
>
> I have made minor modifications in the comments and docs, please see
> attached. Can you please check whether the names of contr
On Tue, Aug 3, 2021 at 12:20 PM Masahiko Sawada wrote:
>
> On Mon, Aug 2, 2021 at 12:21 PM Amit Kapila wrote:
> >
> > On Mon, Aug 2, 2021 at 7:45 AM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Jul 30, 2021 at 12:52 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Thu, Jul 29, 2021 at 11:18 A
On Tue, Aug 3, 2021 at 8:36 AM tanghy.f...@fujitsu.com
wrote:
>
> On Monday, August 2, 2021 11:56 PM vignesh C wrote:
> >
> > Few minor suggestions:
> > 1) Should we change below to "fail - tables can't be added, dropped or
> > set to "FOR ALL TABL
On Wed, Aug 4, 2021 at 8:08 PM tanghy.f...@fujitsu.com <
tanghy.f...@fujitsu.com> wrote:
>
> On Tuesday, August 3, 2021 11:08 PM vignesh C wrote:
> >
> > Thanks for reporting this, this is fixed in the v18 patch attached.
>
> Thanks for fixing it.
>
> Few sugge
On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila wrote:
>
> On Wed, Aug 4, 2021 at 4:10 PM Amit Kapila
wrote:
> >
> > On Tue, Aug 3, 2021 at 8:38 PM vignesh C wrote:
> > >
> > > Thanks for reporting this, this is fixed in the v18 patch attached.
> > >
&
On Fri, Aug 6, 2021 at 4:02 PM Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 2:16 PM vignesh C wrote:
> >
> > On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila wrote:
> > >
> > >
> > > Few more comments:
> > > ===
> > >
On Fri, Aug 6, 2021 at 4:39 PM Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 2:02 PM vignesh C wrote:
> >
> > On Wed, Aug 4, 2021 at 4:10 PM Amit Kapila wrote:
> > >
> > > On Tue, Aug 3, 2021 at 8:38 PM vignesh C wrote:
> >
> > > 6.
> >
On Fri, Aug 6, 2021 at 3:33 PM tanghy.f...@fujitsu.com
wrote:
>
> Hi
>
> I saw some inaccurate comments for AlterPublicationStmt structure when
> reviewing patches related to publication[1].
>
> The variable tables are used for 'ALTER PUBLICATION ... ADD/DROP/SET TABLE',
> but the comments only sa
On Fri, Aug 6, 2021 at 2:00 PM Masahiko Sawada wrote:
>
> On Wed, Aug 4, 2021 at 12:08 AM vignesh C wrote:
> >
> > On Tue, Aug 3, 2021 at 12:00 PM tanghy.f...@fujitsu.com
> > wrote:
> > >
> > > On Monday, August 2, 2021 11:40 PM vignesh C wrote:
> &g
On Mon, Aug 9, 2021 at 9:50 PM Mark Dilger wrote:
>
>
>
> > On Aug 6, 2021, at 1:32 AM, vignesh C wrote:
> >
> > the attached v19 patch
>
> With v19 applied, a schema owner can publish the contents of a table
> regardless of ownership or permissions o
On Mon, Aug 9, 2021 at 9:50 PM Mark Dilger
wrote:
>
>
>
> > On Aug 6, 2021, at 1:32 AM, vignesh C wrote:
> >
> > the attached v19 patch
>
> With v19 applied, a schema owner can publish the contents of a table
regardless of ownership or permissions on that table:
On Tue, Aug 10, 2021 at 1:40 PM Greg Nancarrow wrote:
>
> On Fri, Aug 6, 2021 at 6:32 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v19 patch has the fixes for the
comments.
> >
>
> Some more review comments, this time for the v19 patch:
>
&
On Thu, Aug 12, 2021 at 5:54 PM Masahiko Sawada
wrote:
>
> On Fri, Aug 6, 2021 at 5:33 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v19 patch has the fixes for the
comments.
>
> Thank you for updating the patch!
>
> Here
On Mon, Aug 9, 2021 at 10:23 AM Amit Kapila wrote:
>
> On Sun, Aug 8, 2021 at 2:52 PM vignesh C wrote:
> >
> > On Fri, Aug 6, 2021 at 4:39 PM Amit Kapila
wrote:
> > >
> > > On Fri, Aug 6, 2021 at 2:02 PM vignesh C wrote:
> > > >
> >
On Fri, Aug 6, 2021 at 4:02 PM Amit Kapila wrote:
>
> On Fri, Aug 6, 2021 at 2:16 PM vignesh C wrote:
> >
> > On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila
wrote:
> > >
> > >
> > > Few more comments:
> > > ===
> > >
On Tue, Aug 17, 2021 at 6:55 PM Tom Lane wrote:
>
> Amit Kapila writes:
> > On Tue, Aug 17, 2021 at 6:40 AM Peter Smith
wrote:
> >> On Mon, Aug 16, 2021 at 11:31 PM Tom Lane wrote:
> >>> Abstractly it'd be
> >>>
> >>> createpub := CREATE PUBLICATION pubname FOR cpitem [, ... ] [ WITH
... ]
> >>
On Sat, Aug 14, 2021 at 3:02 PM Peter Eisentraut <
peter.eisentr...@enterprisedb.com> wrote:
>
> On 13.08.21 04:59, Amit Kapila wrote:
> >> Even if we drop all tables added to the publication from it, 'pubkind'
> >> doesn't go back to 'empty'. Is that intentional behavior? If we do
> >> that, we ca
On Mon, 10 Jun 2024 at 12:24, Amul Sul wrote:
>
>
>
> On Sat, Jun 8, 2024 at 6:43 PM vignesh C wrote:
>>
>> On Wed, 5 Jun 2024 at 14:11, Amit Kapila wrote:
>> [...]
>> A new catalog table, pg_subscription_seq, has been introduced for
>> mapping sub
On Mon, 10 Jun 2024 at 16:38, Amit Kapila wrote:
>
> On Tue, Feb 20, 2024 at 12:35 PM vignesh C wrote:
> >
> > On Sat, 17 Feb 2024 at 12:03, Amit Kapila wrote:
> > >
> > >
> > > @@ -1839,7 +1839,8 @@ LogicalConfirmReceivedLocation(XLogRecPtr lsn)
>
On Mon, 10 Jun 2024 at 14:48, Amit Kapila wrote:
>
> On Mon, Jun 10, 2024 at 12:43 PM Masahiko Sawada
> wrote:
> >
> > On Mon, Jun 10, 2024 at 3:14 PM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Jun 7, 2024 at 7:30 PM Amit Kapila
> > > wrote:
> > > >
> > > >
> > > > Are you imagining the
On Tue, 11 Jun 2024 at 09:41, Amul Sul wrote:
>
> On Mon, Jun 10, 2024 at 5:00 PM vignesh C wrote:
>>
>> On Mon, 10 Jun 2024 at 12:24, Amul Sul wrote:
>> >
>> >
>> >
>> > On Sat, Jun 8, 2024 at 6:43 PM vignesh C wrote:
>&
On Tue, 11 Jun 2024 at 12:38, Masahiko Sawada wrote:
>
> On Tue, Jun 11, 2024 at 12:25 PM vignesh C wrote:
> >
> > On Mon, 10 Jun 2024 at 14:48, Amit Kapila wrote:
> > >
> > > On Mon, Jun 10, 2024 at 12:43 PM Masahiko Sawada
> > > wrote:
&g
On Wed, 12 Jun 2024 at 10:51, Dilip Kumar wrote:
>
> On Tue, Jun 11, 2024 at 4:06 PM vignesh C wrote:
> >
> > Amit and I engaged in an offline discussion regarding the design and
> > contemplated that it could be like below:
>
> If I understand correctly, does
On Wed, 12 Jun 2024 at 17:09, Dilip Kumar wrote:
>
> On Wed, Jun 12, 2024 at 4:08 PM vignesh C wrote:
> >
> > On Wed, 12 Jun 2024 at 10:51, Dilip Kumar wrote:
> > >
> > > On Tue, Jun 11, 2024 at 4:06 PM vignesh C wrote:
> > > >
> > > &g
On Thu, 13 Jun 2024 at 10:27, Dilip Kumar wrote:
>
> On Thu, Jun 13, 2024 at 10:10 AM vignesh C wrote:
> >
> > > So, you're saying that when we synchronize the sequence values on the
> > > subscriber side, we will create a new relfilenode to allow reverting
>
On Fri, 14 Jun 2024 at 15:52, Shubham Khanna
wrote:
>
> > Thanks for the updated patch, few comments:
> > 1) The option name seems wrong here:
> > In one place include_generated_column is specified and other place
> > include_generated_columns is specified:
> >
> > + else if (IsSet(s
On Wed, 19 Jun 2024 at 21:43, Peter Eisentraut wrote:
>
> On 19.06.24 13:22, Shubham Khanna wrote:
> > All the comments are handled.
> >
> > The attached Patch contains all the suggested changes.
>
> Please also take a look at the proposed patch for virtual generated
> columns [0] and consider how
On Thu, 20 Jun 2024 at 18:45, Amit Kapila wrote:
>
> On Wed, Jun 19, 2024 at 8:33 PM vignesh C wrote:
> >
> > On Tue, 18 Jun 2024 at 16:10, Amit Kapila wrote:
> > >
> > >
> > > Agreed and I am not sure which is better because there is a value in
&
On Fri, 21 Jun 2024 at 16:51, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Hackers,
>
> This is a follow-up thread for pg_createsubscriber [1]. I started a new thread
> since there is no activity around here.
>
> ## Problem
>
> Assuming that there is a cascading replication like below:
>
> node A --(lo
On Mon, 3 Jun 2024 at 11:21, Peter Smith wrote:
>
> Hi,
>
> I was looking at this code comment and wondered what it meant. AFAICT
> over time code has been moved around causing comments to lose their
> original context, so now it is hard to understand what they are
> saying.
>
> ~~~
>
> After a 20
On Thu, 27 Jun 2024 at 08:38, Amit Kapila wrote:
>
> On Wed, Jun 26, 2024 at 4:57 PM Tomas Vondra
> wrote:
> >
> > On 6/25/24 07:04, Amit Kapila wrote:
> > > On Mon, Jun 24, 2024 at 8:06 PM Tomas Vondra
> > > wrote:
> > >>
> > >> On 6/24/24 12:54, Amit Kapila wrote:
> > >>> ...
> >
> >
On Wed, 3 Jul 2024 at 08:24, Peter Smith wrote:
>
> Here are my comments for patch v20240702-0001
>
> They are all cosmetic and/or typos. Apart from these the 0001 patch LGTM.
>
> ==
> doc/src/sgml/func.sgml
>
> Section 9.17. Sequence Manipulation Functions
>
> pg_sequence_state:
> nitpick - t
On Thu, 4 Jul 2024 at 16:52, Heikki Linnakangas wrote:
>
> I'm don't quite understand the problem we're trying to fix:
>
> > Currently the launcher's latch is used for the following: a) worker
> > process attach b) worker process exit and c) subscription creation.
> > Since this same latch is used
On Fri, 5 Jul 2024 at 09:46, Peter Smith wrote:
>
> Hi Vignesh.
>
> After applying the v20240703-0003 patch, I was always getting errors
> when running the subscription TAP tests.
>
> # +++ tap check in src/test/subscription +++
> t/001_rep_changes.pl ... ok
> t/002_types.pl ..
On Fri, 5 Jul 2024 at 18:38, Heikki Linnakangas wrote:
>
> On 05/07/2024 14:07, vignesh C wrote:
> > On Thu, 4 Jul 2024 at 16:52, Heikki Linnakangas wrote:
> >>
> >> I'm don't quite understand the problem we're trying to fix:
> >>
> >&g
On Tue, 9 Jul 2024 at 17:05, Amit Kapila wrote:
>
> On Mon, Jul 1, 2024 at 10:51 AM vignesh C wrote:
> >
> >
> > This issue is present in all supported versions. I was able to
> > reproduce it using the steps recommended by Andres and Tomas's
> > scrip
On Wed, 10 Jul 2024 at 12:28, Amit Kapila wrote:
>
> On Tue, Jul 9, 2024 at 8:14 PM vignesh C wrote:
> >
> > On Tue, 9 Jul 2024 at 17:05, Amit Kapila wrote:
> > >
> > > On Mon, Jul 1, 2024 at 10:51 AM vignesh C wrote:
> > > >
> > > >
On Mon, 8 Jul 2024 at 17:46, vignesh C wrote:
>
> On Fri, 5 Jul 2024 at 18:38, Heikki Linnakangas wrote:
> >
> > On 05/07/2024 14:07, vignesh C wrote:
> > > On Thu, 4 Jul 2024 at 16:52, Heikki Linnakangas wrote:
> > >>
> > >> I'
On Tue, 11 Jul 2023 at 08:30, Peter Smith wrote:
>
> On Tue, Jul 11, 2023 at 12:31 AM Melih Mutlu wrote:
> >
> > Hi,
> >
> > Hayato Kuroda (Fujitsu) , 6 Tem 2023 Per,
> > 12:47 tarihinde şunu yazdı:
> > >
> > > Dear Melih,
> > >
> > > > Thanks for the 0003 patch. But it did not work for me. Can y
Hi,
Recently chipmunk has failed with the following errors at [1]:
make -C '../../..'
DESTDIR='/home/pgbfarm/buildroot/HEAD/pgsql.build'/tmp_install install
>'/home/pgbfarm/buildroot/HEAD/pgsql.build'/tmp_install/log/install.log
2>&1
make -j1 checkprep
>>'/home/pgbfarm/buildroot/HEAD/pgsql.build
bject: [PATCH 4/4] pg_upgrade: Add check function for
--include-logical-replication-slots option
XXX: Actually, this commit disallows to support slots which are created by user
backends. In the checking function we ensure that all the avtive slots have
confirmed_flush_lsn which is same as current W
rror recovery, disable the subscription in a new transaction
* and exit cleanly.
*/
-static void
+void
DisableSubscriptionAndExit(void)
{
/*
diff --git a/src/include/replication/logicalworker.h b/src/include/replication/logicalworker.h
index 39588da79f..bbd71d0b42 100644
--- a/src/include/replication/l
@@ -1521,6 +1544,11 @@ copy_table_done:
* then return to let LogicalRepApplyLoop do it.
*/
wait_for_worker_state_change(SUBREL_STATE_CATCHUP);
+
+ TimestampDifference(start, GetCurrentTimestamp(), &secs, µsecs);
+ elog(LOG, "SUBREL_STATE_CATCHUP %d", ((int) secs * 100 + microsecs));
+ s
On Wed, 9 Aug 2023 at 09:51, vignesh C wrote:
>
> Hi Melih,
>
> Here is a patch to help in getting the execution at various phases
> like: a) replication slot creation time, b) Wal reading c) Number of
> WAL records read d) subscription relation state change etc
> Couple of
On Fri, 11 Aug 2023 at 16:26, vignesh C wrote:
>
> On Wed, 9 Aug 2023 at 09:51, vignesh C wrote:
> >
> > Hi Melih,
> >
> > Here is a patch to help in getting the execution at various phases
> > like: a) replication slot creation time, b) Wal reading
On Thu, 10 Aug 2023 at 10:16, Amit Kapila wrote:
>
> On Wed, Aug 9, 2023 at 8:28 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > On Thursday, August 3, 2023 7:30 PM Melih Mutlu
> > wrote:
> >
> > > Right. I attached the v26 as you asked.
> >
> > Thanks for posting the patches.
> >
> > While reviewing
On Wed, 23 Aug 2023 at 02:25, Thomas Munro wrote:
>
> On Wed, Aug 23, 2023 at 8:21 AM Thomas Munro wrote:
> > I didn't study it closely but it looks like there might be a second
> > deadlock, after the one that is expected by the test? Examples from
> > the past couple of weeks:
>
> I should add
On Tue, 22 Aug 2023 at 15:42, Amit Kapila wrote:
>
> On Tue, Aug 22, 2023 at 2:56 PM Ashutosh Bapat
> wrote:
> >
> > On Tue, Aug 22, 2023 at 9:48 AM Amit Kapila wrote:
> > > >
> > > > Another idea is to record the confirm_flush_lsn at the time of
> > > > persisting the slot. We can use it in two
On Wed, 23 Aug 2023 at 14:21, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> > Here is a patch to persist to disk logical slots during a shutdown
> > checkpoint if the updated confirmed_flush_lsn has not yet been
> > persisted.
>
> Thanks for making the patch with different approach! Here ar
On Wed, 23 Aug 2023 at 14:21, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> > Here is a patch to persist to disk logical slots during a shutdown
> > checkpoint if the updated confirmed_flush_lsn has not yet been
> > persisted.
>
> Thanks for making the patch with different approach! Here ar
On Sat, 19 Aug 2023 at 11:53, Amit Kapila wrote:
>
> It's entirely possible for a logical slot to have a confirmed_flush
> LSN higher than the last value saved on disk while not being marked as
> dirty. It's currently not a problem to lose that value during a clean
> shutdown / restart cycle but
On Fri, 25 Aug 2023 at 17:40, vignesh C wrote:
>
> On Sat, 19 Aug 2023 at 11:53, Amit Kapila wrote:
> >
> > It's entirely possible for a logical slot to have a confirmed_flush
> > LSN higher than the last value saved on disk while not being marked as
> > dirt
On Mon, 15 Apr 2024 at 11:18, Amit Kapila wrote:
>
> On Thu, Apr 11, 2024 at 6:58 PM Kirill Reshke wrote:
> >
> > While working on [0] i have noticed this comment in
> > TerminateOtherDBBackends function:
> >
> > /*
> > * Check whether we have the necessary rights to terminate other
> > * session
On Sat, 20 Apr 2024 at 10:30, Alexander Lakhin wrote:
>
> Hello Michael and Robert,
>
> 20.04.2024 05:57, Michael Paquier wrote:
> > On Fri, Apr 19, 2024 at 01:57:41PM -0400, Robert Haas wrote:
> >> It looks to me like in the first run it took 3 minutes for the
> >> replay_lsn to catch up to the d
On Wed, 24 Apr 2024 at 11:59, Amit Kapila wrote:
>
> On Wed, Mar 13, 2024 at 9:19 AM vignesh C wrote:
> >
> > On Tue, 12 Mar 2024 at 09:34, Ajin Cherian wrote:
> > >
> > >
> > >
> > > On Tue, Mar 12, 2024 at 2:59 PM vignesh C wrote:
>
Hi,
Currently the launcher's latch is used for the following: a) worker
process attach b) worker process exit and c) subscription creation.
Since this same latch is used for multiple cases, the launcher process
is not able to handle concurrent scenarios like: a) Launcher started a
new apply worker
On Wed, 24 Apr 2024 at 15:49, Amit Kapila wrote:
>
> On Tue, Apr 23, 2024 at 4:53 PM Amit Kapila wrote:
> >
> > On Wed, Mar 13, 2024 at 11:59 AM vignesh C wrote:
> > >
> > > On Wed, 13 Mar 2024 at 10:12, Zhijie Hou (Fujitsu)
> > > wrote:
>
On Thu, 25 Apr 2024 at 16:20, Amit Kapila wrote:
>
> On Thu, Apr 25, 2024 at 7:01 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > On Wednesday, April 24, 2024 6:29 PM vignesh C wrote:
> > >
> > >
> > > The attached patch
> > > v7-000
On Fri, 26 Apr 2024 at 17:24, Jonathan S. Katz wrote:
>
> The Core Team would like to extend our congratulations to Melanie
> Plageman and Richard Guo, who have accepted invitations to become our
> newest PostgreSQL committers.
>
> Please join us in wishing them much success and few reverts!
Cong
h
From 0850792d2d52368af9a54698c03543b48e1f6681 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Mon, 6 May 2024 10:29:01 +0530
Subject: [PATCH v10] Documentation for upgrading logical replication cluster.
Documentation for upgrading logical replication cluster.
---
doc/src/sgml/glossary.sgml| 10 +
doc/src/sgml/l
On Mon, 20 May 2024 at 13:49, Masahiko Sawada wrote:
>
> Hi,
>
> On Wed, May 8, 2024 at 4:14 PM Shubham Khanna
> wrote:
> >
> > On Wed, May 8, 2024 at 11:39 AM Rajendra Kumar Dangwal
> > wrote:
> > >
> > > Hi PG Hackers.
> > >
> > > We are interested in enhancing the functionality of the pgoutpu
On Thu, 23 May 2024 at 09:19, Shubham Khanna
wrote:
>
> > Dear Shubham,
> >
> > Thanks for creating a patch! Here are high-level comments.
>
> > 1.
> > Please document the feature. If it is hard to describe, we should change
> > the API.
>
> I have added the feature in the document.
>
> > 4.
> >
From 072cfefd717a0c7c496a5ca66e9239ccb808ece6 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Wed, 29 May 2024 14:55:49 +0530
Subject: [PATCH v1] Improving the latch handling between logical replication
launcher and the worker processes.
Currently the launcher's latch is used for the followi
On Wed, 29 May 2024 at 10:41, Peter Smith wrote:
>
> On Thu, Apr 25, 2024 at 6:59 PM vignesh C wrote:
> >
>
> > c) Don't reset the latch at worker attach and allow launcher main to
> > identify and handle it. For this there is a patch v6-0002 available at
>
On Wed, 29 May 2024 at 16:30, Alexander Lakhin wrote:
>
> Hello hackers,
>
> As a recent buildfarm test failure [1] shows:
> [14:33:02.374](0.333s) ok 23 - update works with dropped subscriber column
> ### Stopping node "publisher" using mode fast
> # Running: pg_ctl -D
> /home/bf/bf-build/adder/H
On Thu, 30 May 2024 at 08:46, Peter Smith wrote:
>
> On Wed, May 29, 2024 at 7:53 PM vignesh C wrote:
> >
> > On Wed, 29 May 2024 at 10:41, Peter Smith wrote:
> > >
> > > On Thu, Apr 25, 2024 at 6:59 PM vignesh C wrote:
> > > >
> > >
&g
On Mon, 3 Jun 2024 at 13:03, Shubham Khanna wrote:
>
> On Thu, May 16, 2024 at 11:35 AM Peter Smith wrote:
> >
> > Here are some review comments for the patch v1-0001.
> >
> > ==
> > GENERAL
> >
> > G.1. Use consistent names
> >
> > It seems to add unnecessary complications by having differen
On Mon, Aug 15, 2022 at 10:42 AM Michael Paquier wrote:
>
> On Sun, Aug 14, 2022 at 07:56:00PM +0530, vignesh C wrote:
> > Modified the patch to list all the properties in case of "ALTER TYPE
> > typename SET (". I have included the properties in alphabetical or
On Sun, Aug 14, 2022 at 10:24 PM vignesh C wrote:
>
> On Sun, Aug 14, 2022 at 11:07 AM Tom Lane wrote:
> >
> > vignesh C writes:
> > > Currently we do not include the dependent extension information for
> > > index and materialized view in the describe comm
On Mon, Aug 8, 2022 at 2:08 PM Peter Smith wrote:
>
> PSA patch version v1* for a new "Column Lists" pgdocs section
>
> This is just a first draft, but I wanted to post it as-is, with the
> hope that I can get some feedback while continuing to work on it.
Few comments:
1) Row filters mentions tha
On Thu, Aug 18, 2022 at 12:33 PM Nitin Jadhav
wrote:
>
> I spent some time on understanding the proposal and the patch. Here
> are a few comments wrt the test cases.
>
> > +ALTER PUBLICATION testpub_reset ADD TABLE pub_sch1.tbl1;
> > +
> > +-- Verify that tables associated with the publication are
On Mon, Aug 8, 2022 at 2:53 PM vignesh C wrote:
>
> On Mon, Aug 8, 2022 at 12:46 PM vignesh C wrote:
> >
> > On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote:
> > >
> > > On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
> > > wrote:
&g
On Mon, Aug 22, 2022 at 1:58 PM Peter Smith wrote:
>
> Thanks for the view of v1-0001.
>
> On Wed, Aug 17, 2022 at 3:04 AM vignesh C wrote:
> ...
> > 1) Row filters mentions that "It has no effect on TRUNCATE commands.",
> > the same is not present in case
On Tue, Aug 16, 2022 at 9:04 PM Bruce Momjian wrote:
>
> On Mon, Aug 15, 2022 at 10:09:29PM +0530, vignesh C wrote:
> > I have updated the patch to display "Objects depending on extension"
> > as describe extension footer. The changes for the same are available
On Mon, Aug 22, 2022 at 9:19 AM houzj.f...@fujitsu.com
wrote:
>
> On Thursday, August 18, 2022 11:13 AM Amit Kapila
> wrote:
> >
> > On Wed, Aug 17, 2022 at 12:34 PM Peter Smith
> > wrote:
> > >
> > > On Wed, Aug 17, 2022 at 4:33 PM Amit Kapila
> > wrote:
> > > >
> > > > On Wed, Aug 17, 2022 a
On Tue, Aug 23, 2022 at 7:52 AM Peter Smith wrote:
>
> On Mon, Aug 22, 2022 at 9:25 PM vignesh C wrote:
> >
> ...
>
> > Few comments:
> > 1) I felt no expressions are allowed in case of column filters. Only
> > column names can be specified. The second part
On Fri, Aug 26, 2022 at 9:52 AM Dilip Kumar wrote:
>
> On Mon, Aug 22, 2022 at 9:19 AM houzj.f...@fujitsu.com
> wrote:
> >
> > > Jonathan, Sawada-San, Hou-San, and others, what do you think is the best
> > > way
> > > to move forward here?
> >
> > I think it's fine to throw a WARNING in this cas
1301 - 1400 of 1897 matches
Mail list logo
