On Sun, 14 Jan 2024 at 11:21, vignesh C wrote:
>
> On Fri, 2 Dec 2022 at 05:05, Kohei KaiGai wrote:
> >
> > > > IIUC, we already can use ctid in the where clause on the latest
> > > > PostgreSQL, can't we?
> > >
> > > Oh, sorry, I misse
On Sun, 21 Jan 2024 at 07:56, vignesh C wrote:
>
> On Fri, 18 Aug 2023 at 16:29, Juan José Santamaría Flecha
> wrote:
> >
> >
> > On Thu, Aug 17, 2023 at 3:51 PM Frédéric Yhuel
> > wrote:
> >>
> >> On 8/17/23 14:00, Frédéric Yhuel w
On Thu, 11 Jan 2024 at 19:50, vignesh C wrote:
>
> On Tue, 17 Oct 2023 at 04:18, Thomas Munro wrote:
> >
> > I pushed the retry-loop-in-frontend-executables patch and the
> > missing-locking-in-SQL-functions patch yesterday. That leaves the
> > backup ones, which
On Thu, 11 Jan 2024 at 19:55, vignesh C wrote:
>
> On Thu, 9 Feb 2023 at 12:02, Masahiko Sawada wrote:
> >
> > On Wed, Feb 8, 2023 at 1:13 PM Amit Kapila wrote:
> > >
> > > On Wed, Feb 8, 2023 at 1:19 AM Andres Freund wrote:
> > > >
> &g
On Thu, 11 Jan 2024 at 20:00, vignesh C wrote:
>
> On Thu, 13 Apr 2023 at 23:34, Fujii Masao wrote:
> >
> >
> >
> > On 2023/04/13 11:00, Kyotaro Horiguchi wrote:
> > > Agreed, it seems to be a leftover when we moved to parse_int_param()
> > >
On Thu, 11 Jan 2024 at 20:38, vignesh C wrote:
>
> On Tue, 29 Aug 2023 at 06:29, Jimmy Yih wrote:
> >
> > Thanks for the insightful response! I have attached an updated patch
> > that moves the proposed logic to the end of StartupXLOG where it seems
> > more cor
On Thu, 18 Jan 2024 at 06:39, vignesh C wrote:
>
> On Tue, 7 Nov 2023 at 12:23, John Morris wrote:
> >
> > Another update, this time with an abbreviated Doxyfile. Rather than
> > including the full Doxyfile, this updated version only includes modified
> > setting
On Fri, 18 Aug 2023 at 23:04, Hannu Krosing wrote:
>
> I will address the comments here over this coming weekend.
The patch which you submitted has been awaiting your attention for
quite some time now. As such, we have moved it to "Returned with
Feedback" and removed it from the reviewing queue.
On Mon, 4 Sept 2023 at 21:40, Peter Eisentraut wrote:
>
> On 30.06.23 20:48, Karina Litskevich wrote:
> > So as for me calling LockRelationForExtension() and
> > UnlockRelationForExtension()
> > without testing eb.rel first looks more like a bug here. However, they
> > are never
> > actually calle
On Sat, 20 Jan 2024 at 09:03, vignesh C wrote:
>
> On Mon, 20 Feb 2023 at 16:06, David Geier wrote:
> >
> > Hi!
> >
> > On 2/14/23 13:48, David Geier wrote:
> > >
> > > It still fails.
> > >
> > > I'll get Cirrus-CI working o
On Sun, 21 Jan 2024 at 07:32, vignesh C wrote:
>
> On Wed, 2 Aug 2023 at 21:34, Tomas Vondra
> wrote:
> >
> >
> >
> > On 8/2/23 17:25, Sergey Dudoladov wrote:
> > > Hello,
> > >
> > >> Parallel version is not supported, but I thi
On Sat, 27 Jan 2024 at 09:10, vignesh C wrote:
>
> On Fri, 27 Oct 2023 at 18:50, Daniel Gustafsson wrote:
> >
> > Attached is a v10 rebase of this patch which had undergone significant
> > bitrot
> > due to recent changes in the pg_upgrade check phase. This brin
Hi,
Thanks a lot to all the members who participated in the commitfest.
Here are the final numbers at the end of the commitfest:
status | w1 | w2 | w3 | w4| End
++--++-+--
Needs review:
On Sun, 4 Feb 2024 at 14:32, Alvaro Herrera wrote:
>
> On 2024-Jan-10, Daniel Gustafsson wrote:
>
> > > On 9 Jan 2024, at 23:18, Robert Haas wrote:
> >
> > > I think we need to be more aggressive about marking things returned
> > > with feedback when they don't get updated.
> >
> > I very much ag
On Fri, 2 Feb 2024 at 11:30, Alexander Lakhin wrote:
>
> Hello Vignesh and Hou-san,
>
> 01.02.2024 07:59, vignesh C wrote:
> > Here is an updated patch which changes the boolean variable to a
> > tri-state enum and set stable state to valid only if no invalidations
>
On Tue, 6 Feb 2024 at 08:30, Alexander Lakhin wrote:
>
> Hello Amit,
>
> 05.02.2024 15:20, Amit Kapila wrote:
> > If this can be reproduced frequently then we can even try to test the
> > patch in that thread by Osumi-San [1] (I haven't tested that it
> > applies cleanly but shouldn't be difficult
Regards,
Vignesh
From 35e31ca3d843d81b43a01d537073174f30f5097c Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Wed, 7 Feb 2024 15:49:00 +0530
Subject: [PATCH v3] Fix the intermittent buildfarm failures in 031_column_list test.
Fix the intermittent buildfarm failures in 031_column_list test.
---
On Wed, 7 Feb 2024 at 15:26, Amit Kapila wrote:
>
> On Wed, Feb 7, 2024 at 2:06 AM Tom Lane wrote:
> >
> > I wrote:
> > > More to the point, aren't these proposals just band-aids that
> > > would stabilize the test without fixing the actual problem?
> > > The same thing is likely to happen to peo
On Tue, 6 Feb 2024 at 18:30, Alexander Lakhin wrote:
>
> 05.02.2024 13:13, vignesh C wrote:
> > Thanks for the steps for the issue, I was able to reproduce this issue
> > in my environment with the steps provided. The attached patch has a
> > proposed fix where the latch
On Wed, 7 Feb 2024 at 10:24, Euler Taveira wrote:
>
> On Fri, Feb 2, 2024, at 6:41 AM, Hayato Kuroda (Fujitsu) wrote:
>
> Thanks for updating the patch!
Thanks for the updated patch, few comments:
Few comments:
1) Cleanup function handler flag should be reset, i.e.
dbinfo->made_replslot = false;
On Thu, 8 Feb 2024 at 23:30, Alexander Lakhin wrote:
>
> 08.02.2024 12:25, vignesh C wrote:
> > Yes, the wakeup call sent by the "CREATE SUBSCRIPTION" command was
> > getting missed in this case. The wakeup call can be sent during
> > subscription creation/modi
On Tue, 28 Feb 2023 at 01:22, Melih Mutlu wrote:
>
> Hi,
>
> Thanks for all of your reviews!
>
> So, I made some changes in the v10 according to your comments.
>
> 1- copy_format is changed to a boolean parameter copy_binary.
> It sounds easier to use a boolean to enable/disable binary copy. Defau
On Tue, 28 Feb 2023 at 21:21, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Amit,
>
> > Few comments:
>
> Thank you for reviewing! PSA new version.
Thanks for the updated patch, few comments:
1) Currently we have added the delay during the decode of commit,
while decoding the commit walsender process w
On Thu, 2 Mar 2023 at 20:53, Önder Kalacı wrote:
>
> Hi,
>
>>
>> Is it just a matter of testing other
>> index types
>
>
> Yes, there are more to it. build_replindex_scan_key()
> only works for btree indexes, as it does BTEqualStrategyNumber.
>
> I might expect a few more limitations like that. I
x27;)');
> > > > +}
> > > >
> > > > 9b.
> > > > I understand why this function was put here beside the other static
> > > > functions in "Support Routines" but IMO it really belongs nearby (i.e.
> > > > directly ab
On Tue, 7 Mar 2023 at 09:53, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Katsuragi-san,
>
> Thank you for reviewing! PSA new version patches.
>
> > I think we can update the status to ready for committer after
> > this fix, if there is no objection.
>
> That's a very good news for me! How about other
On Fri, 3 Mar 2023 at 18:40, Önder Kalacı wrote:
>
> Hi Vignesh,
>
> Thanks for the review
>
>>
>> 1) We are currently calling RelationGetIndexList twice, once in
>> FindUsableIndexForReplicaIdentityFull function and in the caller too,
>> we could avoid one of the calls by passing the indexlist to
On Tue, 7 Mar 2023 at 19:17, Önder Kalacı wrote:
>
> Hi Amit, Peter
>
>>
>> > > Let me give an example to demonstrate why I thought something is fishy
>> > > here:
>> > >
>> > > Imagine rel has a (non-default) REPLICA IDENTITY with Oid=.
>> > > Imagine the same rel has a PRIMARY KEY with Oid=
On Wed, 8 Mar 2023 at 21:46, Önder Kalacı wrote:
>
> Hi Vignesh C,
>
>>
>>
>> Few comments
>> 1) Maybe this change is not required:
>> fallback if no other solution is possible. If a replica identity other
>> than full is set on the publish
s?
Regards,
Vignesh
From 63b53a87253af6e5d08f473cb0d568c2321a2bd3 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Fri, 3 Mar 2023 15:54:00 +0530
Subject: [PATCH v1] Implement IF NOT EXISTS for CREATE PUBLICATION AND CREATE
SUBSCRIPTION
Implement IF NOT EXISTS for CREATE PUBLICATION AND CREATE
On Fri, 10 Mar 2023 at 04:36, Peter Smith wrote:
>
> Hi,
>
> During a recent code review, I was confused multiple times by the
> toptxn member of ReorderBufferTXN, which is defined only for
> sub-transactions.
>
> e.g. txn->toptxn member == NULL means the txn is a top level txn.
> e.g. txn->toptxn
On Tue, 14 Mar 2023 at 14:36, Önder Kalacı wrote:
>
>
> Amit Kapila , 14 Mar 2023 Sal, 11:59 tarihinde şunu
> yazdı:
>>
>> On Tue, Mar 14, 2023 at 12:48 PM Önder Kalacı wrote:
>> >>
>> >> 2.
>> >> +# make sure that the subscriber has the correct data after the update
>> >> UPDATE
>> >>
>> >> "u
On Tue, 14 Mar 2023 at 12:37, Peter Smith wrote:
>
> Thanks for the review!
>
> On Mon, Mar 13, 2023 at 6:19 PM vignesh C wrote:
> ...
> > Few comments:
> > 1) Can we move the macros along with the other macros present in this
> > file, just above this structure
On Wed, 15 Mar 2023 at 15:30, Melih Mutlu wrote:
>
> Hi,
>
> Please see the attached patch.
One comment:
1) There might be a chance the result order of select may vary as
"ORDER BY" is not specified, Should we add "ORDER BY" as the table
has multiple rows:
+# Check the synced data on the subscri
On Thu, 16 Mar 2023 at 21:55, Tomas Vondra
wrote:
>
> Hi!
>
> On 3/16/23 08:38, Masahiko Sawada wrote:
> > Hi,
> >
> > On Wed, Mar 15, 2023 at 9:52 PM Tomas Vondra
> > wrote:
> >>
> >>
> >>
> >> On 3/14/23 08:30, John Naylor wrote:
> >>> I tried a couple toy examples with various combinations of
On Thu, 16 Mar 2023 at 21:55, Tomas Vondra
wrote:
>
> Hi!
>
> On 3/16/23 08:38, Masahiko Sawada wrote:
> > Hi,
> >
> > On Wed, Mar 15, 2023 at 9:52 PM Tomas Vondra
> > wrote:
> >>
> >>
> >>
> >> On 3/14/23 08:30, John Naylor wrote:
> >>> I tried a couple toy examples with various combinations of
On Fri, 17 Mar 2023 at 17:55, Melih Mutlu wrote:
>
> Hi,
>
> Sharing v17.
>
> Amit Kapila , 17 Mar 2023 Cum, 03:02 tarihinde şunu
> yazdı:
>>
>> I think to reduce the risk of breakage, let's change the check to
>> >=v16. Also, accordingly, update the doc and commit message.
>
>
> Done.
>
> Peter
On Thu, 23 Mar 2023 at 09:22, Ajin Cherian wrote:
>
> On Mon, Mar 20, 2023 at 8:17 PM houzj.f...@fujitsu.com
> wrote:
> >
> > Attach the new patch set which addressed above comments.
> > 0002,0003,0004 patch has been updated in this version.
> >
> > Best Regards,
> > Hou zj
>
> Attached a patch-s
On Thu, 14 Mar 2024 at 15:49, Amit Kapila wrote:
>
> On Thu, Mar 14, 2024 at 1:45 PM Masahiko Sawada wrote:
> >
> > On Thu, Mar 14, 2024 at 2:27 PM Amit Kapila wrote:
> > >
> > > On Thu, Mar 14, 2024 at 5:57 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > This fact makes me think that the slot
point
I have fixed it by pausing the replay in the standby server before the
replication slots get created.
The attached v29-0002-Keep-standby-server-s-minimum-recovery-point-les.patch
patch has the changes for the same.
Thoughts?
Regards,
Vignesh
From e98e1ba0661e3d658de8d46ff9082f6cd4040b41 Mon
On Sat, 16 Mar 2024 at 21:16, Euler Taveira wrote:
>
> On Sat, Mar 16, 2024, at 10:31 AM, vignesh C wrote:
>
> I was able to reproduce this random failure and found the following reason:
> The Minimum recovery ending location 0/500 was more than the
> recovery_target_l
On Sat, 16 Mar 2024 at 21:13, Euler Taveira wrote:
>
> On Fri, Mar 15, 2024, at 3:34 AM, Amit Kapila wrote:
>
> Did you consider adding options for publication/subscription/slot
> names as mentioned in my previous email? As discussed in a few emails
> above, it would be quite confusing for users t
On Mon, 18 Mar 2024 at 16:36, Peter Eisentraut wrote:
>
> On 18.03.24 08:18, vignesh C wrote:
> > 1) Maximum size of the object name is 64, we can have a check so that
> > we don't specify more than the maximum allowed length:
> > + case 3:
> > + if (!simple_str
On Tue, 19 Mar 2024 at 17:18, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Sawada-san,
>
> Thanks for giving comments!
>
> > This behavior makes sense to me. But do we want to handle the case of
> > using environment variables too?
>
> Yeah, v5 does not consider which libpq parameters are specified by
On Wed, 20 Mar 2024 at 17:09, Amit Kapila wrote:
>
> On Tue, Mar 19, 2024 at 5:18 PM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Thanks for giving comments!
> >
> > > This behavior makes sense to me. But do we want to handle the case of
> > > using environment variables too?
> >
> > Yeah, v5 does no
On Thu, 21 Mar 2024 at 09:50, Euler Taveira wrote:
>
> On Mon, Mar 18, 2024, at 10:52 AM, Peter Eisentraut wrote:
>
> On 16.03.24 16:42, Euler Taveira wrote:
> > I'm attaching a new version (v30) that adds:
>
> I have some review comments and attached a patch with some smaller
> fixups (mainly mes
On Thu, 21 Mar 2024 at 18:02, Peter Eisentraut wrote:
>
> On 21.03.24 12:35, vignesh C wrote:
> > Here are a few suggestions:
> > 1) I felt displaying the server log to the console is not a good idea,
> > I prefer this to be logged. There were similar comments from
> &g
On Fri, 22 Mar 2024 at 09:01, Euler Taveira wrote:
>
> On Thu, Mar 21, 2024, at 6:49 AM, Shlok Kyal wrote:
>
> There is a compilation error while building postgres with the patch
> due to a recent commit. I have attached a top-up patch v32-0003 to
> resolve this compilation error.
> I have not upd
On Mon, 25 Mar 2024 at 21:36, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Bharath, Peter,
>
> > Looks like BF animals aren't happy, please check -
> > > https://buildfarm.postgresql.org/cgi-bin/show_failures.pl.
> >
> > Looks like sanitizer failures. There were a few messages about that
> > recently,
blisher before verifying the data.
[1] -
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mamba&dt=2024-03-26%2004%3A23%3A13
Regards,
Vignesh
From 69d7adc27198d5cf3ecf5b8c7d62a3e41263bc2a Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Wed, 27 Mar 2024 11:27:34 +0530
Subject: [PATCH v
On Tue, 26 Mar 2024 at 10:05, Masahiko Sawada wrote:
>
> On Thu, Mar 14, 2024 at 12:02 PM Masahiko Sawada
> wrote:
> >
> >
> > I've attached new version patches.
>
> Since the previous patch conflicts with the current HEAD, I've
> attached the rebased patches.
Thanks for the updated patch.
One
On Fri, 29 Mar 2024 at 17:14, Philip Warner wrote:
>
> I am trying to discover the causes of occasional data loss in logical
> replication; it is VERY rare and happens every few week/months.
>
> Our setup is a source DB running in docker on AWS cloud server. The source
> database is stored in on
On Thu, 28 Mar 2024 at 13:05, Masahiko Sawada wrote:
>
> Hi,
>
> Thank you for the patch!
>
> On Mon, Jul 3, 2023 at 12:12 AM vignesh C wrote:
> >
> > Hi,
> >
> > Improved tab completion for "ALTER DEFAULT PRIVILEGE" and "ALTER TABLE"
On Tue, 2 Apr 2024 at 13:08, Masahiko Sawada wrote:
>
> On Mon, Apr 1, 2024 at 10:41 PM vignesh C wrote:
> >
> > On Thu, 28 Mar 2024 at 13:05, Masahiko Sawada wrote:
> > >
> > > Hi,
> > >
> > > Thank you for the patch!
> &
On Mon, 8 Apr 2024 at 10:29, Masahiko Sawada wrote:
>
> On Fri, Apr 5, 2024 at 1:18 AM vignesh C wrote:
> >
> > On Tue, 2 Apr 2024 at 13:08, Masahiko Sawada wrote:
> > >
> > > On Mon, Apr 1, 2024 at 10:41 PM vignesh C wrote:
> > > >
>
On Thu, 1 Feb 2024 at 14:50, vignesh C wrote:
>
> On Wed, 31 Jan 2024 at 11:42, Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Dear Vignesh,
> >
> > Thanks for updating the patch! Here are my comments for v6.
> >
> > 01.
> > ```
> > + Logical
/src/sgml/ref/pgupgrade.sgml
>
> 6.
> +
> +
> + The steps to upgrade logical replication clusters are not covered here;
> + refer to for details.
> +
> +
>
> Maybe here too there should be a link to the glossary term "logical
> replic
On Mon, 12 Feb 2024 at 14:33, vignesh C wrote:
>
> On Fri, 9 Feb 2024 at 12:30, Peter Smith wrote:
> >
> > Here are some review comments for patch v7-0001.
> >
> > ==
> > doc/src/sgml/glossary.sgml
> >
> > 1.
> > +
> > + Logic
On Wed, 14 Feb 2024 at 09:07, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Justin,
>
> > pg_upgrade/t/004_subscription.pl says
> >
> > |my $mode = $ENV{PG_TEST_PG_UPGRADE_MODE} || '--copy';
> >
> > ..but I think maybe it should not.
> >
> > When you try to use --link, it fails:
> > https://cirrus-ci.co
On Wed, 7 Feb 2024 at 16:27, vignesh C wrote:
>
> On Wed, 7 Feb 2024 at 15:21, Amit Kapila wrote:
> >
> > On Tue, Feb 6, 2024 at 8:21 PM Tom Lane wrote:
> > >
> > > Amit Kapila writes:
> > > > Yeah, I was worried about that. The other idea I hav
Hi,
Recently there have been few upgrade tap test failures in buildfarm
like in [1] & [2]. Analysing these failures requires the log files
that are getting generated from src/bin/pg_upgrade at the following
locations:
tmp_check/*/pgdata/pg_upgrade_output.d/*/*.txt - e.g.
tmp_check/t_004_subscrip
On Thu, 15 Feb 2024 at 07:24, Michael Paquier wrote:
>
> On Wed, Feb 14, 2024 at 03:51:08PM +0530, vignesh C wrote:
> > First regex is the testname_clusterinstance_data, second regex is the
> > timestamp used for pg_upgrade, third regex is for the text files
> > generated
On Thu, 15 Feb 2024 at 08:42, Amit Kapila wrote:
>
> On Wed, Feb 14, 2024 at 12:58 PM vignesh C wrote:
> >
> > On Wed, 7 Feb 2024 at 16:27, vignesh C wrote:
> > >
> > > I was able to reproduce the issue consistently with the changes shared
> > > by
On Fri, 16 Feb 2024 at 08:22, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Amit,
>
> > This sounds like a reasonable way to address the reported problem.
>
> OK, thanks!
>
> > Justin, do let me know if you think otherwise?
> >
> > Comment:
> > ===
> > *
> > -# Setup an enabled subscription to v
Hi,
The following assertion failure was seen while testing one scenario
for other patch:
TRAP: failed Assert("s->data.confirmed_flush >=
s->last_saved_confirmed_flush"), File: "slot.c", Line: 1760, PID:
545314
postgres: checkpointer performing shutdown
checkpoint(ExceptionalCondition+0xbb)[0x564ee
On Fri, 16 Feb 2024 at 10:50, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> Thanks for reviewing! PSA new version.
>
> >
> > Thanks for the updated patch, few suggestions:
> > 1) Can we use a new publication for this subscription too so that the
> > publication and subscription naming will
On Mon, 19 Feb 2024 at 06:54, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> Thanks for reviewing! PSA new version.
>
> >
> > Thanks for the updated patch, Few suggestions:
> > 1) This can be moved to keep it similar to other tests:
> > +# Setup a disabled subscription. The upcoming test wi
12
(1 row)
Thoughts?
[1] -
https://www.postgresql.org/message-id/CAA4eK1%2BT-ETXeRM4DHWzGxBpKafLCp__5bPA_QZfFQp7-0wj4Q%40mail.gmail.com
Regards,
Vignesh
From 9b79dee26554ae4af9ff00948ab185482b071ba8 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Mon, 19 Feb 2024 10:20:02 +0530
Subject: [PATCH
On Mon, 19 Feb 2024 at 12:48, vignesh C wrote:
>
> Hi,
>
> Currently ALTER SUBSCRIPTION ... SET PUBLICATION will break the
> logical replication in certain cases. This can happen as the apply
> worker will get restarted after SET PUBLICATION, the apply worker will
> use
On Sat, 17 Feb 2024 at 12:03, Amit Kapila wrote:
>
> On Fri, Feb 16, 2024 at 5:53 PM vignesh C wrote:
> >
> >
> > After the insert operation is replicated to the subscriber, the
> > subscriber will set the lsn value sent by the publisher in the
> > replication
On Mon, 19 Feb 2024 at 11:15, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear hackers,
>
> > Since it may be useful, I will post top-up patch on Monday, if there are no
> > updating.
>
> And here are top-up patches. Feel free to check and include.
>
> v22-0001: Same as v21-0001.
> === rebased patches ===
On Tue, 20 Feb 2024 at 15:47, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> Thanks for giving comments!
>
> > Few comments for v22-0001 patch:
> > 1) The second "if (strcmp(PQgetvalue(res, 0, 1), "t") != 0)"" should
> > be if (strcmp(PQgetvalue(res, 0, 2), "t") != 0):
> > + if (strcmp
On Mon, 19 Feb 2024 at 11:15, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear hackers,
>
> > Since it may be useful, I will post top-up patch on Monday, if there are no
> > updating.
>
> And here are top-up patches. Feel free to check and include.
>
> v22-0001: Same as v21-0001.
> === rebased patches ===
On Fri, 16 Feb 2024 at 17:39, vignesh C wrote:
>
> Hi,
>
> The following assertion failure was seen while testing one scenario
> for other patch:
> TRAP: failed Assert("s->data.confirmed_flush >=
> s->last_saved_confirmed_flush"), File: "slot.c",
On Mon, 19 Feb 2024 at 11:15, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear hackers,
>
> > Since it may be useful, I will post top-up patch on Monday, if there are no
> > updating.
>
> And here are top-up patches. Feel free to check and include.
>
> v22-0001: Same as v21-0001.
> === rebased patches ===
On Mon, 19 Feb 2024 at 11:15, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear hackers,
>
> > Since it may be useful, I will post top-up patch on Monday, if there are no
> > updating.
>
> And here are top-up patches. Feel free to check and include.
>
> v22-0001: Same as v21-0001.
> === rebased patches ===
https://commitfest.postgresql.org/47/4848/
Regards,
Vignesh
From 3ff1910ec221c4e5f2e1eb8291848528d6ec479a Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Tue, 30 Jan 2024 08:55:20 +0530
Subject: [PATCH v9] Documentation for upgrading logical replication cluster.
Documentation for upgrading logical replication cluster.
---
d
On Thu, 22 Feb 2024 at 21:17, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> > Few comments on the tests:
> > 1) If the dry run was successful because of some issue then the server
> > will be stopped so we can check for "pg_ctl status" if the server is
> > running otherwise the connection w
On Fri, 9 Feb 2024 at 20:51, Masahiko Sawada wrote:
>
> On Thu, Feb 8, 2024 at 6:33 PM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Dear Sawada-san,
> >
> > Thanks for making v3 patchset. I have also benchmarked the case [1].
> > Below results are the average of 5th, there are almost the same result
On Wed, 14 Feb 2024 at 13:19, Bharath Rupireddy
wrote:
>
> Hi,
>
> I recently observed an assertion failure twice in t/001_rep_changes.pl
> on HEAD with the backtrace [1] on my dev EC2 c5.4xlarge instance [2].
> Unfortunately I'm not observing it again. I haven't got a chance to
> dive deep into i
On Thu, 15 Feb 2024 at 08:36, vignesh C wrote:
>
> On Thu, 15 Feb 2024 at 07:24, Michael Paquier wrote:
> >
> > On Wed, Feb 14, 2024 at 03:51:08PM +0530, vignesh C wrote:
> > > First regex is the testname_clusterinstance_data, second regex is the
> > > timest
and new clusters.
Attached patch has the changes for the same.
Regards,
Vignesh
From c76b8b6cbdc7b1f29c0c73290651673cf06fd137 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Sun, 25 Feb 2024 07:22:27 +0530
Subject: [PATCH v1] Preserve subscription OIDs during pg_upgrade.
Currently subscription
On Mon, 26 Feb 2024 at 10:57, Andrew Dunstan wrote:
>
>
> On 2024-02-25 Su 11:18, vignesh C wrote:
> > On Thu, 15 Feb 2024 at 08:36, vignesh C wrote:
> >> On Thu, 15 Feb 2024 at 07:24, Michael Paquier wrote:
> >>> On Wed, Feb 14, 2024 at 03:51:08PM +0530, vi
On Mon, 26 Feb 2024 at 12:33, Masahiko Sawada wrote:
>
> On Fri, Feb 23, 2024 at 6:24 PM vignesh C wrote:
> >
> > On Fri, 9 Feb 2024 at 20:51, Masahiko Sawada wrote:
> > >
> > >
> > > I think this performance regression is not acceptable. In
On Mon, 4 Mar 2024 at 17:43, Aleksander Alekseev
wrote:
>
> > > All,
> > >
> > > The PostgreSQL Contributor Page
> > > (https://www.postgresql.org/community/contributors/) includes people who
> > > have made substantial, long-term contributions of time and effort to the
> > > PostgreSQL project. T
On Wed, 28 Feb 2024 at 11:40, Amit Kapila wrote:
>
> On Mon, Feb 26, 2024 at 7:54 PM Masahiko Sawada wrote:
> >
>
> A few comments on 0003:
> ===
> 1.
> +/*
> + * Threshold of the total number of top-level and sub transactions
> that controls
> + * whether we switch the memory tra
On Sat, 2 Mar 2024 at 02:19, Euler Taveira wrote:
>
> On Thu, Feb 22, 2024, at 12:45 PM, Hayato Kuroda (Fujitsu) wrote:
>
> Based on idea from Euler, I roughly implemented. Thought?
>
> 0001-0013 were not changed from the previous version.
>
> V24-0014: addressed your comment in the replied e-mail
On Thu, 7 Mar 2024 at 10:05, Euler Taveira wrote:
>
> On Wed, Mar 6, 2024, at 7:02 AM, Hayato Kuroda (Fujitsu) wrote:
>
> Thanks for updating the patch!
>
>
> Thanks for the feedback. I'm attaching v26 that addresses most of your
> comments
> and some issues pointed by Vignesh [1].
Few comments:
On Thu, 7 Mar 2024 at 18:31, Shlok Kyal wrote:
>
> Hi,
>
> > Thanks for the feedback. I'm attaching v26 that addresses most of your
> > comments
> > and some issues pointed by Vignesh [1].
>
> I have created a top-up patch v27-0004. It contains additional test
> cases for pg_createsubscriber.
>
>
On Sat, 9 Mar 2024 at 00:56, Tomas Vondra wrote:
>
>
>
> On 3/8/24 10:44, Hayato Kuroda (Fujitsu) wrote:
> > Dear Tomas, Euler,
> >
> > Thanks for starting to read the thread! Since I'm not an original author,
> > I want to reply partially.
> >
> >> I decided to take a quick look on this patch tod
On Mon, 11 Mar 2024 at 17:16, Amit Kapila wrote:
>
> On Tue, Feb 27, 2024 at 2:07 PM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > > PSA the patch for implementing it. It is basically same as Ian's one.
> > > However, this patch still cannot satisfy the condition 3).
> > >
> > > `pg_basebackup -D data
On Tue, 12 Mar 2024 at 09:34, Ajin Cherian wrote:
>
>
>
> On Tue, Mar 12, 2024 at 2:59 PM vignesh C wrote:
>>
>>
>> Thanks, I have created the following Commitfest entry for this:
>> https://commitfest.postgresql.org/47/4816/
>>
>> Regards,
>&g
On Wed, 13 Mar 2024 at 10:12, Zhijie Hou (Fujitsu)
wrote:
>
> On Wednesday, March 13, 2024 11:49 AMvignesh C wrote:
> > On Tue, 12 Mar 2024 at 09:34, Ajin Cherian wrote:
> > >
> > >
> > >
> > > On Tue, Mar 12, 2024 at 2:59 PM vignesh C wrote:
On Wed, 13 Mar 2024 at 16:58, Amit Kapila wrote:
>
> On Tue, Mar 12, 2024 at 5:13 PM vignesh C wrote:
> >
> > On Mon, 11 Mar 2024 at 17:16, Amit Kapila wrote:
> > >
> > > On Tue, Feb 27, 2024 at 2:07 PM Hayato Kuroda (Fujitsu)
> > > wrote:
> &
Hi All,
If no one has volunteered for the upcoming (January 2023) commitfest.
I would like to volunteer for it.
Regards,
Vignesh
(Matches("ALTER", "EXTENSION", MatchAny, "ADD|DROP",
> "FOREIGN"))
> + COMPLETE_WITH("DATA WRAPPER", "TABLE");
>
> The DROP could be matched with the objects that are actually part of
> th
On Wed, 7 Dec 2022 at 17:50, Alvaro Herrera wrote:
>
> I think this patch is split badly.
>
> You have:
>
> 0001 an enormous patch including some required infrastructure, plus the
> DDL deparsing bits themselves.
>
> 0002 another enormous (though not as much) patch, this time for
> DDL replication
On Tue, 3 Jan 2023 at 07:52, Michael Paquier wrote:
>
> On Wed, Dec 28, 2022 at 10:52:38AM +0530, vignesh C wrote:
> > If no one has volunteered for the upcoming (January 2023) commitfest.
> > I would like to volunteer for it.
>
> If you want to be up to the task, that w
On Tue, 27 Dec 2022 at 14:59, Hayato Kuroda (Fujitsu)
wrote:
> Note that more than half of the modifications are done by Osumi-san.
1) This global variable can be removed as it is used only in
send_feedback which is called from maybe_delay_apply so we could pass
it as a function argument:
+ * del
Hi All,
Just a reminder that Commitfest 2023-01 has started.
There are many patches based on the latest run from [1] which require
a) Rebased on top of head b) Fix compilation failures c) Fix test
failure, please have a look and rebase it so that it is easy for the
reviewers and committers:
1. TAP
501 - 600 of 1897 matches
Mail list logo
