Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-17 Thread Thomas Hallgren
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: I submitted a patch to fix this on October 21st, but it has not been applied (in common with several other cleanup patches I sent in about a week ago). Bruce got horribly backlogged recently and didn't get any patches in to speak

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-17 Thread Fabien COELHO
Dear Thomas, Something that Fabien Coelho fixed recently broke tonight. I can no longer compile PL/Java on win32 using pgxs since the directory pgxs/src/include/port/win32/* is missing (again). AFAICS, the patch is in the queue waiting for a review. -- Fabien Coelho - [EMAIL PROTECTED]

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-17 Thread Thomas Hallgren
Thomas Hallgren wrote: Something that Fabien Coelho fixed recently broke tonight. I can no longer compile PL/Java on win32 using pgxs since the directory pgxs/src/include/port/win32/* is missing (again). And in addition to that, the libpostgresql.a is also missing. Regards, Thomas Hallgren

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-17 Thread Fabien COELHO
AFAICS, the patch is in the queue waiting for a review. Well, the CVS HEAD did work as if it indeed had been applied until yesterday evening. I'm quite sure of that since I took a new snapshot yesterday and created a brand new installation. PL/Java compiled fine on win32 (aside from the

[HACKERS] 7.4.5 / 7.4.6 crash (pg_hba.conf issue)

2004-11-17 Thread Rod Taylor
I've run across a bug in pg_hba.conf routines which is repeatable in both 32bit intel on Linux and 64bit AMD on FreeBSD with both 7.4.5 and 7.4.6. It results in the postmaster crashing which is quite annoying when it leaves behind it's children. create a file dev.users within the data directory

Re: [HACKERS] Minor problem with Makefile.shlib

2004-11-17 Thread Reini Urban
Thomas Hallgren schrieb: I have a minor issue with Makefile.shlib. Compiling with win32 it spits out these warnings (the same is true for Cygwin) Makefile.shlib:327: warning: overriding commands for target `libpljava.a' Makefile.shlib:262: warning: ignoring old commands for target

[HACKERS] pgEdit public beta for Macintosh and Windows

2004-11-17 Thread John DeSoi
The first public beta for pgEdit is now available (see product description below). If you would like to participate in the beta program, evaluate the software and send some feedback to me (e.g. criticism, bug reports, feature requests). The first responders will receive a 30 day trial

Re: [PATCHES] [HACKERS] cygwin build failure

2004-11-17 Thread Tom Lane
Reini Urban [EMAIL PROTECTED] writes: I'm just testing a new build from CVS with atttached patch. Patch applied. src/interfaces/ecpg/preproc: the .y and *.l files need to be touched and the generated .c/.h recompiled. They are outdated, at least on CVS. They don't exist in CVS.

[HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Tom Lane
I'd like to propose removing -Wold-style-definition from the default gcc flags. It is cluttering my make logs with warnings that can't be got rid of because they are about code generated by flex. regards, tom lane ---(end of

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Andrew Dunstan
Tom Lane wrote: I'd like to propose removing -Wold-style-definition from the default gcc flags. It is cluttering my make logs with warnings that can't be got rid of because they are about code generated by flex. Would it not be possible to suppress the warnings just for the flex-generated

Re: [HACKERS] 7.4.5 / 7.4.6 crash (pg_hba.conf issue)

2004-11-17 Thread Tom Lane
Rod Taylor [EMAIL PROTECTED] writes: I've run across a bug in pg_hba.conf routines which is repeatable in both 32bit intel on Linux and 64bit AMD on FreeBSD with both 7.4.5 and 7.4.6. It results in the postmaster crashing which is quite annoying when it leaves behind it's children. Off-by-one

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Tom Lane wrote: I'd like to propose removing -Wold-style-definition from the default gcc flags. It is cluttering my make logs with warnings that can't be got rid of because they are about code generated by flex. Would it not be possible to suppress

Re: [HACKERS] pg_resetxlog options

2004-11-17 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: Why does pg_resetxlog seem top be the only one of our programs that has no long form options (or at least the only one that calls getopt rather than getopt_long)? Should we make it consistent with everything else? I think just

[HACKERS] ambiguous column names in subqueries

2004-11-17 Thread Greg Stark
I have a query where I want to override one of the output column names. The problem is that the columns are coming from a subquery. So I have do something like: select *, coalesce(a,b) as a from subquery The problem is that * still includes column a. And replacing * with a complete list of

Re: [HACKERS] 7.4.5 / 7.4.6 crash (pg_hba.conf issue)

2004-11-17 Thread Devrim GUNDUZ
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On Wed, 17 Nov 2004, Tom Lane wrote: Off-by-one memory allocation problem --- it only bites you if the string lengths are just right, which probably explains the lack of prior reports even though the bug has been there since 7.3. Is this worth new

Re: [HACKERS] 7.4.5 / 7.4.6 crash (pg_hba.conf issue)

2004-11-17 Thread Tom Lane
Devrim GUNDUZ [EMAIL PROTECTED] writes: Off-by-one memory allocation problem --- it only bites you if the string lengths are just right, which probably explains the lack of prior reports even though the bug has been there since 7.3. Is this worth new dot releases? I'd say not.

[HACKERS] split_part bug

2004-11-17 Thread John Hansen
PostgreSQL 8.0b4 as released. select split_part('a b c d e f g h i j k l m n o p q r s t u v w x y z',' ',1); select split_part('a b c d e f g h i j k l m n o p q r s t u v w x y z',' ',2); select split_part('a b c d e f g h i j k l m n o p q r s t u v w x y z',' ',3); select split_part('a b c d

Re: [HACKERS] pg_resetxlog options

2004-11-17 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Some other time maybe. Meanwhile, this patch ought to make it compile more cleanly on Windows - not sure why I get errors there but not Linux. The Single Unix Spec says that getopt() is supposed to be defined by unistd.h, but I guess reading the spec

Re: [HACKERS] ambiguous column names in subqueries

2004-11-17 Thread Oliver Jowett
Greg Stark wrote: What purpose is there to returning both columns to the outer query? The columns become effectively inaccessible. There's no syntax for disambiguating any reference. I think postgres should treat the second alias as hiding the first. Currently there's no way to selectively

Re: [HACKERS] ambiguous column names in subqueries

2004-11-17 Thread Tom Lane
Greg Stark [EMAIL PROTECTED] writes: Is there any help in the SQL spec on this? Rename the columns at the output of the subselect, eg select * from (select 1 as foo, 2 as foo) as x(foo1, foo2); regards, tom lane ---(end of

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Alvaro Herrera
On Wed, Nov 17, 2004 at 01:50:00PM -0500, Tom Lane wrote: I'd like to propose removing -Wold-style-definition from the default gcc flags. It is cluttering my make logs with warnings that can't be got rid of because they are about code generated by flex. Oh, so that's what all the noise I see

Re: [HACKERS] split_part bug

2004-11-17 Thread Tom Lane
John Hansen [EMAIL PROTECTED] writes: PostgreSQL 8.0b4 as released. select split_part('a b c d e f g h i j k l m n o p q r s t u v w x y z',' ',1); select split_part('a b c d e f g h i j k l m n o p q r s t u v w x y z',' ',2); select split_part('a b c d e f g h i j k l m n o p q r s t u v w

Re: [HACKERS] ambiguous column names in subqueries

2004-11-17 Thread Greg Stark
Oliver Jowett [EMAIL PROTECTED] writes: Please don't. JDBC (for example) has no problem with ambiguous columns, you just access them by index, and you have resultset metadata available if you want to implement your own rules for finding those indexes. It sounds like your problem really

Re: [HACKERS] ambiguous column names in subqueries

2004-11-17 Thread Greg Stark
Tom Lane [EMAIL PROTECTED] writes: select * from (select 1 as foo, 2 as foo) as x(foo1, foo2); How is this different than simply listing all the columns instead of the *? I still have the maintenance problem of having to edit the outer query every time the list of columns from the inner query

Re: [HACKERS] split_part bug

2004-11-17 Thread John Hansen
Works fine for me. What encoding/locale are you using? unicode / c ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster

Re: [HACKERS] split_part bug

2004-11-17 Thread Tom Lane
John Hansen [EMAIL PROTECTED] writes: Works fine for me. What encoding/locale are you using? unicode / c [ shrug... ] Works fine for me in unicode, too. u=# select split_part('a b c d e f g h i j k l m n o p q r s t u v w x y z',' ',1); split_part a (1 row) u=# select

Re: [HACKERS] ambiguous column names in subqueries

2004-11-17 Thread Tom Lane
Greg Stark [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] writes: select * from (select 1 as foo, 2 as foo) as x(foo1, foo2); I still have the maintenance problem of having to edit the outer query every time the list of columns from the inner query changes. Yeah, but at least you only

Re: [HACKERS] split_part bug

2004-11-17 Thread John Hansen
[ shrug... ] Works fine for me in unicode, too. never mind me,. I broke it. seems my assumption that UCS2 == UTF16 was way off ... john ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ?

Re: [HACKERS] pg_resetxlog options

2004-11-17 Thread Peter Eisentraut
Andrew Dunstan wrote: Some other time maybe. Meanwhile, this patch ought to make it compile more cleanly on Windows - not sure why I get errors there but not Linux. Because getopt() is normally declared in unistd.h, not getopt.h (Windows being an exception?). -- Peter Eisentraut

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Neil Conway
On Wed, 2004-11-17 at 14:59 -0500, Tom Lane wrote: Would it not be possible to suppress the warnings just for the flex-generated code? IMHO it's not worth the trouble. I think this is the better course. At least here, flex-generated files produce warnings even without

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: I think this is the better course. At least here, flex-generated files produce warnings even without -Wold-style-definition: That's because you're using a badly broken flex: % flex --version flex 2.5.31 I'd recommend reverting to 2.5.4. IIRC we have

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Neil Conway
On Wed, 2004-11-17 at 20:22 -0500, Tom Lane wrote: That's because you're using a badly broken flex Sure, but my point is just that different versions of flex, in general, will provoke different compiler warnings. I don't see that it is a net win to disable a flag across the _whole_ source tree

[HACKERS] are there any cons to linking libstdc++ with postgresql?

2004-11-17 Thread Palle Girgensohn
Hi! I'm not a linking guru... Is there a penalty for setting LDFLAGS+= -lstdc++ when building postgresql? Postgis includes a bunch of useful functions for manipulating spatial data. Some of them are provided by geos, a separate c++ library, with postgis providing wrappers. According to postgis

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Kevin HaleBoyes
Tom Lane wrote: That's because you're using a badly broken flex: % flex --version flex 2.5.31 I know very little (enough to get by) about the configuration phase when building postgresql but couldn't this be checked for? That is, configure could check the version of various tools, like flex, and

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Tom Lane
Kevin HaleBoyes [EMAIL PROTECTED] writes: Tom Lane wrote: That's because you're using a badly broken flex: % flex --version flex 2.5.31 That is, configure could check the version of various tools, like flex, and warn if appropriate. It does, although I find that the warnings are of little

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: Why not just disable warnings for just the flex-generated files? Because it's a pain in the neck to do so; it'll require klugery in half a dozen different Makefiles. (I don't see any easy way to make the change apply only to the flex files, and not to the

Re: [HACKERS] are there any cons to linking libstdc++ with postgresql?

2004-11-17 Thread Tom Lane
Palle Girgensohn [EMAIL PROTECTED] writes: Is there a penalty in just leaving LDFLAGS+= -lstdc++ in the postgresql port Makefile? Bad idea? Yup. The portability hazards are considerable. I'm a bit surprised the postgis guys seem to think it works. regards, tom lane

Re: [HACKERS] are there any cons to linking libstdc++ with

2004-11-17 Thread Palle Girgensohn
Does the same arguments apply for linking with libc_r (pthreads)? It is needed by plpython, at least on FreeBSD 4.10 (probably all versions). /Palle --On onsdag, november 17, 2004 20.49.20 -0500 Tom Lane [EMAIL PROTECTED] wrote: Palle Girgensohn [EMAIL PROTECTED] writes: Is there a penalty in

Re: [HACKERS] Tired of -Wold-style-definition already

2004-11-17 Thread Neil Conway
On Wed, 2004-11-17 at 20:44 -0500, Tom Lane wrote: It does, although I find that the warnings are of little use since people tend not to read every line of configure's output. AFAICS no such warning is emitted. Perhaps you are thinking of the warnings about using the wrong version of bison, or

Re: [HACKERS] ambiguous column names in subqueries

2004-11-17 Thread Greg Stark
Tom Lane [EMAIL PROTECTED] writes: AFAICS removing columns from the inner query because they have duplicate names would violate the SQL spec, so it's not going to happen. That's really what I was asking I guess. Does the spec require the current behaviour. An alternative would be some way to