Re: [HACKERS] Windowing Function Patch Review - Standard Conformance

2008-11-09 Thread Hitoshi Harada
2008/11/9 David Rowley [EMAIL PROTECTED]: Hitoshi Harada wrote: I recreate the patch against current HEAD, in the git it's here: http://git.postgresql.org/?p=postgresql.git;a=commit;h=f88970d3c6fb9f99543 d873bb7228f4c057c23e0 I tested `patch -p1` with the attached and succeeded to make it

[HACKERS] Windowing Function Patch Review - NTILE function

2008-11-09 Thread David Rowley
I've done a little testing with NTILE(). I think a check should be added to the ntile() function in wfunc.c. david=# select name,salary,ntile(0) over (order by salary) as n from employees; ERROR: floating-point exception DETAIL: An invalid floating-point operation was signaled. This probably

Re: [HACKERS] Block-level CRC checks

2008-11-09 Thread Martijn van Oosterhout
On Fri, Oct 17, 2008 at 12:26:11PM -0300, Alvaro Herrera wrote: So this discussion died with no solution arising to the hint-bit-setting-invalidates-the-CRC problem. Apparently the only solution in sight is to WAL-log hint bits. Simon opines it would be horrible from a performance

Re: [HACKERS] Simple postgresql.conf wizard

2008-11-09 Thread Greg Smith
On Sun, 2 Nov 2008, Josh Berkus wrote: I'd start with command-line switches, e.g. config --memory=32GB --type=DW --size=500GB --connections=20 Attached version takes all its input via command line switches. If you don't specify an explict number of connections, it also implements setting

Re: [HACKERS] Windowing Function Patch Review - Standard Conformance

2008-11-09 Thread David Rowley
Using one of my original test tables I'm testing windowing functions with a GROUP BY. The following query works as I would expect. -- Works SELECT department, SUM(Salary), ROW_NUMBER() OVER (ORDER BY department), SUM(SUM(salary)) OVER (ORDER BY department) FROM employees

Re: [HACKERS] Windowing Function Patch Review - Standard Conformance

2008-11-09 Thread David Rowley
Hitoshi Harada wrote: I'm glad to hear that. Actually thanks to git it is quite easy for me to merge my own repository with the HEAD. It tells me which lines are new coming and which lines I modified are newer than else in CVS. This is my first project where I use git (and I am not guru of cvs

[HACKERS] Windowing Function Patch Review - NTH_VALUE

2008-11-09 Thread David Rowley
I'm having a little trouble understanding the standard for NTH_VALUE(). I would have assumed that NTH_VALUE(name,1) would return the first name in the window. The current patch is using 0 for the first. Here is the paragraph I'm reading in the standard: The nth-value function takes an arbitrary

Re: [HACKERS] Windowing Function Patch Review - Standard Conformance

2008-11-09 Thread David Rowley
Hitoshi Harada wrote: I recreate the patch against current HEAD, in the git it's here: http://git.postgresql.org/?p=postgresql.git;a=commit;h=f88970d3c6fb9f99543 d873bb7228f4c057c23e0 I tested `patch -p1` with the attached and succeeded to make it work cleanly. It seems to me that this

Re: [HACKERS] Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle

2008-11-09 Thread Ron Mayer
Tom Lane wrote: Ron Mayer [EMAIL PROTECTED] writes: Brendan Jurd wrote: ...I did notice one final ... Just checked in a fix to that one; and updated my website at http://0ape.com/postgres_interval_patches/ and pushed it to my (hopefully fixed now) git server. Applied with some revisions: I

Re: [HACKERS] Block-level CRC checks

2008-11-09 Thread Tom Lane
Martijn van Oosterhout [EMAIL PROTECTED] writes: There is another option I havn't seen mentioned anywhere yet: a single bit change in a page has a predictable change on the CRC, dependant only on the position of the bit. So in theory it would be possible for the process changing the hint bit

Re: [HACKERS] Spurious Kerberos error messages

2008-11-09 Thread Magnus Hagander
Tom Lane wrote: Peter Eisentraut [EMAIL PROTECTED] writes: Nothing has changed about when it fails, only the extra krb error message before the usual error messages (could not connect, server is starting up) are new. This probably has something to do with Magnus's work on concatenating

Re: [HACKERS] Spurious Kerberos error messages

2008-11-09 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Another option would be not to call the kerberos code there at all. All other authentication methods that take the userid externally (gssapi, sspi, ident) require the user to specify the name to connect as if it's different from the one in the

Re: [HACKERS] Spurious Kerberos error messages

2008-11-09 Thread Magnus Hagander
Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: Another option would be not to call the kerberos code there at all. All other authentication methods that take the userid externally (gssapi, sspi, ident) require the user to specify the name to connect as if it's different from the

Re: [HACKERS] [PATCH] Recreate Missing WAL Directories (from TODO)

2008-11-09 Thread Tom Lane
Jonah H. Harris [EMAIL PROTECTED] writes: On Sat, Nov 8, 2008 at 4:08 PM, Tom Lane [EMAIL PROTECTED] wrote: This has been suggested before but I'm unconvinced that it's a good idea. It's reasonably common for pg_xlog to be a symlink. If you neglect to re-establish the symlink then what would

Re: [HACKERS] Block-level CRC checks

2008-11-09 Thread Greg Stark
I think double buffering solves the torn page problem but not the lack of wal logging. Alvarro solved the wal logging by deferring the wal logs. But I'm not sure how confident we are that it's logging enough. I'm beginning to think just excluding the hint bits would be simpler and safer.

Re: [HACKERS] Windowing Function Patch Review - Performance Comparison.

2008-11-09 Thread David Rowley
Hitoshi Harada wrote: I found how to do it, though it's only on the case you gave. Thinking about the planner optimization of the Window nodes (and its attached Sort nodes), we must consider the execution order of more than one node. In the test case we only take care of only one window, but

Re: [HACKERS] Reducing some DDL Locks to ShareLock

2008-11-09 Thread Tom Lane
Reviewing away ... There's a fairly serious problem with this patch, which is that it overlooks one of the reasons that index_update_stats can work the way it does: * 3. Because we execute CREATE INDEX with just share lock on the parent * rel (to allow concurrent index creations), an

Re: [HACKERS] Windowing Function Patch Review - ROW_NUMBER without ORDER BY

2008-11-09 Thread Andreas Joseph Krogh
On Sunday 09 November 2008 22:35:01 David Rowley wrote: I've been trying to think of a use case for using ROW_NUMBER() with no ORDER BY in the window clause. Using the example table I always seem to be using, for those who missed it in other threads. create table employees ( id INT

Re: [HACKERS] Reducing some DDL Locks to ShareLock

2008-11-09 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: On Tue, 2008-10-07 at 11:15 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: 2. Also need to decide whether we want pg_class.reltriggers as int2 (as implemented here) or switch to relhastriggers as boolean. I'd go for changing the column

Re: [HACKERS] [PATCH] Recreate Missing WAL Directories (from TODO)

2008-11-09 Thread Decibel!
On Nov 8, 2008, at 3:08 PM, Tom Lane wrote: Jonah H. Harris [EMAIL PROTECTED] writes: When performing a PITR copy of a data cluster, the pg_xlog directory is generally omitted. As such, when starting the copy up for replay/recovery, the WAL directories need to be recreated. This patch

Re: [HACKERS] Reducing some DDL Locks to ShareLock

2008-11-09 Thread Simon Riggs
On Sun, 2008-11-09 at 17:12 -0500, Tom Lane wrote: Reviewing away ... Thanks for reviewing. There's a fairly serious problem... ... Any thoughts about the best way to do it? My immediate inclination is to use heap_lock_tuple but it's a bit expensive. Not sure how non-transactional

Re: [HACKERS] [WIP] In-place upgrade

2008-11-09 Thread Decibel!
On Nov 6, 2008, at 1:31 PM, Bruce Momjian wrote: 3. What about multi-release upgrades? Say someone wants to upgrade from 8.3 to 8.6. 8.6 only knows how to read pages that are 8.5-and-a-half or better, 8.5 only knows how to read pages that are 8.4-and-a-half or better, and 8.4 only knows how to

Re: [HACKERS] Windowing Function Patch Review - ROW_NUMBER without ORDER BY

2008-11-09 Thread Hitoshi Harada
2008/11/10 David Rowley [EMAIL PROTECTED]: I've been trying to think of a use case for using ROW_NUMBER() with no ORDER BY in the window clause. Using the example table I always seem to be using, for those who missed it in other threads. create table employees ( id INT primary key, name

Re: [HACKERS] SQL5 budget

2008-11-09 Thread Decibel!
I think you're barking up the wrong tree here; the community can't really do hacking for hire. If you want to pay for something to be implemented (which is great!), you'll need to talk to companies that do Postgres consulting. You can find examples on the website and through google. You

Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-09 Thread Decibel!
On Nov 8, 2008, at 8:35 PM, Jonah H. Harris wrote: On Sat, Nov 8, 2008 at 8:08 PM, Tom Lane [EMAIL PROTECTED] wrote: Zdenek Kotala [EMAIL PROTECTED] writes: Attached patch allows to setup storage parameter for space reservation. What is the point of this? That's my question. Why is this

Re: [HACKERS] [WIP] In-place upgrade

2008-11-09 Thread Tom Lane
Decibel! [EMAIL PROTECTED] writes: I think that's pretty seriously un-desirable. It's not at all uncommon for databases to stick around for a very long time and then jump ahead many versions. I don't think we want to tell people they can't do that. Of course they can do that --- they

Re: [HACKERS] Reducing some DDL Locks to ShareLock

2008-11-09 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: Will think some more and report back. If you want to do some more development, here's the portion of the patch as yet unapplied --- will save you extracting it for yourself. regards, tom lane binApLwlsttOX.bin Description:

Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-09 Thread Robert Haas
Well, if that's what it is, I think it's a fairly poor design decision. When I upgrade Oracle, SQL Server, or MySQL, I don't need to plan the amount of free space in my blocks a year or more before an upgrade. In fact, I don't have to plan it at all... it's completely handled by the

Re: [HACKERS] [PATCH] Recreate Missing WAL Directories (from TODO)

2008-11-09 Thread Tom Lane
Decibel! [EMAIL PROTECTED] writes: What if the the location was recorded in something that's not meant to be touched by users, such as pg_control? At that point we'd have a command for actually moving it. [ shrug... ] Possible, perhaps, but I think we have more important problems to

Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-09 Thread Zdenek Kotala
Jonah H. Harris napsal(a): On Sun, Nov 9, 2008 at 7:55 PM, Decibel! [EMAIL PROTECTED] wrote: On Nov 8, 2008, at 8:35 PM, Jonah H. Harris wrote: That's my question. Why is this needed at all? I suspect this is to deal with needing to reserve space in a cluster that you're planning on

[HACKERS] Windowing Function Patch Review - ROW_NUMBER without ORDER BY

2008-11-09 Thread David Rowley
I've been trying to think of a use case for using ROW_NUMBER() with no ORDER BY in the window clause. Using the example table I always seem to be using, for those who missed it in other threads. create table employees ( id INT primary key, name varchar(30) not null, department varchar(30)

Re: [HACKERS] [PATCH] Recreate Missing WAL Directories (from TODO)

2008-11-09 Thread Decibel!
On Nov 9, 2008, at 11:44 AM, Tom Lane wrote: Decibel! [EMAIL PROTECTED] writes: On Nov 8, 2008, at 3:08 PM, Tom Lane wrote: ... It's reasonably common for pg_xlog to be a symlink. ISTM it'd be better still to have an official knob that allows you to determine where pg_xlog lives. ISTR

Re: [HACKERS] [WIP] In-place upgrade

2008-11-09 Thread Joshua D. Drake
On Sun, 2008-11-09 at 20:02 -0500, Tom Lane wrote: Decibel! [EMAIL PROTECTED] writes: I think that's pretty seriously un-desirable. It's not at all uncommon for databases to stick around for a very long time and then jump ahead many versions. I don't think we want to tell people they

Re: [HACKERS] Reducing some DDL Locks to ShareLock

2008-11-09 Thread Simon Riggs
On Sun, 2008-11-09 at 13:58 -0500, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: On Tue, 2008-10-07 at 11:15 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: 2. Also need to decide whether we want pg_class.reltriggers as int2 (as implemented here) or switch to

Re: [HACKERS] auto_explain contrib moudle

2008-11-09 Thread Jeff Davis
On Sat, 2008-11-08 at 11:32 -0800, Jeff Davis wrote: One thing I'm unsure of (this question is for ITAGAKI Takahiro): why is it necessary to define a new function DefineCustomVariable(), when there are already functions DefineCustomBoolVariable() and DefineCustomIntVariable()? Oh, I see.

Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-09 Thread Jonah H. Harris
On Sun, Nov 9, 2008 at 7:55 PM, Decibel! [EMAIL PROTECTED] wrote: On Nov 8, 2008, at 8:35 PM, Jonah H. Harris wrote: That's my question. Why is this needed at all? I suspect this is to deal with needing to reserve space in a cluster that you're planning on upgrading to a new version that

Re: [HACKERS] Windowing Function Patch Review - Performance Comparison.

2008-11-09 Thread David Rowley
Hitoshi Harada wrote: I found how to do it, though it's only on the case you gave. Thinking about the planner optimization of the Window nodes (and its attached Sort nodes), we must consider the execution order of more than one node. In the test case we only take care of only one window, but

Re: [HACKERS] Spurious Kerberos error messages

2008-11-09 Thread Andrew Dunstan
Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: Another option would be not to call the kerberos code there at all. All other authentication methods that take the userid externally (gssapi, sspi, ident) require the user to specify the name to connect as if it's different from the

Re: [HACKERS] Windowing Function Patch Review - ROW_NUMBER without ORDER BY

2008-11-09 Thread Vladimir Sitnikov
I see this as a greate feature. I would treat ranking functions without explicit order by clause as a feature rather than a bug. However, I believe, in most cases optimizer will avoid additional sort when possible, thus an order by in a windowing clause would not cause any performance

Re: [HACKERS] Re: Hot standby v5 patch - Databases created post backup remain inaccessible + replica SIGSEGV when coming out of standby

2008-11-09 Thread Mark Kirkwood
Simon Riggs wrote: On Tue, 2008-11-04 at 18:33 +1300, Mark Kirkwood wrote: postgres=# \l List of databases Name| Owner | Encoding | Collation | Ctype | Access Privileges

Re: [HACKERS] [PATCH] Recreate Missing WAL Directories (from TODO)

2008-11-09 Thread Tom Lane
Decibel! [EMAIL PROTECTED] writes: On Nov 8, 2008, at 3:08 PM, Tom Lane wrote: ... It's reasonably common for pg_xlog to be a symlink. ISTM it'd be better still to have an official knob that allows you to determine where pg_xlog lives. ISTR discussion about that, but I don't see anything

Re: [HACKERS] Block-level CRC checks

2008-11-09 Thread Martijn van Oosterhout
On Sun, Nov 09, 2008 at 11:02:32AM -0500, Tom Lane wrote: Yes it would :-(. Also, this scheme would point us towards maintaining the CRCs *continually* while the page is in memory, rather than only recalculating them upon write. So every tuple insert/update/delete would require a

Re: [HACKERS] array_length()

2008-11-09 Thread Decibel!
On Nov 5, 2008, at 7:00 AM, Peter Eisentraut wrote: There is a tiny problem with this implementation: It returns null for an empty array, not zero. This is because array_lower and/or array_upper return null for an empty array, which makes sense for those cases. We could fix this by

Re: [HACKERS] Patch for ISO-8601-Interval Input and output.

2008-11-09 Thread Brendan Jurd
On Sat, Nov 8, 2008 at 2:19 AM, Ron Mayer [EMAIL PROTECTED] wrote: Hmmm... Certainly what I had in datatype.sgml was wrong, but I'm now thinking 5.5.4.2.1 and 5.5.4.2.2 would be the most clear? Sorry, I don't understand what you mean by 5.5.4.2.1. In the spec you linked to, clause 5 Date and

Re: [HACKERS] ALTER DATABASE SET TABLESPACE vs crash safety

2008-11-09 Thread Decibel!
On Nov 7, 2008, at 9:53 AM, Tom Lane wrote: So I'm looking at the patch for ALTER DATABASE SET TABLESPACE, and wondering about what happens if there's a system crash midway through. The answer doesn't look too good: if the deletion pass has started, your database is hosed. FWIW, I don't see

Re: [HACKERS] Hot standby v5 patch assertion failure

2008-11-09 Thread Mark Kirkwood
Simon Riggs wrote: On Mon, 2008-11-03 at 12:16 +1300, Mark Kirkwood wrote: Trying out a few different scenarios I ran across this: 1/ Setup master and replica with replica using pg_standby 2/ Create a new database (bench in my case) 3/ Initialize pgbench schema size 100 4/ Run with 2

Re: [HACKERS] SQL5 budget

2008-11-09 Thread Jonah H. Harris
On Sun, Nov 9, 2008 at 7:41 PM, Decibel! [EMAIL PROTECTED] wrote: I think you're barking up the wrong tree here; the community can't really do hacking for hire. If you want to pay for something to be implemented (which is great!), you'll need to talk to companies that do Postgres consulting.