Re: [HACKERS] small but useful patches for text search

2009-03-21 Thread Robert Haas
On Sat, Mar 21, 2009 at 12:55 PM, Joshua D. Drake wrote: >> Robert,  this has been discussed many times before, and most people agree >> with >> you, but Bruce doesn't. I think the ony way this will change is if someone >> takes on the role of "release notes manager", subscrbes to pgsql-commits,

Re: [HACKERS] contrib function naming, and upgrade issues

2009-03-21 Thread Robert Haas
On Sat, Mar 21, 2009 at 9:49 PM, Tom Lane wrote: > Robert Treat writes: >> We've been talking about this magical "proper module facility" for a few >> releases now... are we still opposed to putting contrib modules in thier own >> schema? > > I'm hesitant to do that when we don't yet have either

Re: [HACKERS] libxml incompatibility

2009-03-21 Thread Tom Lane
I wrote: > We could possibly use xmlMemGet() to fetch the prior settings and then > restore them after we are done, but making sure that happens after an > error would be a bit tricky. I experimented with this a bit, and came up with the attached patch. Basically what it does is revert libxml to i

Re: [HACKERS] Open 8.4 item list

2009-03-21 Thread Bruce Momjian
bruce wrote: > Here are some of the emails I consider open for 8.4: > > http://momjian.us/cgi-bin/pgsql/open FYI, Tom has added a lot of comments to this page. I have also updated the HTML because some browsers were not showing the existence of comments. -- Bruce Momjian http:

Re: [HACKERS] contrib function naming, and upgrade issues

2009-03-21 Thread Tom Lane
Robert Treat writes: > We've been talking about this magical "proper module facility" for a few > releases now... are we still opposed to putting contrib modules in thier own > schema? I'm hesitant to do that when we don't yet have either a design or a migration plan for the module facility. W

Re: [HACKERS] contrib function naming, and upgrade issues

2009-03-21 Thread Robert Treat
On Saturday 21 March 2009 12:27:27 Tom Lane wrote: > Andrew Gierth writes: > > "Tom" == Tom Lane writes: > > Tom> I agree that this wasn't an amazingly good choice, but I think > > Tom> there's no real risk of name collisions because fmgr only > > Tom> searches for such names within the partic

Re: [HACKERS] Can we drop ABSTIME?

2009-03-21 Thread Tom Lane
Josh Berkus writes: > We've been carrying this warning in our docs since 7.4: > "The key word ABSTIME is ignored for historical reasons: In very old > releases of PostgreSQL, invalid values of type abstime were emitted as > Invalid Abstime. This is no longer the case however and this key word

Re: [HACKERS] One less footgun: deprecating pg_dump -d

2009-03-21 Thread Tom Lane
It seemed that the majority opinion in this thread was to eliminate the confusion by dropping the short form "d" switch in pg_dump and pg_dumpall --- if you want that behavior you'll have to write "--inserts". For consistency I suggested also dropping the short form switch "D" for "--column-insert

[HACKERS] Documentation Update: WAL & Checkpoints

2009-03-21 Thread Michael Renner
Hi, this is a small update to the first paragraph of the WAL configuration chapter, going into more detail WRT redo vs. checkpoint records, since the underlying behavior is currently only deducible from the source. I'm not perfectly sure if I got everything right, so feel free to change as ne

Re: [HACKERS] win32 open item

2009-03-21 Thread Merlin Moncure
On Sat, Mar 21, 2009 at 12:15 PM, Tom Lane wrote: > Magnus Hagander writes: >> The open items list for 8.4 has >> *  problems with Windows global namespace > >> I propose we move this over to the TODO list instead. > > Agreed.  In general, any issue that already exists in released versions > shou

Re: [HACKERS] small but useful patches for text search

2009-03-21 Thread Joshua D. Drake
On Sat, 2009-03-21 at 12:02 -0400, Robert Treat wrote: > On Saturday 21 March 2009 09:04:12 Robert Haas wrote: > > On Fri, Mar 20, 2009 at 11:59 PM, Bruce Momjian wrote: > > > Robert Haas wrote: > > > My concern with the list of outstanding items for 8.4 based on a quick > > look is that I think

Re: [HACKERS] contrib function naming, and upgrade issues

2009-03-21 Thread Tom Lane
Andrew Gierth writes: > "Tom" == Tom Lane writes: > Tom> I agree that this wasn't an amazingly good choice, but I think > Tom> there's no real risk of name collisions because fmgr only > Tom> searches for such names within the particular .so. > Oh, if only life were so simple. I think you ar

Re: [HACKERS] win32 open item

2009-03-21 Thread Tom Lane
Magnus Hagander writes: > The open items list for 8.4 has > * problems with Windows global namespace > I propose we move this over to the TODO list instead. Agreed. In general, any issue that already exists in released versions should not be considered a blocker for 8.4. Certainly it wouldn't

Re: [HACKERS] win32 open item

2009-03-21 Thread Merlin Moncure
On Sat, Mar 21, 2009 at 12:11 PM, Magnus Hagander wrote: > The open items list for 8.4 has *) "PQinitSSL broken in some use casesf" This should be addressed. Andrew C proposed a few different ways to do it and supplied patches. Pick one and apply it. *) Re: [HACKERS] patch to fix client only b

[HACKERS] win32 open item

2009-03-21 Thread Magnus Hagander
The open items list for 8.4 has * problems with Windows global namespace I propose we move this over to the TODO list instead. We are no worse off than we are in previous versions, and we've had *zero* bug reports related to this issue. Basically, we have a small window of failed protection if

Re: [HACKERS] small but useful patches for text search

2009-03-21 Thread Robert Treat
On Saturday 21 March 2009 09:04:12 Robert Haas wrote: > On Fri, Mar 20, 2009 at 11:59 PM, Bruce Momjian wrote: > > Robert Haas wrote: > My concern with the list of outstanding items for 8.4 based on a quick > look is that I think many of those things are not, in fact, > outstanding items for 8.4,

Re: [HACKERS] small but useful patches for text search

2009-03-21 Thread Bruce Momjian
Robert Haas wrote: > Oh, I'm not objecting to email as a way of communicating. I think a > bug tracking system or web forums would increase the amount of effort > required to keep up to date on what is going on, and I can't imagine > what the corresponding advantage would be. What I don't like is

Re: [HACKERS] contrib function naming, and upgrade issues

2009-03-21 Thread Martijn van Oosterhout
On Sat, Mar 21, 2009 at 01:05:35PM +, Andrew Gierth wrote: > (Perhaps we should be linking contrib and pgxs modules with -Bsymbolic > on those platforms where it matters?) Another possibility is to use the visibility attributes such as those provided in GCC. Maybe the version1 declarion of a f

Re: [HACKERS] contrib function naming, and upgrade issues

2009-03-21 Thread Andrew Gierth
> "Tom" == Tom Lane writes: Tom> I agree that this wasn't an amazingly good choice, but I think Tom> there's no real risk of name collisions because fmgr only Tom> searches for such names within the particular .so. Oh, if only life were so simple. Consider two modules mod1 (source files

Re: [HACKERS] small but useful patches for text search

2009-03-21 Thread Robert Haas
On Fri, Mar 20, 2009 at 11:59 PM, Bruce Momjian wrote: > Robert Haas wrote: >> I personally think that the way pgsql-hackers organizes itself using >> email is completely insane.  The only reason that you need to write >> the release notes instead of, say, me, is because the only information >> on

Re: [HACKERS] contrib function naming, and upgrade issues

2009-03-21 Thread Andrew Gierth
> "Simon" == Simon Riggs writes: > On Sat, 2009-03-21 at 01:57 +, Andrew Gierth wrote: >> Note that I'm talking here about the names of the C functions, not >> the SQL names. >> >> The existing hstore has some very dubious choices of function names >> (for non-static functions) in

Re: [HACKERS] contrib function naming, and upgrade issues

2009-03-21 Thread Simon Riggs
On Sat, 2009-03-21 at 01:57 +, Andrew Gierth wrote: > Note that I'm talking here about the names of the C functions, not > the SQL names. > > The existing hstore has some very dubious choices of function names > (for non-static functions) in the C code; functions like each(), > delete(), fetc