[HACKERS] [FeatureRequest] Base Convert Function

2010-12-20 Thread Tomáš Mudruňka
Hi! Is there possibility of having internal base converting function in PgSQL? There are already functions for converting between decimal and hexadecimal notations i think pgsql can be able to convert between number with radixes from 1 to 36 (actually fast (de)encoding base36 is what i need)... t

Re: [HACKERS] pg_ctl and port number detection

2010-12-20 Thread Bruce Momjian
Florian Pflug wrote: > On Dec21, 2010, at 03:04 , Bruce Momjian wrote: > > Tom Lane wrote: > >> Actually, if we're going to do this at all, we should do > >> > >>pid > >>datadir > >>port > >>socketdir > >>... here be dragons ... > >> > >> so that pg_ctl doesn't have to assume

Re: [HACKERS] pg_ctl and port number detection

2010-12-20 Thread Florian Pflug
On Dec21, 2010, at 03:04 , Bruce Momjian wrote: > Tom Lane wrote: >> Actually, if we're going to do this at all, we should do >> >> pid >> datadir >> port >> socketdir >> ... here be dragons ... >> >> so that pg_ctl doesn't have to assume the server is running with a >> d

Re: [HACKERS] proposal : cross-column stats

2010-12-20 Thread Florian Pflug
On Dec18, 2010, at 17:59 , Tomas Vondra wrote: > It seems to me you're missing one very important thing - this was not > meant as a new default way to do estimates. It was meant as an option > when the user (DBA, developer, ...) realizes the current solution gives > really bad estimates (due to cor

Re: [HACKERS] pg_ctl and port number detection

2010-12-20 Thread Bruce Momjian
Tom Lane wrote: > Actually, if we're going to do this at all, we should do > > pid > datadir > port > socketdir > ... here be dragons ... > > so that pg_ctl doesn't have to assume the server is running with a > default value of unix_socket_dir. Not sure what to put

Re: [HACKERS] serializable lock consistency

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 7:19 PM, Florian Pflug wrote: >> Space in the tuple header is >> precious, and I am not at all convinced that we should be willing to >> surrender any for this. > > Thats a pretty tight space to maneuver in, though. So tight, in fact, > that I may as well give up, barring s

Re: [HACKERS] Extensions, patch 22 (cleanup, review, cleanup)

2010-12-20 Thread Erik Rijkers
>> On Mon, December 20, 2010 22:35, Dimitri Fontaine wrote: > > I might be mistaken but it looks like a doc/src/sgml/ref/alter_extension.sgml is missing? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailp

Re: [HACKERS] pg_ctl and port number detection

2010-12-20 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >> No. If it goes in, it should go in as the third line. The shmem key > >> data is private to the server --- we do not want external programs > >> assuming anything at all about the private part of postmaster.pid. > > > OK, so you a

Re: [HACKERS] serializable lock consistency

2010-12-20 Thread Florian Pflug
On Dec21, 2010, at 00:08 , Robert Haas wrote: > My previously expressed concern about (C) wasn't based on ugliness, > but rather on my believe that there is likely a whole lot of code > which relies on the CTID being a self-link when no UPDATE has > occurred. We'd have to be confident that all suc

Re: [HACKERS] Extensions, patch v20 (bitrot fixes)

2010-12-20 Thread Itagaki Takahiro
On Tue, Dec 21, 2010 at 08:04, Martijn van Oosterhout wrote: > On Mon, Dec 20, 2010 at 10:15:56PM +0100, Nicolas Barbier wrote: >> >From >> >http://en.wikipedia.org/wiki/Japanese_language_and_computers#Character_encodings>: > ISTM that since all the mapping tables are public it should be a SMOP >

Re: [HACKERS] serializable lock consistency

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 5:32 PM, Florian Pflug wrote: > On Dec20, 2010, at 18:54 , Robert Haas wrote: >> On Mon, Dec 20, 2010 at 12:49 PM, Florian Pflug wrote: >>> For me, this is another very good reason to explore this further. Plus, it >>> improves the ratio of grotty-ness vs. number-of-proble

Re: [HACKERS] Extensions, patch v20 (bitrot fixes)

2010-12-20 Thread Martijn van Oosterhout
On Mon, Dec 20, 2010 at 10:15:56PM +0100, Nicolas Barbier wrote: > >From > >http://en.wikipedia.org/wiki/Japanese_language_and_computers#Character_encodings>: > > "Unicode is supposed to solve all encoding problems in all languages > of the world. [..] There are still controversies. For Japanese,

Re: [HACKERS] Extensions, patch 22 (cleanup, review, cleanup)

2010-12-20 Thread Alvaro Herrera
Excerpts from Dimitri Fontaine's message of lun dic 20 18:35:44 -0300 2010: > Hi, > > From last round of review from Robert and Álvaro, here's the patch > version 22. Changes: I noticed this bit in the docs: The admin function pg_extension_flag_dump can be used to revert the defau

Re: [HACKERS] serializable lock consistency

2010-12-20 Thread Florian Pflug
On Dec20, 2010, at 18:54 , Robert Haas wrote: > On Mon, Dec 20, 2010 at 12:49 PM, Florian Pflug wrote: >> For me, this is another very good reason to explore this further. Plus, it >> improves the ratio of grotty-ness vs. number-of-problems-soved ;-) > > By all means, look into it further. I fea

Re: [HACKERS] Extensions, patch 22 (cleanup, review, cleanup)

2010-12-20 Thread Erik Rijkers
On Mon, December 20, 2010 22:55, Erik Rijkers wrote: > On Mon, December 20, 2010 22:35, Dimitri Fontaine wrote: > > During configure I spotted this: > > [...] > checking for bison... /usr/bin/bison > configure: using bison (GNU Bison) 2.3 > gawk: { if ($4 < 1.875-extension) exit 0; else exit 1;}

Re: [HACKERS] Extensions, patch 22 (cleanup, review, cleanup)

2010-12-20 Thread Erik Rijkers
On Mon, December 20, 2010 22:35, Dimitri Fontaine wrote: > Hi, > > From last round of review from Robert and �lvaro, here's the patch > version 22. Changes: > > - cleanup contrib/ and 'Adjust search_path' comments > - remove contrib/*/uninstall* scripts > - add some documentation to the NO USER

Re: [HACKERS] Extensions, patch v20 (bitrot fixes)

2010-12-20 Thread Nicolas Barbier
2010/12/20 Martijn van Oosterhout : > On Mon, Dec 20, 2010 at 09:03:56AM +0900, Itagaki Takahiro wrote: > >> UTF-8 is not a superset of all encodings. > > I think you mean Unicode is not a superset of all character sets. I've > heard this before but never found what's missing. [citation needed]?

Re: [HACKERS] bug in SignalSomeChildren

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 3:36 PM, Martijn van Oosterhout wrote: > Frankly it's a wart, for example strace/truss/whatever could (since > it's tracing anyway) just fudge the correct value in the getppid() call > so the userspace process doesn't notice. This has been a bug since > forever though, so I

Re: [HACKERS] bug in SignalSomeChildren

2010-12-20 Thread Martijn van Oosterhout
On Mon, Dec 20, 2010 at 03:08:02PM -0500, Robert Haas wrote: > The attached patch appears to work correctly on MacOS X. I did check, > BTW: getppid() in the attached process returns gdb's pid. Poor! This appears to be a BSDism at least. On Linux and BSD derivatives the man pages specifically men

Re: [HACKERS] Extensions, patch v20 (bitrot fixes)

2010-12-20 Thread Kenneth Marshall
On Mon, Dec 20, 2010 at 03:08:48PM -0500, Tom Lane wrote: > Kenneth Marshall writes: > > On Mon, Dec 20, 2010 at 02:10:39PM -0500, Tom Lane wrote: > >> [citation needed]? Exactly what characters are missing, and why would > >> the Unicode people have chosen to leave them out? It's not like they'

[HACKERS] Happy New Year !

2010-12-20 Thread Oleg Bartunov
Hi There ! Sorry for offtopic, but I'll have no chance to say all of you "Happy New Year !" at right time, since I'm about to fly to Himalaya for winter trek in the Everest area. Regards, Oleg PS. My pictures from Everest 2009 trek: http://www.flickr.com/photos/obart

Re: [HACKERS] bug in SignalSomeChildren

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 3:11 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Dec 20, 2010 at 2:23 PM, Tom Lane wrote: >>> I like that better actually ... one less thing for developers to get wrong. > >> The attached patch appears to work correctly on MacOS X.  I did check, >> BTW: getppid()

Re: [HACKERS] bug in SignalSomeChildren

2010-12-20 Thread Tom Lane
Robert Haas writes: > On Mon, Dec 20, 2010 at 2:23 PM, Tom Lane wrote: >> I like that better actually ... one less thing for developers to get wrong. > The attached patch appears to work correctly on MacOS X. I did check, > BTW: getppid() in the attached process returns gdb's pid. Poor! Looks

Re: [HACKERS] Extensions, patch v20 (bitrot fixes)

2010-12-20 Thread Tom Lane
Kenneth Marshall writes: > On Mon, Dec 20, 2010 at 02:10:39PM -0500, Tom Lane wrote: >> [citation needed]? Exactly what characters are missing, and why would >> the Unicode people have chosen to leave them out? It's not like they've >> not heard of those encodings, I'm sure. > Here is an intere

Re: [HACKERS] Extensions, patch v20 (bitrot fixes)

2010-12-20 Thread David E. Wheeler
On Dec 20, 2010, at 11:53 AM, Kenneth Marshall wrote: > Here is an interesting description of some of the gotchas: > > http://en.wikipedia.org/wiki/Windows-1252 FWIW, those are gotchas translating between Windows 1252 and Latin-1. Windows 1252's nerbles translate to UTF-8 just fine. David --

Re: [HACKERS] bug in SignalSomeChildren

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 2:23 PM, Tom Lane wrote: > Robert Haas writes: >> Another option that might be workable (but I have reservations, and >> haven't tested it either) is to check whether the return value of >> getppid() is equal to 1.  If it's neither 1 nor PostmasterPid then try >> kill(). >

Re: [HACKERS] Extensions, patch v20 (bitrot fixes)

2010-12-20 Thread Kenneth Marshall
On Mon, Dec 20, 2010 at 02:10:39PM -0500, Tom Lane wrote: > David Fetter writes: > > On Mon, Dec 20, 2010 at 08:01:42PM +0100, Martijn van Oosterhout wrote: > >> I think you mean Unicode is not a superset of all character sets. I've > >> heard this before but never found what's missing. [citation

Re: [HACKERS] bug in SignalSomeChildren

2010-12-20 Thread Tom Lane
Robert Haas writes: > Another option that might be workable (but I have reservations, and > haven't tested it either) is to check whether the return value of > getppid() is equal to 1. If it's neither 1 nor PostmasterPid then try > kill(). I like that better actually ... one less thing for devel

Re: [HACKERS] bug in SignalSomeChildren

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 2:07 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Dec 20, 2010 at 1:26 PM, Tom Lane wrote: >>> Robert Haas writes: Can we add a develop option to force use of the kill(0) method? > >>> How will that avoid needing to have an honest answer from getppid()? >>>

Re: [HACKERS] Extensions, patch v20 (bitrot fixes)

2010-12-20 Thread Tom Lane
David Fetter writes: > On Mon, Dec 20, 2010 at 08:01:42PM +0100, Martijn van Oosterhout wrote: >> I think you mean Unicode is not a superset of all character sets. I've >> heard this before but never found what's missing. [citation needed]? > Windows-1252, ISO-2022-JP-2 and EUC-TW are such encodi

Re: [HACKERS] bug in SignalSomeChildren

2010-12-20 Thread Tom Lane
Robert Haas writes: > On Mon, Dec 20, 2010 at 1:26 PM, Tom Lane wrote: >> Robert Haas writes: >>> Can we add a develop option to force use of the kill(0) method? >> How will that avoid needing to have an honest answer from getppid()? >> Without that you can't know what to issue kill() against.

Re: [HACKERS] Extensions, patch v20 (bitrot fixes)

2010-12-20 Thread David Fetter
On Mon, Dec 20, 2010 at 08:01:42PM +0100, Martijn van Oosterhout wrote: > On Mon, Dec 20, 2010 at 09:03:56AM +0900, Itagaki Takahiro wrote: > > On Mon, Dec 20, 2010 at 01:34, Tom Lane wrote: > > >> I agree that "the default encoding is UTF-8", but it should be > > >> configurable by the 'encoding'

Re: [HACKERS] plperlu problem with utf8

2010-12-20 Thread Robert Haas
On Sun, Dec 19, 2010 at 7:56 PM, David E. Wheeler wrote: > +1 Awesome. Should this go into the next commitfest? Or might it be > considered a bug fix? CommitFest or no CommitFest, patches get applied when a committer acquires enough round tuits. Putting then into the next CommitFest just provid

Re: [HACKERS] Extensions, patch v20 (bitrot fixes)

2010-12-20 Thread Martijn van Oosterhout
On Mon, Dec 20, 2010 at 09:03:56AM +0900, Itagaki Takahiro wrote: > On Mon, Dec 20, 2010 at 01:34, Tom Lane wrote: > >> I agree that "the default encoding is UTF-8", but it should be > >> configurable by the 'encoding' parameter in control files. > > > > Why is it necessary to have such a paramete

Re: [HACKERS] bug in SignalSomeChildren

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 1:26 PM, Tom Lane wrote: > Robert Haas writes: Attaching gdb to either the startup process or a WAL sender causes PostmasterIsAlive to return false, resulting in a near-immediate exit.  Seems pretty stupid for attaching gdb to change the return value of

Re: [HACKERS] bug in SignalSomeChildren

2010-12-20 Thread Tom Lane
Robert Haas writes: >>> Attaching gdb to either the startup process or a WAL sender causes >>> PostmasterIsAlive to return false, resulting in a near-immediate exit. >>>  Seems pretty stupid for attaching gdb to change the return value of >>> getppid() but it seems like that must be what's happeni

Re: [HACKERS] MingW and MiniDumps

2010-12-20 Thread Magnus Hagander
On Mon, Dec 20, 2010 at 19:24, Tom Lane wrote: > Andrew Dunstan writes: >> Maybe. I have no idea where narwhal got its version of dbghelp.h. I >> copied the file from the SDK directory to mingw's include directory and >> the build then ran perfectly. I think therefore the right thing is to >> hav

Re: [HACKERS] MingW and MiniDumps

2010-12-20 Thread Tom Lane
Andrew Dunstan writes: > Maybe. I have no idea where narwhal got its version of dbghelp.h. I > copied the file from the SDK directory to mingw's include directory and > the build then ran perfectly. I think therefore the right thing is to > have a configure test for the file and for MINIDUMP_TY

[HACKERS] texteq/byteaeq: avoid detoast

2010-12-20 Thread Noah Misch
texteq, textne, byteaeq and byteane detoast their arguments, then check for equality of length. Unequal lengths imply the answer trivially; given equal lengths, the functions proceed to compare the actual bytes. We can skip detoasting entirely when the lengths are unequal. The attached patch imp

[HACKERS] strncmp->memcmp when we know the shorter length

2010-12-20 Thread Noah Misch
When the caller knows the smaller string length, memcmp and strncmp are functionally equivalent. Since memcmp need not watch each byte for a NULL terminator, it often compares a CPU word at a time for better performance. The attached patch changes use of strncmp to memcmp where we have the length

Re: [HACKERS] relaxing sync commit if no WAL written (was Re: unlogged tables)

2010-12-20 Thread Robert Haas
On Sun, Dec 19, 2010 at 3:08 PM, Simon Riggs wrote: > On Sun, 2010-12-19 at 07:33 -0500, Robert Haas wrote: >> On Sun, Dec 19, 2010 at 7:01 AM, Simon Riggs wrote: >> > On Fri, 2010-12-17 at 13:35 -0500, Robert Haas wrote: >> > >> >> I'm >> >> thinking it makes sense to commit this part first. >>

Re: [HACKERS] serializable lock consistency

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 12:49 PM, Florian Pflug wrote: > For me, this is another very good reason to explore this further. Plus, it > improves the ratio of grotty-ness vs. number-of-problems-soved ;-) By all means, look into it further. I fear the boat is filling up with water, but if you manage

Re: [HACKERS] pg_ctl and port number detection

2010-12-20 Thread Andrew Dunstan
On 12/20/2010 12:41 PM, Tom Lane wrote: Actually, if we're going to do this at all, we should do pid datadir port socketdir ... here be dragons ... so that pg_ctl doesn't have to assume the server is running with a default value of unix_socket_dir. No

Re: [HACKERS] unlogged tables

2010-12-20 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Robert Haas's message of sáb dic 18 02:21:41 -0300 2010: >> 1. pg_dump needs an option to control whether unlogged tables are >> dumped. --no-unlogged-tables seems like the obvious choice, assuming >> we want the default to be to dump them, which seems like

Re: [HACKERS] serializable lock consistency

2010-12-20 Thread Florian Pflug
On Dec20, 2010, at 17:54 , Robert Haas wrote: > On Mon, Dec 20, 2010 at 9:11 AM, Florian Pflug wrote: >> On Dec20, 2010, at 13:13 , Heikki Linnakangas wrote: >>> One way to look at this is that the problem arises because SELECT FOR >>> UPDATE doesn't create a new tuple like UPDATE does. The probl

Re: [HACKERS] serializable lock consistency

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 12:39 PM, Kevin Grittner wrote: > I see Florian's patch meeting a real need though, I agree, but that whole approach seems to be foundering on the rocks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hacker

Re: [HACKERS] pg_ctl and port number detection

2010-12-20 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> No. If it goes in, it should go in as the third line. The shmem key >> data is private to the server --- we do not want external programs >> assuming anything at all about the private part of postmaster.pid. > OK, so you are suggesting having it as a t

Re: [HACKERS] Extensions and custom_variable_classes

2010-12-20 Thread Alvaro Herrera
Excerpts from Dimitri Fontaine's message of lun dic 20 14:25:14 -0300 2010: > Robert Haas writes: > > Patches are better for me, anyway... > > Here it is then, version 21. Changes: Just noticed a small problem: you're removing the "SET search_path" lines in contrib Makefiles but you're leaving t

Re: [HACKERS] serializable lock consistency

2010-12-20 Thread Kevin Grittner
Robert Haas wrote: > Kevin Grittner's work is a whole different approach to this > problem, and while that's obviously not fully debugged and > committed yet either, it's often easier to design a new tool to > solve a particular problem than to make an existing tool that was > really meant for s

[HACKERS] fix to allow mingw+vpath

2010-12-20 Thread Andrew Dunstan
The simple change below allows a vpath build to be used on Mingw. Is there any objection? cheers andrew diff --git a/src/bin/pgevent/Makefile b/src/bin/pgevent/Makefile index 013b801..39cb7dc 100644 --- a/src/bin/pgevent/Makefile +++ b/src/bin/pgevent/Makefile @@ -27,7 +27,7 @@ pgevent.dll:

Re: [HACKERS] unlogged tables

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 9:05 AM, Alvaro Herrera wrote: > Excerpts from Robert Haas's message of sáb dic 18 02:21:41 -0300 2010: >> Here's an attempt to summarize the remaining issues with this patch >> that I know about.  I may have forgotten something, so please mention >> it if you notice someth

Re: [HACKERS] A quick warning on the win32 build scripts

2010-12-20 Thread Magnus Hagander
(Hello, very old thread) On Tue, Oct 5, 2010 at 16:29, Tom Lane wrote: > Craig Ringer writes: >> The cause turns out to be the automatic .DEF file generation. It skips >> DEF file generation if a DEF file already exists, even if the >> object/sources are newer than the existing DEF file. > > Um,

Re: [HACKERS] serializable lock consistency

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 9:11 AM, Florian Pflug wrote: > On Dec20, 2010, at 13:13 , Heikki Linnakangas wrote: >> One way to look at this is that the problem arises because SELECT FOR UPDATE >> doesn't create a new tuple like UPDATE does. The problematic case was: >> >>> T1 locks, T1 commits, T2 up

Re: [HACKERS] Extensions and custom_variable_classes

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 11:36 AM, Dimitri Fontaine wrote: > Robert Haas writes: >> The effect of that has to be that the postmaster adds a certain amount >> of space to PostgreSQL's initial shared memory allocation.  That means >> the postmaster has to know that pg_stat_statements is a valid cust

Re: [HACKERS] Extensions and custom_variable_classes

2010-12-20 Thread Dimitri Fontaine
Robert Haas writes: > The effect of that has to be that the postmaster adds a certain amount > of space to PostgreSQL's initial shared memory allocation. That means > the postmaster has to know that pg_stat_statements is a valid custom > variable class. Ah. Yes. Indeed. So you still needed to ed

Re: [HACKERS] Binary timestamp with without timezone

2010-12-20 Thread Merlin Moncure
On Mon, Dec 20, 2010 at 6:29 AM, Radosław Smogura wrote: > > On Thu, 16 Dec 2010 14:24:27 -0500, Tom Lane wrote: >> >> =?utf-8?q?Rados=C5=82aw_Smogura?= writes: >>> >>> Tom Lane Thursday 16 December 2010 18:59:56 =?utf-8?q?Rados=C5=82aw_Smogura?= writes: > > ... This timestam

Re: [HACKERS] bug in SignalSomeChildren

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 8:20 AM, Alvaro Herrera wrote: > Excerpts from Robert Haas's message of vie dic 17 14:08:04 -0300 2010: > >> I'm having a bit of trouble confirming this on MacOS X, though. >> Attaching gdb to either the startup process or a WAL sender causes >> PostmasterIsAlive to return

Re: [HACKERS] Extensions and custom_variable_classes

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 3:56 AM, Dimitri Fontaine wrote: > Robert Haas writes: >> I bet it doesn't.  The *postmaster* never connects to a database, so >> which copy of pg_extension does it ever read? > > None, which does it need to read? My answer is none, you're saying it's > wrong, I don't get

Re: [HACKERS] MingW and MiniDumps

2010-12-20 Thread Andrew Dunstan
On 12/19/2010 03:09 PM, Magnus Hagander wrote: I can't find either the header or the symbols. That's weird - from what I can tell, at least narwahl isn't complaining about a missing include file, just the undefined symbols. Different versions of mingw perhaps? Maybe. I have no idea where

Re: [HACKERS] [GENERAL] queriing the version of libpq

2010-12-20 Thread Magnus Hagander
On Thu, Dec 16, 2010 at 17:13, Tom Lane wrote: > Magnus Hagander writes: >> On Thu, Dec 16, 2010 at 17:07, Tom Lane wrote: >>> because if you're trying to link against an older libpq, the link will >>> fail before you ever get to execute.  So let's have a less implausible >>> use-case please. >

Re: [HACKERS] bug in SignalSomeChildren

2010-12-20 Thread Tom Lane
Alvaro Herrera writes: > ... We have an open problem report on autovacuum failing to run after > some time, and we haven't been able to get a backtrace or strace because > of this issue ... I wonder whether that's the already-fixed problem with autovacuum cost limit going to zero in long-lived w

Re: [HACKERS] Timeout for asynchronous replication Re: Timeout and wait-forever in sync rep

2010-12-20 Thread Aidan Van Dyk
On Mon, Dec 20, 2010 at 3:17 AM, Fujii Masao wrote: > OK. How about keepalive-like parameters and behaviors? > >    replication_keepalives_idle >    replication_keepalives_interval >    replication_keepalives_count > > The master sends the keepalive packet if replication_keepalives_idle > elapsed

Re: [HACKERS] Timeout for asynchronous replication Re: Timeout and wait-forever in sync rep

2010-12-20 Thread Robert Haas
On Mon, Dec 20, 2010 at 3:17 AM, Fujii Masao wrote: > On Tue, Dec 7, 2010 at 12:20 AM, Robert Haas wrote: >> Yeah.  If we rely on the TCP send buffer filling up, then the amount >> of time the master takes to notice a dead standby is going to be hard >> for the user to predict.  I think the stand

Re: [HACKERS] serializable lock consistency

2010-12-20 Thread Florian Pflug
On Dec20, 2010, at 13:13 , Heikki Linnakangas wrote: > One way to look at this is that the problem arises because SELECT FOR UPDATE > doesn't create a new tuple like UPDATE does. The problematic case was: > >> T1 locks, T1 commits, T2 updates, T2 aborts, all after T0 >> took its snapshot but befo

Re: [HACKERS] unlogged tables

2010-12-20 Thread Alvaro Herrera
Excerpts from Robert Haas's message of sáb dic 18 02:21:41 -0300 2010: > Here's an attempt to summarize the remaining issues with this patch > that I know about. I may have forgotten something, so please mention > it if you notice something missing. > > 1. pg_dump needs an option to control wheth

Re: [HACKERS] bug in SignalSomeChildren

2010-12-20 Thread Alvaro Herrera
Excerpts from Robert Haas's message of vie dic 17 14:08:04 -0300 2010: > I'm having a bit of trouble confirming this on MacOS X, though. > Attaching gdb to either the startup process or a WAL sender causes > PostmasterIsAlive to return false, resulting in a near-immediate exit. > Seems pretty stu

Re: [HACKERS] pg_ctl and port number detection

2010-12-20 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > >> I wonder if we should write the port number as the 4th line in > >> postmaster.pid and return in a few major releases and use that. We > >> could fall back and use our existing code if there is no 4th line. > > No. If it goes in, it should go in as t

Re: [HACKERS] serializable lock consistency

2010-12-20 Thread Heikki Linnakangas
On 20.12.2010 13:52, Florian Pflug wrote: On Dec20, 2010, at 07:16 , Heikki Linnakangas wrote: On 19.12.2010 20:57, Florian Pflug wrote: If we reuse the legacy field xvac to store xlast, we don't get into trouble with binary upgrades either. We' need to find a way to deal with tuples where HEAP

Re: [HACKERS] serializable lock consistency

2010-12-20 Thread Florian Pflug
On Dec20, 2010, at 07:16 , Heikki Linnakangas wrote: > On 19.12.2010 20:57, Florian Pflug wrote: >> If we reuse the legacy field xvac to store xlast, we don't get into >> trouble with binary upgrades either. We' need to find a way to deal >> with tuples where HEAP_MOVED_IN or HEAP_MOVED_OUT is set,

Re: [HACKERS] Binary timestamp with without timezone

2010-12-20 Thread Radosław Smogura
On Thu, 16 Dec 2010 14:24:27 -0500, Tom Lane wrote: =?utf-8?q?Rados=C5=82aw_Smogura?= writes: Tom Lane Thursday 16 December 2010 18:59:56 =?utf-8?q?Rados=C5=82aw_Smogura?= writes: ... This timestamp must be properly encoded depending if target is WITH TZ or not, but JDBC (and other clien

Re: [HACKERS] Extensions and custom_variable_classes

2010-12-20 Thread Dimitri Fontaine
Itagaki Takahiro writes: > I think so. It would be better to remove the CVC support and related code. Will isolate that into another branch just in case and prepare a patch with that removed. > Preloading modules that defines CVC is a good direction to fix the issue, > but we need more considera

Re: [HACKERS] Extensions and custom_variable_classes

2010-12-20 Thread Dimitri Fontaine
Robert Haas writes: > I bet it doesn't. The *postmaster* never connects to a database, so > which copy of pg_extension does it ever read? None, which does it need to read? My answer is none, you're saying it's wrong, I don't get why. postmaster surely has no business with what's in a specific da

Re: [HACKERS] Timeout for asynchronous replication Re: Timeout and wait-forever in sync rep

2010-12-20 Thread Fujii Masao
On Tue, Dec 7, 2010 at 12:20 AM, Robert Haas wrote: > Yeah.  If we rely on the TCP send buffer filling up, then the amount > of time the master takes to notice a dead standby is going to be hard > for the user to predict.  I think the standby ought to send some sort > of heartbeat and the master s