Re: [HACKERS] patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c

2011-10-13 Thread Martijn van Oosterhout
On Wed, Oct 12, 2011 at 02:27:51PM -0400, Phil Sorber wrote: My proposal would be to table the discussion about the 'ALTER DATABASE SET ROLE' case because there seems to be a bit of a philosophical debate behind this that needs to be sorted out first. Note: to table the discussion means

Re: [HACKERS] Online base backup from the hot-standby

2011-10-13 Thread Jun Ishiduka
ERROR: full_page_writes on master is set invalid at least once since latest checkpoint I think this error should be rewritten as ERROR: full_page_writes on master has been off at some point since latest checkpoint We should be using 'off' instead of 'invalid'

Re: [HACKERS] [v9.2] Object access hooks with arguments support (v1)

2011-10-13 Thread Kohei KaiGai
Robert, I agree with it is a reasonable argument that compiler cannot raise warnings if all the arguments are delivered as Datum. In fact, I also tried to implement this feature with InvokeObjectAccessHook() defined as function. The first needed point to be improved is that we hope compiler to

Re: [HACKERS] ts_rank

2011-10-13 Thread Oleg Bartunov
I'm sorry, my plane to Nepal is waiting me :) I'll be back in the midst of November. In short, ts_rank is based only on frequencies of lexems and doesn't count distance between query lexems. Also, it supports only primitive queries. Oleg On Wed, 12 Oct 2011, Bruce Momjian wrote: Bruce Momjian

Re: [HACKERS] [REVIEW] pg_last_xact_insert_timestamp

2011-10-13 Thread Robert Haas
On Tue, Oct 4, 2011 at 9:15 AM, Simon Riggs si...@2ndquadrant.com wrote: Simon, could you? If your proposal turns out to be better than mine, I'd be happy to agree to drop my patch and adopt yours. Yes, will do. Simon, I believe that we are still waiting for this. Thanks, -- Robert Haas

[HACKERS] Additional supplied modules

2011-10-13 Thread Thom Brown
I've been thinking about the terminology used for various tools and extensions in PostgreSQL. The documentation bundles all them together in Additional Supplied Modules, but really some are tools, some are libraries and some are extensions: Tools: oid2name pg_archivecleanup pgbench pg_standby

Re: [HACKERS] Online base backup from the hot-standby

2011-10-13 Thread Fujii Masao
On Mon, Oct 10, 2011 at 3:56 AM, Simon Riggs si...@2ndquadrant.com wrote: 2011/10/9 Jun Ishiduka ishizuka@po.ntts.co.jp:  Insert WAL including a value of current FPW (on master)   * In the the same timing as update, they insert WAL (is named     XLOG_FPW_CHANGE). XLOG_FPW_CHANGE has a

Re: [HACKERS] pl/perl example in the doc no longer works in 9.1

2011-10-13 Thread Alexey Klyukin
On Oct 13, 2011, at 7:09 AM, Alex Hunsaker wrote: On Wed, Oct 12, 2011 at 15:33, Alex Hunsaker bada...@gmail.com wrote: On Wed, Oct 12, 2011 at 15:00, Tom Lane t...@sss.pgh.pa.us wrote: The core of the problem seems to be that if SvROK(sv) then the code assumes that it must be intended

[HACKERS] [bug] relcache leaks in get_object_address

2011-10-13 Thread Kohei KaiGai
I noticed a problem of get_object_address() with missing_ok = true. When we try to solve the name of nonexistent rule/trigger/constraint on a particular existing table, get_object_address_relobject() opens the relation, but address.objectId = InvalidOid shall be set. I think it should be closed

Re: [HACKERS] Overhead cost of Serializable Snapshot Isolation

2011-10-13 Thread Greg Sabino Mullane
On Wed, Oct 12, 2011 at 10:50:13AM +0300, Peter Eisentraut wrote: Actually, I'm currently personally more concerned about the breakage we introduce in minor releases. We'd need to solve that problem before we can even begin to think about dealing with the major release issue. +1 This bit

Re: [HACKERS] [bug] relcache leaks in get_object_address

2011-10-13 Thread Kohei KaiGai
The attached patch fixes this problem. Unfortunately, we have no code that invokes get_object_address() with missing_ok = true now, so please apply a couple of patches to rework DROP statement of mine. DROP TRIGGER no_such_trigger ON existing_table; shall cause a relcache reference leaks,

Re: [HACKERS] Change 'pg_ctl: no server running' Exit Status to 3

2011-10-13 Thread Bruce Momjian
Peter Eisentraut wrote: On m?n, 2011-05-23 at 20:50 -0400, Aaron W. Swenson wrote: According to Linux Standard Base Core Specification 3.1 [1], the exit status should be '3' when the server isn't running. I've attached a very simple patch that resolves this cosmetic issue, which

Re: [HACKERS] Dumping roles improvements?

2011-10-13 Thread Dimitri Fontaine
Josh Berkus j...@agliodbs.com writes: (1) I cannot produce a single file in custom dump format which includes both a single database and all of the roles I need to build that database. I would see addressing this with the proposal to have pg_dumpall able to issue an archive of -Fc dumps, that

Re: [HACKERS] Dumping roles improvements?

2011-10-13 Thread Dimitri Fontaine
Bruce Momjian br...@momjian.us writes: We are not writing this software for you. Please submit a clear proposal. I am sure you have 10k customers who want this. :-| I think I did (write this software). https://github.com/dimitri/pg_staging

Re: [HACKERS] [BUGS] BUG #6034: pg_upgrade fails when it should not.

2011-10-13 Thread Bruce Momjian
Tom Lane wrote: Florian Pflug f...@phlo.org writes: On Jun1, 2011, at 20:28 , Peter Eisentraut wrote: Well, initdb still succeeds if you give it an invalid locale name. It warns, but that can easily be missed if initdb is hidden behind a few other layers. If you then run pg_upgrade, you

Re: [HACKERS] pl/perl example in the doc no longer works in 9.1

2011-10-13 Thread Tom Lane
Alex Hunsaker bada...@gmail.com writes: On Wed, Oct 12, 2011 at 15:33, Alex Hunsaker bada...@gmail.com wrote: On Wed, Oct 12, 2011 at 15:00, Tom Lane t...@sss.pgh.pa.us wrote: The core of the problem seems to be that if SvROK(sv) then the code assumes that it must be intended to convert that

Re: [HACKERS] Additional supplied modules

2011-10-13 Thread Josh Berkus
On 10/13/11 6:32 AM, Thom Brown wrote: Could we somehow categorise these, and also do something to clarify that SPI is a collection of extensions rather than an extension itself? Alternately we should clean up SPI and break it out into its separate extensions. -- Josh Berkus PostgreSQL

Re: [HACKERS] pl/perl example in the doc no longer works in 9.1

2011-10-13 Thread David E. Wheeler
On Oct 13, 2011, at 11:02 AM, Tom Lane wrote: I'm working through this patch now. Does anyone object to having the array-to-non-array-result-type and hash-to-non-rowtype-result-type cases throw errors, rather than returning the rather useless ARRAY(...) and HASH(...) strings as pre-9.1 did?

Re: [HACKERS] ts_rank

2011-10-13 Thread Bruce Momjian
Oleg Bartunov wrote: I'm sorry, my plane to Nepal is waiting me :) I'll be back in the midst of November. In short, ts_rank is based only on frequencies of lexems and doesn't count distance between query lexems. Also, it supports only primitive queries. Thanks. Attached doc patch applied to

Re: [HACKERS] pl/perl example in the doc no longer works in 9.1

2011-10-13 Thread Tom Lane
David E. Wheeler da...@kineticode.com writes: On Oct 13, 2011, at 11:02 AM, Tom Lane wrote: I'm working through this patch now. Does anyone object to having the array-to-non-array-result-type and hash-to-non-rowtype-result-type cases throw errors, rather than returning the rather useless

Re: [HACKERS] pl/perl example in the doc no longer works in 9.1

2011-10-13 Thread David E. Wheeler
On Oct 13, 2011, at 11:25 AM, Tom Lane wrote: Certainly not in 9.2, no. Not sure about 9.1, though. Well, right now 9.1 is returning some rather random results. If we don't change it, someone might claim that later releases ought to be compatible with that ... Okay then, works for me. D

Re: [HACKERS] about EDITOR_LINENUMBER_SWITCH

2011-10-13 Thread Bruce Momjian
Alvaro Herrera wrote: Excerpts from Tom Lane's message of mi?? may 25 16:07:55 -0400 2011: Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Tom Lane's message of mar may 24 17:11:17 -0400 2011: Right. It would also increase the cognitive load on the user to have to

Re: [HACKERS] Additional supplied modules

2011-10-13 Thread Dimitri Fontaine
Josh Berkus j...@agliodbs.com writes: On 10/13/11 6:32 AM, Thom Brown wrote: Could we somehow categorise these, and also do something to clarify that SPI is a collection of extensions rather than an extension itself? Alternately we should clean up SPI and break it out into its separate

Re: [HACKERS] Additional supplied modules

2011-10-13 Thread Thom Brown
On 13 October 2011 19:46, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Josh Berkus j...@agliodbs.com writes: On 10/13/11 6:32 AM, Thom Brown wrote: Could we somehow categorise these, and also do something to clarify that SPI is a collection of extensions rather than an extension itself?

Re: [HACKERS] pl/perl example in the doc no longer works in 9.1

2011-10-13 Thread Alexey Klyukin
On Oct 13, 2011, at 9:02 PM, Tom Lane wrote: Alex Hunsaker bada...@gmail.com writes: On Wed, Oct 12, 2011 at 15:33, Alex Hunsaker bada...@gmail.com wrote: On Wed, Oct 12, 2011 at 15:00, Tom Lane t...@sss.pgh.pa.us wrote: The core of the problem seems to be that if SvROK(sv) then the code

Re: [HACKERS] pl/perl example in the doc no longer works in 9.1

2011-10-13 Thread Tom Lane
Alex Hunsaker bada...@gmail.com writes: This gets rid of of most of the if/else chain and the has_retval crap in plperl_handl_func(). Instead we let plperl_sv_to_datum() do most of the lifting. It also now handles VOIDOID and checks that the request result oid can be converted from the perl

Re: [HACKERS] Additional supplied modules

2011-10-13 Thread Tom Lane
Josh Berkus j...@agliodbs.com writes: On 10/13/11 6:32 AM, Thom Brown wrote: Could we somehow categorise these, and also do something to clarify that SPI is a collection of extensions rather than an extension itself? Alternately we should clean up SPI and break it out into its separate

Re: [HACKERS] Remove support for 'userlocks'?

2011-10-13 Thread Bruce Momjian
Josh Berkus wrote: On 6/3/11 11:01 AM, Bruce Momjian wrote: According to our documentation, 'userlocks' were removed in PG 8.2: http://developer.postgresql.org/pgdocs/postgres/runtime-config-developer.html I take it this doesn't trace advisory locks, and trace_locks does? If

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-13 Thread Bruce Momjian
Should this be marked as TODO? --- Mitsuru IWASAKI wrote: Hi, On 05/07/2011 03:32 AM, Mitsuru IWASAKI wrote: For 1, I've just finish my work. The latest patch is available at:

Re: [HACKERS] WIP: AuthenticationMD5 protocol documentation clarification

2011-10-13 Thread Bruce Momjian
Heikki Linnakangas wrote: On 06.06.2011 16:58, Robert Haas wrote: On Sun, Jun 5, 2011 at 11:26 AM, Cyan Ogilviecyan.ogil...@gmail.com wrote: This is my first patch, so I hope I've got the process right for submitting patches. You're doing great. I suspect we do want to either (1)

Re: [HACKERS] WALInsertLock tuning

2011-10-13 Thread Bruce Momjian
I assume this was addressed with this commit: commit 465883b0a2b4236ba6b31b648a9eabef3b7cdddb Author: Simon Riggs si...@2ndquadrant.com Date: Tue Jun 28 22:58:17 2011 +0100 Introduce compact WAL record for the common case of commit (non-DDL).

Re: [HACKERS] pl/perl example in the doc no longer works in 9.1

2011-10-13 Thread Alex Hunsaker
On Thu, Oct 13, 2011 at 16:05, Tom Lane t...@sss.pgh.pa.us wrote: Applied with some further hacking of my own to clean up memory leaks and grotty coding. Thanks! BTW after seeing it I agree passing in fcinfo (and the other fixes) to plperl_sv_to_datum() is better. -- Sent via pgsql-hackers