Re: [HACKERS] [PATCH] pgbench --throttle (submission 7 - with lag measurement)

2013-06-23 Thread Fabien COELHO
So my argumented conclusion is that the issue is somewhere within PQfinish(), possibly in interaction with pgbench doings, but is *NOT* related in any way to the throttling patch, as it is preexisting it. Gregs stumbled upon it because he looked at latencies. An additional thought: The late

Re: [HACKERS] Patch for fast gin cache performance improvement

2013-06-23 Thread Stefan Kaltenbrunner
On 06/23/2013 04:03 AM, ian link wrote: > Looks like my community login is still not working. No rush, just wanted > to let you know. Thanks! have you tried to log in once to the main website per: http://www.postgresql.org/message-id/CABUevEyt9tQfcF7T2Uzcr8WeF9M=s8qSACuCmN5L2Et26=r...@mail.gmail.

Re: [HACKERS] Patch for fast gin cache performance improvement

2013-06-23 Thread Ian Link
I just tried it and my account works now. Thanks! Ian Stefan Kaltenbrunner Sunday, June 23, 2013 2:05 AM have you tried to log in once to the main website per:http://www.postgresql.org/message-id/CABUevEyt9tQfcF7T2Uzcr8WeF9M=s8qSACuCmN5L2Et26=r...@mail.gmail.com?Stefan

Re: [HACKERS] A better way than tweaking NTUP_PER_BUCKET

2013-06-23 Thread Simon Riggs
On 23 June 2013 03:16, Stephen Frost wrote: > Will think on it more. Some other thoughts related to this... * Why are we building a special kind of hash table? Why don't we just use the hash table code that we in every other place in the backend. If that code is so bad why do we use it everywhe

[HACKERS] INTERVAL overflow detection is terribly broken

2013-06-23 Thread Rok Kralj
Hi, after studying ITERVAL and having a long chat with RhoidumToad and StuckMojo on #postgresql, I am presenting you 3 bugs regarding INTERVAL. As far as I understand, the Interval struct (binary internal representation) consists of: int32 months int32 days int64 microseconds 1. OUTPUT ERRORS: S

Re: [HACKERS] A better way than tweaking NTUP_PER_BUCKET

2013-06-23 Thread Stephen Frost
On Sunday, June 23, 2013, Simon Riggs wrote: > On 23 June 2013 03:16, Stephen Frost > > wrote: > > > Still doesn't really address the issue of dups though. > > Checking for duplicates in all cases would be wasteful, since often we > are joining to the PK of a smaller table. Well, that's what nd

Re: [HACKERS] A better way than tweaking NTUP_PER_BUCKET

2013-06-23 Thread Stephen Frost
On Sunday, June 23, 2013, Simon Riggs wrote: > On 23 June 2013 03:16, Stephen Frost > > wrote: > > > Will think on it more. > > Some other thoughts related to this... > > * Why are we building a special kind of hash table? Why don't we just > use the hash table code that we in every other place in

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

2013-06-23 Thread Dean Rasheed
On 21 June 2013 10:02, Dean Rasheed wrote: > On 21 June 2013 06:16, David Fetter wrote: >> On Fri, Jun 21, 2013 at 12:10:25AM -0400, Alvaro Herrera wrote: >>> David Fetter escribió: >>> > On Thu, Jun 20, 2013 at 08:59:27PM +0100, Dean Rasheed wrote: >>> >>> > > In my testing of sub-queries in the

Re: Review [was Re: [HACKERS] MD5 aggregate]

2013-06-23 Thread Dean Rasheed
On 21 June 2013 21:04, David Fetter wrote: > On Fri, Jun 21, 2013 at 10:48:35AM -0700, David Fetter wrote: >> On Mon, Jun 17, 2013 at 11:34:52AM +0100, Dean Rasheed wrote: >> > On 15 June 2013 10:22, Dean Rasheed wrote: >> > > There seem to be 2 separate directions that this could go, which >> >

Re: [HACKERS] wrong state of patch in CF

2013-06-23 Thread Kevin Grittner
Amit kapila wrote: > Patch (https://commitfest.postgresql.org/action/patch_view?id=1161) is already > committed by Commit > http://git.postgresql.org/pg/commitdiff/b23160889c963dfe23d8cf1f9be64fb3c535a2d6 > > It should be marked as Committed in CF. Done.  Thanks! -- Kevin Grittner EnterpriseDB:

Re: [HACKERS] changeset generation v5-01 - Patches & git tree

2013-06-23 Thread Kevin Grittner
Andres Freund wrote: > The git tree is at: > git://git.postgresql.org/git/users/andresfreund/postgres.git branch > xlog-decoding-rebasing-cf4 > http://git.postgresql.org/gitweb/?p=users/andresfreund/postgres.git;a=shortlog;h=refs/heads/xlog-decoding-rebasing-cf4 > > On 2013-06-15 00:48:17 +0200,

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

2013-06-23 Thread Kevin Grittner
Dean Rasheed wrote: > I'm still not happy that this patch is making FILTER a new reserved > keyword, because I think it is a common enough English word (and an > obscure enough SQL keyword) that people may well have used it for > table names or aliases, and so their code will break. Well, if it

Re: [HACKERS] A better way than tweaking NTUP_PER_BUCKET

2013-06-23 Thread Heikki Linnakangas
On 23.06.2013 01:48, Simon Riggs wrote: On 22 June 2013 21:40, Stephen Frost wrote: I'm actually not a huge fan of this as it's certainly not cheap to do. If it can be shown to be better than an improved heuristic then perhaps it would work but I'm not convinced. We need two heuristics, it w

Re: [HACKERS] changeset generation v5-01 - Patches & git tree

2013-06-23 Thread Kevin Grittner
Kevin Grittner wrote: > Confirmed that all 17 patch files now apply cleanly, and that `make > check-world` builds cleanly after each patch in turn. Just to be paranoid, I did one last build with all 17 patch files applied to 7dfd5cd21c0091e467b16b31a10e20bbedd0a836 using this line: make maintai

Re: [HACKERS] changeset generation v5-01 - Patches & git tree

2013-06-23 Thread Kevin Grittner
Kevin Grittner wrote: >  uninstall: >     rm -f '$(DESTDIR)$(bindir)/pg_basebackup$(X)' >     rm -f '$(DESTDIR)$(bindir)/pg_receivexlog$(X)' > +   rm -f '$(DESTDIR)$(bindir)/pg_receivellog$(X)' Oops.  That part is not needed. >  clean distclean maintainer-clean: > -   rm -f pg_basebackup$(X) p

Re: [HACKERS] BUG #7493: Postmaster messages unreadable in a Windows console

2013-06-23 Thread Noah Misch
On Wed, Feb 20, 2013 at 04:00:00PM +0400, Alexander Law wrote: > 15.02.2013 02:59, Noah Misch wrote: With your proposed change, the problem will resurface in an actual SQL_ASCII database. At the problem's root is write_console()'s assumption that messages are in the data

Re: [HACKERS] changeset generation v5-01 - Patches & git tree

2013-06-23 Thread Kevin Grittner
Andres Freund wrote: > Pushed and attached. The contrib/test_logical_decoding/sql/ddl.sql script is generating unexpected results.  For both table_with_pkey and table_with_unique_not_null, updates of the primary key column are showing: old-pkey: id[int4]:0 ... instead of the expected value of

[HACKERS] Re: backend hangs at immediate shutdown (Re: Back-branch update releases coming in a couple weeks)

2013-06-23 Thread Noah Misch
On Sun, Jun 23, 2013 at 01:55:19PM +0900, MauMau wrote: > From: "Robert Haas" >> On Fri, Jun 21, 2013 at 10:02 PM, MauMau wrote: >>> I'm comfortable with 5 seconds. We are talking about the interval >>> between >>> sending SIGQUIT to the children and then sending SIGKILL to them. In >>> most

Re: [HACKERS] changeset generation v5-01 - Patches & git tree

2013-06-23 Thread Andres Freund
On 2013-06-23 08:27:32 -0700, Kevin Grittner wrote: > Kevin Grittner wrote: > > > Confirmed that all 17 patch files now apply cleanly, and that `make > > check-world` builds cleanly after each patch in turn. > > Just to be paranoid, I did one last build with all 17 patch files > applied to 7dfd5

Re: [HACKERS] updated emacs configuration

2013-06-23 Thread Andrew Dunstan
On 06/13/2013 09:27 PM, Peter Eisentraut wrote: I think the suggested emacs configuration snippets in src/tools/editors/emacs.samples no longer represent current best practices. I have come up with some newer things that I'd like to propose for review. First, I propose adding a .dir-locals.el

Re: [HACKERS] updated emacs configuration

2013-06-23 Thread Noah Misch
On Thu, Jun 13, 2013 at 09:27:07PM -0400, Peter Eisentraut wrote: > I think the suggested emacs configuration snippets in > src/tools/editors/emacs.samples no longer represent current best > practices. I have come up with some newer things that I'd like to > propose for review. > ((c-mode . ((c-b

Re: [HACKERS] [PATCH] pgbench --throttle (submission 7 - with lag measurement)

2013-06-23 Thread Fabien COELHO
An additional thought: Yet another thought, hopefully final on this subject. I think that the probability of a context switch is higher when calling PQfinish than in other parts of pgbench because it contains system calls (e.g. closing the network connection) where the kernel is likely to s

Re: [HACKERS] updated emacs configuration

2013-06-23 Thread Andrew Dunstan
On 06/23/2013 03:43 PM, Andrew Dunstan wrote: The idea is a very good one in principle, but my short experiment with the provided .dir-locals.el didn't give me BSD style brace indentation. It works if we can do those "unsafe" things, but then we surely don't want to have a user prompted to

Re: [HACKERS] updated emacs configuration

2013-06-23 Thread Tom Lane
Andrew Dunstan writes: > The idea is a very good one in principle, but my short experiment with > the provided .dir-locals.el didn't give me BSD style brace indentation. > It works if we can do those "unsafe" things, but then we surely don't > want to have a user prompted to accept the settings

Re: [HACKERS] changeset generation v5-01 - Patches & git tree

2013-06-23 Thread Andres Freund
On 2013-06-23 10:32:05 -0700, Kevin Grittner wrote: > Andres Freund wrote: > > > Pushed and attached. > > The contrib/test_logical_decoding/sql/ddl.sql script is generating > unexpected results.  For both table_with_pkey and > table_with_unique_not_null, updates of the primary key column are > s

Re: [HACKERS] changeset generation v5-01 - Patches & git tree

2013-06-23 Thread Tom Lane
Andres Freund writes: > On 2013-06-23 08:27:32 -0700, Kevin Grittner wrote: >> gcc: error: pg_receivellog.o: No such file or directory >> make[3]: *** [pg_receivellog] Error 1 > I have seen that once as well. It's really rather strange since > pg_receivellog.o is a clear prerequisite for pg_recei

Re: [HACKERS] changeset generation v5-01 - Patches & git tree

2013-06-23 Thread Andres Freund
On 2013-06-23 16:48:41 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2013-06-23 08:27:32 -0700, Kevin Grittner wrote: > >> gcc: error: pg_receivellog.o: No such file or directory > >> make[3]: *** [pg_receivellog] Error 1 > > > I have seen that once as well. It's really rather strange sin

Re: [HACKERS] in-catalog Extension Scripts and Control parameters (templates?)

2013-06-23 Thread Jaime Casanova
On Wed, Apr 3, 2013 at 8:29 AM, Dimitri Fontaine wrote: > Hi, > > Dimitri Fontaine writes: >>> Documentation doesn't build, multiple errors. In addition to the reference >>> pages, there should be a section in the main docs about these templates. >> >> I'm now working on that, setting up the docu

Re: [HACKERS] in-catalog Extension Scripts and Control parameters (templates?)

2013-06-23 Thread Dimitri Fontaine
Jaime Casanova writes: > just tried to build this one, but it doesn't apply cleanly anymore... > specially the ColId_or_Sconst contruct in gram.y Will rebase tomorrow, thanks for the notice! -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent vi

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

2013-06-23 Thread David Fetter
On Sun, Jun 23, 2013 at 07:44:26AM -0700, Kevin Grittner wrote: > Dean Rasheed wrote: > > > I'm still not happy that this patch is making FILTER a new reserved > > keyword, because I think it is a common enough English word (and an > > obscure enough SQL keyword) that people may well have used it

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-06-23 Thread Fujii Masao
On Wed, Jun 19, 2013 at 9:50 AM, Michael Paquier wrote: > On Wed, Jun 19, 2013 at 12:36 AM, Fujii Masao wrote: >> On Tue, Jun 18, 2013 at 10:53 AM, Michael Paquier >> wrote: >>> An updated patch for the toast part is attached. >>> >>> On Tue, Jun 18, 2013 at 3:26 AM, Fujii Masao wrote: Her

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-06-23 Thread Fujii Masao
On Sun, Jun 23, 2013 at 3:34 PM, Michael Paquier wrote: > OK. Please find an updated patch for the toast part. > > On Sat, Jun 22, 2013 at 10:48 PM, Andres Freund > wrote: >> On 2013-06-22 22:45:26 +0900, Michael Paquier wrote: >>> On Sat, Jun 22, 2013 at 10:34 PM, Andres Freund >>> wrote: >>>

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

2013-06-23 Thread Tom Lane
David Fetter writes: > On Sun, Jun 23, 2013 at 07:44:26AM -0700, Kevin Grittner wrote: >> I think it is OK if that gets a syntax error.  If that's the "worst >> case" I like this approach. > I think reducing the usefulness of error messages is something we need > to think extremely hard about bef

[HACKERS] Naming of ORDINALITY column (was: Re: Review: UNNEST (and other functions) WITH ORDINALITY)

2013-06-23 Thread Andrew Gierth
OK, let's try to cover all the bases here in one go. First, the spec definition of WITH ORDINALITY simply says that the column name in the result is not equivalent to any other identifier in the same (including the ). It is clear that the intention of the spec is that any non-positional reference

Re: [HACKERS] Naming of ORDINALITY column

2013-06-23 Thread Josh Berkus
On 06/23/2013 08:00 PM, Andrew Gierth wrote: > OK, let's try to cover all the bases here in one go. > 1. Stick with "?column?" as a warning flag that you're not supposed to > be using this without aliasing it to something. How do I actually supply an alias which covers both columns? What does th

Re: [HACKERS] ALTER TABLE ... ALTER CONSTRAINT

2013-06-23 Thread Abhijit Menon-Sen
At 2013-06-08 21:45:24 +0100, si...@2ndquadrant.com wrote: > > ALTER TABLE foo >ALTER CONSTRAINT fktable_fk_fkey DEFERRED INITIALLY IMMEDIATE; I read the patch (looks good), applied it on HEAD (fine), ran make check (fine), and played with it in a test database. It looks great, and from previo

[HACKERS] [9.4 CF 1] Commitfest Week One

2013-06-23 Thread Josh Berkus
Current Stats: Needs Review: 61, Waiting on Author: 19, Ready for Committer: 11, Committed: 11, Returned with Feedback: 3, Rejected: 1 34 Patches are awaiting review, and do not have a reviewer assigned. In the last week, 3 patches have moved to Ready for Committer and 3 patches have been commit

[HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-06-23 Thread Josh Berkus
Folks, For 9.2, we adopted it as policy that anyone submitting a patch to a commitfest is expected to review at least one patch submitted by someone else. And that failure to do so would affect the attention your patches received in the future. For that reason, I'm publishing the list below of p

Re: [HACKERS] [PERFORM] In progress INSERT wrecks plans on table

2013-06-23 Thread Abhijit Menon-Sen
(Cc: to pgsql-performance dropped, pgsql-hackers added.) At 2013-05-06 09:14:01 +0100, si...@2ndquadrant.com wrote: > > New version of patch attached which fixes a few bugs. I read the patch, but only skimmed the earlier discussion about it. In isolation, I can say that the patch applies cleanly

Re: [HACKERS] Reduce maximum error in tuples estimation after vacuum.

2013-06-23 Thread Amit Kapila
On Friday, June 14, 2013 2:05 PM Kyotaro HORIGUCHI wrote: > Hello, > > Postgresql estimates the number of live tuples after the vacuum has > left some buffers unscanned. This estimation does well for most cases, > but makes completely different result with a strong imbalance of tuple > density. >

Re: [HACKERS] [GENERAL] Floating point error

2013-06-23 Thread Abhijit Menon-Sen
At 2013-03-06 10:04:25 +, laurenz.a...@wien.gv.at wrote: > > How about this elaboration? Sorry to nitpick, but I don't like that either, on the grounds that if I had been in Tom Duffey's place, this addition to the docs wouldn't help me to understand and resolve the problem. I'm not entirely

Re: [HACKERS] Clean switchover

2013-06-23 Thread Andres Freund
On 2013-06-14 04:56:15 +0900, Fujii Masao wrote: > On Wed, Jun 12, 2013 at 9:48 PM, Stephen Frost wrote: > > * Magnus Hagander (mag...@hagander.net) wrote: > >> On Wed, Jun 12, 2013 at 1:48 PM, Andres Freund > >> wrote: > >> > On 2013-06-12 07:53:29 +0900, Fujii Masao wrote: > >> >> The attached