Re: [HACKERS] Add regression tests for DISCARD

Thanks Fabrizio. Although parallel_schedule was a miss for this specific patch, however, I guess I seem to have missed out serial_schedule completely (in all patches) and then thanks for pointing this out. Subsequently Robert too noticed the miss at the serial_schedule end. Please find attached a

Re: [HACKERS] bool abuse in path_encode()

Peter Eisentraut writes: > The function path_encode() in geo_ops.c takes an argument "bool closed", > to indicate an open or closed path --- but you can also pass -1 to > indicate "neither". Egad :-(. > I propose to change this to an enum to make the > code clearer and less weird. Please change

Re: [HACKERS] Add regression tests for ROLE (USER)

> However, before it can get committed, I think this set of tests needs > streamlining. It does seem to me valuable, but I think it's wasteful > in terms of runtime to create so many roles, do just one thing with > them, and then drop them. I recommend consolidating some of the > tests. For exam

[HACKERS] bool abuse in path_encode()

The function path_encode() in geo_ops.c takes an argument "bool closed", to indicate an open or closed path --- but you can also pass -1 to indicate "neither". I propose to change this to an enum to make the code clearer and less weird. diff --git a/src/backend/utils/adt/geo_ops.c b/src/backend/u

[HACKERS] How to implement Gin method?

Hi. I want to try GIN and know programming information of GIN technology. Please teach me about these functions extractValue, extractQuery and consistent. I have posted question at stack overflow. http://stackoverflow.com/questions/17489703/postgresql-how-to-implement-gin Please help my questi

Re: [HACKERS] [PATCH] Add transforms feature

Josh Berkus writes: > (c) I'd like to do a future feature which supports "install all > transforms" functionality, which would be helped by having them in their > own directory. I think we should install required extensions automatically when they are available. Also, we will need better tooling

Re: [HACKERS] Review: extension template

Hi, Thanks a lot for your detailed review! Markus Wanner writes: > Initially, I was confused about what the patch is supposed to achieve. > The 'template' naming certainly contributed to that confusion. My mental Yes, I did share this viewpoint over the naming of the feature, but Tom insisted t

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

On Fri, Jul 05, 2013 at 08:08:06AM -0400, Andrew Dunstan wrote: > This looks incomplete. Surely just escaping backslashes alone is not > enough. I suspect at least the " char and any chars below 0x20 > should be quoted also. The " char I just added, however, my tests did bring up any problem with

Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

On 6 July 2013 17:58, Claudio Freire wrote: > Look at that: > > return x > $$ LANGUAGE plpythonu; > SELECT * FROM test_type_conversion_numeric(100); > ! INFO: (Decimal('100'), 'Decimal') > CONTEXT: PL/Python function "test_type_conversion_numeric" >test_type_conversion_numeric > -

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

- Original Message - > * Josh Berkus (j...@agliodbs.com) wrote: > > Is there anyone else on the committer list with similar circumstances? > > I'll just flip it around and offer to be publically flogged whenever I'm > not helping out with a commitfest. :) Perhaps this should be more > "

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

* Josh Berkus (j...@agliodbs.com) wrote: > Is there anyone else on the committer list with similar circumstances? I'll just flip it around and offer to be publically flogged whenever I'm not helping out with a commitfest. :) Perhaps this should be more "opt-in" than "opt-out", wrt committers anyw

Re: [HACKERS] in-catalog Extension Scripts and Control parameters (templates?)

Jaime Casanova writes: > not sure if you're wrong. but at the very least, you miss a > heap_freetuple(oldtup) there, because get_catalog_object_by_oid() Well, oldtup can be either a syscache copy or a heap tuple. I've been looking at other call sites and they don't free their tuple either. So I'm

Re: [HACKERS] Run-time posix_fallocate failures

Jeff Davis writes: > On Sat, 2013-07-06 at 10:33 -0400, Tom Lane wrote: >> I think you'd better rejigger that patch so that it falls through to the >> old implementation if posix_fallocate() fails. > Do you mean "fails at all" or "fails with EINVAL"? I'd be inclined to ignore the specific error

Re: [HACKERS] planner not choosing fastest estimated plan

On Sat, Jul 6, 2013 at 10:52 AM, Pavel Stehule wrote: > Hello > > pls, can you send EXPLAIN ANALYZE result? Sure. I've put them on depesz. (I don't know how useful it will be, as I'm worried about the internal inconsistency rather than the actual run time): enable_seqscan=on http://explain.dep

Re: [HACKERS] [PATCH] Fix conversion for Decimal arguments in plpython functions

On 28 June 2013 22:29, Claudio Freire wrote: > On Fri, Jun 28, 2013 at 5:14 PM, Steve Singer wrote: > > On 06/27/2013 05:04 AM, Szymon Guz wrote: > >> > >> On 27 June 2013 05:21, Steve Singer >> > wrote: > >> > >> On 06/26/2013 04:47 PM, Szymon Guz wrote: > >> > >

Re: [HACKERS] Run-time posix_fallocate failures

On Sat, 2013-07-06 at 10:33 -0400, Tom Lane wrote: > Apparently OmniOS has a version of posix_fallocate that doesn't actually > work, or at least doesn't work on the specific filesystem rover_firefly > is using. The Single Unix Spec says that that is the correct error to > return if the filesystem

Re: [HACKERS] planner not choosing fastest estimated plan

Hello pls, can you send EXPLAIN ANALYZE result? Regards Pavel Stehule 2013/7/6 Jeff Janes : > I have a weird case where the planner doesn't choose the plan that it > itself believes to be the fastest plan. If I disable seqscan, it then > chooses a faster plan (faster in estimate and faster in

[HACKERS] planner not choosing fastest estimated plan

I have a weird case where the planner doesn't choose the plan that it itself believes to be the fastest plan. If I disable seqscan, it then chooses a faster plan (faster in estimate and faster in reality) than the one chosen when all options were open to it. I can't figure out how this can be any

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

On 07/05/2013 02:34 PM, Jeff Janes wrote: > On Wed, Jul 3, 2013 at 12:03 PM, Christopher Browne wrote: > >> On Wed, Jul 3, 2013 at 2:24 PM, Cédric Villemain >> wrote: >>> Others rules appeared, like the 5 days limit. >>> >> > The limit was previously 4 days (at least according to > http://wiki.po

Re: [HACKERS] GIN improvements part 3: ordering in index

Hi, this is a follow-up to the message I posted to the thread about additional info in GIN. I've applied all three patches (ginaddinfo7.patch, gin_fast_scan.4.patch and gin_ordering.4.patch) onto commit b8fd1a09. I ended up with two definitions of ‘cmpEntries’ in ginget.c, but I suppose this is d

Re: [HACKERS] MemoryContextAllocHuge(): selectively bypassing MaxAllocSize

Jeff, * Jeff Janes (jeff.ja...@gmail.com) wrote: > I was going to add another item to make nodeHash.c use the new huge > allocator, but after looking at it just now it was not clear to me that it > even has such a limitation. nbatch is limited by MaxAllocSize, but > nbuckets doesn't seem to be.

Re: [HACKERS] GIN improvements part2: fast scan

Hi, this is a follow-up to the message I posted to the thread about additional info in GIN. I've applied both ginaddinfo.7.patch and gin_fast_scan.4.patch on commit b8fd1a09, but I'm observing a lot of failures like this: STATEMENT: SELECT id FROM messages WHERE body_tsvector @@ plainto_tsquery

Re: [HACKERS] GIN improvements part 1: additional information

Hi, I've done a fair amount of testing by loading pgsql-general archives into a database and running a bunch of simple ts queries that use a GIN index. I've tested this as well as the two other patches, but as I was able to get meaningful results only from this patch, I'll post the results here a

[HACKERS] A mailing-list based bug tracker

I'm just a user, not a contributer, but I've read -hackers long enough to remember the many discussions over the years about bug trackers, and the consensus always seemed to come back to "if it doesn't fit our mailing-list-based workflow, it's going to fail." I happened upon mention of a new bug t

Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

Look at that: return x $$ LANGUAGE plpythonu; SELECT * FROM test_type_conversion_numeric(100); ! INFO: (Decimal('100'), 'Decimal') CONTEXT: PL/Python function "test_type_conversion_numeric" test_type_conversion_numeric -- --- 219,225 return x $$

Re: [HACKERS] Have REFRESH MATERIALIZED VIEW run as the MV owner

On Fri, Jul 05, 2013 at 11:18:50PM -0700, Hitoshi Harada wrote: > On Fri, Jul 5, 2013 at 9:45 AM, Noah Misch wrote: > > REFRESH MATERIALIZED VIEW should temporarily switch the current user ID to > > the > > MV owner. REINDEX and VACUUM do so to let privileged users safely maintain > > objects ow

[HACKERS] Run-time posix_fallocate failures

Buildfarm member "rover_firefly" has been failing like this since 269e780 went in: creating template1 database in /export/home/postgres/HEAD/pgsql.47842/src/test/regress/./tmp_check/data/base/1 ... FATAL: could not allocate space for file "pg_xlog/xlogtemp.60072" using posix_fallocate: Invalid

Re: [HACKERS] Add regression tests for COLLATE

On 07/06/2013 09:12 AM, Robert Haas wrote: On Fri, Jul 5, 2013 at 6:56 PM, Andres Freund wrote: On 2013-07-03 14:17:20 -0400, Robert Haas wrote: I agree. I think it'd be a good idea to get the buildfarm to run the existing collate.utf8.linux test regularly on platforms where it passes, but t

Re: [HACKERS] Add regression tests for COLLATE

On Fri, Jul 5, 2013 at 6:56 PM, Andres Freund wrote: > On 2013-07-03 14:17:20 -0400, Robert Haas wrote: >> I agree. I think it'd be a good idea to get the buildfarm to run the >> existing collate.utf8.linux test regularly on platforms where it >> passes, but this particular approach is valuable m

Re: [HACKERS] MVCC catalog access

On Fri, Jul 5, 2013 at 11:27 AM, Andres Freund wrote: > Hi Robert, > > On 2013-07-02 09:31:23 -0400, Robert Haas wrote: >> I have a few ideas for getting rid of the remaining uses of >> SnapshotNow that I'd like to throw out there: > > Is your current plan to get rid of SnapshotNow entirely? I am

Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

On 07/06/2013 01:52 AM, Claudio Freire wrote: On Sat, Jul 6, 2013 at 2:39 AM, Tom Lane wrote: Peter Eisentraut writes: PL/Python: Convert numeric to Decimal Assorted buildfarm members don't like this patch. Do you have failure details? This is probably an attempt to operate decimals vs f

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

On 5 July 2013 18:23, David Fetter wrote: > Please find attached changes based on the above. > This looks good. The grammar changes are smaller and neater now on top of the makeFuncCall() patch. Overall I think this patch offers useful additional functionality, in compliance with the SQL spec, w

[HACKERS] copy & pasted include guard in attoptcache.h

Hi, attoptcache.h currently uses #ifndef SPCCACHE_H. The attached patch fixes that. A quick $ grep -r '\#ifndef' src/include/|grep _H|awk '{print $2}'|sort|uniq -cd doesn't show any further duplicated ones. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.c

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

On Fri, Jul 05, 2013 at 09:41:26AM -0400, Tom Lane wrote: > Um ... 9.3 is a separate branch now, please fix it there also. Done. Seems I missed a new branch - yet again. Sorry and thanks for pointing it out to me. michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|