Re: [HACKERS] PoC: Partial sort

2013-12-28 Thread David Rowley
On Sat, Dec 28, 2013 at 9:28 PM, Alexander Korotkov aekorot...@gmail.comwrote: On Tue, Dec 24, 2013 at 6:02 AM, Andreas Karlsson andr...@proxel.sewrote: Attached revision of patch implements partial sort usage in merge joins. I'm looking forward to doing a bit of testing on this patch. I

[HACKERS] control to don't toast one new type

2013-12-28 Thread Mohsen SM
I create type based on varlena. I want control it that don't toast. how to control the length? I must control all of varlena size or data varlena size? thank.

Re: [HACKERS] [bug fix] connection service file doesn't take effect with ECPG apps

2013-12-28 Thread Michael Meskes
On Sat, Dec 28, 2013 at 04:37:44PM +0900, MauMau wrote: You can confirm it by adding the following code fragment to ecpglib/connect.c. The attached file contains this. ... Sorry for not being precide enough. I did run some tests and it works like a charm for me. Or in other words, I used

Re: [HACKERS] [bug fix] ECPG app crashes due to SIGBUS on SPARC Solaris

2013-12-28 Thread Michael Meskes
On Sat, Dec 28, 2013 at 08:04:09AM +0900, MauMau wrote: OK, I'll run the ECPG regression test on Solaris without the patch. Please wait until Jan 6 2014 or so, because we've just entered new year holidays here in Japan. Sure, we're no in a particular hurry. Michael -- Michael Meskes Michael

Re: [HACKERS] WITHIN GROUP patch

2013-12-28 Thread Andrew Gierth
Tom == Tom Lane t...@sss.pgh.pa.us writes: Tom I've committed this after significant editorialization --- most Tom notably, I pushed control of the sort step into the aggregate Tom support functions. Initial tests suggest that your version is ~40% slower than ours on some workloads. On my

Re: [HACKERS] [PATCH] Regression tests in windows ignore white space

2013-12-28 Thread Amit Kapila
On Thu, Dec 26, 2013 at 3:02 PM, David Rowley dgrowle...@gmail.com wrote: In the following thread I discovered that my new regression tests worked perfectly on windows, but when they were run on linux they failed.

Re: [HACKERS] [bug fix] connection service file doesn't take effect with ECPG apps

2013-12-28 Thread MauMau
From: Michael Meskes mes...@postgresql.org Or in other words, I used the connect command you had in your email with a services file pointing to a local database and it connected to that database. Instead of adding an additional output I checked the log output which suggested that host was

Re: [HACKERS] [PATCH] Regression tests in windows ignore white space

2013-12-28 Thread David Rowley
On Sun, Dec 29, 2013 at 2:29 AM, Amit Kapila amit.kapil...@gmail.comwrote: On Thu, Dec 26, 2013 at 3:02 PM, David Rowley dgrowle...@gmail.com wrote: In the following thread I discovered that my new regression tests worked perfectly on windows, but when they were run on linux they failed.

Re: [HACKERS] truncating pg_multixact/members

2013-12-28 Thread Kevin Grittner
Alvaro Herrera alvhe...@2ndquadrant.com wrote: 1. slru.c doesn't consider file names longer than 4 hexadecimal chars. Fixing (1) is simple: we can have each SLRU user declare how many digits to have in file names.  All existing users but pg_multixact/members should declare 4 digits; that one

Re: [HACKERS] planner missing a trick for foreign tables w/OR conditions

2013-12-28 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Dec 17, 2013 at 12:28 PM, Tom Lane t...@sss.pgh.pa.us wrote: So at this point I'm pretty much talked into it. We could eliminate the dependence on indexes entirely, and replace this code with a step that simply tries to pull

Re: [HACKERS] [BUG FIX] Version number expressed in octal form by mistake

2013-12-28 Thread Tom Lane
Kevin Grittner kgri...@ymail.com writes: Oh, I just noticed that this is for the *pg_restore* code, not the pg_dump code, so there isn't necessarily a conflict with the docs. The pg_dump code does match the docs on its version check. The question becomes, for each supported version, what do we

Re: [HACKERS] truncating pg_multixact/members

2013-12-28 Thread Alvaro Herrera
Kevin Grittner wrote: Alvaro Herrera alvhe...@2ndquadrant.com wrote: 1. slru.c doesn't consider file names longer than 4 hexadecimal chars. Fixing (1) is simple: we can have each SLRU user declare how many digits to have in file names.  All existing users but pg_multixact/members

Re: [HACKERS] trailing comment ghost-timing

2013-12-28 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2013-12-24 12:27:59 -0500, Tom Lane wrote: What I was proposing was that we do include comments in what we send, as long as those comments are embedded in the statement text, not on lines before it. The common way I've seen what I've described

Re: [HACKERS] Fix typo in src/backend/utils/mmgr/README

2013-12-28 Thread Peter Eisentraut
On Wed, 2013-12-25 at 17:50 +0900, Etsuro Fujita wrote: Peter Eisentraut wrote: On 12/24/13, 1:33 AM, Etsuro Fujita wrote: This is a small patch to fix a typo in src/backend/utils/mmgr/README. I don't think that change is correct. I've fixed the patch, though that might be still

Re: [HACKERS] [PATCH] work_mem calculation possible overflow

2013-12-28 Thread Tom Lane
David Rowley dgrowle...@gmail.com writes: I was just looking through a few of the warnings flagged up by PVS Studio. I found some warnings around some calculations that were doing work_mem * 1024L and comparing that to a double. On windows 64 sizeof(long) is 4 bytes. Currently work_mem's

[HACKERS] pgcrypto missing header file inclusions

2013-12-28 Thread Peter Eisentraut
While playing around with the pginclude tools, I noticed that pgcrypto header files are failing to include some header files whose symbols they use. This change would fix it: diff --git a/contrib/pgcrypto/pgp.h b/contrib/pgcrypto/pgp.h index 3022abf..f856e07 100644 --- a/contrib/pgcrypto/pgp.h

Re: [HACKERS] Planning time in explain/explain analyze

2013-12-28 Thread Andreas Karlsson
New version of the patch with updated documentation and which does not display the planning time when the COSTS are off. I will add it to the next commitfest. -- Andreas Karlsson diff --git a/doc/src/sgml/perform.sgml b/doc/src/sgml/perform.sgml new file mode 100644 index 2af1738..240a3d5 ***

[HACKERS] Bogus error handling in pg_upgrade

2013-12-28 Thread Tom Lane
A credulous person might suppose that this chunk of code is designed to abort if pg_resetxlog fails: prep_status(Setting next transaction ID for new cluster); exec_prog(UTILITY_LOG_FILE, NULL, true, \%s/pg_resetxlog\ -f -x %u \%s\, new_cluster.bindir,

Re: [HACKERS] ALTER SYSTEM SET command to change postgresql.conf parameters

2013-12-28 Thread Amit Kapila
On Tue, Dec 24, 2013 at 11:38 PM, Fujii Masao masao.fu...@gmail.com wrote: On Sun, Dec 22, 2013 at 8:32 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Sun, Dec 22, 2013 at 3:01 PM, Fujii Masao masao.fu...@gmail.com wrote: I found the bug of ALTER SYSTEM SET patch. The procedure to reproduce

Re: [HACKERS] ALTER SYSTEM SET command to change postgresql.conf parameters

2013-12-28 Thread Amit Kapila
On Fri, Dec 27, 2013 at 5:01 AM, Robert Haas robertmh...@gmail.com wrote: On Tue, Dec 24, 2013 at 10:08 AM, Fujii Masao masao.fu...@gmail.com wrote: When I read ProcessConfigFile() more carefully, I found another related problem. The procedure to reproduce the problem is here.

Re: [HACKERS] INSERT...ON DUPLICATE KEY LOCK FOR UPDATE

2013-12-28 Thread Peter Geoghegan
Attached revision only uses heavyweight page locks across complex operations. I haven't benchmarked it, but it appears to perform reasonably well. I haven't attempted to measure a regression for regular insertion, but offhand it seems likely that any regression would be well within the noise -

Re: [HACKERS] PoC: Partial sort

2013-12-28 Thread David Rowley
On Sun, Dec 29, 2013 at 4:51 AM, Alexander Korotkov aekorot...@gmail.comwrote: I've compiled it with clang. Yeah, there was mixed declarations. I've rechecked it with gcc, now it gives no warnings. I didn't try it with visual studio, but I hope it will be OK. Thanks for the patch. It now

Re: [HACKERS] [COMMITTERS] pgsql: Upgrade to Autoconf 2.69

2013-12-28 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On Fri, 2013-12-20 at 10:54 -0300, Alvaro Herrera wrote: Evidently something is not going well in ReadRecord. It should have reported the read failure, but didn't. That seems a separate bug that needs fixed. This is enabling large-file support on OS