Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-28 Thread Pavel Stehule
Hi 2014-06-29 0:48 GMT+02:00 MauMau : > From: "Pavel Stehule" > > I modified description of setting system variables in dependency on O.S. >> > > Thank you, it's almost OK. As mentioned in my previous mail, I think > "determines" should be "determine" to follow other messages. I'll mark > th

Re: [HACKERS] better atomics - v0.5

2014-06-28 Thread Amit Kapila
On Sat, Jun 28, 2014 at 1:48 PM, Andres Freund wrote: > On 2014-06-28 11:58:41 +0530, Amit Kapila wrote: > > 1. > > +pg_atomic_compare_exchange_u32_impl(volatile pg_atomic_uint32 *ptr, > > + uint32 *expected, uint32 newval) > > +{ > > + bool ret; > > + uint32 current; > > + current = InterlockedCo

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-28 Thread Amit Kapila
On Sat, Jun 28, 2014 at 10:38 PM, Christoph Berg wrote: > Re: Vik Fearing 2014-06-27 <53ad15f7.2060...@dalibo.com> > > Amit, > > > > I added this to the next commitfest with your name as reviewer. > > > > https://commitfest.postgresql.org/action/patch_view?id=1495 > > > > Please update the status

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-28 Thread MauMau
From: "Pavel Stehule" I modified description of setting system variables in dependency on O.S. Thank you, it's almost OK. As mentioned in my previous mail, I think "determines" should be "determine" to follow other messages. I'll mark this patch as ready for committer when this is fixed.

Re: [HACKERS] Array of composite types returned from python

2014-06-28 Thread Sim Zacks
Am I missing anything, (ie memory leak, undesirable behavior elsewhere)? -Ed I applied the patch and it looks like it is working well. As a longtime plpython user, I appreciate the fix. I have a few comments: 1) I would remove the error message from the PO files as well. 2) You removed th

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-06-28 Thread Pavel Stehule
Hello rebase for 9.5 test: \pset linestyle unicode \pset border 2 \pset unicode_header_linestyle double \l Regards Pavel 2014-03-11 21:17 GMT+01:00 Pavel Stehule : > Hello > > I had to reduce allowed line style to single or double, because unicode > allows only combination single,double o

Re: [HACKERS] How about a proper TEMPORARY TABLESPACE?

2014-06-28 Thread Matheus de Oliveira
Hi Hackers, I have worked on that patch a little more. So now I have functional patch (although still WIP) attached. The feature works as following: - Added a boolean parameter "only_temp_files" to pg_tablespace.spcoptions; - This parameter can be set to true only during CREATE TABLESPACE, not on

Re: [HACKERS] ALTER SYSTEM RESET?

2014-06-28 Thread Christoph Berg
Re: Vik Fearing 2014-06-27 <53ad15f7.2060...@dalibo.com> > On 06/27/2014 08:49 AM, Vik Fearing wrote: > > This third patch reformats the documentation in the way I expected it to > > be committed. > > Amit, > > I added this to the next commitfest with your name as reviewer. > > https://commitfes

Re: [HACKERS] better atomics - v0.5

2014-06-28 Thread Heikki Linnakangas
On 06/27/2014 08:15 PM, Robert Haas wrote: On Thu, Jun 26, 2014 at 3:04 PM, Andres Freund wrote: I don't really see usecases where it's not related data that's being touched, but: The point is that the fastpath (not using a spinlock) might touch the atomic variable, even while the slowpath has

[HACKERS] Re: proposal: ignore null fields in not relation type composite type based constructors

2014-06-28 Thread Pavel Stehule
Hello I am sending small patch, that allows ignore nulls in row_to_json function. It allow significant size reduction of generated JSON documents. Regards Pavel 2014-05-25 7:53 GMT+02:00 Pavel Stehule : > Hello > > In Czech Postgres mailing list was user request for serialization to json >

Re: [HACKERS] delta relations in AFTER triggers

2014-06-28 Thread Kevin Grittner
David Fetter wrote: > On Sat, Jun 21, 2014 at 11:06:26AM -0700, Kevin Grittner wrote: >> Here is v2. > I've taken the liberty of making an extension that uses this. > Preliminary tests indicate a 10x performance improvement over the > user-space hack I did that's similar in functionality. Wow,

Re: [HACKERS] Spinlocks and compiler/memory barriers

2014-06-28 Thread Andres Freund
On 2014-06-28 15:41:46 +0200, Andres Freund wrote: > On 2014-06-28 09:25:32 -0400, Robert Haas wrote: > > No, I think it's going to be *much* simpler than that. How about I > > take a crack at this next week and then either (a) I'll see why it's a > > bad idea and we can go from there or (b) you c

Re: [HACKERS] Spinlocks and compiler/memory barriers

2014-06-28 Thread Andres Freund
On 2014-06-28 09:25:32 -0400, Robert Haas wrote: > On Sat, Jun 28, 2014 at 4:31 AM, Andres Freund wrote: > >> > Do we want to introduce acquire/release barriers? Or do we want to > >> > redefine the current barriers to be strong enough for that? > >> > >> Well, unless we're prepared to dump suppor

Re: [HACKERS] Spinlocks and compiler/memory barriers

2014-06-28 Thread Robert Haas
On Sat, Jun 28, 2014 at 4:31 AM, Andres Freund wrote: >> > Do we want to introduce acquire/release barriers? Or do we want to >> > redefine the current barriers to be strong enough for that? >> >> Well, unless we're prepared to dump support for an awful lot of >> platfomrs, trying to support acqui

Re: [HACKERS] Cluster name in ps output

2014-06-28 Thread Andres Freund
Hi, On 2014-06-26 23:03:24 +0100, Thomas Munro wrote: > + {"cluster_name", PGC_POSTMASTER, CONN_AUTH_SETTINGS, > + gettext_noop("Sets the name of the cluster that appears > in 'ps' output."), > + NULL, > + GUC_IS_NAME > +

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-28 Thread Pavel Stehule
Hello I modified description of setting system variables in dependency on O.S. Regards Pavel 2014-06-27 8:54 GMT+02:00 Pavel Stehule : > Hello > > thank you Peter, so now only setting for MS Windows is missing? > > Regards > > Pavel > > > 2014-06-26 21:57 GMT+02:00 Petr Jelinek : > > Hello,

Re: [HACKERS] Add a filed to PageHeaderData

2014-06-28 Thread Soroosh Sardari
On Tue, Jun 24, 2014 at 10:18 PM, Pavan Deolasee wrote: > > On Tue, Jun 24, 2014 at 3:40 PM, Kevin Grittner wrote: > > > > Soroosh Sardari wrote: > > > > > I check this problem with a virgin source code of > > > postgresql-9.3.2. So the bug is not for my codes. > > > > > By the way, following c

Re: [HACKERS] Window function optimisation, allow pushdowns of items matching PARTITION BY clauses

2014-06-28 Thread David Rowley
On 28 June 2014 18:12, Tom Lane wrote: > David Rowley writes: > > [ wfunc_pushdown_partitionby_v0.4.patch ] > > I've committed this with the addition of a volatility check and some > other basically-cosmetic adjustments. > > Great, thank you for making the required changes. Vik, thank you for r

Re: [HACKERS] Spinlocks and compiler/memory barriers

2014-06-28 Thread Andres Freund
On 2014-06-27 22:34:19 -0400, Robert Haas wrote: > On Fri, Jun 27, 2014 at 2:04 PM, Andres Freund wrote: > > On 2014-06-27 13:04:02 -0400, Robert Haas wrote: > >> On Thu, Jun 26, 2014 at 6:40 PM, Tom Lane wrote: > >> > Andres Freund writes: > >> >> On 2014-06-26 14:13:07 -0700, Tom Lane wrote: >

Re: [HACKERS] better atomics - v0.5

2014-06-28 Thread Andres Freund
On 2014-06-27 22:47:02 -0400, Robert Haas wrote: > On Fri, Jun 27, 2014 at 2:00 PM, Andres Freund wrote: > > On 2014-06-27 13:15:25 -0400, Robert Haas wrote: > >> On Thu, Jun 26, 2014 at 3:04 PM, Andres Freund > >> wrote: > >> > I don't really see usecases where it's not related data that's bein

Re: [HACKERS] better atomics - v0.5

2014-06-28 Thread Andres Freund
On 2014-06-28 11:58:41 +0530, Amit Kapila wrote: > On Wed, Jun 25, 2014 at 10:44 PM, Andres Freund > wrote: > > > > Attached is a new version of the atomic operations patch. Lots has > > changed since the last post: > > > > * gcc, msvc work. acc, xlc, sunpro have blindly written support which > >