Re: [HACKERS] Free indexed_tlist memory explicitly within set_plan_refs()

2015-07-12 Thread Andres Freund
On 2015-05-28 14:37:43 -0700, Peter Geoghegan wrote: To fix, allow ParseState to reflect that an individual statement can be both p_is_insert and p_is_update at the same time. /* Process DO UPDATE */ if (onConflictClause-action == ONCONFLICT_UPDATE) { + /*

Re: [HACKERS] Free indexed_tlist memory explicitly within set_plan_refs()

2015-07-12 Thread Peter Geoghegan
On Sun, Jul 12, 2015 at 1:45 PM, Andres Freund and...@anarazel.de wrote: But that's more crummy API's fault than yours. As you probably noticed, the only reason the p_is_update and p_is_insert fields exist is for transformAssignedExpr() -- in fact, in the master branch, nothing checks the value

Re: [HACKERS] PostgreSQL 9.5 Alpha 1 build fail with perl 5.22

2015-07-12 Thread Noah Misch
On Sun, Jul 12, 2015 at 05:02:51PM -0400, Andrew Dunstan wrote: Marco Atzeri marco.atz...@gmail.com writes: for what I see the hstore_plperl link has a double problem. It requires a link to hstore as it also requires a link to perl. Attached patch for solving this and a similar issue with

Re: [HACKERS] PostgreSQL 9.5 Alpha 1 build fail with perl 5.22

2015-07-12 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: On 07/04/2015 11:02 AM, Tom Lane wrote: It's not apparent to me how that works at all. BTW, the .a files being linked to above are not like Unix .a static archives - they are import library files, which I think they are only used at link time, not

Re: [HACKERS] creating extension including dependencies

2015-07-12 Thread David Fetter
On Tue, Jul 07, 2015 at 10:14:49AM -0700, David E. Wheeler wrote: On Jul 7, 2015, at 6:41 AM, Andres Freund and...@anarazel.de wrote: At the minimum I'd like to see that CREATE EXTENSION foo; would install install extension 'bar' if foo dependended on 'bar' if CASCADE is specified. Right

Re: [HACKERS] Fixes for a couple of resource leaks

2015-07-12 Thread Tom Lane
Michael Paquier michael.paqu...@gmail.com writes: Coverity is pointing out a couple of resource leaks: ... Attached is a patch to address all those things. Backpatches would be good to have as well. I'll take this up, unless some other committer is already on it.

Re: [HACKERS] PostgreSQL 9.5 Alpha 1 build fail with perl 5.22

2015-07-12 Thread Andrew Dunstan
On 07/04/2015 01:09 PM, Andrew Dunstan wrote: On 07/04/2015 11:02 AM, Tom Lane wrote: Marco Atzeri marco.atz...@gmail.com writes: for what I see the hstore_plperl link has a double problem. It requires a link to hstore as it also requires a link to perl. Attached patch for solving this and a

Re: [HACKERS] One question about security label command

2015-07-12 Thread Adam Brightwell
Stephen, Stephen, would you have the time to review this patch, and commit if appropriate, please? And if you could set up the buildfarm animal to run this, even better. I gave this a quick review/test against master (0a0fe2f). Everything builds and installs as would be expected. All of the

Re: [HACKERS] Fixes for a couple of resource leaks

2015-07-12 Thread Michael Paquier
On Mon, Jul 13, 2015 at 4:06 AM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: Coverity is pointing out a couple of resource leaks: ... Attached is a patch to address all those things. Backpatches would be good to have as well. I'll take this up,

Re: [HACKERS] optimizing vacuum truncation scans

2015-07-12 Thread Haribabu Kommi
On Thu, Jul 9, 2015 at 5:36 PM, Haribabu Kommi kommi.harib...@gmail.com wrote: I will do some performance tests and send you the results. Here are the performance results tested on my machine. Head vm patchvm+prefetch patch First vacuum

Re: [HACKERS] anole: assorted stability problems

2015-07-12 Thread Robert Haas
On Tue, Jul 7, 2015 at 7:25 AM, Andres Freund and...@anarazel.de wrote: On 2015-06-30 11:35:56 +0200, Andres Freund wrote: On 2015-06-29 22:58:05 -0400, Tom Lane wrote: So personally, I would be inclined to put back the volatile qualifier, independently of any fooling around with

Re: [HACKERS] TABLESAMPLE patch is really in pretty sad shape

2015-07-12 Thread Tom Lane
I wrote: The two contrib modules this patch added are nowhere near fit for public consumption. They cannot clean up after themselves when dropped: ... Raw inserts into system catalogs just aren't a sane thing to do in extensions. I had some thoughts about how we might fix that, without

Re: [HACKERS] A little RLS oversight?

2015-07-12 Thread Michael Paquier
On Sun, Jul 12, 2015 at 5:59 PM, Yaroslav wrote: I can still see all statistics for 'test' in pg_stats under unprivileged user. Indeed, this looks like an oversight of RLS. Even if a policy is defined to prevent a user from seeing the rows of other users, it is still possible to get some

Re: [HACKERS] [PATCH] Generalized JSON output functions

2015-07-12 Thread Pavel Stehule
2015-07-12 10:29 GMT+02:00 Shulgin, Oleksandr oleksandr.shul...@zalando.de : On Jul 11, 2015 8:41 PM, Pavel Stehule pavel.steh...@gmail.com wrote: There is simple rule - be strict on output and tolerant on input. If I understand to sense of this patch - the target is one same format of JSON

Re: [HACKERS] Re: Removing SSL renegotiation (Was: Should we back-patch SSL renegotiation fixes?)

2015-07-12 Thread Michael Paquier
On Sat, Jul 11, 2015 at 9:28 PM, Andres Freund and...@anarazel.de wrote: On 2015-07-11 21:09:05 +0900, Michael Paquier wrote: Something like the patches attached Thanks for that! could be considered, one is for master and REL9_5_STABLE to remove ssl_renegotiation_limit, the second one

[HACKERS] Fixes for a couple of resource leaks

2015-07-12 Thread Michael Paquier
Hi all, Coverity is pointing out a couple of resource leaks: - In DropReplicationSlot@streamutil.c, query is leaked. - In getTransforms@pg_dump.c, the alloced result of get_language_name is not free'd. Other code paths calling this routine do the job. - In

[HACKERS] Could be improved point of UPSERT

2015-07-12 Thread Yourfriend
Hi, Hackers, The feature of UPSERT was my most interested one of 9.5, I really like need it. I have test the different usages for this features like one record input, multi records input, and also more than 10,000 records upserting, all look great, thanks for your work. When I checked my

Re: [HACKERS] drop/truncate table sucks for large values of shared buffers

2015-07-12 Thread Amit Kapila
On Thu, Jul 2, 2015 at 7:33 PM, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: On 2 July 2015 at 14:08, Heikki Linnakangas hlinn...@iki.fi wrote: I'm marking this as returned with feedback in the commitfest. There are no unresolved issues with the approach,

Re: [HACKERS] [PATCH] Generalized JSON output functions

2015-07-12 Thread Merlin Moncure
On Sun, Jul 12, 2015 at 4:35 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2015-07-12 10:29 GMT+02:00 Shulgin, Oleksandr oleksandr.shul...@zalando.de: On Jul 11, 2015 8:41 PM, Pavel Stehule pavel.steh...@gmail.com wrote: There is simple rule - be strict on output and tolerant on

Re: [HACKERS] TABLESAMPLE doesn't actually satisfy the SQL spec, does it?

2015-07-12 Thread Robert Haas
On Sun, Jul 12, 2015 at 12:02 PM, Tom Lane t...@sss.pgh.pa.us wrote: As best I can tell (evidence below), the SQL standard requires that if a single query reads a table with a TABLESAMPLE clause multiple times (say, because it's on the inside of a nestloop), then the exact same set of sampled

Re: [HACKERS] [PATCH] Generalized JSON output functions

2015-07-12 Thread Pavel Stehule
2015-07-12 20:11 GMT+02:00 Shulgin, Oleksandr oleksandr.shul...@zalando.de : we talking about output - I can imagine, so there is only two possibilities - plain join, and pretty formatted join (but with only one style). This makes sense. Postgres core really only needs to support the

[HACKERS] TRANSFORM modules vs. AIX

2015-07-12 Thread Noah Misch
(was Re: [COMMITTERS] pgsql: Add transforms feature) On Tue, May 05, 2015 at 10:24:03PM -0400, Peter Eisentraut wrote: Any dlopenable module will have undefined symbols, namely those that it uses to call back into the executable that loads the module. The only way it can know to not complain

Re: [HACKERS] [PATCH] Generalized JSON output functions

2015-07-12 Thread Shulgin, Oleksandr
we talking about output - I can imagine, so there is only two possibilities - plain join, and pretty formatted join (but with only one style). This makes sense. Postgres core really only needs to support the minimum styles necessary for core requirements. This means raw unformatted json

Re: [HACKERS] TABLESAMPLE doesn't actually satisfy the SQL spec, does it?

2015-07-12 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Sun, Jul 12, 2015 at 12:02 PM, Tom Lane t...@sss.pgh.pa.us wrote: As best I can tell (evidence below), the SQL standard requires that if a single query reads a table with a TABLESAMPLE clause multiple times (say, because it's on the inside of a

[HACKERS] TABLESAMPLE doesn't actually satisfy the SQL spec, does it?

2015-07-12 Thread Tom Lane
As best I can tell (evidence below), the SQL standard requires that if a single query reads a table with a TABLESAMPLE clause multiple times (say, because it's on the inside of a nestloop), then the exact same set of sampled rows are returned each time. The BERNOULLI code, at least, fails to