Re: [HACKERS] [PATCH] SQL function to report log message

2015-10-18 Thread Pavel Stehule
2015-10-18 21:13 GMT+02:00 Jim Nasby : > On 10/17/15 11:49 AM, Pavel Stehule wrote: > >> 2015-10-17 18:42 GMT+02:00 Jim Nasby > >: >> >> On 10/15/15 11:51 PM, Pavel Stehule wrote: >> >> I don't think so ignoring NULL in RAISE statement is good idea >>

Re: [HACKERS] Foreign join pushdown vs EvalPlanQual

2015-10-18 Thread Kouhei Kaigai
> On Fri, Oct 16, 2015 at 6:12 PM, Kouhei Kaigai wrote: > > I think, it is right approach to pretend EPQ doesn't exist if scanrelid==0, > > because what replaced by these ForeignScan/CustomScan node are local join > > node like NestLoop. They don't have its own EPQ slot, but constructs joined- > >

[HACKERS] Minor comment fix

2015-10-18 Thread Amit Langote
Attached fixes the following in comment above ExecCheckIndexConstraints: s/no no conflict/no conflict/g Thanks, Amit diff --git a/src/backend/executor/execIndexing.c b/src/backend/executor/execIndexing.c index 7299329..8f1b058 100644 --- a/src/backend/executor/execIndexing.c +++ b/src/backend/exe

Re: [HACKERS] Making tab-complete.c easier to maintain

2015-10-18 Thread Thomas Munro
On Mon, Oct 19, 2015 at 4:58 PM, Jeff Janes wrote: > On Sun, Oct 18, 2015 at 5:31 PM, Thomas Munro > wrote: >> >> Hi >> >> Here is a new version merging recent changes. > > > For reasons I do not understand, "SET work_mem " does not complete with > "TO". > > But if I change: > > else if (Matches2

Re: [HACKERS] Making tab-complete.c easier to maintain

2015-10-18 Thread Jeff Janes
On Sun, Oct 18, 2015 at 5:31 PM, Thomas Munro wrote: > Hi > > Here is a new version merging recent changes. > For reasons I do not understand, "SET work_mem " does not complete with "TO". But if I change: else if (Matches2("SET", MatchAny)) to: else if (TailMatches2("SET", MatchAny)) Then i

Re: [HACKERS] Why no CONSTANT for row variables in plpgsql?

2015-10-18 Thread Tom Lane
Jim Nasby writes: > Is there a particular reason why row and record variables can't be > CONSTANT in plpgsql? Well, you can't usefully do anything with such a variable unless it can be initialized, which isn't currently supported either: regression=# do $$ declare x int8_tbl := row(1,2); begin

Re: [HACKERS] Making tab-complete.c easier to maintain

2015-10-18 Thread Thomas Munro
Hi Here is a new version merging recent changes. -- Thomas Munro http://www.enterprisedb.com tab-complete-macrology-v4.patch.gz Description: GNU Zip compressed data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgres

[HACKERS] Why no CONSTANT for row variables in plpgsql?

2015-10-18 Thread Jim Nasby
Is there a particular reason why row and record variables can't be CONSTANT in plpgsql? -- Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX Experts in Analytics, Data Architecture and PostgreSQL Data in Trouble? Get it in Treble! http://BlueTreble.com -- Sent via pgsql-hackers maili

[HACKERS] tab completion for extension versions

2015-10-18 Thread Jeff Janes
This patch adds "VERSION" to the list of words completed after "create extension foo", and adds the list of available versions of foo after "create extension foo version". There is no point in filtering out the already installed version, as the entire statement is doomed already if any version of

Re: [HACKERS] checkpointer continuous flushing

2015-10-18 Thread Andres Freund
Hi, On 2015-09-10 17:15:26 +0200, Fabien COELHO wrote: > > >Thanks for the hints! Two-part v12 attached fixes these. > > Here is a v13, which is just a rebase after 1aba62ec. I'm working on this patch, to get it into a state I think it'd be commitable. In my performance testing it showed tha

[HACKERS] COPY FREEZE and PD_ALL_VISIBLE

2015-10-18 Thread Jeff Janes
I'm planning on adding a todo item to have COPY FREEZE set PD_ALL_VISIBLE. Or is there some reason this can't be done? Since the whole point of COPY FREEZE is to avoid needing to rewrite the entire table, it seems rather perverse that the first time the table is vacuumed, it needs to rewrite the e

Re: [HACKERS] Allow ssl_renegotiation_limit in PG 9.5

2015-10-18 Thread Shay Rojansky
Here's a patch that adds back the GUC, with default/min/max 0 and GUC_NO_SHOW_ALL | GUC_NOT_IN_SAMPLE | GUC_DISALLOW_IN_FILE. This is my first pg patch, please be gentle with any screwups :) patch_tolerate_ssl_renegotiation_limit_zero Description: Binary data -- Sent via pgsql-hackers mailing

Re: [HACKERS] [PATCH] SQL function to report log message

2015-10-18 Thread Jim Nasby
On 10/17/15 11:49 AM, Pavel Stehule wrote: 2015-10-17 18:42 GMT+02:00 Jim Nasby mailto:jim.na...@bluetreble.com>>: On 10/15/15 11:51 PM, Pavel Stehule wrote: I don't think so ignoring NULL in RAISE statement is good idea (it is not safe). We can replace NULL by some

Re: [HACKERS] More work on SortSupport for text - strcoll() and strxfrm() caching

2015-10-18 Thread Peter Geoghegan
On Thu, Oct 15, 2015 at 9:07 AM, Robert Haas wrote: > Would you be willing to try coding it up that way so we can see how it looks? I attach a patch that does it that way. Note that I will be away for until late this month. Do not expect a response from me before then, unless it's truly urgent.

Re: [HACKERS] fs issues on software raid0 (PG_VERSION does not contain valid data)

2015-10-18 Thread Andres Freund
Hi, On 2015-10-18 20:25:29 +0200, Tomas Vondra wrote: > I've been doing a lot of filesystem testing / benchmarking recently, and > today I've ran into a really strange issue with ext4 on two SSD devices in a > RAID-0 configuration (Linux software raid). > All this happens on an ext4 filesystem, c

[HACKERS] fs issues on software raid0 (PG_VERSION does not contain valid data)

2015-10-18 Thread Tomas Vondra
Hi there, I've been doing a lot of filesystem testing / benchmarking recently, and today I've ran into a really strange issue with ext4 on two SSD devices in a RAID-0 configuration (Linux software raid). I'm currently trying rerunning the test to see if it's reproducible, but maybe someone h