Re: [HACKERS] snapshot too old, configured by time

2016-02-29 Thread Michael Paquier
On Tue, Mar 1, 2016 at 9:35 AM, Andres Freund wrote: > On 2016-02-29 18:30:27 -0600, Kevin Grittner wrote: >> Basically, a connection needs to remain open and interleave >> commands with other connections, which the isolation tester does >> just fine; but it needs to do that using a custom postgre

Re: [HACKERS] Publish autovacuum informations

2016-02-29 Thread Michael Paquier
On Tue, Mar 1, 2016 at 4:38 AM, Julien Rouhaud wrote: > On 29/02/2016 20:20, Fabrízio de Royes Mello wrote: >> >> On Mon, Feb 29, 2016 at 3:04 PM, Julien Rouhaud >> mailto:julien.rouh...@dalibo.com>> wrote: >>> >>> On 04/06/2015 22:10, Guillaume Lelarge wrote: >>> > 2015-01-05 17:44 GMT+01:00 Guil

Re: [HACKERS] [REVIEW] In-core regression tests for replication, cascading, archiving, PITR, etc.

2016-02-29 Thread Michael Paquier
On Tue, Mar 1, 2016 at 11:28 AM, Michael Paquier wrote: > On Tue, Mar 1, 2016 at 6:25 AM, Alvaro Herrera > wrote: >> Michael Paquier wrote: >> >>> 9) I have no logical explanation to explain why I am seeing all those >>> things now. >> >> Happens all the time ... >> >> Pushed, thanks. > > Thanks

Re: [HACKERS] remove wal_level archive

2016-02-29 Thread Michael Paquier
On Tue, Mar 1, 2016 at 10:02 AM, Peter Eisentraut wrote: > On 2/8/16 7:34 AM, Michael Paquier wrote: >> - if (ControlFile->wal_level < WAL_LEVEL_HOT_STANDBY) >> + if (ControlFile->wal_level < WAL_LEVEL_REPLICA) >> Upthread it was mentioned that switching to an approach

[HACKERS] OOM in libpq and infinite loop with getCopyStart()

2016-02-29 Thread Michael Paquier
Hi all, One year and a half ago Heikki has reported that libpq could run on an infinite loop in a couple of code paths should an OOM happen in PQExec(): http://www.postgresql.org/message-id/547480de.4040...@vmware.com The code paths are: - BIND messages for getRowDescriptions(), or 'T' messages, f

[HACKERS] Logic problem in SerializeSnapshot()

2016-02-29 Thread Rushabh Lathia
Hi All, During the testing of parallel query (with force_parallel_mode = regress), noticed random server crash with the below stack: #0 0x003fc84896d5 in memcpy () from /lib64/libc.so.6 #1 0x00a36867 in SerializeSnapshot (snapshot=0x1e49f40, start_address=0x7f391e9ec728 ) at snapmgr

Re: [HACKERS] pg_dump dump catalog ACLs

2016-02-29 Thread Tom Lane
Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> No, the point of it would be to not have pg_dump scripts overriding >> installed-by-default ACLs. A newer PG version might have different >> ideas about what those should be. I don't think this is exactly an >> academic concern, e

Re: [HACKERS] Move PinBuffer and UnpinBuffer to atomics

2016-02-29 Thread Dilip Kumar
On Mon, Feb 29, 2016 at 5:18 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > I didn't reproduce the regression. I had access to multicore machine but > didn't see either regression on low clients or improvements on high clients. > In the attached path spinlock delay was exposed in s_l

Re: [HACKERS] dealing with extension dependencies that aren't quite 'e'

2016-02-29 Thread Abhijit Menon-Sen
At 2016-02-29 19:56:07 -0600, jim.na...@bluetreble.com wrote: > > I don't see why this would be limited to just functions. […] Am I > missing something? No, you are not missing anything. The specific problem I was trying to solve involved a function, so I sketched out a solution for functions. Onc

Re: [HACKERS] pg_dump dump catalog ACLs

2016-02-29 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> To make this work, you'd need a way to distinguish privileges installed > >> by initdb from those changed later. > > > To replicate whatever the current ACL is, we don't actually need to

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

2016-02-29 Thread Amit Kapila
On Mon, Feb 29, 2016 at 11:10 PM, Robert Haas wrote: > > On Fri, Feb 26, 2016 at 11:37 PM, Amit Kapila wrote: > > On Sat, Feb 27, 2016 at 10:03 AM, Amit Kapila > > wrote: > >> > >> Here, we can see that there is a gain of ~15% to ~38% at higher client > >> count. > >> > >> The attached document

Re: [HACKERS] pg_dump dump catalog ACLs

2016-02-29 Thread Tom Lane
Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> To make this work, you'd need a way to distinguish privileges installed >> by initdb from those changed later. > To replicate whatever the current ACL is, we don't actually need to > make such a differentiation. I'm not against do

Re: [HACKERS] Improve error handling in pltcl

2016-02-29 Thread Tom Lane
Jim Nasby writes: > On 2/28/16 5:50 PM, Jim Nasby wrote: >> Per discussion in [1], this patch improves error reporting in pltcl. > I forgot to mention that this work is sponsored by Flight Aware > (http://flightaware.com). Huh ... I use that site. There's PG and pltcl code behind it? Cool!

Re: [HACKERS] pg_dump dump catalog ACLs

2016-02-29 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > Per discussion about the best approach to reduce the amount of > > superuser-only capabilities, this patch modifies pg_dump to dump out > > all ACLs which exist on objects in the pg_catalog schema. > > Um ... surely there are some

Re: [HACKERS] pg_dump dump catalog ACLs

2016-02-29 Thread Tom Lane
Stephen Frost writes: > Per discussion about the best approach to reduce the amount of > superuser-only capabilities, this patch modifies pg_dump to dump out > all ACLs which exist on objects in the pg_catalog schema. Um ... surely there are some of those that are installed by default? To make th

[HACKERS] Default Roles

2016-02-29 Thread Stephen Frost
All, Attached is a stripped-down version of the default roles patch which includes only the 'pg_signal_backend' default role. This provides the framework and structure for other default roles to be added and formally reserves the 'pg_' role namespace. This is split into two patches, the first to

Re: [HACKERS] Proposal: "Causal reads" mode for load balancing reads without stale data

2016-02-29 Thread Thomas Munro
On Tue, Mar 1, 2016 at 2:46 PM, Amit Langote wrote: > > Hi, > > On 2016/02/29 18:05, Thomas Munro wrote: >> On Mon, Feb 29, 2016 at 9:05 PM, Amit Langote wrote: >>> + servers. A transaction that is run with >>> causal_reads set >>> + to on is guaranteed either to see the effects o

Re: [HACKERS] [REVIEW] In-core regression tests for replication, cascading, archiving, PITR, etc.

2016-02-29 Thread Michael Paquier
On Tue, Mar 1, 2016 at 6:25 AM, Alvaro Herrera wrote: > Michael Paquier wrote: > >> 9) I have no logical explanation to explain why I am seeing all those >> things now. > > Happens all the time ... > > Pushed, thanks. Thanks. I am going to patch by buildfarm scripts to run those tests on hamster.

[HACKERS] pg_dump dump catalog ACLs

2016-02-29 Thread Stephen Frost
All, Per discussion about the best approach to reduce the amount of superuser-only capabilities, this patch modifies pg_dump to dump out all ACLs which exist on objects in the pg_catalog schema. With this change, follow-on trivial patches will remove explicit superuser() checks from functions and

Re: [HACKERS] dealing with extension dependencies that aren't quite 'e'

2016-02-29 Thread Jim Nasby
On 2/29/16 7:27 PM, Abhijit Menon-Sen wrote: 1. This adds the 'x'/DEPENDENCY_AUTO_EXTENSION type. 2. This adds an 'ALTER FUNCTION … ADD DEPENDENT FUNCTION …' command. I split up the two because we may want the new dependency type without going to the trouble of adding a new command. Maybe extens

Re: [HACKERS] Improve error handling in pltcl

2016-02-29 Thread Jim Nasby
On 2/28/16 5:50 PM, Jim Nasby wrote: Per discussion in [1], this patch improves error reporting in pltcl. I forgot to mention that this work is sponsored by Flight Aware (http://flightaware.com). -- Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX Experts in Analytics, Data Archit

Re: [HACKERS] Convert pltcl from strings to objects

2016-02-29 Thread Jim Nasby
On 2/29/16 9:57 AM, Tom Lane wrote: plpgsql already has a similar mechanism (see PLpgSQL_function.use_count) which you could probably copy. But I'd advise that this is a separate matter to be addressed in a separate patch; it has little to do with the nominal subject matter of this patch. Ahh,

Re: [HACKERS] Proposal: "Causal reads" mode for load balancing reads without stale data

2016-02-29 Thread Amit Langote
Hi, On 2016/02/29 18:05, Thomas Munro wrote: > On Mon, Feb 29, 2016 at 9:05 PM, Amit Langote wrote: >> + servers. A transaction that is run with >> causal_reads set >> + to on is guaranteed either to see the effects of all >> + completed transactions run on the primary wi

Re: [HACKERS] dealing with extension dependencies that aren't quite 'e'

2016-02-29 Thread Abhijit Menon-Sen
At 2016-01-18 11:08:19 +0530, a...@2ndquadrant.com wrote: > > I'm proposing to address a part of that problem by allowing extension > dependencies to be explicitly declared for functions and objects > created either by a user or dynamically by the extension itself—things > that need the extension t

Re: [HACKERS] create opclass documentation outdated

2016-02-29 Thread Tom Lane
Julien Rouhaud writes: > On 25/02/2016 23:12, Vik Fearing wrote: >> On 02/25/2016 09:13 PM, Julien Rouhaud wrote: >>> I just saw that the CREATE OPERATOR CLASS documentation doesn't >>> mention that BRIN indexes also support the STORAGE parameter. >> I think this is the wrong approach; that paren

Re: [HACKERS] remove wal_level archive

2016-02-29 Thread Peter Eisentraut
On 2/8/16 7:34 AM, Michael Paquier wrote: > Shouldn't backup.sgml be updated as well? Here is the portion that I > am referring to: > To enable WAL archiving, set the > configuration parameter to archive or higher, > to on, > > But minimal WAL does not contain enough informa

Re: [HACKERS] remove wal_level archive

2016-02-29 Thread Peter Eisentraut
On 2/8/16 9:36 AM, David Steele wrote: > -#define XLogIsNeeded() (wal_level >= WAL_LEVEL_ARCHIVE) > +#define XLogIsNeeded() (wal_level >= WAL_LEVEL_REPLICA) > <...> > -#define XLogStandbyInfoActive() (wal_level >= WAL_LEVEL_HOT_STANDBY) > +#define XLogStandbyInfoActive() (wal_level >= WAL_LEVEL_REP

Re: [HACKERS] snapshot too old, configured by time

2016-02-29 Thread Andres Freund
On 2016-02-29 18:30:27 -0600, Kevin Grittner wrote: > Basically, a connection needs to remain open and interleave > commands with other connections, which the isolation tester does > just fine; but it needs to do that using a custom postgresql.conf > file, which TAP does just fine. I haven't been

Re: [HACKERS][REVIEW]: Password identifiers, protocol aging and SCRAM protocol

2016-02-29 Thread Michael Paquier
On Mon, Feb 29, 2016 at 8:43 PM, Valery Popov wrote: > vpopov@vpopov-Ubuntu:~/Projects/pwdtest/postgresql$ git branch Thanks for the input! > 0001-Add-facility-to-store-multiple-password-verifiers.patch:2547: trailing > whitespace. > warning: 1 line adds whitespace errors. > 0003-Add-pg_auth_ver

Re: [HACKERS] snapshot too old, configured by time

2016-02-29 Thread Kevin Grittner
On Fri, Jan 8, 2016 at 5:22 PM, Alvaro Herrera wrote: >> People have said that issuing SQL commands directly from a TAP test >> via DBD::Pg is not acceptable for a core feature, and (despite >> assertions to the contrary) I see no way to test this feature with >> existing testing mechanisms. The

Re: [HACKERS] pglogical - logical replication contrib module

2016-02-29 Thread Petr Jelinek
Hi On 03/02/16 03:25, Steve Singer wrote: The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, failed Spec compliant: not tested Documentation:tested, failed Here is some more re

[HACKERS] amcheck (B-Tree integrity checking tool)

2016-02-29 Thread Peter Geoghegan
I was assigned an "action point" during the FOSDEM developer meeting: "Post new version of btree consistency checker patch". I attach a new WIP version of my consistency checker tool, amcheck. This patch is proposed for 9.6, as an extension in contrib -- maybe we can still get it in. This is the fi

[HACKERS] pg_resetxlog reference page reorganization

2016-02-29 Thread Peter Eisentraut
The pg_resetxlog reference page has grown over the years into an unnavigable jungle, so here is a patch that reorganizes it to be more in the style of the other ref pages, with a normal options list. From a9024195e9f7a0b47e592f39938bdc9743152a70 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date

Re: [HACKERS] psql completion for ids in multibyte string

2016-02-29 Thread Thomas Munro
On Fri, Feb 26, 2016 at 6:34 PM, Kyotaro HORIGUCHI wrote: > Hello, this is the second patch plitted out. This allows > multibyte names to be completed in psql. > > At Fri, 06 Nov 2015 11:47:17 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI > wrote in > <20151106.114717.170526268.horiguchi.kyot.

Re: [HACKERS] [PATCH] Logical decoding support for sequence advances

2016-02-29 Thread Alvaro Herrera
Petr Jelinek wrote: > I wonder if it would be acceptable to create new info flag for RM_SEQ_ID > that would behave just like XLOG_SEQ_LOG but would be used only for the > nontransactional updates (nextval) so that decoding could easily > differentiate between transactional and non-transactional up

Re: [HACKERS] GCC 6 warning fixes

2016-02-29 Thread Thomas Munro
On Sat, Feb 20, 2016 at 5:14 PM, Peter Eisentraut wrote: > Here are three patches to fix new warnings in GCC 6. > > 0001 is apparently a typo. Right, looks like it. Builds and tests OK with this change (though I didn't get any warning from GCC6.0.0 -Wall for this one). > 0002 was just (my?) stu

Re: [HACKERS] Patch to install config/missing

2016-02-29 Thread Alvaro Herrera
Tom Lane wrote: > Given our inability to come to a consensus on rejiggering the uses of > "missing", I think maybe we should just apply the original patch and > call it good. For the record: Tom applied this patch as commit dccf8e9e608824ce15. -- Álvaro Herrerahttp://www.2ndQuad

Re: [HACKERS] [PATCH] Logical decoding support for sequence advances

2016-02-29 Thread Petr Jelinek
On 29/02/16 03:23, Craig Ringer wrote: On 17 December 2015 at 10:08, Craig Ringer mailto:cr...@2ndquadrant.com>> wrote: On 15 December 2015 at 20:17, Andres Freund mailto:and...@anarazel.de>> wrote: I think this is quite the wrong approach. You're calling the logical deco

Re: [HACKERS] [REVIEW] In-core regression tests for replication, cascading, archiving, PITR, etc.

2016-02-29 Thread Alvaro Herrera
Michael Paquier wrote: > 9) I have no logical explanation to explain why I am seeing all those > things now. Happens all the time ... Pushed, thanks. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent vi

[HACKERS] Issue with NULLS LAST, with postgres_fdw sort pushdown

2016-02-29 Thread Rajkumar Raghuwanshi
Hi, I am testing postgres_fdw sort pushdown feature for PostgreSQL 9.6 DB, and I observed below issue. *Observation: *If giving nulls last option with the order by clause as 'desc nulls last', remote query is not considering nulls last and giving wrong result in 9.6 version. while in 9.5 it is gi

Re: [HACKERS] get current log file

2016-02-29 Thread Armor
Yes, if we cannot find a perfect solution, we need to wait. Actually, the customer need a unified interface to access the status of database, so we implement it. -- Jerry Yu https://github.com/scarbrofair -- Original -- From: "Robert Haa

Re: [HACKERS] Minor typo in syncrep.c

2016-02-29 Thread Alvaro Herrera
Amit Langote wrote: > On 2016/02/03 17:50, Amit Langote wrote: > > Attached patch removes an extraneous word in the comment above > > I kept reading and found one place in a comment within the function where > a word is most probably missing, Attached fixes it. Pushed both, thanks. -- Álvaro H

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-02-29 Thread Petr Jelinek
Hi, attached is the newest version of the patch. I removed the registry, renamed the 'send' to 'emit', documented the callback parameters properly. I also added the test to ddl.sql for the serialization and deserialization (and of course found a bug there) and in general fixed all the stuff A

Re: [HACKERS] [COMMITTERS] pgsql: Add isolationtester spec for old heapam.c bug

2016-02-29 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > Tom Lane wrote: > >> guaibasaurus is not a particularly slow machine, and it's not using any > >> special build flags AFAICT. So I'm not sure what to make of this case, > >> except that it proves the timing problem can manifest on normal builds. > > >

Re: [HACKERS] Publish autovacuum informations

2016-02-29 Thread Julien Rouhaud
On 29/02/2016 20:20, Fabrízio de Royes Mello wrote: > > On Mon, Feb 29, 2016 at 3:04 PM, Julien Rouhaud > mailto:julien.rouh...@dalibo.com>> wrote: >> >> On 04/06/2015 22:10, Guillaume Lelarge wrote: >> > 2015-01-05 17:44 GMT+01:00 Guillaume Lelarge >> >

Re: [HACKERS] Publish autovacuum informations

2016-02-29 Thread Fabrízio de Royes Mello
On Mon, Feb 29, 2016 at 3:04 PM, Julien Rouhaud wrote: > > On 04/06/2015 22:10, Guillaume Lelarge wrote: > > 2015-01-05 17:44 GMT+01:00 Guillaume Lelarge > >: > > > > 2015-01-05 17:40 GMT+01:00 Robert Haas > >: > > > >

Re: [HACKERS] [PATH] Jsonb, insert a new value into an array at arbitrary position

2016-02-29 Thread Petr Jelinek
On 29/02/16 18:19, Dmitry Dolgov wrote: > I'd strongly prefer the jsonb_array_insert naming though > I don't think it's a good idea to use set when this is used on object, I think that we should throw error in that case. Well, I thought it's wrong to introduce different functions and behaviour

Re: [HACKERS] pg_dump / copy bugs with "big lines" ?

2016-02-29 Thread Alvaro Herrera
A customer of ours was hit by this recently and I'd like to get it fixed for good. Robert Haas wrote: > On Mon, Apr 6, 2015 at 1:51 PM, Jim Nasby wrote: > > In any case, I don't think it would be terribly difficult to allow a bit > > more than 1GB in a StringInfo. Might need to tweak palloc too;

Re: [HACKERS] Publish autovacuum informations

2016-02-29 Thread Julien Rouhaud
On 04/06/2015 22:10, Guillaume Lelarge wrote: > 2015-01-05 17:44 GMT+01:00 Guillaume Lelarge >: > > 2015-01-05 17:40 GMT+01:00 Robert Haas >: > > On Wed, Dec 31, 2014 at 12:46 PM, Tom Lane

Re: [HACKERS] POC, WIP: OR-clause support for indexes

2016-02-29 Thread Teodor Sigaev
Thank you for review! I'd like to see comments too! but more so in the code. :) I've had a look over this, and it seems like a great area in which we could improve on, and your reported performance improvements are certainly very interesting too. However I'm finding the code rather hard to follo

Re: [HACKERS] Reduce lock levels others reloptions in ALTER TABLE

2016-02-29 Thread Fabrízio de Royes Mello
On Mon, Feb 29, 2016 at 2:58 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > Hi all, > > Some time ago we added [1] the infrastructure to allow different lock levels for relation options. > > So per discussion [2] the attached patch reduce lock levels down to ShareUpdateExclusiveL

[HACKERS] Reduce lock levels others reloptions in ALTER TABLE

2016-02-29 Thread Fabrízio de Royes Mello
Hi all, Some time ago we added [1] the infrastructure to allow different lock levels for relation options. So per discussion [2] the attached patch reduce lock levels down to ShareUpdateExclusiveLock for: - fastupdate - fillfactor - gin_pending_list_limit - seq_page_cost - random_page_cost - n_di

Re: [HACKERS] WIP: Upper planner pathification

2016-02-29 Thread Tom Lane
Robert Haas writes: > I'll abstain from the question of whether this patch is too late in > coming (but the answer is probably "yes") and instead volunteer to > review it. OK, I've put it into the commitfest. Thanks for volunteering! regards, tom lane -- Sent via pgsq

Re: [HACKERS] WIP: Upper planner pathification

2016-02-29 Thread Robert Haas
On Sun, Feb 28, 2016 at 3:03 PM, Tom Lane wrote: > So, where to go from here? I'm acutely aware that we're hard up against > the final 9.6 commitfest, and that we discourage major patches arriving > so late in a devel cycle. But I simply couldn't get this done any faster. > I don't really want t

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

2016-02-29 Thread Robert Haas
On Fri, Feb 26, 2016 at 11:37 PM, Amit Kapila wrote: > On Sat, Feb 27, 2016 at 10:03 AM, Amit Kapila > wrote: >> >> Here, we can see that there is a gain of ~15% to ~38% at higher client >> count. >> >> The attached document (perf_write_clogcontrollock_data_v6.ods) contains >> data, mainly focuss

Re: [HACKERS] postgres_fdw vs. force_parallel_mode on ppc

2016-02-29 Thread Robert Haas
On Sat, Feb 27, 2016 at 7:05 PM, Noah Misch wrote: > On Fri, Feb 26, 2016 at 04:16:58PM +0530, Robert Haas wrote: >> Committed these patches after revising the comment you wrote and >> adding documentation. > > I've modified buildfarm member mandrill to use force_parallel_mode=regress and > max_pa

Re: [HACKERS] [PATH] Jsonb, insert a new value into an array at arbitrary position

2016-02-29 Thread Dmitry Dolgov
> I'd strongly prefer the jsonb_array_insert naming though > I don't think it's a good idea to use set when this is used on object, I think that we should throw error in that case. Well, I thought it's wrong to introduce different functions and behaviour patterns for objects and arrays, because it

Re: [HACKERS] proposal: PL/Pythonu - function ereport

2016-02-29 Thread Pavel Stehule
> 0003 is the most controversial. It removes the ability to pass message > as keyword argument. My reasoning was that keyword arguments are > usually optional and configure extra aspects of the function call > while message is required and fundamental so therefore it should be > positional. If you

Re: [HACKERS] proposal: PL/Pythonu - function ereport

2016-02-29 Thread Catalin Iacob
On 2/26/16, Pavel Stehule wrote: > Sending updated version I did some changes on top of your last version as that was easier than commenting about them, see attached. 0001 and 0005 are comment changes. 0002 is really needed, without it the tests fail on Python2.4. 0004 removes more code relate

Re: [HACKERS] Convert pltcl from strings to objects

2016-02-29 Thread Tom Lane
Jim Nasby writes: > On 2/25/16 9:30 AM, Alvaro Herrera wrote: >> Refcounting the prodesc would let it live until the cursor's closed, >> then free it. > I'm also not sure how the reference would get decremented... via > ResourceOwner somehow? plpgsql already has a similar mechanism (see PLpgSQL

Re: [HACKERS] Typo fix

2016-02-29 Thread Tom Lane
Amit Langote writes: > Attached fixes a typo: Pushed, thanks. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] Phrase search ported to 9.6

2016-02-29 Thread Artur Zakirov
Hello, Dmitry This is my initial review for you patch. Below are my comments. Introduction This patch introduce new operator and new functions. New operator: - ?? New functions: - phraseto_tsquery([ config regconfig , ] query text) - setweight(tsquery, "char") - tsquery_phrase(quer

Re: [HACKERS]WIP: Covering + unique indexes.

2016-02-29 Thread Anastasia Lubennikova
25.02.2016 21:39, Jeff Janes: As promised, here's the new version of the patch "including_columns_4.0". I fixed all issues except some points mentioned below. Thanks for the update patch. I get a compiler warning: genam.c: In function 'BuildIndexValueDescription': genam.c:259: warning: unused

Re: [HACKERS] Compilation broken when OPTIMIZER_DEBUG is set

2016-02-29 Thread Tom Lane
Michael Paquier writes: > On Mon, Feb 29, 2016 at 8:44 PM, salvador fandino wrote: >> allpaths.c: In function ‘debug_print_rel’: >> allpaths.c:2943:50: error: ‘RelOptInfo {aka struct RelOptInfo}’ has no >> member named ‘width’ > Indeed. The width is now part of rel->reltarget.width.

[HACKERS] WAL log only necessary part of 2PC GID

2016-02-29 Thread Pavan Deolasee
Hello Hackers, The maximum size of the GID, used as a 2PC identifier is currently defined as 200 bytes (see src/backend/access/transam/twophase.c). The actual GID used by the applications though may be much smaller than that. So IMO instead of WAL logging the entire 200 bytes during PREPARE TRANSA

Re: [HACKERS] WIP: Upper planner pathification

2016-02-29 Thread Simon Riggs
On 28 February 2016 at 20:03, Tom Lane wrote: > So, where to go from here? I'm acutely aware that we're hard up against > the final 9.6 commitfest, and that we discourage major patches arriving > so late in a devel cycle. But I simply couldn't get this done any faster. > I don't really want to

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2016-02-29 Thread Amit Kapila
On Thu, Feb 25, 2016 at 2:54 AM, Peter Eisentraut wrote: > > Could you enhance the documentation about the difference between "wait > event type name" and "wait event name" (examples?)? > I am planning to add possible values for each of the wait event type and wait event and will add few examples

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2016-02-29 Thread Amit Kapila
On Wed, Feb 24, 2016 at 7:14 PM, Robert Haas wrote: > > On Mon, Feb 22, 2016 at 10:05 AM, Amit Kapila wrote: > >> I wouldn't bother tinkering with it at this point. The value isn't > >> going to be recorded on disk anywhere, so it will be easy to change > >> the way it's computed in the future i

Re: [HACKERS] Compilation broken when OPTIMIZER_DEBUG is set

2016-02-29 Thread Michael Paquier
On Mon, Feb 29, 2016 at 8:44 PM, salvador fandino wrote: > gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement > -Wendif-labels -Wmissing-format-attribute -Wformat-security > -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O0 > -DOPTIMIZER_DEBUG -I../../../../

[HACKERS] Reworks of CustomScan serialization/deserialization

2016-02-29 Thread Kouhei Kaigai
Hello, I'd like to adjust a few of custom-scan interface prior to v9.6 freeze. The major point is serialization/deserialization mechanism. Now, extension has to give LibraryName and SymbolName to reproduce same CustomScanMethods on the background worker process side. Indeed, it is sufficient info

Re: [HACKERS] WIP: Access method extendability

2016-02-29 Thread Michael Paquier
On Mon, Feb 29, 2016 at 7:42 PM, Alexander Korotkov wrote: > On Fri, Feb 19, 2016 at 4:08 AM, Michael Paquier > wrote: >> This is basically a copy of RewindTest.pm. This is far from generic. >> If this patch gets committed first I would suggest to wait for the >> more-generic routines that would

Re: [HACKERS] Move PinBuffer and UnpinBuffer to atomics

2016-02-29 Thread Alexander Korotkov
On Sat, Feb 27, 2016 at 2:44 AM, Andres Freund wrote: > On 2016-02-02 13:12:50 +0300, Alexander Korotkov wrote: > > On Tue, Feb 2, 2016 at 12:43 AM, Andres Freund > wrote: > > > > > On 2016-02-01 13:06:57 +0300, Alexander Korotkov wrote: > > > > On Mon, Feb 1, 2016 at 11:34 AM, Alexander Korotko

[HACKERS] Compilation broken when OPTIMIZER_DEBUG is set

2016-02-29 Thread salvador fandino
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O0 -DOPTIMIZER_DEBUG -I../../../../src/include -D_GNU_SOURCE -c -o allpaths.o allpaths.c allpaths.c

Re: [HACKERS][REVIEW]: Password identifiers, protocol aging and SCRAM protocol

2016-02-29 Thread Valery Popov
Hi, Michael 23.02.2016 10:17, Michael Paquier пишет: Attached is a set of patches implementing a couple of things that have been discussed, so let's roll in. Those 4 patches are aimed at putting in-core basics for the concept I call password protocol aging, which is a way to allow multiple pa

Re: [HACKERS] Proposal: "Causal reads" mode for load balancing reads without stale data

2016-02-29 Thread Michael Paquier
On Mon, Feb 29, 2016 at 6:05 PM, Thomas Munro wrote: > "All changes made by the transaction become visible to others ..." -- > which others? But I backed out, that succinct account of COMMIT is 20 > years old, and in any case visibility is tied to committing, not > specifically to the COMMIT comm

[HACKERS] Confusing with commit time usage in logical decoding

2016-02-29 Thread Artur Zakirov
Hello, I read this message http://www.postgresql.org/message-id/56d4197e.9050...@informatik.uni-kl.de Is this a bug or a typo? In DecodeCommit() in decode.c instead of: if (parsed->xinfo & XACT_XINFO_HAS_ORIGIN) { origin_lsn = parsed->origin_lsn; commit_time = parsed->origin_t

Re: [HACKERS] Support for N synchronous standby servers - take 2

2016-02-29 Thread Kyotaro HORIGUCHI
Sorry, I misread the previous patch. It actually worked. At Sun, 28 Feb 2016 04:04:37 +0900, Masahiko Sawada wrote in > The changes from previous version are, > - Fix parser, lexer bugs. > - Add regression test patch based on patch Suraji submitted. Thank you for the new patch. The parser alm

Re: [HACKERS] Relation extension scalability

2016-02-29 Thread Dilip Kumar
On Wed, Feb 10, 2016 at 7:06 PM, Dilip Kumar wrote: > I have tested Relation extension patch from various aspects and performance results and other statistical data are explained in the mail. Test 1: Identify the Heavy Weight lock is the Problem or the Actual Context Switch 1. I converted the Re

[HACKERS] A trivial fix on extensiblenode

2016-02-29 Thread Kouhei Kaigai
Hello, RegisterExtensibleNodeMethods() initializes its hash table with keysize=NAMEDATALEN, instead of EXTNODENAME_MAX_LEN. The attached patch fixes it. Thanks, -- NEC Business Creation Division / PG-Strom Project KaiGai Kohei pgsql-v9.6-trivial-fix-extensiblenode.patch Description: pgsql-v

Re: [HACKERS] Proposal: "Causal reads" mode for load balancing reads without stale data

2016-02-29 Thread Thomas Munro
On Mon, Feb 29, 2016 at 9:05 PM, Amit Langote wrote: > > Hi Thomas, > > On 2016/02/29 15:20, Thomas Munro wrote: >> Thanks for looking at the patch! Here is a new version with the >> following changes: >> >> 1. Some draft user documentation has been added, as requested. > > Just to clarify, in:

Re: [HACKERS] Proposal: "Causal reads" mode for load balancing reads without stale data

2016-02-29 Thread Amit Langote
Hi Thomas, On 2016/02/29 15:20, Thomas Munro wrote: > Thanks for looking at the patch! Here is a new version with the > following changes: > > 1. Some draft user documentation has been added, as requested. Just to clarify, in: + servers. A transaction that is run with causal_reads s