Re: [HACKERS] multivariate statistics v14

2016-03-18 Thread Tomas Vondra
Hi, On 03/16/2016 03:58 AM, Tatsuo Ishii wrote: I apology if it's already discussed. I am new to this patch. Attached is v15 of the patch series, fixing this and also doing quite a few additional improvements: * added some basic examples into the SGML documentation * addressing the

Re: [HACKERS] Proposal: BSD Authentication support

2016-03-18 Thread Marisa Emerson
>Our usual wording is "the PostgreSQL user account". Perhaps we should >be more explicit about the fact that membership of this Unix group is >needed on *OpenBSD*, since other current or future BSD forks could >vary. I see that the specific reason this is needed on this OpenBSD >5.8 box is so

Re: [HACKERS] Parallel Aggregate

2016-03-18 Thread David Rowley
On 18 March 2016 at 01:22, Amit Kapila wrote: > On Thu, Mar 17, 2016 at 10:35 AM, David Rowley > wrote: >> >> On 17 March 2016 at 01:19, Amit Kapila wrote: >> > Few assorted comments: >> > >> > 2. >> > AggPath * >>

Re: [HACKERS] Odd system-column handling in postgres_fdw join pushdown patch

2016-03-18 Thread Ashutosh Bapat
(2) when any of >> xmins, xmaxs, cmins, and cmaxs are requested, postgres_fdw gives up >> pushing down foreign joins. (We might be able to set appropriate >> values >> for them locally the same way as for tableoids, but I'm not sure it's >> worth complicating the code.) I

Re: [HACKERS] Small patch: fix comments in contrib/pg_trgm/

2016-03-18 Thread Aleksander Alekseev
Here are a few more patches. On Wed, 16 Mar 2016 18:11:04 +0300 Aleksander Alekseev wrote: > Typos for the most part. > -- Best regards, Aleksander Alekseev http://eax.me/ diff --git a/src/backend/utils/adt/timestamp.c b/src/backend/utils/adt/timestamp.c index

Re: [HACKERS] Make primnodes.h gender neutral

2016-03-18 Thread Peter Geoghegan
On Thu, Mar 17, 2016 at 4:46 PM, Tom Lane wrote: > Alvaro's original complaint that the sentences no longer agree as to > person is on-point. That's reasonable. Still, there are only a few existing instances of gendered pronouns in the code, so fixing them carefully, without

Re: [HACKERS] Logical decoding slots can go backwards when used from SQL, docs are wrong

2016-03-18 Thread Craig Ringer
The first patch was incorrectly created on top of failover slots not HEAD. Attached patch applies on HEAD. From 87d839f8a2e78abb17fa985502fd5b66f0872b57 Mon Sep 17 00:00:00 2001 From: Craig Ringer Date: Wed, 16 Mar 2016 15:45:16 +0800 Subject: [PATCH 1/2] Correct incorrect

Re: [HACKERS] 2016-03 Commitfest

2016-03-18 Thread Andreas Karlsson
Hi, The COPY RAW patch seems to have two entries in the commitfest. https://commitfest.postgresql.org/9/223/ and https://commitfest.postgresql.org/9/547/ Are those about the same patch? Andreas -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] logger process infinite loop

2016-03-18 Thread Andres Freund
Hi, On 2016-03-18 21:59:01 -0700, Jeff Janes wrote: > While testing some patches on my laptop, I noticed my knee getting > uncomfortably warm. It turns out I has accumulating deranged logging > processes, needing kill -9 to get rid of them. > > The culprit is: > > commit

Re: [HACKERS] fd.c doesn't remove files on a crash-restart

2016-03-18 Thread Joshua D. Drake
On 03/16/2016 11:05 AM, Tom Lane wrote: "Joshua D. Drake" writes: Hello, fd.c[1] will remove files from pgsql_tmp on a restart but not a crash-restart per this comment: /* * NOTE: we could, but don't, call this during a post-backend-crash restart * cycle. The

Re: [HACKERS] fd.c doesn't remove files on a crash-restart

2016-03-18 Thread Tom Lane
Robert Haas writes: > On Wed, Mar 16, 2016 at 2:05 PM, Tom Lane wrote: >> Possible compromise: remove files only in non-Assert builds? > That sorta seems like tying two things together that aren't obviously > related. I think building with

Re: [HACKERS] GinPageIs* don't actually return a boolean

2016-03-18 Thread Yury Zhuravlev
Robert Haas wrote: On Wed, Mar 2, 2016 at 9:48 PM, Peter Eisentraut wrote: On 2/11/16 9:30 PM, Michael Paquier wrote: ... We need to decide what to do about this. I disagree with Peter: I think that regardless of stdbool, what we've got right now is sloppy coding - bad

[HACKERS] Re: Add generate_series(date,date) and generate_series(date,date,integer)

2016-03-18 Thread David Steele
On 3/10/16 1:24 PM, Corey Huinker wrote: New patch for Alvaro's consideration. Very minor changes since the last time, the explanations below are literally longer than the changes: - Rebased, though I don't think any of the files had changed in the mean time - Removed

Re: [HACKERS] silent data loss with ext4 / all current versions

2016-03-18 Thread Robert Haas
On Thu, Mar 17, 2016 at 11:03 AM, Andres Freund wrote: > On 2016-03-17 23:05:42 +0900, Michael Paquier wrote: >> > Are you working on a fix for pg_rewind? Let's go with initdb -S in a >> > first iteration, then we can, if somebody is interest enough, work on >> > making this

Re: [HACKERS] POC, WIP: OR-clause support for indexes

2016-03-18 Thread Teodor Sigaev
I also wonder whether the patch should add explanation of OR-clauses handling into the READMEs in src/backend/access/* Oops, will add shortly. The patch would probably benefit from transforming it into a patch series - one patch for the infrastructure shared by all the indexes, then one

Re: [HACKERS] GinPageIs* don't actually return a boolean

2016-03-18 Thread Tom Lane
Michael Paquier writes: > FWIW, when compiling with MS 2015 using the set of perl scripts I am > not seeing this compilation error... We may want to understand first > what kind of dependency is involved when doing the cmake build > compared to what is done with

Re: [HACKERS] insufficient qualification of some objects in dump files

2016-03-18 Thread Michael Paquier
On Fri, Mar 18, 2016 at 5:38 AM, Tom Lane wrote: > Given the lack of any other complaints about this, I'm okay with the > approach as presented. (I haven't read the patch in detail, though.) FWIW, I am still of the opinion that the last patch sent by Peter is in a pretty

Re: [HACKERS] proposal: function parse_ident

2016-03-18 Thread Pavel Stehule
Hi 2016-03-14 17:39 GMT+01:00 Teodor Sigaev : > I afraid so I cannot to fix this inconsistency (if this is inconsistency - >> the >> binary values are same) - the parameter of function is raw string with >> processed >> escape codes, and I have not any information about

Re: [HACKERS] Performance degradation in commit ac1d794

2016-03-18 Thread Robert Haas
On Thu, Mar 17, 2016 at 11:17 AM, Andres Freund wrote: > Right now, do use a WaitEventSet you'd do something like > WaitEvent event; > > ModifyWaitEvent(FeBeWaitSet, 0, waitfor, NULL); > > WaitEventSetWait(FeBeWaitSet, 0 /* no

Re: [HACKERS] Choosing parallel_degree

2016-03-18 Thread Julien Rouhaud
On 16/03/2016 18:42, Robert Haas wrote: > On Wed, Mar 16, 2016 at 1:23 PM, Julien Rouhaud > wrote: >> On 16/03/2016 17:55, Robert Haas wrote: >>> On Wed, Mar 16, 2016 at 12:47 PM, Julien Rouhaud >>> wrote: Something like a

Re: [HACKERS] Patch: Implement failover on libpq connect level.

2016-03-18 Thread David Steele
On 3/10/16 7:34 AM, Simon Riggs wrote: On 9 March 2016 at 23:11, David Steele > wrote: There hasn't been any movement on this patch in a while. Will you have a new tests ready for review soon? I see the value in this feature, but the

Re: [HACKERS] [PATH] Jsonb, insert a new value into an array at arbitrary position

2016-03-18 Thread Dmitry Dolgov
Hi Vitaly, thanks for the review. I've attached a new version of path with improvements. Few notes: > 7. Why did you remove "skip"? It is a comment what "true" means... Actually, I thought that this comment was about skipping an element from jsonb in order to change/delete it, not about the last

Re: [HACKERS] Make primnodes.h gender neutral

2016-03-18 Thread Kevin Grittner
On Thu, Mar 17, 2016 at 6:07 PM, Tom Lane wrote: > Chapman Flack writes: >> On 03/17/16 17:29, Kevin Grittner wrote: >>> A grep with a quick skim of the results to exclude references to >>> particular people who are mentioned by name and then referred

Re: [HACKERS] [PATCH] Integer overflow in timestamp[tz]_part() and date/time boundaries check

2016-03-18 Thread Tom Lane
Vitaly Burovoy writes: > Is there any reason to leave JULIAN_MINDAY and JULIAN_MAXDAY which are > not used now? Those are just there to document what the limits really are. Possibly some code would need them in future. > Also why JULIAN_MAXMONTH is set to "6" whereas

Re: [HACKERS] Typo in monitoring.sgml

2016-03-18 Thread Robert Haas
On Wed, Mar 16, 2016 at 1:38 AM, Amit Langote wrote: > Attached fixes a minor typo as follows: > > s/index vacuums cycles/index vacuum cycles/g > Committed, thanks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2016-03-18 Thread Haribabu Kommi
On Thu, Mar 17, 2016 at 6:56 PM, Shulgin, Oleksandr wrote: > On Thu, Mar 17, 2016 at 2:12 AM, Haribabu Kommi > wrote: >> >> On Wed, Mar 16, 2016 at 9:49 PM, Shulgin, Oleksandr >> wrote: >> > >> > Some

[HACKERS] logger process infinite loop

2016-03-18 Thread Jeff Janes
While testing some patches on my laptop, I noticed my knee getting uncomfortably warm. It turns out I has accumulating deranged logging processes, needing kill -9 to get rid of them. The culprit is: commit c4901a1e03a7730e4471fd1143f1caf79695493d Author: Andres Freund Date:

Re: [HACKERS] WIP: Covering + unique indexes.

2016-03-18 Thread Peter Geoghegan
On Fri, Mar 18, 2016 at 5:15 AM, David Steele wrote: > It looks like this patch should be marked "needs review" and I have done so. Uh, no it shouldn't. I've posted an extensive review on the original design thread. See CF entry: https://commitfest.postgresql.org/9/433/

Re: [HACKERS] Speedup twophase transactions

2016-03-18 Thread Stas Kelvich
> On 11 Mar 2016, at 19:41, Jesper Pedersen wrote: > Thanks for review, Jesper. > Some comments: > > * The patch needs a rebase against the latest TwoPhaseFileHeader change Done. > * Rework the check.sh script into a TAP test case (src/test/recovery), as >

Re: [HACKERS] POC, WIP: OR-clause support for indexes

2016-03-18 Thread Andreas Karlsson
I gave this patch a quick spin and noticed a strange query plan. CREATE TABLE test (a int, b int, c int); CREATE INDEX ON test USING gin (a, b, c); INSERT INTO test SELECT i % 7, i % 9, i % 11 FROM generate_series(1, 100) i; EXPLAIN ANALYZE SELECT * FROM test WHERE (a = 3 OR b = 5) AND c =

Re: [HACKERS] [WIP] speeding up GIN build with parallel workers

2016-03-18 Thread Dmitry Ivanov
Hi Constantin, I did a quick review of your patch, and here are my comments: - This patch applies cleanly to the current HEAD (61d2ebdbf91). - Code compiles without warnings. - Currently there's no documentation regarding parallel gin build feature and provided GUC variables. - Built indexes

Re: [HACKERS] Idle In Transaction Session Timeout, revived

2016-03-18 Thread Jeff Janes
On Wed, Mar 16, 2016 at 8:32 AM, Robert Haas wrote: > > Committed with slight changes to the docs, and I added a flag variable > instead of relying on IdleInTransactionSessionTimeout not changing at > an inopportune time. Thanks for committing, this should be a useful

Re: [HACKERS] Make primnodes.h gender neutral

2016-03-18 Thread Tom Lane
Peter Geoghegan writes: > (In case it matters, I'm in favor of this proposal on its merits). For the record, I'm also in favor of fixing that para, but I'd like to see attention paid to grammatical correctness as well as political. Alvaro's original complaint that the sentences

Re: [HACKERS] Using quicksort for every external sort run

2016-03-18 Thread Robert Haas
On Wed, Mar 16, 2016 at 9:42 PM, Peter Geoghegan wrote: >> - I haven't yet figured out why we use batching only for the final >> on-the-fly merge pass, instead of doing it for all merges. I expect >> you have a reason. I just don't know what it is. > > The most obvious reason,

Re: [HACKERS] plpgsql - DECLARE - cannot to use %TYPE or %ROWTYPE for composite types

2016-03-18 Thread Pavel Stehule
2016-03-16 16:50 GMT+01:00 Pavel Stehule : > > > 2016-03-16 16:46 GMT+01:00 Joe Conway : > >> On 03/15/2016 05:17 PM, Tom Lane wrote: >> > In short, I think we should reject this implementation and instead try >> > to implement the type operators we

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-03-18 Thread Craig Ringer
On 17 March 2016 at 19:08, Artur Zakirov wrote: > On 16.03.2016 18:56, David Steele wrote: > >> >> This patch applies cleanly and is ready for review with no outstanding >> issues that I can see. Simon and Artur, you are both signed up as >> reviewers. Care to take a

[HACKERS] typmod is always -1

2016-03-18 Thread Chapman Flack
nothing like resurrecting a really old thread ... > Pavel Stehule writes: >> I have a problem - every call of mvarcharin is with typmod = -1. 2009/3/17 Tom Lane : > Also, there are a bunch of scenarios where we rely on a cast

Re: [HACKERS] WIP: Access method extendability

2016-03-18 Thread Teodor Sigaev
Good catch, thanks! Tests were added. I don't see any objection, is consensus reached? I'm close to comiit that... -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via

Re: [HACKERS] plpgsql - DECLARE - cannot to use %TYPE or %ROWTYPE for composite types

2016-03-18 Thread Joe Conway
On 03/15/2016 05:17 PM, Tom Lane wrote: > In short, I think we should reject this implementation and instead try > to implement the type operators we want in the core grammar's Typename > production, from which plpgsql will pick it up automatically. That is > going to require some other syntax

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-03-18 Thread Artur Zakirov
On 16.03.2016 18:56, David Steele wrote: This patch applies cleanly and is ready for review with no outstanding issues that I can see. Simon and Artur, you are both signed up as reviewers. Care to take a crack at it? Thanks, I have tested the patch once again and have looked the code. It

Re: [HACKERS] oldest xmin is far in the past

2016-03-18 Thread Tomas Vondra
Hi, On 03/18/2016 09:42 AM, John Snow wrote: Hi everyone! Trying to make VACUUM FREEZE on PG instance and keep getting this error: 2016-03-18 05:56:51 UTC 46750 WARNING: oldest xmin is far in the past 2016-03-18 05:56:51 UTC 46750 HINT: Close open transactions soon to avoid wraparound

Re: [HACKERS] pg_dump / copy bugs with "big lines" ?

2016-03-18 Thread Alvaro Herrera
Daniel Verite wrote: > To go past that problem, I've tried tweaking the StringInfoData > used for COPY FROM, like the original patch does in CopyOneRowTo. > > It turns out that it fails a bit later when trying to make a tuple > from the big line, in heap_form_tuple(): > > tuple = (HeapTuple)

Re: [HACKERS] Patch: fix lock contention for HASHHDR.mutex

2016-03-18 Thread Amit Kapila
On Sat, Mar 19, 2016 at 1:41 AM, Robert Haas wrote: > > On Tue, Mar 1, 2016 at 9:43 AM, Aleksander Alekseev > wrote: > > > > So answering your question - it turned out that we _can't_ reduce > > NUM_FREELISTS this way. > > That's perplexing. I

Re: [HACKERS] Fuzzy substring searching with the pg_trgm extension

2016-03-18 Thread Artur Zakirov
2016-03-18 23:46 GMT+03:00 Jeff Janes : > > > <% and <<-> are not documented at all. Is that a deliberate choice? > Since they were added as convenience functions for the user, I think > they really need to be in the user documentation. > I can send a patch a little bit

Re: [HACKERS] Performance degradation in commit ac1d794

2016-03-18 Thread Andres Freund
On 2016-03-18 15:49:51 -0300, Alvaro Herrera wrote: > This seems a reasonable change, but I think that the use of WIN32 vs. > LATCH_USE_WIN32 is pretty confusing. In particular, LATCH_USE_WIN32 > isn't actually used for anything ... I suppose we don't care since this > is a temporary state of

[HACKERS] flex: where's THIS been all this time?

2016-03-18 Thread Tom Lane
For years upon years, we have endured the ugly hack of compiling flex-generated lexers as part of some other .c file, because of the problem explained thus in, eg, psql/mainloop.c: /* * psqlscan.c is #include'd here instead of being compiled on its own. * This is because we need postgres_fe.h

Re: [HACKERS] Re: PATCH: Split stats file per database WAS: autovacuum stress-testing our system

2016-03-18 Thread Tomas Vondra
Hi, On 03/15/2016 03:04 AM, Noah Misch wrote: On Mon, Mar 14, 2016 at 01:33:08PM +0100, Tomas Vondra wrote: On 03/14/2016 07:14 AM, Noah Misch wrote: On Mon, Mar 14, 2016 at 02:00:03AM +0100, Tomas Vondra wrote: +* XXX Maybe this should also care about the clock skew, just like the +

Re: [HACKERS] Fuzzy substring searching with the pg_trgm extension

2016-03-18 Thread Jeff Janes
On Mon, Mar 14, 2016 at 9:27 AM, Artur Zakirov wrote: > On 14.03.2016 18:48, David Steele wrote: >> >> Hi Jeff, >> >> On 2/25/16 5:00 PM, Jeff Janes wrote: >> >>> But, It doesn't sound like I am going to win that debate. Given that, >>> I don't think we need a different

Re: [HACKERS] Publish autovacuum informations

2016-03-18 Thread Jim Nasby
On 3/3/16 3:54 AM, Kyotaro HORIGUCHI wrote: I wonder why there haven't been discussions so far on what kind of information we want by this feature. For example I'd be happy to see the time of last autovacuum trial and the cause if it has been skipped for every table. Such information would

Re: [HACKERS] Weighted Stats

2016-03-18 Thread Jeff Janes
On Tue, Mar 15, 2016 at 8:36 AM, David Fetter wrote: > > Please find attached a patch that uses the float8 version to cover the > numeric types. Is there a well-defined meaning for having a negative weight? If no, should it be disallowed? I don't know what I was expecting,

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2016-03-18 Thread Robert Haas
On Thu, Mar 17, 2016 at 9:22 PM, Michael Paquier wrote: > FWIW, my instinctive thought on the matter is to report the event > directly in WaitLatch() via a name of the event caller provided > directly in it. The category of the event is then defined > automatically as

Re: [HACKERS] Odd system-column handling in postgres_fdw join pushdown patch

2016-03-18 Thread Etsuro Fujita
On 2016/03/17 22:15, Ashutosh Bapat wrote: On Thu, Mar 17, 2016 at 4:30 PM, Etsuro Fujita > wrote: BUT: we don't make any effort to ensure that local and remote values match, so system columns other than ctid and oid

Re: [HACKERS] Parallel Aggregate

2016-03-18 Thread David Rowley
On 19 March 2016 at 05:46, Robert Haas wrote: > On Wed, Mar 16, 2016 at 5:05 PM, David Rowley > wrote: >>> Cool! Why not initialize aggpartialtype always? >> >> Because the follow-on patch sets that to either the serialtype or the >>

[HACKERS] postgresql 9.4 on AIX 7.1

2016-03-18 Thread Lizeth Solis Aramayo
Hello, Please I want to install the software mentioned Up (postgresql 9.4 on AIX 7.1 - 8.0 ). Do you think that I could do this? Thanks a lot, I am from Bolivia, south America. [dos] La informaci?n contenida en este mensaje esta dirigida en forma exclusiva para el uso personal y

Re: [HACKERS] Using quicksort for every external sort run

2016-03-18 Thread Peter Geoghegan
On Thu, Mar 17, 2016 at 1:13 PM, Robert Haas wrote: > OK, I have now committed 0001, and separately, some comment > improvements - or at least, I think they are improvements - based on > this discussion. Thanks! Your changes look good to me. It's always interesting to

Re: [HACKERS] WIP: Upper planner pathification

2016-03-18 Thread Tom Lane
Robert Haas writes: > On Wed, Mar 16, 2016 at 2:47 PM, Tom Lane wrote: >> Robert Haas writes: >>> On Mon, Mar 14, 2016 at 9:21 PM, Kouhei Kaigai wrote: So, even though we don't need to define multiple

Re: [HACKERS] Proposal: BSD Authentication support

2016-03-18 Thread Marisa Emerson 
On 18/03/16 03:57, Thomas Munro wrote:

You used one name in the docs and another in the code:

+BSD Authentication on PostgreSQL uses the

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-03-18 Thread David Steele
On 3/16/16 9:00 AM, Michael Paquier wrote: > On Tue, Mar 15, 2016 at 6:38 PM, David Steele wrote: > >> 1) I see that rolvaliduntil is still in pg_authid: >> I think that's OK if we now define it to be "role validity" (it's still >> password validity in the patched docs). I

Re: [HACKERS] IF (NOT) EXISTS in psql-completion

2016-03-18 Thread Pavel Stehule
Hi 2016-03-16 5:01 GMT+01:00 Kyotaro HORIGUCHI : > Hello, > > # It seems that I have been forgotten in the recepient list.. > > At Tue, 15 Mar 2016 22:09:59 -0400, Peter Eisentraut > wrote in <56e8c077.2000...@gmx.net> > > On 2/5/16 3:09 AM,

Re: [HACKERS] Relation extension scalability

2016-03-18 Thread Petr Jelinek
On 17/03/16 04:42, Dilip Kumar wrote: On Mon, Mar 14, 2016 at 8:26 AM, Petr Jelinek > wrote: Well any value we choose will be very arbitrary. If we look at it from the point of maximum absolute disk space we allocate for relation

Re: [HACKERS] Re: Add generate_series(date,date) and generate_series(date,date,integer)

2016-03-18 Thread Tom Lane
David Steele writes: > On 3/17/16 11:30 AM, David G. Johnston wrote: >> ​I'd call it "generate_dates(...)" and be done with it. >> We would then have: >> generate_series() >> generate_subscripts() >> generate_dates() > To me this completely negates the idea of this "just

Re: [HACKERS] Re: Add generate_series(date,date) and generate_series(date,date,integer)

2016-03-18 Thread David G. Johnston
On Thu, Mar 17, 2016 at 8:41 AM, David Steele wrote: > On 3/17/16 11:30 AM, David G. Johnston wrote: > > On Thu, Mar 17, 2016 at 7:57 AM, Corey Huinker > >wrote: > > > > On Thu, Mar 17, 2016 at 10:00 AM, David

Re: [HACKERS] Proposal: Generic WAL logical messages

2016-03-18 Thread David Steele
On 3/9/16 6:58 PM, Petr Jelinek wrote: > On 08/03/16 21:21, Artur Zakirov wrote: >> I think here >> >>> +const char * >>> +logicalmsg_identify(uint8 info) >>> +{ >>> +if (info & ~XLR_INFO_MASK == XLOG_LOGICAL_MESSAGE) >>> +return "MESSAGE"; >>> + >>> +return NULL; >>> +} >> >> we

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-03-18 Thread Robert Haas
On Fri, Mar 18, 2016 at 9:31 AM, Michael Paquier wrote: > That's not an issue for me to rebase this set of patches. The only > conflicts that I anticipate are on 0009, but I don't have high hopes > to get this portion integrating into core for 9.6, the rest of the >

Re: [HACKERS] POC: Cache data in GetSnapshotData()

2016-03-18 Thread Mithun Cy
On Thu, Mar 17, 2016 at 9:00 AM, Amit Kapila wrote: >If you see, for the Base readings, there is a performance increase up till 64 clients and then there is a fall at 88 clients, which to me >indicates that it hits very high-contention around CLogControlLock at 88 clients

Re: [HACKERS] Relaxing SSL key permission checks

2016-03-18 Thread Christoph Berg
Re: Peter Eisentraut 2016-03-16 <56e8c221.1050...@gmx.net> > >> * it failed to check for S_IXUSR, so permissions 0700 were okay, in > >> contradiction with what the error message indicates. This is a > >> preexisting bug actually. Do we want to fix it by preventing a > >> user-executable file

Re: [HACKERS] [PATCH] we have added support for box type in SP-GiST index

2016-03-18 Thread Teodor Sigaev
Do reconstructedValues is required now? Wouldn't it be cleaner to use the new field on the prefix tree implementation, too? reconstructedValues is needed to reconctruct full indexed value and should match to type info indexed column We haven't had specific memory context for

Re: [HACKERS] WIP: Upper planner pathification

2016-03-18 Thread Kouhei Kaigai
> -Original Message- > From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Tom Lane > Sent: Friday, March 18, 2016 11:44 PM > To: Kaigai Kouhei(海外 浩平) > Cc: Robert Haas; Petr Jelinek; David Rowley; pgsql-hackers@postgresql.org > Subject: Re:

Re: [HACKERS] [WIP] speeding up GIN build with parallel workers

2016-03-18 Thread Robert Haas
On Thu, Mar 17, 2016 at 11:42 PM, Amit Kapila wrote: > I think here the comparison should be between the case of (active backend + > 1 worker) with (passive backend + 1 worker) or (active backend + 2 worker) > with (passive backend + 2 workers). I don't think it is good

[HACKERS] incorrect docs for pgbench / skipped transactions

2016-03-18 Thread Tomas Vondra
Hi, while learning about format of the transaction log produced by pgbench, I've noticed this sentence in the section describing format of the per-transaction log: The last field skipped_transactions reports the number of transactions skipped because they were too far behind schedule.

Re: [HACKERS] GinPageIs* don't actually return a boolean

2016-03-18 Thread Yury Zhuravlev
Michael Paquier wrote: FWIW, when compiling with MS 2015 using the set of perl scripts I am not seeing this compilation error... This error not in build stage but in GIN regresion tests. CMake nothing to do with. -- Yury Zhuravlev Postgres Professional: http://www.postgrespro.com The

Re: [HACKERS] Choosing parallel_degree

2016-03-18 Thread Julien Rouhaud
On 18/03/2016 00:56, Tom Lane wrote: > Julien Rouhaud writes: >> Shouldn't we also check "parallel_degree < max_worker_process" ? > >> There's no need to compute any further than that. I think the best fix >> would be to add a CheckHook or AssignHook on

Re: [HACKERS] [PATCH] we have added support for box type in SP-GiST index

2016-03-18 Thread Emre Hasegeli
Here are my first comments. I haven't read the actual index implementation, yet. I think traversal value is a useful addition. It is nice that the implementation for the range types is also changed. My questions about them are: Do reconstructedValues is required now? Wouldn't it be cleaner

Re: [HACKERS] Small patch: fix comments in contrib/pg_trgm/

2016-03-18 Thread Robert Haas
On Thu, Mar 17, 2016 at 5:38 AM, Aleksander Alekseev wrote: > Here are a few more patches. OK, I committed all three of these, minus some parts of 02-guc-c-typos.diff, plus the other patch you posted on pgsql-committers. The parts I left out of 02-guc-c-typos.diff

Re: [HACKERS] proposal: function parse_ident

2016-03-18 Thread Teodor Sigaev
I hope so the messages are ok now. Few more regress tests added. Thank you, committed. -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ -- Sent via pgsql-hackers mailing list

Re: [HACKERS] statistics for array types

2016-03-18 Thread David Steele
On 3/9/16 7:42 PM, David Steele wrote: > On 1/18/16 11:24 AM, Alvaro Herrera wrote: >> Alexander Korotkov wrote: >> >>> The patch implementing my idea above is attached. >> What's the status here? Jeff, did you have a look at Alexander's >> version of your patch? Tomas, does this patch satisfy

Re: [HACKERS] Patch: fix lock contention for HASHHDR.mutex

2016-03-18 Thread Robert Haas
On Tue, Mar 1, 2016 at 9:43 AM, Aleksander Alekseev wrote: >> I am not sure, if this is exactly what has been suggested by Robert, >> so it is not straightforward to see if his suggestion can allow us to >> use NUM_FREELISTS as 8 rather than 32. I think instead of

Re: [HACKERS] Parallel Aggregate

2016-03-18 Thread David Rowley
On 19 March 2016 at 09:53, Alvaro Herrera wrote: > I read this a bit, as an exercise to try to follow parallel query a bit. Thanks for taking a look at this. > I think the most interesting thing I have to say is that the new error > messages in ExecInitExpr do not