On 7 November 2016 at 05:08, Stefan Scheid wrote:
> Hi all,
>
> are there plans to introduce temporal tables?
>
> I don't know of anybody working on them, but someone else may. Try
searching the list archives.
PostgreSQL development happens because people who want features step up and
either imp
Hi Jaime,
On 2016/11/08 2:15, Jaime Casanova wrote:
> On 28 October 2016 at 02:53, Amit Langote
> wrote:
>
> I started to review the functionality of this patch, so i applied all
> 9 patches. After that i found this warning, which i guess is because
> it needs a cast.
Thanks a ton for reviewi
From: Michael Paquier [mailto:michael.paqu...@gmail.com]
> I just looked more deeply at your refactoring patch, and I didn't know about
> CheckTokenMembership()... The whole logic of your patch depends on it.
> That's quite a cleanup that you have here. It looks that the former
> implementation jus
On Tue, Nov 8, 2016 at 2:33 PM, Kuntal Ghosh wrote:
> Either the comment is wrongly written or the check for overflow
> condition has to be fixed. Assuming the overflow check condition to be
> erroneous, I've attached a patch to fix this.
Good catch. Interesting copy-pasto from 88e9823.
--
Micha
On Tue, Nov 8, 2016 at 2:25 PM, Tsunakawa, Takayuki
wrote:
> From: pgsql-hackers-ow...@postgresql.org
>> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier
>> Things are this way since b15f9b08 that introduced pgwin32_is_service().
>> Still, by considering what you say, you d
On Tue, Nov 1, 2016 at 8:31 PM, Kyotaro HORIGUCHI
wrote:
> Could you let me struggle a bit more to avoid LWLocks in
> GetProgressRecPtr?
Be my guest :)
> I considered two alternatives for updating logic of progressAt
> more seriously. One is, as Amit suggested, replacing progressAt
> within the
Hi all,
Although we restrict the WAL segment size to 64 MB as upper limit, the
following piece of code in guc.c (line 715) seems confusing to me.
#if XLOG_SEG_SIZE < (1024*1024) || XLOG_BLCKSZ > (1024*1024*1024)
#error XLOG_SEG_SIZE must be between 1MB and 1GB
#endif
Either the comment is wrongl
From: pgsql-hackers-ow...@postgresql.org
> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier
> Things are this way since b15f9b08 that introduced pgwin32_is_service().
> Still, by considering what you say, you definitely have a point that if
> postgres is started by another s
On Tue, Nov 8, 2016 at 1:36 PM, Tsunakawa, Takayuki
wrote:
> From: pgsql-hackers-ow...@postgresql.org
>> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier
>> Hm... See here:
>> http://stackoverflow.com/questions/6084547/how-to-check-whether-a-proc
>> ess-is-running-as-a-wind
Hi hackers
Here is an experimental WIP patch to allow SERIALIZABLE READ ONLY
DEFERRABLE transactions on standby servers without serialisation
anomalies, based loosely on an old email from Kevin Grittner[1]. I'm
not sure how far this is from what he had in mind or whether I've
misunderstood someth
On Wed, Nov 2, 2016 at 12:48 PM, Ashutosh Sharma wrote:
> Hi,
>
> I have started with the review for this patch and would like to share
> some of my initial review comments that requires author's attention.
>
Thanks.
> 1) I am getting some trailing whitespace errors when trying to apply
> this p
From: pgsql-hackers-ow...@postgresql.org
> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier
> Hm... See here:
> http://stackoverflow.com/questions/6084547/how-to-check-whether-a-proc
> ess-is-running-as-a-windows-service
> And particularly this quote:
> "No, that is not reli
On Mon, Oct 24, 2016 at 6:17 PM, Peter Geoghegan wrote:
>> * Cost model. Should probably attempt to guess final index size, and
>> derive calculation of number of workers from that. Also, I'm concerned
>> that I haven't given enough thought to the low end, where with default
>> settings most CREAT
Hi Jaime,
On 2016/11/08 2:24, Jaime Casanova wrote:
> On 7 November 2016 at 12:15, Jaime Casanova
> wrote:
>> On 28 October 2016 at 02:53, Amit Langote
>> wrote:
>>>
>>> Please find attached the latest version of the patches
>>
>> Hi,
>>
>> I started to review the functionality of this patch,
On Tue, Nov 8, 2016 at 7:39 AM, Jim Nasby wrote:
> On 8/31/16 2:57 AM, Michael Paquier wrote:
> Seems like a good idea, I'm guessing it slipped through the cracks. Do you
> want to add it to the next CF?
0001 has been pushed as d062245b.
> Why mark one as volatile but not the other? Based on [1]
Thanks for the patch. This shows a very good performance improvement.
I started reviewing the patch, during this process and I ran the regression
test on the WARM patch. I observed a failure in create_index test.
This may be a bug in code or expected that needs to be corrected.
Regards,
Hari Babu
On 11/6/16 12:15 PM, Tom Lane wrote:
I wrote:
I got the code to a state that I liked (attached), and started reviewing
the docs, and then it occurred to me to wonder why you'd chosen to use
Tcl lists to represent composite output values. The precedent established
by input argument handling is t
On 8/31/16 2:57 AM, Michael Paquier wrote:
Hi all,
Cleanup $subject has been raised a couple of times, like one year ago here:
https://www.postgresql.org/message-id/cab7npqrxvq+q66ufzd9wa5uaftyn4wauadbjxkfrync96kf...@mail.gmail.com
And more recently here while working on the NULL checks for mall
On 11/4/16 4:28 PM, Tom Lane wrote:
My proposal therefore is for SPI_fnumber to ignore (not match to)
dropped columns, and to remove any caller-side attisdropped tests that
thereby become redundant.
Yeah, SPI users certainly shouldn't need to worry about attisdropped,
and exposing attnum doesn
On Tue, Nov 8, 2016 at 12:16 PM, Tsunakawa, Takayuki
wrote:
> From: pgsql-hackers-ow...@postgresql.org
>> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier
>> https://msdn.microsoft.com/ja-jp/library/windows/desktop/ms684190(v=vs
>> > .85).aspx
>>
>> That's what I looked at
From: pgsql-hackers-ow...@postgresql.org
> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier
> https://msdn.microsoft.com/ja-jp/library/windows/desktop/ms684190(v=vs
> > .85).aspx
>
> That's what I looked at as well :) And this part is what caught my attention,
> meaning tha
On 8 November 2016 at 07:41, Clifford Hammerschmidt
wrote:
> Hi Craig,
>
> Thanks for the pointers; I made a stab at it in:
> https://github.com/tanglebones/pg_tuid
>
> I've no idea if the shmem and lwlock code is correct, or how to test it. It
> seems to work (requires loading via the shared_prel
On Tue, Nov 8, 2016 at 5:12 AM, Jeff Janes wrote:
> On Mon, Nov 7, 2016 at 5:55 AM, Amit Kapila wrote:
>>
>> On Tue, Sep 20, 2016 at 8:15 AM, Tsunakawa, Takayuki
>> wrote:
>> > I ran read-only and read-write modes of pgbench, and could not see any
>> > apparent decrease in performance when I inc
On Tue, Nov 8, 2016 at 11:36 AM, Tsunakawa, Takayuki
wrote:
> SECURITY_SERVICE_RID
> Accounts authorized to log on as a service. This is a group identifier added
> to the token of a process when it was logged as a service. The corresponding
> logon type is LOGON32_LOGON_SERVICE.
>
> I saw descri
From: pgsql-hackers-ow...@postgresql.org
> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier
> Meh. Local System accounts are used only by services (see comments of
> pgwin32_is_service), so I'd expect pgwin32_is_service() to return true in
> this case, contrary to what your
Hello,
At Sat, 5 Nov 2016 21:18:42 +0900, Michael Paquier
wrote in
> > I don't see any problem on the state-transition of
> > exclusiveBackupState. For the following part
> >
> > @@ -10217,7 +10255,7 @@ do_pg_start_backup(const char *backupidstr, bool
> > fast, TimeLineID *starttli_p,
> >
On Tue, Nov 8, 2016 at 10:57 AM, Hao Lee wrote:
> It's a tedious work to figure out these numbers real meaning. for example,
> if i want to know the value of '71' represent what it is. I should go back
> to refer to definition of pg_class struct. It's a tedious work and it's not
> maintainable or
Hello,
At Mon, 7 Nov 2016 17:19:29 +0100, Daniel Gustafsson wrote in
<39e295b9-7391-40b6-911d-fe852e460...@yesql.se>
> > On 07 Nov 2016, at 12:32, Daniel Gustafsson wrote:
> >
> >> On 04 Nov 2016, at 08:34, Kyotaro HORIGUCHI
> >> wrote:
> >>
> >> I'm not sure how the discussion about this g
Hi guys,
Although, usually, we do not change the system catalog or modify the
catalog schema, or adding a new system catalog, but in these system catalog
head files, such as pg_xxx.h, i think we should use more meaningful
variables. As we known, in pg_xxx.h files, we insert some initial values
i
Hello,
At Mon, 7 Nov 2016 12:32:55 +0100, Daniel Gustafsson wrote in
> > On 04 Nov 2016, at 08:34, Kyotaro HORIGUCHI
> > wrote:
> > I'm not sure how the discussion about this goes, these patches
> > makes me think about coding style of Perl.
>
> Some of this can absolutely be considered styl
On Tue, Nov 8, 2016 at 6:47 AM, MauMau wrote:
> As I guessed in the previous mail, both our patches cause
> pgwin32_is_service() to return 1 even when SECURITY_SERVICE_RID is
> disabled, if the service is running as a Local System. The existing
> logic of checking for Local System should be remov
On Wed, Oct 26, 2016 at 7:34 PM, Thomas Munro
wrote:
> Hi hackers,
>
> Here is a new version of my patch to add a replay_lag column to the
> pg_stat_replication view (originally proposed as part of a larger
> patch set for 9.6[1]), like this:
Thank you for working on this!
> postgres=# select ap
On Mon, Nov 7, 2016 at 10:31 PM, MauMau wrote:
> Yes, I tested both your patch and mine. I used the attached pg_ctl.c.
> It adds -z option which disables SECURITY_SERVICE_RID.
Okay, so you did exactly what I did except that you wrapped with an option...
> I guess you registered the service with
On Tue, Nov 8, 2016 at 1:24 AM, Albe Laurenz wrote:
> The patch does not apply, I had to change the hunk for
> src/include/common/file_utils.h.
Yes, the patch has rotten a bit because of f82ec32a. 5d58c07a has also
made the --noxxx option names appearing as --no-xxx.
> Also, compilation fails be
On Tue, Nov 8, 2016 at 12:13 AM, Peter Eisentraut
wrote:
> On 11/5/16 8:03 AM, Michael Paquier wrote:
>> On Sat, Nov 5, 2016 at 9:17 AM, Peter Eisentraut
>> wrote:
>>> > On 11/3/16 7:17 PM, Michael Paquier wrote:
>> This patch not being complicated, so I would vote for those being
>> ad
On Mon, Nov 7, 2016 at 5:55 AM, Amit Kapila wrote:
> On Tue, Sep 20, 2016 at 8:15 AM, Tsunakawa, Takayuki
> wrote:
> > Hello,
> >
> >> From: pgsql-hackers-ow...@postgresql.org
> >> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Magnus
> Hagander
> >> On Wed, Aug 24, 2016 at 4:35 AM, Ts
On Wed, Nov 2, 2016 at 10:45 AM, Oskari Saarenmaa wrote:
> 26.10.2016, 21:34, Andres Freund kirjoitti:
>>
>> Any chance that plsh or the script it executes does anything with the file
>> descriptors it inherits? That'd certainly one way to get into odd corruption
>> issues.
>>
>> We processor real
Le 04/11/2016 à 21:07, Karl O. Pinc a écrit :
> On Fri, 4 Nov 2016 16:58:45 +0100
> Gilles Darold wrote:
>
>> I attached a v12 patch
> Attached is a comment patch which improves the comment
> describing CURRENT_LOG_FILENAME. It's been bugging me.
> I should have made this change long ago when I
Hi, Michael
As I guessed in the previous mail, both our patches cause
pgwin32_is_service() to return 1 even when SECURITY_SERVICE_RID is
disabled, if the service is running as a Local System. The existing
logic of checking for Local System should be removed. The attached
patch fixes this problem
Hi all,
are there plans to introduce temporal tables?
best,
Stefan
Weitergeleitete Nachricht
Betreff:Re: [CORE] temporal tables (SQL2011)
Datum: Fri, 4 Nov 2016 10:27:40 -0400
Von:Peter Eisentraut
An: Stefan Scheid
Kopie (CC): pgsql-c...@postgresql.org
Attached (in patch 0003) is a proof-of-concept implementing an
expression evalution framework that doesn't use recursion. Instead
ExecInitExpr2 computes a number of 'steps' necessary to compute an
expression. These steps are stored in a linear array, and executed one
after another (save boolean ex
I wrote:
> Pavel Stehule writes:
>> 2016-11-07 2:16 GMT+01:00 Tom Lane :
>>> So I think we should just delete these functions and adjust SPI_connect
>>> and SPI_finish so that they just push/pop a context level unconditionally.
>>> (Which will make them simpler, not more complicated.)
>> cannot b
On 11/4/16 4:04 AM, Oleksandr Shulgin wrote:
The psql process even exits with an error code 2, which might be not
that expected. We could stop reading the file and reset connection
afterwards, but this is probably not that easy to achieve (think of
nested \i calls).
Well, if you stop reading f
Hello,
Posting an update to this issue (which by the way also shows up on 9.6)
Maybe this information is useful for extension developers (that have all the
warnings flags on while developing using GNUC)
By wrapping the files as follows, any warnings generated by the postgres's
header files
Hello,
On Mon, Nov 7, 2016 at 8:42 PM, Masahiko Sawada
wrote:
> On Mon, Nov 7, 2016 at 10:52 PM, Beena Emerson
> wrote:
> > Hello Sawada-san,
> >
> > On Mon, Nov 7, 2016 at 4:47 PM, Masahiko Sawada
> > wrote:
> >>
> >> On Wed, Nov 2, 2016 at 3:57 PM, Beena Emerson
> >> wrote:
> >> > Hello,
>
I wrote:
> Now that I've seen this I wonder which other uses of rd_options are
> potentially broken. RelationIsUsedAsCatalogTable() is hardly the
> only macro that is assuming with little justification that it's
> applied to the right kind of reloptions.
>
> We could band-aid this by having the R
On 7 November 2016 at 12:15, Jaime Casanova
wrote:
> On 28 October 2016 at 02:53, Amit Langote
> wrote:
>>
>> Please find attached the latest version of the patches
>
> Hi,
>
> I started to review the functionality of this patch, so i applied all
> 9 patches. After that i found this warning, whi
On 28 October 2016 at 02:53, Amit Langote wrote:
>
> Please find attached the latest version of the patches
Hi,
I started to review the functionality of this patch, so i applied all
9 patches. After that i found this warning, which i guess is because
it needs a cast.
After that, i tried a case
Michael Paquier wrote:
>> In my quest of making the backup tools more compliant to data
>> durability, here is a thread for pg_dump and pg_dumpall.
>
> Okay, here is a patch doing the above. I have added a new --nosync
> option to pg_dump and pg_dumpall to switch to the pre-10 behavior. I
> have a
> On 07 Nov 2016, at 12:32, Daniel Gustafsson wrote:
>
>> On 04 Nov 2016, at 08:34, Kyotaro HORIGUCHI
>> wrote:
>>
>> I'm not sure how the discussion about this goes, these patches
>> makes me think about coding style of Perl.
>
> Some of this can absolutely be considered style and more or le
2016-11-07 15:47 GMT+01:00 Tom Lane :
> Pavel Stehule writes:
> > 2016-11-07 2:16 GMT+01:00 Tom Lane :
> >> So I think we should just delete these functions and adjust SPI_connect
> >> and SPI_finish so that they just push/pop a context level
> unconditionally.
> >> (Which will make them simpler,
On 9/27/16 6:57 PM, Vitaly Burovoy wrote:
> On 9/27/16, Vitaly Burovoy wrote:
>> On 9/27/16, Tom Lane wrote:
>>> (The other thing I'd want here is a --target-version option so that
>>> you could get the same output alterations in pg_dump or pg_restore to
>>> text. Otherwise it's nigh undebuggabl
Albe Laurenz writes:
> Tom Lane wrote:
>> I'm inclined to give this up as a bad job and go back to the
>> previous state. We have a solution that works and doesn't
>> produce warnings; third-party authors who don't want to use it
>> are on their own.
> I think you are right.
Done. We can alway
On Tue, Oct 25, 2016 at 10:35 PM, Michael Paquier
wrote:
> On Mon, Oct 17, 2016 at 4:00 PM, Masahiko Sawada
> wrote:
>> Attached latest patch.
>> Please review it.
>
> Okay, so let's move on with this patch...
Thank you for reviewing this patch.
> +
> + The keyword ANY is omis
On 11/5/16 8:03 AM, Michael Paquier wrote:
> On Sat, Nov 5, 2016 at 9:17 AM, Peter Eisentraut
> wrote:
>> > On 11/3/16 7:17 PM, Michael Paquier wrote:
>>> >> This patch not being complicated, so I would vote for those being
>>> >> addressed now so as they are not forgotten even if there is a FIXME
On Mon, Nov 7, 2016 at 10:52 PM, Beena Emerson wrote:
> Hello Sawada-san,
>
> On Mon, Nov 7, 2016 at 4:47 PM, Masahiko Sawada
> wrote:
>>
>> On Wed, Nov 2, 2016 at 3:57 PM, Beena Emerson
>> wrote:
>> > Hello,
>> >
>> > On Wed, Nov 2, 2016 at 4:16 AM, Fabien COELHO
>> > wrote:
>> >>
>> >>
>> >>
On Fri, Nov 4, 2016 at 7:14 AM, Haribabu Kommi wrote:
>> + if (cstate->rel->rd_rel->relkind != RELKIND_RELATION
>> + && (!cstate->rel->trigdesc ||
>> + !cstate->rel->trigdesc->trig_insert_instead_row))
>
>
> changed.
>
>>
>> Meanwhile I will test it and give the feedback.
>
>
> Thanks.
>
> Updated
On 11/5/16 9:19 AM, Alvaro Herrera wrote:
> Peter Eisentraut wrote:
>> pg_xlogdump [etc]: Add NLS
>
> So how large are the new .po files?
pg_archivecleanup/po/pg_archivecleanup.pot: 0 translated messages, 25
untranslated messages.
pg_test_fsync/po/pg_test_fsync.pot: 0 translated messages, 28
untr
Pavel Stehule writes:
> 2016-11-07 2:16 GMT+01:00 Tom Lane :
>> So I think we should just delete these functions and adjust SPI_connect
>> and SPI_finish so that they just push/pop a context level unconditionally.
>> (Which will make them simpler, not more complicated.)
> cannot be there some per
On Sat, Oct 29, 2016 at 4:12 PM, Michael Paquier
wrote:
> On Fri, Oct 28, 2016 at 9:57 PM, David Steele wrote:
> > On 10/28/16 3:49 PM, Magnus Hagander wrote:
> > The change from 10 to 11 increases the tests that are skipped on Windows,
> > which is necessary because one extra symlink test is ad
On 11/5/16 8:03 AM, Michael Paquier wrote:
>> > Yeah that was wrong anyway. The previously existing translation markers
>> > were wrong. We want to translate the fmt, not the formatted message.
> Does using one way or the other actually change something? Because
> pg_rewind/logging.c is not marki
On Tue, Sep 20, 2016 at 8:15 AM, Tsunakawa, Takayuki
wrote:
> Hello,
>
>> From: pgsql-hackers-ow...@postgresql.org
>> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Magnus Hagander
>> On Wed, Aug 24, 2016 at 4:35 AM, Tsunakawa, Takayuki
>> wrote:
>> As a similar topic, I wonder wh
Hello Sawada-san,
On Mon, Nov 7, 2016 at 4:47 PM, Masahiko Sawada
wrote:
> On Wed, Nov 2, 2016 at 3:57 PM, Beena Emerson
> wrote:
> > Hello,
> >
> > On Wed, Nov 2, 2016 at 4:16 AM, Fabien COELHO
> wrote:
> >>
> >>
> >> Hello Masahiko,
> >>
> So I would suggest to:
> - fix the compil
From: Michael Paquier
Hm.. I have just tested HEAD, my patch and your patch using my patch
test on pg_ctl.c, but I am always getting pgwin32_is_service set to 0
when running pg_ctl start from a terminal, and set it to 1 when
running pg_ctl service to register the service startup. Could you
precise
On 2016/11/07 11:24, Etsuro Fujita wrote:
On 2016/11/04 19:55, Etsuro Fujita wrote:
Attached is an updated version of the patch.
I noticed that I have included an unrelated regression test in the
patch. Attached is a patch with the test removed.
I noticed that I inadvertently removed some
On Fri, Nov 4, 2016 at 8:30 AM, Thomas Munro
wrote:
> On Thu, Oct 27, 2016 at 10:50 PM, Rushabh Lathia
> wrote:
>> Please find attached latest patch which fix the review point as well as
>> additional clean-up.
>
> +/*
> + * Read the tuple for given reader into nowait mode, and form the tuple
>
>
> > As I said before, Npgsql for one loads data types by name, not by OID.
>>> > So this would definitely cause breakage.
>>>
>>> Why would that cause breakage?
>>
>>
>> Well, the first thing Npgsql does when it connects to a new database, is
>> to query pg_type. The type names are used to associ
> On 04 Nov 2016, at 08:34, Kyotaro HORIGUCHI
> wrote:
>
> Thank you for looling this.
And thank you for taking the time to read my patches!
> At Mon, 31 Oct 2016 17:11:17 +0100, Daniel Gustafsson wrote
> in <3fc648b5-2b7f-4585-9615-207a44b73...@yesql.se>
>>> On 27 Oct 2016, at 09:23, Kyotar
On Wed, Nov 2, 2016 at 3:57 PM, Beena Emerson wrote:
> Hello,
>
> On Wed, Nov 2, 2016 at 4:16 AM, Fabien COELHO wrote:
>>
>>
>> Hello Masahiko,
>>
So I would suggest to:
- fix the compilation issue
- leave -l/--log as it is, i.e. use "pgbench_log" as a prefix
- add --log-pr
Tom Lane wrote:
>> Albe Laurenz writes:
>>> Anyway, I have prepared a patch along the lines you suggest.
>>
>> Pushed, we'll see if the buildfarm likes this iteration any better.
>
> And the answer is "not very much". The Windows builds aren't actually
> failing, but they are producing lots of
On Mon, Nov 7, 2016 at 9:49 AM, Tsunakawa, Takayuki
wrote:
> From: pgsql-hackers-ow...@postgresql.org
>> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier
>> On Sun, Nov 6, 2016 at 6:30 PM, MauMau wrote:
>> So you see the same behavior with the patch I sent and your refacto
71 matches
Mail list logo
