2017-06-27 17:30 GMT+02:00 Fabien COELHO :
>
> Hello Pavel,
>
> We can introduce macro SetVariableBool(vars, varname, bool) instead
>>>
>>> SetVariable(pset.vars, "ERROR", "FALSE");
>>>
>>
>> I checked source code, and it requires little bit more harder refactoring
>> because now we have SetVaria
On Wed, Aug 24, 2016 at 2:58 AM, Robert Haas wrote:
> Now, for bigger segment sizes, I think there actually could be a
> little bit of a noticeable performance hit here, because it's not just
> about total elapsed time. Even if the code eventually touches all of
> the memory, it might not touch i
On Wed, Jun 28, 2017 at 1:47 AM, Petr Jelinek
wrote:
>
> On 27/06/17 10:51, Masahiko Sawada wrote:
>> On Mon, Jun 26, 2017 at 12:12 PM, Masahiko Sawada
>> wrote:
>>
>> I've reviewed this patch briefly.
>
> Thanks!
>
>>
>> @@ -515,6 +533,31 @@ logicalrep_worker_stop(Oid subid, Oid relid)
>> }
>>
On Fri, Jun 23, 2017 at 09:42:10PM -0400, Peter Eisentraut wrote:
> On 6/21/17 22:47, Peter Eisentraut wrote:
> > On 6/20/17 22:44, Noah Misch wrote:
> >>> A patch has been posted, and it's being reviewed. Next update Monday.
> >>
> >> This PostgreSQL 10 open item is past due for your status updat
On Tue, Jun 27, 2017 at 11:53 PM, Alexander Korotkov <
a.korot...@postgrespro.ru> wrote:
> On Tue, Jun 27, 2017 at 4:08 PM, Amit Kapila
> wrote:
>
>> On Thu, Jun 22, 2017 at 8:00 PM, Alexander Korotkov
>> wrote:
>> > On Wed, Jun 21, 2017 at 10:47 PM, Robert Haas
>> wrote:
>> >>
>> >> On Mon, Ju
On Wed, Jun 28, 2017 at 12:00 AM, Alexander Korotkov <
a.korot...@postgrespro.ru> wrote:
> On Tue, Jun 27, 2017 at 4:19 PM, Amit Kapila
> wrote:
>
>> On Thu, Jun 22, 2017 at 5:46 PM, Alexander Korotkov
>> wrote:
>> > On Tue, Jun 13, 2017 at 4:50 AM, Haribabu Kommi <
>> kommi.harib...@gmail.com>
On Thu, Jun 22, 2017 at 5:47 AM, Robert Haas wrote:
> On Mon, Jun 12, 2017 at 9:50 PM, Haribabu Kommi
> wrote:
> > Open Items:
> >
> > 1. The BitmapHeapScan and TableSampleScan are tightly coupled with
> > HeapTuple and HeapScanDesc, So these scans are directly operating
> > on those structures
On Sat, Mar 25, 2017 at 7:27 AM, Thomas Munro
wrote:
> On Sat, Mar 25, 2017 at 3:11 AM, Anastasia Lubennikova
> wrote:
>> You claim that SLRUs now support five digit segment name, while in slru.h
>> at current master I see the following:
>>
>> * Note: slru.c currently assumes that segment file n
On Mon, May 22, 2017 at 6:39 AM, Thomas Munro
wrote:
> On Thu, Apr 27, 2017 at 11:03 AM, Thomas Munro
> wrote:
>> On Thu, Apr 27, 2017 at 5:13 AM, Oleg Golovanov wrote:
>>> Can you actualize your patch set? The error got from
>>> 0010-hj-parallel-v12.patch.
>>
>> I really should get around to se
Attached fixes $SUBJECT.
s/fetch_ckpt/fetching_ckpt/g
Thanks,
Amit
diff --git a/src/backend/access/transam/xlog.c
b/src/backend/access/transam/xlog.c
index 0a6314a642..5b6cec8dee 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -4221,10 +4221,10 @@ ReadRe
> "Noah" == Noah Misch writes:
Noah> IMMEDIATE ATTENTION REQUIRED. This PostgreSQL 10 open item is
Noah> long past due for your status update. Please reacquaint yourself
Noah> with the policy on open item ownership[1] and then reply
Noah> immediately. If I do not hear from you by 2017-
On Tue, Apr 4, 2017 at 8:25 AM, Thomas Munro
wrote:
> ... but considering that these data structures may
> finish up being redesigned as part of the GSoC project[1], it may be
> best to wait and see where that goes before doing anything. I'll
> follow developments there, and if this patch remains
On 2017-06-28 06:04:23 +0900, Michael Paquier wrote:
> On Wed, Jun 28, 2017 at 3:44 AM, Andres Freund wrote:
> > I'm far from convinced by this. By now WAL replay with checkpointer,
> > bgwriter, etc. active is actually *more* tested than the cases without
> > it. The likelihood of bugs is higher
On Wed, Jun 28, 2017 at 3:44 AM, Andres Freund wrote:
> I'm far from convinced by this. By now WAL replay with checkpointer,
> bgwriter, etc. active is actually *more* tested than the cases without
> it. The likelihood of bugs is higher in the less frequently exercised
> paths, and given that rep
Andres Freund writes:
> On 2017-06-27 14:59:18 -0400, Tom Lane wrote:
>> If we decide that it has to wait for v11,
>> I'd address Jeff's complaint by hacking the loop behavior in
>> test_postmaster_connection, which'd be ugly but not many lines of code.
> Basically increasing the wait time over t
Hi,
On 2017-06-27 14:59:18 -0400, Tom Lane wrote:
> Here's a draft patch for that. I quite like the results --- this seems
> way simpler and more reliable than what pg_ctl has done up to now.
Yea, I like that too.
> However, it's certainly arguable that this is too much change for an
> optiona
Over on the "memory layouts for binary search in nbtree" thread, I
described a plausible way of implementing abbreviated keys for nbtree
internal pages [1]. I've been going on about this technique for a long
time, but the insight that we can do it by reusing an itemId's lp_len
field is a new one. I
I wrote:
> Andres Freund writes:
>> On 2017-06-26 17:38:03 -0400, Tom Lane wrote:
>>> Hm. Take that a bit further, and we could drop the connection probes
>>> altogether --- just put the whole responsibility on the postmaster to
>>> show in the pidfile whether it's ready for connections or not.
On 2017-06-27 11:13:38 -0700, Peter Geoghegan wrote:
> On Tue, Jun 27, 2017 at 11:04 AM, Andres Freund wrote:
> >
> > On 2017-06-27 10:57:15 -0700, Peter Geoghegan wrote:
> >> I looked at this again recently. I wrote a patch to prove to myself
> >> that we can fairly easily reclaim 15 bits from ev
On 2017-06-23 10:56:07 +0900, Michael Paquier wrote:
> > And even there it might actually be
> > a pretty good idea to not force a full checkpoint - getting up fast
> > after a crash is kinda important..
>
> But not that. Crash recovery is designed to be simple and robust, with
> only the postmast
On Tue, Jun 27, 2017 at 11:05 AM, Andres Freund wrote:
>> Did you ever try running a pgbench SELECT benchmark, having modified
>> things such that all PKs are on columns that are not of type
>> int4/int8, but rather are of type numeric? It's an interesting
>> experiment, that I've been meaning to
On Tue, Jun 27, 2017 at 11:04 AM, Andres Freund wrote:
>
> On 2017-06-27 10:57:15 -0700, Peter Geoghegan wrote:
>> I looked at this again recently. I wrote a patch to prove to myself
>> that we can fairly easily reclaim 15 bits from every nbtree internal
>> page ItemId, and put an abbreviated key
On 2016-05-19 19:38:02 -0700, Peter Geoghegan wrote:
> On Wed, May 18, 2016 at 6:25 AM, Andres Freund wrote:
> > currently we IIRC use linearly sorted datums for the search in
> > individual btree nodes. Not surprisingly that's often one of the
> > dominant entries in profiles. We could probably
Hi,
On 2017-06-27 10:57:15 -0700, Peter Geoghegan wrote:
> I looked at this again recently. I wrote a patch to prove to myself
> that we can fairly easily reclaim 15 bits from every nbtree internal
> page ItemId, and put an abbreviated key there instead.
Interesting. Not sure however that really
On Thu, May 19, 2016 at 7:28 PM, Peter Geoghegan wrote:
> Abbreviated keys in indexes are supposed to help with this. Basically,
> the ItemId array is made to be interlaced with small abbreviated keys
> (say one or two bytes), only in the typically less than 1% of pages
> that are internal (leaf p
On 27/06/17 10:51, Masahiko Sawada wrote:
> On Mon, Jun 26, 2017 at 12:12 PM, Masahiko Sawada
> wrote:
>
> I've reviewed this patch briefly.
Thanks!
>
> @@ -515,6 +533,31 @@ logicalrep_worker_stop(Oid subid, Oid relid)
> }
>
> /*
> + * Request worker to be stopped on commit.
> + */
> +voi
On Tue, Jun 27, 2017 at 10:12 AM, Colin 't Hart wrote:
> On 27 Jun 2017, at 17:06, Merlin Moncure wrote:
>>
>>> On Tue, Jun 27, 2017 at 10:01 AM, Colin 't Hart
>>> wrote:
>>> Hi,
>>>
>>> The following rather contrived example illustrates that lag(), lead()
>>> (and probably other functions) can
Hello Pavel,
We can introduce macro SetVariableBool(vars, varname, bool) instead
SetVariable(pset.vars, "ERROR", "FALSE");
I checked source code, and it requires little bit more harder refactoring
because now we have SetVariableBool - what is unhappy name, because it
initialize variable to
Peter Eisentraut writes:
> On 6/25/17 11:45, Tom Lane wrote:
>> * Should not the FROM code path copy the old collation's version?
>> It seems a little bit weird that "cloning" a collation takes the
>> liberty of installing a new version.
> I think this is working correctly. Specifying the versio
On 27 Jun 2017, at 17:06, Merlin Moncure wrote:
>
>> On Tue, Jun 27, 2017 at 10:01 AM, Colin 't Hart wrote:
>> Hi,
>>
>> The following rather contrived example illustrates that lag(), lead()
>> (and probably other functions) can't automatically cast an integer to
>> a bigint:
>>
>> select lag(
On Tue, Jun 27, 2017 at 10:01 AM, Colin 't Hart wrote:
> Hi,
>
> The following rather contrived example illustrates that lag(), lead()
> (and probably other functions) can't automatically cast an integer to
> a bigint:
>
> select lag(sum,1,0) over () from (select sum(generate_series) over
> (order
Hi,
The following rather contrived example illustrates that lag(), lead()
(and probably other functions) can't automatically cast an integer to
a bigint:
select lag(sum,1,0) over () from (select sum(generate_series) over
(order by generate_series) from generate_series(1,10)) x;
ERROR: function l
On 6/25/17 11:45, Tom Lane wrote:
> * Should not the FROM code path copy the old collation's version?
> It seems a little bit weird that "cloning" a collation takes the
> liberty of installing a new version.
I think this is working correctly. Specifying the version explicitly is
really only usefu
On Tue, Jun 27, 2017 at 4:19 PM, Amit Kapila
wrote:
> On Thu, Jun 22, 2017 at 5:46 PM, Alexander Korotkov
> wrote:
> > On Tue, Jun 13, 2017 at 4:50 AM, Haribabu Kommi <
> kommi.harib...@gmail.com>
> > wrote:
> >>
> >> On Fri, Oct 14, 2016 at 7:26 AM, Alvaro Herrera <
> alvhe...@2ndquadrant.com>
On Tue, Jun 27, 2017 at 4:08 PM, Amit Kapila
wrote:
> On Thu, Jun 22, 2017 at 8:00 PM, Alexander Korotkov
> wrote:
> > On Wed, Jun 21, 2017 at 10:47 PM, Robert Haas
> wrote:
> >>
> >> On Mon, Jun 12, 2017 at 9:50 PM, Haribabu Kommi
> >> wrote:
> >> > Open Items:
> >> >
> >> > 1. The BitmapHeap
Hi,
I suspect its happening because of delay in status update by client but even
after trying forceUpdateStatus its quitting prematurely.
Thanks,
Sanyam Jain
From: sanyam jain
Sent: Tuesday, June 27, 2017 6:47:55 AM
To: Peter Eisentraut; Pg Hackers
Subject: R
On Fri, Jun 23, 2017 at 4:04 PM, Tom Lane wrote:
> Peter Eisentraut writes:
>> We also allow the same column more than once in an index. We probably
>> don't have to be more strict here.
>
> There actually are valid uses for the same column more than once in
> an index, eg if you use a different
On Thu, Jun 22, 2017 at 5:46 PM, Alexander Korotkov
wrote:
> On Tue, Jun 13, 2017 at 4:50 AM, Haribabu Kommi
> wrote:
>>
>> On Fri, Oct 14, 2016 at 7:26 AM, Alvaro Herrera
>> wrote:
>>>
>>> I have sent the partial patch I have to Hari Babu Kommi. We expect that
>>> he will be able to further th
On Thu, Jun 22, 2017 at 8:00 PM, Alexander Korotkov
wrote:
> On Wed, Jun 21, 2017 at 10:47 PM, Robert Haas wrote:
>>
>> On Mon, Jun 12, 2017 at 9:50 PM, Haribabu Kommi
>> wrote:
>> > Open Items:
>> >
>> > 1. The BitmapHeapScan and TableSampleScan are tightly coupled with
>> > HeapTuple and HeapS
On Tue, Jun 27, 2017 at 7:46 PM, Ashutosh Sharma wrote:
> I am still seeing the issue with the attached patch. I had a quick
> look into the patch. It seems to me like you have canonicalized the
> tablespace path to convert win32 slashes to unix type of slashes but
> that is not being passed to st
On Fri, 23 Jun 2017 19:43:35 -0400
Stephen Frost wrote:
> Alvaro, all,
>
> * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
> > Yugo Nagata wrote:
> >
> > > I tried to make it. Patch attached.
> > >
> > > It is easy and simple. Although I haven't tried for autovacuum worker,
> > > I confirm
On Sat, 24 Jun 2017 08:09:52 +0900
Michael Paquier wrote:
> On Sat, Jun 24, 2017 at 5:07 AM, Alvaro Herrera
> wrote:
> > Yugo Nagata wrote:
> >
> >> I tried to make it. Patch attached.
> >>
> >> It is easy and simple. Although I haven't tried for autovacuum worker,
> >> I confirmed I can change
Hi,
On Tue, Jun 27, 2017 at 10:13 AM, Michael Paquier
wrote:
> On Tue, Jun 27, 2017 at 12:13 PM, Michael Paquier
> wrote:
>> At quick glance, I think that this should definitely be a client-only
>> fix. One reason is that pg_basebackup should be able to work with past
>> servers. A second is tha
Project: Explicitly support predicate locks in index AMs besides b-tree
Hi,
During this week, I continued my work on predicate locking in the hash
index and created a patch for it. As I have written in my proposal for the
hash index, every scan operation acquires a predicate lock on the primary
p
On Mon, Jun 26, 2017 at 12:12 PM, Masahiko Sawada wrote:
> On Sun, Jun 25, 2017 at 7:35 PM, Petr Jelinek
> wrote:
>> (was away for a while, got some time now for this again)
>>
>> On 22/06/17 04:43, Peter Eisentraut wrote:
>>> The alternative is that we use the LockSharedObject() approach that wa
On 2017/06/27 10:22, Michael Paquier wrote:
> On Mon, Jun 26, 2017 at 4:11 PM, Masahiko Sawada
> wrote:
>> Thank you for the patches! I checked additional patches for brin and
>> spgist. They look good to me.
>
> Last versions are still missing something: brin_mask() and spg_mask()
> can be upda
On 2017/06/26 18:44, Kyotaro HORIGUCHI wrote:
> At Mon, 26 Jun 2017 18:16:42 +0900, Amit Langote wrote:
>>
>> I recall I had proposed a fix for the same thing some time ago [1].
>
> Wow. About 1.5 years ago and stuck? I have a concrete case where
> this harms so I'd like to fix that this time. Ho
Hi
2017-06-19 5:55 GMT+02:00 Pavel Stehule :
>
>
> 2017-06-17 7:58 GMT+02:00 Fabien COELHO :
>
>>
>> I have not any other comments. The implementation is trivial. I rerun all
>>> tests and tests passed.
>>>
>>> I'll mark this patch as ready for commiters.
>>>
>>
>> Oops, I just noticed a stupid c
48 matches
Mail list logo