[HACKERS] dead or outdated URLs found in win32.h

/8fskxacy(v=vs.80).aspx -- outdated http://msdn.microsoft.com/en-us/library/a90k134d(v=vs.80).aspx -- outdated https://msdn.microsoft.com/en-gb/library/aa489609.aspx -- outdated -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Page Scan Mode in Hash Index

On Fri, Sep 22, 2017 at 11:56 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Sep 21, 2017 at 3:08 AM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> I have added a note for handling of logged and unlogged tables in >> README file and als

Re: [HACKERS] Page Scan Mode in Hash Index

On Thu, Sep 21, 2017 at 9:30 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Sep 20, 2017 at 11:43 AM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> Attached are the patches with above changes. Thanks. > > Thanks. I think that the comments a

Re: [HACKERS] Page Scan Mode in Hash Index

On Thu, Sep 21, 2017 at 9:30 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Sep 20, 2017 at 11:43 AM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> Attached are the patches with above changes. Thanks. > > Thanks. I think that the comments a

Re: [HACKERS] Page Scan Mode in Hash Index

On Wed, Sep 20, 2017 at 8:05 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Sep 20, 2017 at 5:37 AM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> Thanks for all your review comments. Please find my comments in-line. > > +if (!BlockNumberI

Re: [HACKERS] Page Scan Mode in Hash Index

readpage contains unnecessary "continue" statements inside the > loops. The reason that they're unnecessary is that there's no code > below that in the loop anyway, so the loop is already going to go back > around to the top. Whether to change this is a matter of style, so I >

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks

mments from Robert, Moon Insung and supply the new patch. I just had a quick glance into this mail thread (after a long time) and could understand Robert's concern till some extent. I think, he is trying to say that if a tuple is frozen (committed|invalid) then it shouldn't be shown as COMMITTED and

Re: [HACKERS] Warnings "unrecognized node type" for some DDLs with log_statement = 'ddl'

to reproduce the failures reported by you. Your patch does solve the problem. Just to confirm if we are still missing TAGS for any other Statement nodes, I had a quick look into the list given in 'nodes.h' file but couldn't find any missing nodes. So, yes, your patch does solve the problem

Re: [HACKERS] Getting error message with latest PG source on Windows.

Hi, On Wed, Sep 13, 2017 at 3:15 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > Hi Thomas, > > On Wed, Sep 13, 2017 at 2:57 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> On Wed, Sep 13, 2017 at 9:11 PM, Thomas Munro >> <thomas.mu...@ente

Re: [HACKERS] Supporting huge pages on Windows

ly I have repeated the test cases which I had done earlier on v8 patch. For more details, on the tests that i have re-executed, please refer to - [1]. Thanks. [1]- https://www.postgresql.org/message-id/CAE9k0Pkz%2BtOiPmx2LrVePM7cZydTLNbQ6R3GqgeivurfsXyZ5w%40mail.gmail.com -- With Regards, Ashutosh S

Re: [HACKERS] Getting error message with latest PG source on Windows.

Hi Thomas, On Wed, Sep 13, 2017 at 2:57 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Wed, Sep 13, 2017 at 9:11 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> On Wed, Sep 13, 2017 at 8:58 PM, Ashutosh Sharma <ashu.coe...@gmail.com&g

[HACKERS] Getting error message with latest PG source on Windows.

83aaac41c66959a3ebaec7daadc4885b5f98f561 Author: Peter Eisentraut <pete...@gmx.net> Date: Tue Sep 12 09:46:14 2017 -0400 Allow custom search filters to be configured for LDAP auth. Please ignore this email if this issue has already been reported. -- With Regards, Ashutosh Sharma EnterpriseD

Re: [HACKERS] [PATCH] Pageinspect - add functions on GIN and GiST indexes from gevel

On Wed, Sep 13, 2017 at 1:15 PM, Alexey Chernyshov <a.chernys...@postgrespro.ru> wrote: > On Sat, 9 Sep 2017 13:53:35 +0530 > Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > >> >> Finally, i got some time to look into this patch and surprisingly I >> didn't

Re: [HACKERS] pg_basebackup fails on Windows when using tablespace mapping

On Tue, Jun 27, 2017 at 6:36 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Jun 27, 2017 at 7:46 PM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> I am still seeing the issue with the attached patch. I had a quick >> look into the patch

Re: [HACKERS] [PATCH] Pageinspect - add functions on GIN and GiST indexes from gevel

a better match as Tomas also mentioned or may be add a new contrib module itself. I think, adding a new contrib module looks like a better option. The reason being, it doesn't simply include the function for showing index level statistics (for e.g.. index size, no of rows, values..e.t.c) like pgs

Re: [HACKERS] Page Scan Mode in Hash Index

instances of "inline" in the code base, so I guess that this > is ok. > > +* Advance to next tuple on current page; or if there's no more, try > to > > Advance to the next tuple on the current page; or if done, try to > Done. Attached are the patches with a

Re: [HACKERS] Page Scan Mode in Hash Index

Hi Amit, On Wed, Aug 23, 2017 at 5:08 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Tue, Aug 22, 2017 at 7:24 PM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> On Tue, Aug 22, 2017 at 3:55 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> &g

Re: [HACKERS] Page Scan Mode in Hash Index

On Tue, Aug 22, 2017 at 3:55 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Tue, Aug 22, 2017 at 2:28 PM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> On Sat, Aug 19, 2017 at 11:37 AM, Amit Kapila <amit.kapil...@gmail.com> >> wrote: >>&

Re: [HACKERS] Page Scan Mode in Hash Index

On Sat, Aug 19, 2017 at 11:37 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Fri, Aug 11, 2017 at 6:51 PM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >>> >>> 7. >>> _hash_kill_items(IndexScanDesc scan) >>> { >>>

Re: [HACKERS] Page Scan Mode in Hash Index

safe. > + */ > + page = BufferGetPage(buf); > + if (PageGetLSN(page) != so->currPos.lsn) > + { > + _hash_relbuf(rel, buf); > + return; > + } > .. > } > > How does this check cover the case of unlogged tables? Thanks for putting that point. It doesn't cover the case

Re: [HACKERS] pl/perl extension fails on Windows

On Thu, Aug 10, 2017 at 8:06 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Thu, Aug 10, 2017 at 8:30 AM, Ashutosh Sharma <ashu.coe...@gmail.com> >> wrote: >>> So, the question is should we allow the

Re: [HACKERS] pl/perl extension fails on Windows

g VC8 # the time_t types will still be compatible. ifeq ($(WIN64),undef) ifeq ((PREMSVC80),define) BUILDOPT += -D_USE_32BIT_TIME_T endif endif So, the question is should we allow the preprocessor option '_USE_32BIT_TIME_T' to be defined implicitly or not in postgresql provided

Re: [HACKERS] free space % calculation in pgstathashindex

On Mon, Aug 7, 2017 at 7:19 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Aug 7, 2017 at 6:07 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: >> Hi, >> > .. >> In step #1, assuming '*' as an arithmetic operator, the left operand >> i

[HACKERS] free space % calculation in pgstathashindex

a34659959fe7385e68d196e57e90fe92b12764d4 Author: ashu <ashutosh1...@example.com> Date: Mon Aug 7 11:18:27 2017 +0530 Add proper typecasting to the operands when doing arithmatic operations. Patch by Ashutosh Sharma. diff --git a/contrib/pgstattuple/pgstatindex.c b/contrib/pgstattuple/pgstatindex.c

Re: [HACKERS] Page Scan Mode in Hash Index

On Fri, Aug 4, 2017 at 7:14 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Sun, Jul 30, 2017 at 2:07 PM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> Hi, >> >> On Wed, May 10, 2017 at 2:28 PM, Ashutosh Sharma <ashu.coe...@gmail.com> &

[HACKERS] Gettting warning message during PostgreSQL-9.5 installation on Windows

om modern perl about unescaped braces -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com Silence_warning_unescaped_braces.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pl/perl extension fails on Windows

Hi Christoph, On Mon, Jul 31, 2017 at 9:18 AM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > Hi Christoph, > > On Mon, Jul 31, 2017 at 2:44 AM, Christoph Berg <m...@debian.org> wrote: >> Re: Tom Lane 2017-07-28 <3254.1501276...@sss.pgh.pa.us> >>&g

Re: [HACKERS] pl/perl extension fails on Windows

test plperlu ... ok test plperl_array ... ok == shutting down postmaster == == removing temporary instance== -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Page Scan Mode in Hash Index

Hi, On Wed, May 10, 2017 at 2:28 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > While doing the code coverage testing of v7 patch shared with - [1], I > found that there are few lines of code in _hash_next() that are > redundant and needs to be removed. I basically came to

Re: [HACKERS] pl/perl extension fails on Windows

On Sat, Jul 29, 2017 at 12:05 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Ashutosh Sharma <ashu.coe...@gmail.com> writes: >> On Fri, Jul 28, 2017 at 10:05 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> Uh-huh. So the issue is indeed that they're injecting PERL

Re: [HACKERS] pl/perl extension fails on Windows

On Fri, Jul 28, 2017 at 10:05 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Ashutosh Sharma <ashu.coe...@gmail.com> writes: >> On Fri, Jul 28, 2017 at 7:22 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> Assuming that the Perl crew know what they're doing and

Re: [HACKERS] pl/perl extension fails on Windows

On Fri, Jul 28, 2017 at 7:22 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Ashutosh Sharma <ashu.coe...@gmail.com> writes: >> Thanks for the patch. I am seeing some compilation errors on Windows >> with the patch. Below are the errors observed, >> ... >&g

Re: [HACKERS] pl/perl extension fails on Windows

d this and attached is the new version of patch. Moreover, I have also tested this patch along with the patch to import switches used by perl into plperl and together it fixes the server crash issue. Also, now, the interpreter size in both perl and plperl module are the same thereby generating t

Re: [HACKERS] pl/perl extension fails on Windows

On Thu, Jul 27, 2017 at 7:51 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Ashutosh Sharma <ashu.coe...@gmail.com> writes: >> Anyways, attached is the patch that corrects this issue. The patch now >> imports all the switches used by perl into plperl module but, after &g

Re: [HACKERS] pl/perl extension fails on Windows

Hi All, On Wed, Jul 26, 2017 at 7:56 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > On Wed, Jul 26, 2017 at 8:51 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Robert Haas <robertmh...@gmail.com> writes: >>> Based on discussion downthread, it seems

Re: [HACKERS] pl/perl extension fails on Windows

On Wed, Jul 26, 2017 at 8:51 AM, Tom Lane wrote: > Robert Haas writes: >> Based on discussion downthread, it seems like what we actually need to >> do is update perl.m4 to extract CCFLAGS. Turns out somebody proposed >> a patch for that back in 2002:

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks

s() in both documentation and sql file. I am basically refering to 'include_combined' argument. IF you see the function definition, the argument name used is 'include_combined' whereas in documentation you have mentioned 'show_combined'. -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.c

Re: [HACKERS] pl/perl extension fails on Windows

On Wed, Jul 19, 2017 at 9:42 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Ashutosh Sharma <ashu.coe...@gmail.com> writes: > > Actually the function used for generation of handshake Key i.e HS_KEYp() > > considers 'sizeof(PerlInterpreter)' to generate the

Re: [HACKERS] pl/perl extension fails on Windows

of now, i haven't found the reason behind it and i am still investigating on it. -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com > > regards, tom lane

Re: [HACKERS] hash index on unlogged tables doesn't behave as expected

On Sat, Jul 15, 2017 at 8:20 AM, Amit Kapila wrote: > On Fri, Jul 14, 2017 at 6:02 PM, Michael Paquier > wrote: >> (catching up finally with this thread) >> >> On Mon, Jul 10, 2017 at 11:57 AM, Kyotaro HORIGUCHI >>

Re: [HACKERS] pl/perl extension fails on Windows

On Thu, Jul 13, 2017 at 6:04 PM, Andrew Dunstan <andrew.duns...@2ndquadrant.com> wrote: > > > On 07/13/2017 08:08 AM, Ashutosh Sharma wrote: >> >> After doing some study, I could understand that Util.c is generated >> from Util.xs by xsubpp compiler

Re: [HACKERS] pl/perl extension fails on Windows

deas. > > Latest versions of ActivePerl don't ship with library descriptor files, > either, which is unpleasant. > I too had similar observation and surprisingly, I am seeing 'libperl*.a' file instead of 'perl*.lib' file in most of the ActiverPerl versions for Windows. -- With Regards

Re: [HACKERS] Partition : Append node over a single SeqScan

Hi, On Wed, Jul 5, 2017 at 3:58 PM, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> wrote: > On Wed, Jul 5, 2017 at 3:48 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: >> Hi All, >> >> Today while exploring a bit on Range table partitioning, I could see

[HACKERS] Partition : Append node over a single SeqScan

q Scan on part2 (cost=0.00..38.25 rows=753 width=8) (actual time=0.009..0.009 rows=0 loops=1) Filter: (c1 > 100) Planning time: 166698.973 ms Execution time: 0.043 ms (5 rows) -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com -- Sent via pgsql-hackers mai

Re: [HACKERS] hash index on unlogged tables doesn't behave as expected

Hi, On Mon, Jul 3, 2017 at 4:10 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Mon, Jul 3, 2017 at 3:24 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > > On Mon, Jul 3, 2017 at 9:12 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > >> T

Re: [HACKERS] hash index on unlogged tables doesn't behave as expected

_node, forkNum, blkno, BufferGetPage(buf), true); _hash_relbuf(rel, buf); .... } I have also ran the WAL consistency check tool to verify the things and didn't find any issues. Thanks. -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com

Re: [HACKERS] pg_basebackup fails on Windows when using tablespace mapping

space_dirs.head; cell; cell = cell->next) - if (strcmp(dir, cell->old_dir) == 0) + if (strcmp(canon_dir, cell->old_dir) == 0) -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_filedump doesn't compile with v10 sources

tamps" output column of pg_control_init(), though, as that function hasn't been around long and probably doesn't have ossified users. Discussion: https://postgr.es/m/26788.1487455...@sss.pgh.pa.us I think we will have change pg_filedump such that it no more refers to 'enableIn

Re: [HACKERS] Getting server crash on Windows when using ICU collation

ich first detects the platform type and runs the uconv commands accordingly from the corresponding icu bin path. Please have a look and let me know for any issues. Thanks. -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com detect_ICU_version_v4.patch Description: Binary data -- S

Re: [HACKERS] Getting server crash on Windows when using ICU collation

Hi, On Tue, Jun 20, 2017 at 2:36 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 6/19/17 00:42, Ashutosh Sharma wrote: >>> If we don't find unconv, isn't it better to fall back to non-UTF8 >>> version rather than saying command not found? >>

Re: [HACKERS] BUG: pg_dump generates corrupted gzip file in Windows

Hi, On Mon, Jun 19, 2017 at 12:25 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Jun 19, 2017 at 11:42 AM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> Hi, >> >> On Fri, Mar 24, 2017 at 10:16 PM, Robert Haas <robertmh...@gmail.com>

Re: [HACKERS] BUG: pg_dump generates corrupted gzip file in Windows

ts nose and does CR / LF conversions on its own. So, >>> whenever we want compression on a plain-text dump file, we can set the >>> stdout mode to O_BINARY. Is it a wrong approach? >> With the help from Ashutosh Sharma, I tested this in Windows >> environment. Sadl

Re: [HACKERS] Getting server crash on Windows when using ICU collation

Hi, On Sun, Jun 18, 2017 at 6:39 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Sat, Jun 17, 2017 at 8:27 PM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> Hi, >> >> On Sat, Jun 17, 2017 at 6:38 PM, Peter Eisentraut >> <peter.eisentr...

Re: [HACKERS] Getting server crash on Windows when using ICU collation

er today)). Yes, it's hard to find any user's having ICU version < 50 installed on their system. But, having said that, it's always good to have such detective checks basically considering that we already have such configure check for Linux platform. Thanks. -- With Regards, Ashutosh Sharma Enterpris

Re: [HACKERS] Getting server crash on Windows when using ICU collation

uses the new function by default. -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com On Sat, Jun 17, 2017 at 9:16 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Sat, Jun 17, 2017 at 6:57 AM, Peter Eisentraut > <peter.eisentr...@2ndquadrant.com> wrote: &g

Re: [HACKERS] Getting server crash on Windows when using ICU collation

this and we keep > using the old code path indefinitely. Well, it will work for the users who are using ICU version >= 50 but not for the older ICU versions So, we will have to figure out a way, to either detect the availability of ucoll_strcollutf8() on Windows or may be ICU vers

Re: [HACKERS] Getting server crash on Windows when using ICU collation

Hi, On Thu, Jun 15, 2017 at 8:36 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 6/12/17 00:38, Ashutosh Sharma wrote: >> PFA patch that fixes the issue described in above thread. As mentioned >> in the above thread, the crash is basically happening in var

Re: [HACKERS] Getting server crash on Windows when using ICU collation

Hi, On Thu, Jun 15, 2017 at 7:43 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Jun 12, 2017 at 10:08 AM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> PFA patch that fixes the issue described in above thread. As mentioned >> in the above

Re: [HACKERS] ICU support on Windows

On Tue, Jun 13, 2017 at 6:45 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 6/12/17 14:03, Ashutosh Sharma wrote: >>> I noticed that this only works if you use the "Win32" download of ICU, >>> because the "Win64" download uses &

Re: [HACKERS] ICU support on Windows

Hi, On Jun 12, 2017 11:43 PM, "Alvaro Herrera" <alvhe...@2ndquadrant.com> wrote: Ashutosh Sharma wrote: > > I noticed that this only works if you use the "Win32" download of ICU, > > because the "Win64" download uses "lib64" paths

Re: [HACKERS] ICU support on Windows

Hi, On Mon, Jun 12, 2017 at 8:39 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 6/10/17 05:40, Ashutosh Sharma wrote: >> With the help of attached patch, we can use icu feature on Windows. >> All we have to do is, download the ICU librari

Re: [HACKERS] ICU support on Windows

Hi, On Mon, Jun 12, 2017 at 12:18 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Sat, Jun 10, 2017 at 6:40 PM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> Currently, we cannot perform ICU enabled build for postgres on Windows >> platform. Howe

Re: [HACKERS] Getting server crash on Windows when using ICU collation

to compare the string. Infact, we directly attempt to call the OS function wsccoll*() which is not expected. Thanks. -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com On Sat, Jun 10, 2017 at 3:25 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > Hi All, > > I am

[HACKERS] Getting server crash on Windows when using ICU collation

ollprovider: %c", mylocale->provider);#endif}* Fix: I am currently working on this and will try to come up with the fix asap. [1] - https://www.postgresql.org/message-id/CAE9k0P%3DQRjtS1a0rgTyKag_%2Bs6XCs7vovV%2BgSkUfYVASog0P8w%40mail.gmail.com -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com

[HACKERS] ICU support on Windows

ttp://site.icu-project.org/download/53 -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com ICU_support_windows.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.

Re: [HACKERS] Page Scan Mode in Hash Index

removed those lines and attached is the newer version of patch. [1] - https://www.postgresql.org/message-id/CAE9k0Pmn92Le0iOTU5b6087eRXzUnkq1PKcihxtokHJ9boXCBg%40mail.gmail.com On Mon, May 8, 2017 at 6:55 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > Hi, > > On Tue, Apr 4,

Re: [HACKERS] Page Scan Mode in Hash Index

Hi, On Tue, Apr 4, 2017 at 3:56 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Sun, Apr 2, 2017 at 4:14 AM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: >> >> Please note that these patches needs to be applied on top of [1]. >> > > Fe

Re: [HACKERS] Re: [BUGS] BUG #14634: On Windows pg_basebackup should write tar to stdout in binary mode

red WAL seg ments are copied through other means to complete the backup C:\Users\ashu\postgresql\TMP\test\bin>cp base.tar ..\basebakup C:\Users\ashu\postgresql\TMP\test\basebakup>tar -xf base.tar C:\Users\ashu\postgresql\TMP\test\basebakup>ls PG_VERSIONpg_commit_ts pg_multi

Re: [HACKERS] Add pgstathashindex() to get hash index table statistics.

those things to be different, and I think the pageinspect code is > better. I have reviewed the patch and it looks good to me. Also, the idea of including both zero and unused pages in a single 'unused' column looks better. Thanks. -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterpr

Re: [HACKERS] Re: PATCH: pageinspect / add page_checksum and bt_page_items(bytea)

intention behind Ashutosh (reviewer) working on this patch is to ensure that we do not miss the things that can easily get committed in this commit-fest. Thanks. -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com On Tue, Apr 4, 2017 at 7:23 PM, David Steele <da...@pgmasters.

Re: [HACKERS] Page Scan Mode in Hash Index

gt; After this change, you need to modify comments on top of function > hashbucketcleanup() and _hash_squeezebucket(). > Done. Please note that these patches needs to be applied on top of [1]. [1] - https://www.postgresql.org/message-id/CAE9k0P%3D3rtgUtxopG%2BXQVxgASFzAnGd9sNmYUaj_%3DKeVsKG

Re: [HACKERS] [sqlsmith] Failed assertion in _hash_kill_items/MarkBufferDirtyHint

On Apr 1, 2017 18:11, "Amit Kapila" <amit.kapil...@gmail.com> wrote: On Sat, Apr 1, 2017 at 6:00 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Mar 31, 2017 at 6:09 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: >> Well, That is another opti

Re: [HACKERS] [sqlsmith] Failed assertion in _hash_kill_items/MarkBufferDirtyHint

out one TRAP per hour when testing on 20 nodes with one postgres > and 5 sqlsmithes on each. > Ashutosh Sharma writes: >> [2. reacquire_lock_hashkillitems_if_required.patch] I've done about 12 hours of testing since applying this patch and no failed assertions so far. Thanks for testin

Re: [HACKERS] PATCH: pageinspect / add page_checksum and bt_page_items(bytea)

Hi Tomas, On Fri, Mar 31, 2017 at 11:05 PM, Tomas Vondra <tomas.von...@2ndquadrant.com> wrote: > On 03/31/2017 06:01 PM, Ashutosh Sharma wrote: >> >> >> It seems like the latest patch(v4) shared by Tomas upthread is an >> empty patch. If I am not wrong, please s

Re: [HACKERS] Page Scan Mode in Hash Index

Hi, > > On 03/29/2017 09:16 PM, Ashutosh Sharma wrote: >>> >>> This patch needs a rebase. >> >> >> Please try applying these patches on top of [1]. I think you should be >> able >> to apply it cleanly. Sorry, I think I forgot to mention thi

Re: [HACKERS] [sqlsmith] Failed assertion in _hash_kill_items/MarkBufferDirtyHint

Hi, On Sat, Apr 1, 2017 at 7:06 AM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > On Sat, Apr 1, 2017 at 6:00 AM, Robert Haas <robertmh...@gmail.com> wrote: >> On Fri, Mar 31, 2017 at 6:09 PM, Ashutosh Sharma <ashu.coe...@gmail.com> >> wrote: >>> Well

Re: [HACKERS] [sqlsmith] Failed assertion in _hash_kill_items/MarkBufferDirtyHint

On Sat, Apr 1, 2017 at 6:00 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Mar 31, 2017 at 6:09 PM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> Well, That is another option but the main idea was to be inline with >> the btree code. > >

Re: [HACKERS] [sqlsmith] Failed assertion in _hash_kill_items/MarkBufferDirtyHint

On Sat, Apr 1, 2017 at 1:08 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Mar 27, 2017 at 5:39 AM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> Thanks for reporting this problem. Could you please let me know on for >> how long did you run sqlsmith

Re: [HACKERS] PATCH: pageinspect / add page_checksum and bt_page_items(bytea)

sentially shares just > the tuple-forming part, which is exactly the same in both cases. > > It also adds the P_ISMETA(opaque) check to the original function, which > seems like a useful defense against page written to a different place (which > is essentially the issue I was original

[HACKERS] inconsistent page found on STANDBY server

that while registering data for xlog record 'XLOG_HASH_UPDATE_META_PAGE' we are not passing the correct length of data being registered and therefore, data (xl_hash_update_meta_page) is not completely recorded into the wal record. Fix: === Attached patch fixes this issue. -- With Regards, Ashutosh Sharma

Re: [HACKERS] Page Scan Mode in Hash Index

I think you should consider refactoring this so that it doesn't need >> to use goto. Maybe move the while (offnum <= maxoff) logic into a >> helper function and have it return itemIndex. If itemIndex == 0, you >> can call it again. >> > > okay, Added a helper function for _hash_readpage().

Re: [HACKERS] [sqlsmith] Failed assertion in _hash_kill_items/MarkBufferDirtyHint

On Mar 28, 2017 00:00, "Andreas Seltenreich" <seltenre...@gmx.de> wrote: Ashutosh Sharma writes: >> TRAP: FailedAssertion("!(LWLockHeldByMe(((LWLock*) (&(bufHdr)->content_lock", File: "bufmgr.c", Line: 3397) > Thanks for reporting this pro

Re: [HACKERS] segfault in hot standby for hash indexes

On Mar 27, 2017 22:25, "Robert Haas" <robertmh...@gmail.com> wrote: On Fri, Mar 24, 2017 at 3:49 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Fri, Mar 24, 2017 at 12:25 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: >>> >>> I t

Re: [HACKERS] segfault in hot standby for hash indexes

f there is any inconsistent block on standby the tool would probably terminate the recovery process and you would see following message in the server logfile. "inconsistent page found, rel %u/%u/%u, forknum %u, blkno %u" -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.ente

Re: [HACKERS] Page Scan Mode in Hash Index

ave added similar check for hash_kill_items() as well. > > This is not a full review, but I'm out of time for the moment. No worries. I will be ready for your further review comments any time. Thanks for the review. -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com From

Re: [HACKERS] [sqlsmith] Failed assertion in _hash_kill_items/MarkBufferDirtyHint

the killed items but we do this without releasing lock and pin on the current page. Hence, with SELECT queries this crash is not visible. The attached patch fixes this. But, please note that all these changes will get removed with the patch for page scan mode - [1]. [1] - https://www.postgresql

Re: [HACKERS] Add pgstathashindex() to get hash index table statistics.

gt; that illustrates this point, >> > > oh, is it a page where all the items have been deleted and no new > items have been inserted? Yes, it is a page from where items have been removed and no new insertion has happened. The reason why I have told that place is > not appropriate is becau

Re: [HACKERS] comments in hash_alloc_buckets

>> While working on - [1], I realised that the following comments in >> _hash_alloc_buckets() needs to be corrected. >> >> /* >> * Initialize the freed overflow page. Just zeroing the page won't work, >> * See _hash_freeovflpage for similar usage. >> */ >>

Re: [HACKERS] Add pgstathashindex() to get hash index table statistics.

On Sat, Mar 25, 2017 at 11:02 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Thu, Mar 23, 2017 at 11:24 PM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> Hi, >> >> On Tue, Feb 7, 2017 at 9:23 AM, Robert Haas <robertmh...@gmail.com> wrote:

Re: [HACKERS] pageinspect and hash indexes

Thanks for reviewing my patch. I have removed the extra white space. Attached are both the patches. >>> >>> Sorry, I have mistakenly attached wrong patch. Here are the correct >>> set of patches. >> >> The latest version of patches looks fine to me. > > I don't really like 0002. What

Re: [HACKERS] Supporting huge pages on Windows

t;> Amit, Magnus, you are signed up as reviewers for this patch. Do you know >>> when you'll have a chance to take a look? >>> >> >> I have provided my feedback and I could not test it on my machine. I >> think Ashutosh Sharma has tested it. I can give it ano

Re: [HACKERS] segfault in hot standby for hash indexes

t;> _hash_vacuum_one_page() >>> { >>> .. >>> deletable[ndeletable++] = offnum; >>> tuples_removed += 1;-- >>> >> >> Yes, I think 'ndeletable' alone should be fine. >> > > I think it would have been probably okay to use *int* for ntu

Re: [HACKERS] pageinspect and hash indexes

On Fri, Mar 24, 2017 at 9:46 AM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > On Fri, Mar 24, 2017 at 9:21 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> On Thu, Mar 23, 2017 at 6:46 PM, Ashutosh Sharma <ashu.coe...@gmail.com> >> wrote: >>

Re: [HACKERS] pageinspect and hash indexes

On Fri, Mar 24, 2017 at 9:21 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Thu, Mar 23, 2017 at 6:46 PM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >>> >>> Oh, okay, but my main objection was that we should not check hash page >>&g

Re: [HACKERS] Page Scan Mode in Hash Index

> Hi, > > On 03/23/2017 02:11 PM, Ashutosh Sharma wrote: >> >> On Thu, Mar 23, 2017 at 8:29 PM, Jesper Pedersen >> <jesper.peder...@redhat.com> wrote: >>> >>> 0001v2: >>> >>> In hashgettuple() you can remove the 'currItem' an

Re: [HACKERS] Page Scan Mode in Hash Index

On Thu, Mar 23, 2017 at 8:29 PM, Jesper Pedersen <jesper.peder...@redhat.com> wrote: > Hi, > > On 03/22/2017 09:32 AM, Ashutosh Sharma wrote: >> >> Done. Please refer to the attached v2 version of patch. >> > > Thanks. > >>>> 1) 0001-R

Re: [HACKERS] Add pgstathashindex() to get hash index table statistics.

I have prepared a patch that would allow pgstathashindex() to show the number of unused pages in hash index. Please find the attached patch for the same. Thanks. -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com From e3b59fa85f16d6d15be5360e85b7faf63e8683a9 Mon Sep 17 00:0

Re: [HACKERS] pageinspect and hash indexes

fference to user. > okay, I have now anyways removed the check for PageIsEmpty. Please refer to the attached '0002 allow_pageinspect_handle_UNUSED_hash_pages.patch' Also, I have attached '0001-Mark-freed-overflow-page-as-UNUSED-pagetype-v2.patch' that handles your comment mentioned in [1]. [1] - htt

Re: [HACKERS] segfault in hot standby for hash indexes

On Thu, Mar 23, 2017 at 9:17 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, Mar 23, 2017 at 8:43 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, Mar 22, 2017 at 3:39 PM, Ashutosh Sharma <ashu.coe...@gmail.com> > > wrote: > >&g

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

than HEAD, with 7 and 10 SP(s) we do see regression with patch. Therefore, I think the threshold value of 4 for number of subtransactions considered in the patch looks fine to me. -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com On Tue, Mar 21, 2017 at 6:19 PM, Amit

  1   2   3   >