Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-12-18 Thread Haribabu kommi
On 19 December 2013 05:31 Bruce Momjian wrote: On Wed, Dec 11, 2013 at 10:22:32AM +, Haribabu kommi wrote: The make_absolute_path() function moving to port is changed in similar way as Bruce Momjian approach. The psprintf is used to store the error string which Occurred

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-12-11 Thread Haribabu kommi
On 10 December 2013 19:55 Alvaro Herrera wrote: Haribabu kommi escribió: To detect provided data and xlog directories are same or not, I reused the Existing make_absolute_path() code as follows. 1. Moved the make_absolute_path() function from miscinit.c to path.c and Changed all

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-12-11 Thread Haribabu kommi
On 06 December 2013 11:57 Amit Kapila wrote: On Fri, Nov 29, 2013 at 6:55 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 29 November 2013 12:00 Amit Kapila wrote: On Tue, Nov 26, 2013 at 7:26 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: Few questions about your latest

Re: [HACKERS] Performance Improvement by reducing WAL for Update Operation

2013-12-05 Thread Haribabu kommi
On 05 December 2013 21:16 Amit Kapila wrote: Note - a. Performance is data is taken on my laptop, needs to be tested on some better m/c b. Attached Patch is just a prototype of chunkwise concept, code needs to be improved and decode handling/test is pending. I ran the performance test

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-30 Thread Haribabu kommi
On 27 November 2013 10:35 Fujii Masao wrote: On Wed, Nov 27, 2013 at 1:27 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 26 November 2013 23:11 Fujii Masao wrote: On Wed, Nov 20, 2013 at 7:43 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: I tried using of stat'ing in two

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-29 Thread Haribabu kommi
On 29 November 2013 12:00 Amit Kapila wrote: On Tue, Nov 26, 2013 at 7:26 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 25 November 2013 10:43 Amit Kapila wrote: On Fri, Nov 22, 2013 at 12:12 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 19 November 2013 10:33 Amit

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-28 Thread Haribabu kommi
On 27 November 2013 10:35 Fujii Masao wrote: On Wed, Nov 27, 2013 at 1:27 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 26 November 2013 23:11 Fujii Masao wrote: On Wed, Nov 20, 2013 at 7:43 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: I tried using of stat'ing in two

Re: [HACKERS] Regress tests to improve the function coverage of schemacmds and user and tablespace files

2013-11-26 Thread Haribabu kommi
On 24 November 2013 03:04 David Rowley wrote: I've done a quick benchmark on this this morning. Note that I'm using windows here and I used powershell to time the regression run with the following command: PS D:\Postgres\b\src\tools\msvc Measure-Command { .\vcregress.bat check } I ran the tests

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-26 Thread Haribabu kommi
On 25 November 2013 10:43 Amit Kapila wrote: On Fri, Nov 22, 2013 at 12:12 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 19 November 2013 10:33 Amit Kapila wrote: If I understood correctly, then your patch's main intention is to correct the estimate of dead tuples, so that it can

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-26 Thread Haribabu kommi
On 26 November 2013 23:11 Fujii Masao wrote: On Wed, Nov 20, 2013 at 7:43 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: I tried using of stat'ing in two directories, which is having a problem in windows. So modified old approach to detect limited errors. Updated patch attached

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-21 Thread Haribabu kommi
On 19 November 2013 10:33 Amit Kapila wrote: If I understood correctly, then your patch's main intention is to correct the estimate of dead tuples, so that it can lead to Vacuum cleaning the table/index which otherwise is not happening as per configuration value (autovacuum_vacuum_threshold)

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-20 Thread Haribabu kommi
On 19 November 2013 19:12 Fujii Masao wrote: On Tue, Nov 19, 2013 at 9:14 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 18 November 2013 23:30 Fujii Masao wrote: On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi haribabu.ko...@huawei.com wrote: Thanks for newer version

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-20 Thread Haribabu kommi
on 20 November 2013 23:44 Gavin Flower wrote: On 20/11/13 23:43, Haribabu kommi wrote: I tried using of stat'ing in two directories, which is having a problem in windows. So modified old approach to detect limited errors. Updated patch attached. This will detect and throw an error

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-11-19 Thread Haribabu kommi
On 19 November 2013 09:59 Amit Kapila wrote: On Mon, Nov 18, 2013 at 8:31 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 18 November 2013 20:01 Amit Kapila wrote: Code changes are fine. If two or three errors are present in the configuration file, it prints the last error

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-19 Thread Haribabu kommi
On 18 November 2013 23:30 Fujii Masao wrote: On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 18 November 2013 18:45 Fujii Masao wrote: On Mon, Nov 18, 2013 at 6:31 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 18 November 2013 11:19

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-18 Thread Haribabu kommi
On 18 November 2013 11:19 Haribabu kommi wrote: On 17 November 2013 00:55 Fujii Masao wrote: On Sat, Nov 16, 2013 at 2:27 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: on 15 November 2013 17:26 Magnus Hagander wrote: On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi

Re: [HACKERS] Improvement of pg_stat_statement usage about buffer hit ratio

2013-11-18 Thread Haribabu kommi
On 18 October 2013 13:35 KONDO Mitsumasa wrote: Hi, I submit improvement of pg_stat_statement usage patch in CF3. In pg_stat_statement, I think buffer hit ratio is very important value. However, it is difficult to calculate it, and it need complicated SQL. This patch makes it more simple

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-11-18 Thread Haribabu kommi
On 17 November 2013 12:25 Amit Kapila wrote: On Sat, Nov 16, 2013 at 4:35 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 16 November 2013 09:43 Amit Kapila wrote: On Fri, Nov 15, 2013 at 10:18 PM, Peter Eisentraut pete...@gmx.net wrote: On 11/14/13, 2:50 AM, Amit Kapila wrote

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-18 Thread Haribabu kommi
On 18 November 2013 18:45 Fujii Masao wrote: On Mon, Nov 18, 2013 at 6:31 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 18 November 2013 11:19 Haribabu kommi wrote: On 17 November 2013 00:55 Fujii Masao wrote: On Sat, Nov 16, 2013 at 2:27 PM, Haribabu kommi haribabu.ko

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-11-18 Thread Haribabu kommi
On 18 November 2013 20:01 Amit Kapila wrote: On Mon, Nov 18, 2013 at 6:28 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 17 November 2013 12:25 Amit Kapila wrote: On Sat, Nov 16, 2013 at 4:35 PM, Haribabu kommi Find the rebased version attached with this mail

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-18 Thread Haribabu kommi
On 18 November 2013 23:25 Andres Freund wrote: On 2013-11-18 15:01:42 +, Haribabu kommi wrote: /* + * Returns the malloced string of containing current working directory. + * The caller has to take care of freeing the memory. + * On failure exits with error code. + */ +static

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-17 Thread Haribabu kommi
On 17 November 2013 00:55 Fujii Masao wrote: On Sat, Nov 16, 2013 at 2:27 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: on 15 November 2013 17:26 Magnus Hagander wrote: On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 14 November 2013 23:59

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-11-16 Thread Haribabu kommi
On 16 November 2013 09:43 Amit Kapila wrote: On Fri, Nov 15, 2013 at 10:18 PM, Peter Eisentraut pete...@gmx.net wrote: On 11/14/13, 2:50 AM, Amit Kapila wrote: Find the rebased version attached with this mail. Doesn't build: openjade -wall -wno-unused-param -wno-empty

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-15 Thread Haribabu kommi
On 14 November 2013 23:59 Fujii Masao wrote: On Thu, Nov 14, 2013 at 9:08 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: Please find attached the patch, for adding a new option for pg_basebackup, to specify a different directory for pg_xlog. Sounds good! Here are the review comments

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-15 Thread Haribabu kommi
On 15 November 2013 17:26 Magnus Hagander wrote: On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi haribabu.ko...@huawei.commailto:haribabu.ko...@huawei.com wrote: On 14 November 2013 23:59 Fujii Masao wrote: On Thu, Nov 14, 2013 at 9:08 PM, Haribabu kommi haribabu.ko

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-15 Thread Haribabu kommi
on 15 November 2013 17:26 Magnus Hagander wrote: On Fri, Nov 15, 2013 at 12:10 PM, Haribabu kommi haribabu.ko...@huawei.commailto:haribabu.ko...@huawei.com wrote: On 14 November 2013 23:59 Fujii Masao wrote: On Thu, Nov 14, 2013 at 9:08 PM, Haribabu kommi haribabu.ko

[HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2013-11-14 Thread Haribabu kommi
Please find attached the patch, for adding a new option for pg_basebackup, to specify a different directory for pg_xlog. Design A new option: xlogdir is added to the list of options for pg_basebackup. The new option is not having an equivalent short option letter. This option will allow the

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-14 Thread Haribabu kommi
On 15 November 2013 10:00 Amit Kapila wrote: On Wed, Nov 13, 2013 at 12:02 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 12 November 2013 08:47 Amit Kapila wrote: On Mon, Nov 11, 2013 at 3:14 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 08 November 2013 18:35 Amit

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-11-13 Thread Haribabu kommi
On 01 October 2013 00:56 Amit Kapila wrote: On Mon, Sep 30, 2013 at 9:07 PM, Peter Eisentraut pete...@gmx.net wrote: On 9/28/13 3:05 AM, Amit Kapila wrote: Now as we have an agreement, I had updated patch for below left issues: Regression tests are failing. Thanks for informing. I

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-12 Thread Haribabu kommi
On 12 November 2013 08:47 Amit Kapila wrote: On Mon, Nov 11, 2013 at 3:14 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 08 November 2013 18:35 Amit Kapila wrote: On Fri, Nov 8, 2013 at 10:56 AM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 07 November 2013 09:42 Amit

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-11 Thread Haribabu kommi
On 08 November 2013 18:35 Amit Kapila wrote: On Fri, Nov 8, 2013 at 10:56 AM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 07 November 2013 09:42 Amit Kapila wrote: I am not sure whether the same calculation as done for new_rel_tuples works for new_dead_tuples, you can once check

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-11-07 Thread Haribabu kommi
On 07 November 2013 09:42 Amit Kapila wrote: On Tue, Oct 22, 2013 at 2:09 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 22 October 2013 10:15 Amit Kapila wrote: On Mon, Oct 21, 2013 at 10:54 AM, Haribabu kommi haribabu.ko...@huawei.com wrote: Actually what I had in mind

[HACKERS] Regress tests to improve the function coverage of schemacmds and user and tablespace files

2013-10-24 Thread Haribabu kommi
Here I have added some more regression tests to improve the missing function coverage of schemacmds.c, user.c and tablespace.c. The added tests are mainly RENAME TO and OWNER TO support. patches are attached in the mail. please check and provide your suggestions. Regards, Hari babu.

[HACKERS] Ident context leak during reloading of conf files when no ident information is present in the file

2013-10-24 Thread Haribabu kommi
There is an ident context leak which is occurs during reload of configuration files when there is no ident configuration items are present in the configuration file. In function load_ident(), New context is allocated to store the new_parsed_lines and deletes the old context when

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-10-22 Thread Haribabu kommi
On 22 October 2013 10:15 Amit Kapila wrote: On Mon, Oct 21, 2013 at 10:54 AM, Haribabu kommi haribabu.ko...@huawei.com wrote: Yes, it's correct. nkeep counter have the dead tuples which are recently dead and are not vacuumed. The removal of tuples vacuumed from dead tuples should

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-10-20 Thread Haribabu kommi
On 20 October 2013 12:06 Amit Kapila wrote: On Tue, Oct 15, 2013 at 3:37 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: On 12 October 2013 11:30 Tom Lane wrote: Haribabu kommi haribabu.ko...@huawei.com writes: To handle the above case instead of directly resetting the dead tuples as zero

Re: [HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-10-15 Thread Haribabu kommi
On 12 October 2013 11:30 Tom Lane wrote: Haribabu kommi haribabu.ko...@huawei.com writes: To handle the above case instead of directly resetting the dead tuples as zero, how if the exact dead tuples are removed from the table stats. With this approach vacuum gets triggered frequently thus

Re: [HACKERS] Compression of full-page-writes

2013-10-11 Thread Haribabu kommi
On 10 October 2013 23:06 Fujii Masao wrote: On Wed, Oct 9, 2013 at 1:35 PM, Haribabu kommi haribabu.ko...@huawei.com wrote: Thread-1 Threads-2 Head code FPW

[HACKERS] Heavily modified big table bloat even in auto vacuum is running

2013-10-11 Thread Haribabu kommi
vacuum is not happening on a heavily modified big table even if the dead tuples are more than configured threshold. This is because during at the end of vacuum, the number of dead tuples of the table is reset as zero, because of this reason the dead tuples which are occurred during the vacuum

Re: [HACKERS] Compression of full-page-writes

2013-10-08 Thread Haribabu kommi
On 08 October 2013 15:22 KONDO Mitsumasa wrote: (2013/10/08 17:33), Haribabu kommi wrote: The checkpoint_timeout and checkpoint_segments are increased to make sure no checkpoint happens during the test run. Your setting is easy occurred checkpoint in checkpoint_segments = 256. I don't know

Re: [HACKERS] insert throw error when year field len 4 for timestamptz datatype

2013-10-04 Thread Haribabu kommi
On 03 October 2013 19:30 Bruce Momjian wrote: On Thu, Oct 3, 2013 at 11:54:14AM +0530, Rushabh Lathia wrote: Thanks Bruce. Yes for me main problem was to make assumption that a 5-digit number is a year, as was bit worried about side effect of that assumption in the date/time module. I

Re: [HACKERS] insert throw error when year field len 4 for timestamptz datatype

2013-09-27 Thread Haribabu kommi
On 27 September 2013 15:04 Rushabh Lathia wrote: On Tue, Sep 17, 2013 at 6:23 PM, Haribabu kommi haribabu.ko...@huawei.commailto:haribabu.ko...@huawei.com wrote: I feel changing the year value to accept the length (4) is not simple. So many places the year length crossing more than length 4

Re: [HACKERS] insert throw error when year field len 4 for timestamptz datatype

2013-09-17 Thread Haribabu kommi
On Tue, 17 September 2013 14:33 Rushabh Lathia wrote: On Mon, Sep 16, 2013 at 7:22 PM, Haribabu kommi haribabu.ko...@huawei.commailto:haribabu.ko...@huawei.com wrote: On 14 August 2013 Rushabh Lathia wrote: postgres=# create table test ( a timestamptz); CREATE TABLE -- Date with year 1000

Re: [HACKERS] insert throw error when year field len 4 for timestamptz datatype

2013-09-16 Thread Haribabu kommi
On 14 August 2013 Rushabh Lathia wrote: postgres=# create table test ( a timestamptz); CREATE TABLE -- Date with year 1000 postgres=# insert into test values ( 'Sat Mar 11 23:58:48 1000 IST'); INSERT 0 1 -- Now try with year 1 it will return error postgres=# insert into test values ( 'Sat

<    1   2   3   4   5   6