Re: [HACKERS] Syntax for partitioning

2009-10-29 Thread Itagaki Takahiro
Peter Eisentraut pete...@gmx.net wrote: On tor, 2009-10-29 at 11:15 +0900, Itagaki Takahiro wrote: Range partitioning: CREATE TABLE table_name ( columns ) PARTITION BY RANGE ( a_expr ) ( PARTITION name VALUES LESS THAN [(] const [)], PARTITION name VALUES LESS

Re: [HACKERS] Syntax for partitioning

2009-10-29 Thread Itagaki Takahiro
command for PARTITION in other operations. ALTER TABLE table_name PARTITION BY RANGE (expr) (...) Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

[HACKERS] Syntax for partitioning

2009-10-28 Thread Itagaki Takahiro
partition can have optional WITH (...) and TABLESPACE clauses. * '(' and ')' are optional to support both Oracle and MySQL syntax. Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

[HACKERS] pg_read_file() and non-ascii input file

2009-10-27 Thread Itagaki Takahiro
. Comments, better ideas? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Proposal: String key space for advisory locks

2009-10-26 Thread Itagaki Takahiro
, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] toast.fillfactor is documented but not recognized?

2009-10-26 Thread Itagaki Takahiro
it from documentation. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Proposal: String key space for advisory locks

2009-10-26 Thread Itagaki Takahiro
Josh Berkus j...@agliodbs.com wrote: Why aren't you satisfied with hashtext('foo') ? Collisions, mostly. Hmmm, hashtext() returns int32. , Can you reduce the collision issue if we had hashtext64()? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers

Re: [HACKERS] Statement Level Deferred Triggers

2009-10-25 Thread Itagaki Takahiro
SET tgdeferrable = true, tginitdeferred = true WHERE tgrelid = 'atcommit_tbl'::regclass AND tgname = 'atcommit'; Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] (WIP) VACUUM REWRITE - CLUSTER by ctid

2009-10-25 Thread Itagaki Takahiro
is consistent with existing syntex of EXPLAIN (...). We can choose any keyword for the new rewrite version. For example: * VACUUM ( REWRITE ) * VACUUM ( FULL [ INPLACE | REPLACE ] ) Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list

[HACKERS] (WIP) VACUUM REWRITE - CLUSTER by ctid

2009-10-22 Thread Itagaki Takahiro
for it might be ALTER TABLE tbl CLUSTER ON COLUMN ctid or so. Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center cluster-without-index_20091023.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Prelim specs for parser hooks for plpgsql

2009-10-21 Thread Itagaki Takahiro
relationships between the hooks and Function Call Hook/parser hook submitted by Pavel-san? https://commitfest.postgresql.org/action/patch_view?id=160 If we can also use them in normal SQL parsing, they are very useful to implement SYSDATE global variable for porting from Oracle. Regards, --- ITAGAKI Takahiro

Re: [HACKERS] UTF8 with BOM support in psql

2009-10-20 Thread Itagaki Takahiro
Bruce Momjian br...@momjian.us wrote: Itagaki Takahiro wrote: When psql opens a file with -f or \i, it checks first 3 bytes of the file. If they are BOM, discard the 3 bytes and change client encoding to UTF8 automatically. Seems there is community support for accepting BOM

[HACKERS] ProcessUtility_hook

2009-10-20 Thread Itagaki Takahiro
. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Going, going, GUCs!

2009-10-20 Thread Itagaki Takahiro
be on) 5. Still used: synchronize_seqscans (should be on) -- used by pg_dump Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ProcessUtility_hook

2009-10-20 Thread Itagaki Takahiro
. But I'd leave it alone for now, unless it's few lines of code. I see it is debatable whether pg_stat_statements should support the hook. So I split the change in another patch. (pgss_utility_hook_20091021.patch) Regards, --- ITAGAKI Takahiro NTT Open Source Software Center

Re: [HACKERS] UTF8 with BOM support in psql

2009-10-20 Thread Itagaki Takahiro
, --- ITAGAKI Takahiro NTT Open Source Software Center psql-utf8bom_20091021.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Going, going, GUCs!

2009-10-20 Thread Itagaki Takahiro
can still use it. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] UTF8 with BOM support in psql

2009-10-19 Thread Itagaki Takahiro
, it checks first 3 bytes of the file. If they are BOM, discard the 3 bytes and change client encoding to UTF8 automatically. Is this change reasonable? Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

[HACKERS] EXPLAIN BUFFERS

2009-10-15 Thread Itagaki Takahiro
explain output, but the patch does not drop log_statement_stats variable families nor ShowUsage() functions. We could also remove all of them if no one use them at all. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center explain_buffers_20091015.patch Description: Binary data -- Sent

Re: [HACKERS] Trigger with WHEN clause (WIP)

2009-10-15 Thread Itagaki Takahiro
Tom Lane t...@sss.pgh.pa.us wrote: Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp writes: I think there is a benefit to provide WHEN cluase at least for compatibility with other DBMSs, even through we can move the expressions into the body of trigger functions. This seems to me

Re: [HACKERS] Buffer usage in EXPLAIN and pg_stat_statements (review)

2009-10-14 Thread Itagaki Takahiro
in it at pg_stat_statements. But it is hard to be maintained on executor nodes changes. Are there any better idea? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Triggers on columns

2009-10-14 Thread Itagaki Takahiro
... Thanks for the fix. I'll be careful about it. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Buffer usage in EXPLAIN and pg_stat_statements (review)

2009-10-14 Thread Itagaki Takahiro
to split the patch into EXPLAIN-part and contrib-part. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Buffer usage in EXPLAIN and pg_stat_statements (review)

2009-10-14 Thread Itagaki Takahiro
of luck. Yeah, that makes sense. But the partial change should also be a long-term solution ;-). It is hard to determine whether the partial change is a good solution until the whole features works as expected (at least partially). Regards, --- ITAGAKI Takahiro NTT Open Source Software Center

Re: [HACKERS] Skip WAL in ALTER TABLE

2009-10-14 Thread Itagaki Takahiro
Simon Riggs si...@2ndquadrant.com wrote: Is it possible to use WAL-skipping and BulkInsertState in ATRewriteTable() ? If ok, I'll submit a patch for the next commitfest. Yes Patch attached. This patch skip WAL writes during table rewrites from ALTER TABLE. Regards, --- ITAGAKI Takahiro

Re: [HACKERS] Encoding issues in console and eventlog on win32

2009-10-12 Thread Itagaki Takahiro
there are some text editors that do not support wide characters. At any rate, the logfile encoding feature will come from another patch, that might add log_encoding variable and work on any platforms. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center eventlog_20091013.patch Description

[HACKERS] Skip WAL in ALTER TABLE

2009-10-12 Thread Itagaki Takahiro
for the next commitfest. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] transaction_isolation vs. default_transaction_isolation

2009-10-12 Thread Itagaki Takahiro
uses default_transaction_isolation SHOW transaction_isolation; = read committed Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] Encoding issues in console and eventlog on win32

2009-10-06 Thread Itagaki Takahiro
), def_enc2name(EUC_JP), ... I don't have the time to clean this up right now, so if you have, please do so and resubmit. If not, I can clean it up later and apply. Patch attached. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center eventlog_20091007.patch Description: Binary data

Re: [HACKERS] Triggers on columns

2009-10-04 Thread Itagaki Takahiro
| proname | oid | proname ! --+---+--+--- ! 1662 | pg_get_triggerdef | 2730 | pg_get_triggerdef ! (1 row) Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] CREATE LIKE INCLUDING COMMENTS and STORAGES

2009-10-04 Thread Itagaki Takahiro
of a primary key, i.e. a unique index and a not null constraint, thus both conditions are required? It might be a confusable feature, but it should be discussed separated from this patch. IMO, almost all user will use INCLUDING ALL if the syntax is added by the patch. Regards, --- ITAGAKI Takahiro NTT

Re: [HACKERS] CREATE LIKE INCLUDING COMMENTS and STORAGES

2009-10-04 Thread Itagaki Takahiro
because we will have some duplicated codes; pg_expression_%d hacks and uses of ChooseRelationName() are spread into index.c, indexcmds.c and parse_utilcmd.c. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center create-including_20091005.patch Description: Binary data -- Sent via pgsql

[HACKERS] dblink memory leak

2009-10-04 Thread Itagaki Takahiro
should be still registered after SRF_RETURN_NEXT, so we cannot place callback context on stack of the function. More works needed. RegisterExprContextCallback() might be good for this purpose, but we need to modify callbacks are fired even if error. Regards, --- ITAGAKI Takahiro NTT Open Source

Re: [HACKERS] dblink memory leak

2009-10-04 Thread Itagaki Takahiro
might call dblink() only 3 times if we optimize executor logic (it should not occur for now, though). Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Buffer usage in EXPLAIN and pg_stat_statements (review)

2009-10-04 Thread Itagaki Takahiro
in understanding what has gone wrong. This message is only for hackers and should not occur. Assert() might be ok instead. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Buffer usage in EXPLAIN and pg_stat_statements (review)

2009-10-04 Thread Itagaki Takahiro
) Blocks Hit: 32 Read: 1635 Temp Read: 0 Total runtime: 52.026 ms (7 rows) Regards, --- ITAGAKI Takahiro NTT Open Source Software Center buffer_usage_20091005.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] Triggers on columns

2009-09-30 Thread Itagaki Takahiro
on pg_get_triggerdef(), you could nowadays also implement that via a parameter default value instead of a second function. OK, I'll rewrite it to use default parameter. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] CREATE LIKE INCLUDING COMMENTS and STORAGES

2009-09-30 Thread Itagaki Takahiro
EXCLUDING xxx are meaningful; it copies all components except xxx. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Triggers on columns

2009-09-30 Thread Itagaki Takahiro
] on 32bit platform. I think we should not use default values in functions listed on pg_proc.h, so the previous patch is better than default value version. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] CommitFest 2009-09, two weeks on

2009-09-30 Thread Itagaki Takahiro
queries, and the current synchronous method uses standard libpq calls. The point is *memory leak* in dblink when a query is canceled or become time-out. I think it is a bug, and my patch could fix it. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers

Re: [HACKERS] CommitFest 2009-09, two weeks on

2009-09-30 Thread Itagaki Takahiro
, because Windows is only platform that supports UTF-16 encoding natively. I believe my patch is the best solution for Windows even if we have another approach for other platforms. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Buffer usage in EXPLAIN and pg_stat_statements (review)

2009-09-30 Thread Itagaki Takahiro
+ LocalBufferHitCount; longnum_read = num_get - num_hit; ReadBufferCount means number of buffer access :( Patch attached. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center buffer_usage_20091001.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] CREATE LIKE INCLUDING COMMENTS and STORAGES

2009-09-28 Thread Itagaki Takahiro
, the patch looks to be in excellent shape. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center create-including_20090928a.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Buffer usage in EXPLAIN and pg_stat_statements (review)

2009-09-28 Thread Itagaki Takahiro
but merged with shared buffer statistics. Are there any better way to group them? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] CREATE LIKE INCLUDING COMMENTS and STORAGES

2009-09-27 Thread Itagaki Takahiro
COMMENTS also copy comments on indexes. * Add syntax to define storage options inline like CREATE TABLE tbl (col text STORAGE MAIN). Regards, --- ITAGAKI Takahiro NTT Open Source Software Center create-including_20090928.patch Description: Binary data -- Sent via pgsql-hackers mailing

Re: [HACKERS] CREATE LIKE INCLUDING COMMENTS and STORAGES

2009-09-27 Thread Itagaki Takahiro
ignore the part. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] FSM search modes

2009-09-17 Thread Itagaki Takahiro
put a new tuple into the same page where the old tuple is placed if possible. In addition to your intelligent FSM search modes, do we need another algorithm to make the compaction to work better? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing

Re: [HACKERS] WIP - syslogger infrastructure changes

2009-09-15 Thread Itagaki Takahiro
Magnus Hagander mag...@hagander.net wrote: On 15 sep 2009, at 07.21, Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp I'd like to have an opposite approach -- per-backend log files. I can see each backend writing it, certainly, but keeping it in separate files makes it useless without

[HACKERS] dblink doesn't transfar non-error meesages

2009-09-15 Thread Itagaki Takahiro
) Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] query cancel issues in contrib/dblink

2009-09-15 Thread Itagaki Takahiro
: * Fix connection leak on cancel. In the previous patch, running transactions are canceled, but the temporary connection was leaked. * Discard all pending results on cancel handler. I implemented PQexec-compatible behavior with async APIs. Regards, --- ITAGAKI Takahiro NTT Open Source

Re: [HACKERS] FDW-based dblink (WIP)

2009-09-15 Thread Itagaki Takahiro
of 2PC. * Automatic 2PC is very useful if we supports non-select query in SQL/MED. It would be better to have some infrastructure for it. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Encoding issues in console and eventlog on win32

2009-09-14 Thread Itagaki Takahiro
-specific routines because UTF16 is the native encoding in Windows. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center eventlog-20090915.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] WIP - syslogger infrastructure changes

2009-09-14 Thread Itagaki Takahiro
file will be a performance bottleneck when we want write a lot of logs. Per-backend log files like postgres.backend-id.log would be a help then. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Why does LOG have higher priority than ERROR and WARNING?

2009-09-13 Thread Itagaki Takahiro
Tom Lane t...@sss.pgh.pa.us wrote: Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp writes: Can I reorder them to ERROR WARNING LOG ? No. That was an intentional decision. LOG is for stuff that we really want to get logged, in most cases. ERROR is very often not that interesting

[HACKERS] syslog_line_prefix

2009-09-13 Thread Itagaki Takahiro
to syslog. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center syslog_line_prefix-20090914.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] logging hook for database audit

2009-09-13 Thread Itagaki Takahiro
be hard work, but needed anyway if we will support any kinds of per-category log filters. Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

[HACKERS] Why does LOG have higher priority than ERROR and WARNING?

2009-09-11 Thread Itagaki Takahiro
. Am I missing something? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] logging hook for database audit

2009-09-10 Thread Itagaki Takahiro
. Do you think the feature is useful and acceptable? Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] logging hook for database audit

2009-09-10 Thread Itagaki Takahiro
their own prefix, but stderr has no default prefix) * per-category minimum message levels (don't write sql logs in syslog, but can write other LOGs) I'll take a direction to make them into some pieces of core patches. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent

Re: [HACKERS] CREATE LIKE INCLUDING COMMENTS and STORAGES

2009-09-08 Thread Itagaki Takahiro
... ? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Triggers on columns

2009-09-08 Thread Itagaki Takahiro
DB2 http://publib.boulder.ibm.com/infocenter/db2luw/v9/index.jsp?topic=/com.ibm.db2.udb.admin.doc/doc/r931.htm [3] SQLite3 http://www.sqlite.org/lang_createtrigger.html Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Triggers on columns

2009-09-07 Thread Itagaki Takahiro
extension for triggers -- if we want to check modifications of actual values, it could be defined as: CREATE TRIGGER trig BEFORE UPDATE ON tbl FOR EACH ROW WHEN (NEW.col OLD.col) EXECUTE PROCEDURE trigger_func(); Regards, --- ITAGAKI Takahiro NTT Open Source Software Center

Re: [HACKERS] CREATE LIKE INCLUDING COMMENTS and STORAGES

2009-09-07 Thread Itagaki Takahiro
David Fetter da...@fetter.org wrote: On Mon, Sep 07, 2009 at 12:15:21PM +0900, Itagaki Takahiro wrote: Here is a patch to implement the following items in our ToDo list: * Add CREATE TABLE LIKE ... INCLUDING COMMENTS * Have CREATE TABLE LIKE copy column storage parameters

Re: [HACKERS] Triggers on columns

2009-09-06 Thread Itagaki Takahiro
. 3. Restriction of implementation; We don't have RTE in trigger routine for now. The current patch doesn't modify codes a lot. Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center column-trigger-20090907.patch Description: Binary data -- Sent via pgsql

[HACKERS] _WIN32_WINNT should be 0x0501 in win32.h

2009-09-06 Thread Itagaki Takahiro
build with SSPI support. Keep it as a #define in case * we want a switch to disable it sometime in the future. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

[HACKERS] Rename StrNCpy to avoid conflictions on win32

2009-09-06 Thread Itagaki Takahiro
be some places to replace it to strlcpy() instead. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] CREATE LIKE INCLUDING COMMENTS and STORAGES

2009-09-06 Thread Itagaki Takahiro
COMMENTS); Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center create-including-20090907.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] _WIN32_WINNT should be 0x0501 in win32.h

2009-09-06 Thread Itagaki Takahiro
at all, no? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Triggers on columns

2009-09-03 Thread Itagaki Takahiro
://dev.mysql.com/doc/refman/5.4/en/create-trigger.html Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Triggers on columns

2009-09-03 Thread Itagaki Takahiro
because I think almost user expects the former behavior. Unmodified UPDATE-targets are common case if we use a framework that generates SQL statements internally. Anyway, we need to compare the actual values if we want to treat NEW value modifed by another trigger correctly. Regards, --- ITAGAKI

[HACKERS] Concurrent execution of pg_relation_size and DROP TABLE

2009-09-03 Thread Itagaki Takahiro
() ? If failed, pg_relation_size() will just return NULLs. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Triggers on columns

2009-09-03 Thread Itagaki Takahiro
? Should we fire column triggers when their columns are mentioned in the UPDATE statement, but modified by another triggers? I believe we should fire them, but it is inconsistent because we will make different decisions whether NEW values are modified or not. Regards, --- ITAGAKI Takahiro NTT Open Source

[HACKERS] Triggers on columns

2009-09-02 Thread Itagaki Takahiro
and always considered as not-modified. Please grep with TODO: (TRIGGER) to check the issue. Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center column-trigger-20090903.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] Triggers on columns

2009-09-02 Thread Itagaki Takahiro
is modified. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Triggers on columns

2009-09-02 Thread Itagaki Takahiro
to support dependency-to-columns? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] make installcheck is broken in HEAD on mingw

2009-09-01 Thread Itagaki Takahiro
: FATAL: attempted change of parameter port ignored DETAIL: This parameter cannot be changed after server start. command failed: C:/mingw/local/pgsql/bin/psql -X -c DROP DATABASE IF EXISTS \contrib_regression\ postgres make: *** [installcheck] Error 2 Regards, --- ITAGAKI Takahiro NTT Open Source

Re: [HACKERS] make installcheck is broken in HEAD on mingw

2009-09-01 Thread Itagaki Takahiro
Tom Lane t...@sss.pgh.pa.us wrote: Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp writes: make installcheck seems to be broken in HEAD on mingw for a few days, though it ran sucessfully on Linux. The mingw buildfarm machines seem to be happy. Are you sure you have a clean build? Yes

Re: [HACKERS] [BUGS] fillfactor hides autovacuum parameters in 8.4.0

2009-08-27 Thread Itagaki Takahiro
Alvaro Herrera alvhe...@commandprompt.com wrote: So I'm going to apply your patch to both 8.4 and HEAD; we can always improve it later, I guess. Thank you for your applying. I think the fix is ugly, too. We need to introduce cleaner solution for 8.5. Regards, --- ITAGAKI Takahiro NTT Open

Re: [HACKERS] [PATCH] Largeobject access controls

2009-08-27 Thread Itagaki Takahiro
without owner. It might require full-scanning of pg_largeobject table, but we can accept it because the size of pg_largeobject will be smaller; we have actual data out of the table. * Don't we also need ALTER LARGE OBJECT oid OWNER TO user for consistency? Regards, --- ITAGAKI

Re: [HACKERS] [COMMITTERS] pgsql: Update release notes for 7.4.26, 8.0.22, 8.1.18, 8.2.14, 8.3.8,

2009-08-26 Thread Itagaki Takahiro
: --- Update release notes for 7.4.26, 8.0.22, 8.1.18, 8.2.14, 8.3.8, 8.4.1. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] [BUGS] fillfactor hides autovacuum parameters in 8.4.0

2009-08-19 Thread Itagaki Takahiro
values of reloptions to some magic number (-1 or so) ? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center fix-relopts-20090820.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] FDW-based dblink (WIP)

2009-08-19 Thread Itagaki Takahiro
); Regards, --- ITAGAKI Takahiro NTT Open Source Software Center twophase_callbacks-20090820.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] auto_explain log_verbose causes regression failure

2009-08-19 Thread Itagaki Takahiro
and unexpected FieldStore errors yet. We might need another fix for them. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center auto_explain-20090820.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

[HACKERS] Buffer usage in EXPLAIN and pg_stat_statements

2009-08-17 Thread Itagaki Takahiro
; | 26999 | 1929 UPDATE pgbench_tellers SET tbalance = tbalance + $1 WHERE tid = $2; | 25474 | 1 SELECT abalance FROM pgbench_accounts WHERE aid = $1;| 19950 | 0 (4 rows) Regards, --- ITAGAKI Takahiro NTT Open Source Software Center buffer_usage-20090817.patch

[HACKERS] Encoding issues in console and eventlog on win32

2009-08-16 Thread Itagaki Takahiro
choose UTF-8 or EUC_* on those platforms. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center eventlog-20090817.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] FDW-based dblink

2009-08-14 Thread Itagaki Takahiro
, true. But I think hard-to-use is better than unable-to-do. If needed, we can develop some recovery systems working with the dblink together, no? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

[HACKERS] FDW-based dblink

2009-08-13 Thread Itagaki Takahiro
to an external database. However, I think we need SQL-based interface in any case. ScanKey will be converted to SQL and passed to an external database. I have a prototype of the feature. I'd like to submit it for 8.5. Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center

Re: [HACKERS] FDW-based dblink

2009-08-13 Thread Itagaki Takahiro
. It is just same as present dblink_exec(), that only returns a command tag. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] FDW-based dblink

2009-08-13 Thread Itagaki Takahiro
-- and we have some should-not-failed operations in the final works already (flushing WAL, etc.). Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

[HACKERS] pg_ctl stop -m fast after -m smart

2009-08-06 Thread Itagaki Takahiro
: $ pg_ctl stop $ (found some connections remain) $ [Ctrl+C] $ pg_ctl stop -m fast $ (force disconnect and stop server safely) Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

[HACKERS] include/commands/version.h is not used

2009-08-06 Thread Itagaki Takahiro
Hi, I found include/commands/version.h is empty and not included from any files. What is the purpose of the file? http://doxygen.postgresql.org/version_8h.html Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-08-06 Thread Itagaki Takahiro
? Spawning a new process is not so cheap, no? -1 for -P option because it is too narrow purpose and 'ls' and '/tmp/' is not portable. We don't need to include your workload because you can use -f FILENAME to run your benchmark script. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center

Re: [HACKERS] [BUGS] BUG #4941: pg_stat_statements crash

2009-07-26 Thread Itagaki Takahiro
in postmaster; There are no chance to see uninitialized state of 'pgss' after relasing AddinShmemInitLock and before load dumpfile into it. I also check pgss_shmem_shutdown and no problem. It is called only once from postmaster on shutdown. Regards, --- ITAGAKI Takahiro NTT Open Source Software

[HACKERS] trace hooks (for 2nd commitfest)

2009-07-23 Thread Itagaki Takahiro
: tps = 28101 ENABLE_DTRACE only : tps = 27945 Enable both: tps = 27760 Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] multi-threaded pgbench

2009-07-23 Thread Itagaki Takahiro
Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp wrote: Greg Smith gsm...@gregsmith.com wrote: That second code path, when --enable-thread-safety is turned off, crashes and burns on my Linux system: It comes from confliction of identifiers. Renaming identifiers with #define can solve

Re: [HACKERS] query decorrelation in postgres

2009-07-23 Thread Itagaki Takahiro
by query decorrelation? Is it an addtional method for query optimization? At least there is no word 'decorrelation' in the postgres documentation. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] multi-threaded pgbench

2009-07-22 Thread Itagaki Takahiro
queue. We need to put the queue on inter-process shared memory, but it introduces additional complexities. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Duplicate key value error

2009-07-21 Thread Itagaki Takahiro
. ex) ERROR: ... STATEMENT: (very long query without length-limit) Also, we cannot use so long keys because length of key must be less then BLCKSZ. Error messages is 256kB at longest (INDEX_MAX_KEYS=32 * BLKCSZ=8kB), so I think it is not so dangerous. Regards, --- ITAGAKI Takahiro NTT Open

Re: [HACKERS] Sampling profiler updated

2009-07-21 Thread Itagaki Takahiro
of the hooks. It might be good to initialize LWLOCK_WAIT_START_hook with lwlock__wait__start(). If do so, dtrace probes still work and we can avoid if-null checks for each call. If acceptable, I'll also suggest new probe functions like SLEEP, SEND, RECV, SPINLOCK_FAILURE and so on. Regards, --- ITAGAKI

Re: [HACKERS] Duplicate key value error

2009-07-20 Thread Itagaki Takahiro
function to itup.h. [include/access/itup.h] extern void report_unique_violation(Relation rel, IndexTuple itup); Regards, --- ITAGAKI Takahiro NTT Open Source Software Center report_dupkey-20090721.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

<    1   2   3   4   5   6   7   8   9   >