Re: [HACKERS] CLUSTER command progress monitor

2017-09-12 Thread Tatsuro Yamada
On 2017/09/12 21:20, Tatsuro Yamada wrote: On 2017/09/11 23:38, Robert Haas wrote: On Sun, Sep 10, 2017 at 10:36 PM, Tatsuro Yamada wrote: Thanks for the comment. As you know, CLUSTER command uses SEQ SCAN or INDEX SCAN as a scan method by cost estimation. In the case of SEQ SCAN, these two

Re: [HACKERS] CLUSTER command progress monitor

2017-09-12 Thread Tatsuro Yamada
On 2017/09/11 23:38, Robert Haas wrote: On Sun, Sep 10, 2017 at 10:36 PM, Tatsuro Yamada wrote: Thanks for the comment. As you know, CLUSTER command uses SEQ SCAN or INDEX SCAN as a scan method by cost estimation. In the case of SEQ SCAN, these two phases not overlap. However, in INDEX SCAN

Re: [HACKERS] CLUSTER command progress monitor

2017-09-10 Thread Tatsuro Yamada
On 2017/09/08 18:55, Robert Haas wrote: On Wed, Aug 30, 2017 at 10:12 PM, Tatsuro Yamada wrote: 1. scanning heap 2. sort tuples These two phases overlap, though. I believe progress reporting for sorts is really hard. In the simple case where the data fits in work_mem, none of the work

Re: [HACKERS] CLUSTER command progress monitor

2017-09-06 Thread Tatsuro Yamada
On 2017/09/06 16:11, Michael Paquier wrote: On Wed, Sep 6, 2017 at 3:58 PM, Tatsuro Yamada wrote: I revised the patch like this: You should avoid top-posting. I see. I didn't change the name of view (pg_stat_progress_cluster) because I'm not sure whether th

Re: [HACKERS] ANALYZE command progress checker

2017-09-06 Thread Tatsuro Yamada
targrows; /* target # of sample rows */ int numrows;/* # of sample rows collected */ /* for random sampling */ double samplerows; /* # of rows fetched */ double rowstoskip; /* # of rows to skip before next sample */ ... I hope it will

Re: [HACKERS] Minor code improvement to postgresGetForeignPlan

2017-09-06 Thread Tatsuro Yamada
On 2017/09/07 6:52, Tom Lane wrote: Tatsuro Yamada writes: The declaration of postgresGetForeignPlan uses baserel, but the actual definition uses foreignrel. It would be better to sync. Pushed, thanks. regards, tom lane Thanks! Regards, Tatsuro Yamada -- Sent

Re: [HACKERS] CLUSTER command progress monitor

2017-09-05 Thread Tatsuro Yamada
mments or suggestion are welcome. Thanks, Tatsuro Yamada On 2017/09/04 20:17, Tatsuro Yamada wrote: On 2017/09/04 15:38, Michael Paquier wrote: On Thu, Aug 31, 2017 at 11:12 AM, Tatsuro Yamada wrote: Then I have questions. * Should we have separate views for them? Or should both be cove

Re: [HACKERS] CLUSTER command progress monitor

2017-09-04 Thread Tatsuro Yamada
On 2017/09/04 15:38, Michael Paquier wrote: On Thu, Aug 31, 2017 at 11:12 AM, Tatsuro Yamada wrote: Then I have questions. * Should we have separate views for them? Or should both be covered by the same view with some indication of which command (CLUSTER or VACUUM FULL) is

Re: [HACKERS] Minor code improvement to postgresGetForeignPlan

2017-09-03 Thread Tatsuro Yamada
> so, I'd vote for leaving that for another patch.) +1 Regards, Tatsuro Yamada -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] CLUSTER command progress monitor

2017-09-03 Thread Tatsuro Yamada
Hi Sawada-san, Thanks for taking your time. I'll be more careful. Regards, Tatsuro Yamada On 2017/09/04 11:51, Masahiko Sawada wrote: On Mon, Sep 4, 2017 at 11:37 AM, Tatsuro Yamada wrote: Hi Sawada-san, Thomas, Thanks for sharing the reggression.diff. I realized Thomas's commen

Re: [HACKERS] CLUSTER command progress monitor

2017-09-03 Thread Tatsuro Yamada
Hi Sawada-san, Thomas, Thanks for sharing the reggression.diff. I realized Thomas's comment is right. Attached patch is fixed version. Could you try it? Regards, Tatsuro Yamada NTT Open Source Software Center On 2017/09/01 17:59, Masahiko Sawada wrote: On Fri, Sep 1, 2017 at 3:

Re: [HACKERS] CLUSTER command progress monitor

2017-08-31 Thread Tatsuro Yamada
uot;initdb" command after "make install"? The pg_stat_progress_cluster view is created in initdb, probably. Regards, Tatsuro Yamada -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] CLUSTER command progress monitor

2017-08-30 Thread Tatsuro Yamada
UM FULL command. * I chose tuples as scan heap's counter (heap_tuples_scanned) since it's not easy to get current blocks from Index Scan. Is it Ok? I'll add this patch to CF2017-09. Any comments or suggestion are welcome. Regards, Tatsuro Yamada NTT Open Source Software Ce

[HACKERS] Minor code improvement to postgresGetForeignPlan

2017-04-06 Thread Tatsuro Yamada
Hi, The declaration of postgresGetForeignPlan uses baserel, but the actual definition uses foreignrel. It would be better to sync. Please find attached a patch. Tatsuro Yamada NTT Open Source Software Center diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c

Re: [HACKERS] Minor code improvement to postgresGetForeignJoinPaths

2016-11-08 Thread Tatsuro Yamada
On 2016/11/04 0:29, Robert Haas wrote: Committed. Thanks! Tatsuro Yamada NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Minor code improvement to postgresGetForeignJoinPaths

2016-10-24 Thread Tatsuro Yamada
Hi Ashutosh, You are right. Every call except that one is using NIL, so better to fix it. The pattern was repeated in the recent aggregate pushdown support. Here's patch to fix create_foreignscan_path() call in add_foreign_grouping_paths() as well. Thanks for the review! Tatsuro Yamad

[HACKERS] Minor code improvement to postgresGetForeignJoinPaths

2016-10-23 Thread Tatsuro Yamada
Hi, The last argument of create_foreignscan_path called by postgresGetForeignJoinPaths is set to NULL, but it would be suitable to set it to NIL because the argument type is List. Please find attached a patch. Tatsuro Yamada NTT Open Source Software Center diff --git a/contrib/postgres_fdw

Re: [HACKERS] ERROR: ORDER/GROUP BY expression not found in targetlist

2016-06-20 Thread Tatsuro Yamada
Hi, I ran tpc-h's queries on this version and it's successful. The error is fixed. commit 705ad7f3b523acae0ddfdebd270b7048b2bb8029 Author: Tom Lane Date: Sun Jun 19 13:11:40 2016 -0400 Regards, Tatsuro Yamada NTT OSS Center On 2016/06/18 1:26, Robert Haas wrote: On Fri, Jun 17,

Re: [HACKERS] ERROR: ORDER/GROUP BY expression not found in targetlist

2016-06-13 Thread Tatsuro Yamada
date ) group by o_orderpriority order by o_orderpriority LIMIT 1; ---------- Regards, Tatsuro Yamada NTT OSS Center On 2016/06/13 16:18, Amit Kapila wrote: On Mon, Jun 13, 2016 at 11:05 AM, David Rowley mail

Re: [HACKERS] ERROR: ORDER/GROUP BY expression not found in targetlist

2016-06-13 Thread Tatsuro Yamada
On 2016/06/13 15:52, Michael Paquier wrote: On Mon, Jun 13, 2016 at 2:42 PM, Tatsuro Yamada wrote: I got mistake to write an e-mail to -hackers on last week. :-< I should have written this. The bug has not fixed by Tom Lane's patch: commit aeb9ae6. Because I got the same error u

Re: [HACKERS] ERROR: ORDER/GROUP BY expression not found in targetlist

2016-06-12 Thread Tatsuro Yamada
wiki.postgresql.org/wiki/PostgreSQL_9.6_Open_Items Regards, Tatsuro Yamada NTT OSS Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ERROR: ORDER/GROUP BY expression not found in targetlist

2016-06-12 Thread Tatsuro Yamada
ms (11 rows) postgres=# set max_parallel_workers_per_gather = default; SET postgres=# \i queries/1.explain.sql ERROR: ORDER/GROUP BY expression not found in targetlist --------- Regards, Tatsuro Yamada NTT OSS Center On 2016/06/13 12:39, Thomas Munro wrote: Hi, What is going on here? pos

Re: [HACKERS] ORDER/GROUP BY expression not found in targetlist

2016-06-08 Thread Tatsuro Yamada
Hi, I got same error by TPC-H: Q1,4,8,12 and 17. I've attached results of the queries. TPC-H (thanks to Tomas Vondra) https://github.com/tvondra/pg_tpch Datasize Scale Factor: 1 PG96beta1 commit: f721e94b5f360391fc3ffe183bf697a0441e9184 Regards, Tatsuro Yamada NTT OSS Cente

[HACKERS] Comment typo in port/atomics/generic.h

2016-01-14 Thread Tatsuro Yamada
Hi, I found a typo in generic.h The attached patch fixes it: s/tomic/atomic/g Best regards, Tatsuro Yamada *** a/src/include/port/atomics/generic.h --- b/src/include/port/atomics/generic.h *** *** 1,7

[HACKERS] Comment typo in port/atomics/arch-x86.h

2016-01-07 Thread Tatsuro Yamada
Hi, I found a typo in arch-x86.h. The attached patch fixes a typo: s/468/486/g Best regards, Tatsuro Yamada *** a/src/include/port/atomics/arch-x86.h --- b/src/include/port/atomics/arch-x86.h *** *** 67,73 typedef struct pg_atomic_uint32 /* * It's too complicat

[HACKERS] A Typo in regress/sql/privileges.sql

2015-12-16 Thread Tatsuro Yamada
Hi, This is my first post to -hackers. I found typos in privileges.sql and privileges.out Please find attached a patch. Best regards, Tatsuro Yamada *** a/src/test/regress/expected/privileges.out --- b/src/test/regress/expected/privileges.out *** *** 390,396 INSERT INTO atest5