Re: [HACKERS] PATCH: CreateComments: use explicit indexing for ``values''

2011-06-14 Thread richhguard-monotone
me to submit a patch which just changes comment.c by adding in the constants via a comment like the other places. What do you think ? Richard --- On Tue, 14/6/11, Alvaro Herrera wrote: > From: Alvaro Herrera > Subject: Re: [HACKERS] PATCH: CreateComments: use explicit indexing for > ``v

Re: [HACKERS] PATCH: CreateComments: use explicit indexing for ``values''

2011-06-13 Thread richhguard-monotone
Apologies - I meant to CC in the list but forgot. I have gone through and changed all the related functions except ``update_attstats''. Do you have any advice of how to handle the inner loops, such as those initializing ``stakindN''. The entries before can be handled just like in this patch, b

[HACKERS] PATCH: CreateComments: use explicit indexing for ``values''

2011-06-13 Thread richhguard-monotone
Hello, I'm new to PostgreSQL and git, but having read through the wiki entries such as http://wiki.postgresql.org/wiki/Submitting_a_Patch, I think I have a patch worthy of submission. It's a readability improvement in src/backend/commands/comment.c (CreateComments function), which changes the e