Re: [HACKERS] %TYPE and array declaration patch review

2011-12-10 Thread Wojciech Muła
On Sat, 10 Dec 2011 10:22:54 -0500 Greg Smith wrote: > Tom's concerns about the grammar rewrite and way parsing is handled > here seem the worst blockers for committing this, and I can't imagine > how those could be resolved before this CommitFest is over. I'm > going to mark this one as returne

Re: [HACKERS] %TYPE and array declaration patch review

2011-12-10 Thread Pavel Stehule
2011/12/10 Greg Smith : > On 11/30/2011 10:42 AM, Pavel Stehule wrote: >> >> Regress tests are really large - it is question if about 900 lines is >> necessary - should be more compact >> > > > Can't recall the last time I heard a complaint about having too many > regression tests for new code.  We

Re: [HACKERS] %TYPE and array declaration patch review

2011-12-10 Thread Greg Smith
On 11/30/2011 10:42 AM, Pavel Stehule wrote: Regress tests are really large - it is question if about 900 lines is necessary - should be more compact Can't recall the last time I heard a complaint about having too many regression tests for new code. We've got some bit rot, code convention

Re: [HACKERS] %TYPE and array declaration patch review

2011-11-30 Thread Pavel Stehule
Hello 2011/11/28 Greg Smith : > I'm trying to find someone for the "[PL/pgSQL] %TYPE and array declaration - > second patch" patch submitted recently: >  https://commitfest.postgresql.org/action/patch_view?id=666 > > Not too many people work on the PL/pgSQL code, and I see you reviewed an > earlie