Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-26 Thread Amit Kapila
On Tuesday, February 26, 2013 1:36 PM Heikki Linnakangas wrote: > On 26.02.2013 09:06, Amit Kapila wrote: > > On Monday, February 25, 2013 11:26 PM Heikki Linnakangas wrote: > >> On 21.02.2013 16:09, Amit Kapila wrote: > >>> On Thursday, February 21, 2013 12:46 AM Heikki Linnakangas wrote: > >> I'v

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-26 Thread Heikki Linnakangas
On 26.02.2013 09:06, Amit Kapila wrote: On Monday, February 25, 2013 11:26 PM Heikki Linnakangas wrote: On 21.02.2013 16:09, Amit Kapila wrote: On Thursday, February 21, 2013 12:46 AM Heikki Linnakangas wrote: I've committed those patches, with some further changes. If you have the time, pleas

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-25 Thread Amit Kapila
On Monday, February 25, 2013 11:26 PM Heikki Linnakangas wrote: > On 21.02.2013 16:09, Amit Kapila wrote: > > On Thursday, February 21, 2013 12:46 AM Heikki Linnakangas wrote: > I've committed those patches, with some further changes. If you have > the > time, please take another look at the commit

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-25 Thread Heikki Linnakangas
On 21.02.2013 16:09, Amit Kapila wrote: On Thursday, February 21, 2013 12:46 AM Heikki Linnakangas wrote: The second adds it to pg_dump, per above. The third adds it to pg_dumpall. The third patch is a bit complicated. It first parses the user- specified connection string using PQconninfoParse,

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-21 Thread Amit Kapila
On Thursday, February 21, 2013 12:46 AM Heikki Linnakangas wrote: > On 20.02.2013 11:42, Amit Kapila wrote: > > The patch for providing connection string for pg_basebackup, > > pg_receivexlog, pg_dump and pg_dumpall is attached with this mail. > > Thanks. Now that I look at this patch, I realize t

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-20 Thread Phil Sorber
On Wed, Feb 20, 2013 at 2:16 PM, Heikki Linnakangas wrote: > Where does this leave the PQconninfoParseParams/PQconninfodefaultsMerge > patch? I'm not sure. Somehow I thought it would be necessary for this work, > but it wasn't. I didn't remember that we already have PQconninfoParse() > function, w

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-20 Thread Heikki Linnakangas
On 20.02.2013 11:42, Amit Kapila wrote: The patch for providing connection string for pg_basebackup, pg_receivexlog, pg_dump and pg_dumpall is attached with this mail. Thanks. Now that I look at this patch, I realize that we don't actually need these new functions for pg_basebackup and friends

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-20 Thread Amit Kapila
> > Tuesday, February 19, 2013 6:23 PM Amit Kapila wrote: > > On Monday, February 18, 2013 1:41 PM Heikki Linnakangas wrote: > > > On 18.02.2013 06:07, Amit Kapila wrote: > > > > On Sunday, February 17, 2013 8:44 PM Phil Sorber wrote: > > > >> On Sun, Feb 17, 2013 at 1:35 AM, Amit > > kapila > > >

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-19 Thread Amit Kapila
ro Herrera'; 'Magnus Hagander'; 'PostgreSQL- > development' > Subject: Re: [HACKERS] [PATCH] Add PQconninfoParseParams and > PQconninfodefaultsMerge to libpq > > On Monday, February 18, 2013 1:41 PM Heikki Linnakangas wrote: > > On 18.02.2013 06:07, Amit Kapila w

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-18 Thread Amit Kapila
On Monday, February 18, 2013 1:41 PM Heikki Linnakangas wrote: > On 18.02.2013 06:07, Amit Kapila wrote: > > On Sunday, February 17, 2013 8:44 PM Phil Sorber wrote: > >> On Sun, Feb 17, 2013 at 1:35 AM, Amit kapila > >> wrote: > >>> Now the patch of Phil Sober provides 2 new API's > >> PQconninfoPa

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-18 Thread Amit Kapila
On Monday, February 18, 2013 1:41 PM Heikki Linnakangas wrote: > On 18.02.2013 06:07, Amit Kapila wrote: > > On Sunday, February 17, 2013 8:44 PM Phil Sorber wrote: > >> On Sun, Feb 17, 2013 at 1:35 AM, Amit kapila > >> wrote: > >>> Now the patch of Phil Sober provides 2 new API's > >> PQconninfoPa

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-18 Thread Heikki Linnakangas
On 18.02.2013 06:07, Amit Kapila wrote: On Sunday, February 17, 2013 8:44 PM Phil Sorber wrote: On Sun, Feb 17, 2013 at 1:35 AM, Amit kapila wrote: Now the patch of Phil Sober provides 2 new API's PQconninfoParseParams(), and PQconninfodefaultsMerge(), using these API's I can think of below w

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-17 Thread Amit Kapila
On Sunday, February 17, 2013 8:44 PM Phil Sorber wrote: > On Sun, Feb 17, 2013 at 1:35 AM, Amit kapila > wrote: > > On Tuesday, February 12, 2013 2:49 AM Heikki Linnakangas wrote: > > On 04.02.2013 17:32, Alvaro Herrera wrote: > >> Phil Sorber wrote: > >>> On Mon, Feb 4, 2013 at 10:16 AM, Alvaro H

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-17 Thread Phil Sorber
On Sun, Feb 17, 2013 at 1:35 AM, Amit kapila wrote: > On Tuesday, February 12, 2013 2:49 AM Heikki Linnakangas wrote: > On 04.02.2013 17:32, Alvaro Herrera wrote: >> Phil Sorber wrote: >>> On Mon, Feb 4, 2013 at 10:16 AM, Alvaro Herrera >>> wrote: Phil Sorber wrote: > On Mon, Feb 4, 201

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-16 Thread Amit kapila
On Tuesday, February 12, 2013 2:49 AM Heikki Linnakangas wrote: On 04.02.2013 17:32, Alvaro Herrera wrote: > Phil Sorber wrote: >> On Mon, Feb 4, 2013 at 10:16 AM, Alvaro Herrera >> wrote: >>> Phil Sorber wrote: On Mon, Feb 4, 2013 at 9:13 AM, Alvaro Herrera wrote: >>> > I think this

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-11 Thread Phil Sorber
On Mon, Feb 11, 2013 at 4:19 PM, Heikki Linnakangas wrote: > On 04.02.2013 17:32, Alvaro Herrera wrote: >> >> Phil Sorber wrote: >>> >>> On Mon, Feb 4, 2013 at 10:16 AM, Alvaro Herrera >>> wrote: Phil Sorber wrote: > > On Mon, Feb 4, 2013 at 9:13 AM, Alvaro > Herrera wrote

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-11 Thread Heikki Linnakangas
On 04.02.2013 17:32, Alvaro Herrera wrote: Phil Sorber wrote: On Mon, Feb 4, 2013 at 10:16 AM, Alvaro Herrera wrote: Phil Sorber wrote: On Mon, Feb 4, 2013 at 9:13 AM, Alvaro Herrera wrote: Uh, no existing code can use this new functionality? That seems disappointing. I wrote this bec

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-04 Thread Alvaro Herrera
Phil Sorber wrote: > On Mon, Feb 4, 2013 at 10:16 AM, Alvaro Herrera > wrote: > > Phil Sorber wrote: > >> On Mon, Feb 4, 2013 at 9:13 AM, Alvaro Herrera > >> wrote: > > > >> > Uh, no existing code can use this new functionality? That seems > >> > disappointing. > >> > >> I wrote this because I

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-04 Thread Phil Sorber
On Mon, Feb 4, 2013 at 10:16 AM, Alvaro Herrera wrote: > Phil Sorber wrote: >> On Mon, Feb 4, 2013 at 9:13 AM, Alvaro Herrera >> wrote: > >> > Uh, no existing code can use this new functionality? That seems >> > disappointing. >> >> I wrote this because I wanted to use it in pg_isready. I also

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-04 Thread Alvaro Herrera
Phil Sorber wrote: > On Mon, Feb 4, 2013 at 9:13 AM, Alvaro Herrera > wrote: > > Uh, no existing code can use this new functionality? That seems > > disappointing. > > I wrote this because I wanted to use it in pg_isready. I also wrote > something for pg_isready to get around not having this.

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-04 Thread Phil Sorber
On Mon, Feb 4, 2013 at 9:13 AM, Alvaro Herrera wrote: > >> > On Feb 3, 2013 4:16 AM, "Phil Sorber" wrote: >> >> >> >> This patch came up from discussion about pg_isready. >> >> >> >> PQconninfoParseParams is similar to PQconninfoParse but takes two >> >> arrays like PQconnectdbParams. It essentia

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-04 Thread Alvaro Herrera
> > On Feb 3, 2013 4:16 AM, "Phil Sorber" wrote: > >> > >> This patch came up from discussion about pg_isready. > >> > >> PQconninfoParseParams is similar to PQconninfoParse but takes two > >> arrays like PQconnectdbParams. It essentially exposes > >> conninfo_array_parse(). > >> > >> PQconninfod

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-02 Thread Phil Sorber
On Sun, Feb 3, 2013 at 1:37 AM, Magnus Hagander wrote: > > On Feb 3, 2013 4:16 AM, "Phil Sorber" wrote: >> >> This patch came up from discussion about pg_isready. >> >> PQconninfoParseParams is similar to PQconninfoParse but takes two >> arrays like PQconnectdbParams. It essentially exposes >> co

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-02 Thread Magnus Hagander
On Feb 3, 2013 4:16 AM, "Phil Sorber" wrote: > > This patch came up from discussion about pg_isready. > > PQconninfoParseParams is similar to PQconninfoParse but takes two > arrays like PQconnectdbParams. It essentially exposes > conninfo_array_parse(). > > PQconninfodefaultsMerge essentially expo

[HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-02 Thread Phil Sorber
This patch came up from discussion about pg_isready. PQconninfoParseParams is similar to PQconninfoParse but takes two arrays like PQconnectdbParams. It essentially exposes conninfo_array_parse(). PQconninfodefaultsMerge essentially exposes conninfo_add_defaults(). It allows you to pass a PQconni